From bf322c6dee3a0936e579c12918b767af0d412f39 Mon Sep 17 00:00:00 2001 From: Ben Chatelain Date: Thu, 20 Dec 2018 19:00:56 -0700 Subject: [PATCH] =?UTF-8?q?=F0=9F=8D=BA=20Use=20install=20script=20in=20Ho?= =?UTF-8?q?mebrew=20formula?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Instead of redundant xcodebuild install commands --- Homebrew/mas-tap.rb | 13 +++---------- Homebrew/mas.rb | 13 +++---------- 2 files changed, 6 insertions(+), 20 deletions(-) diff --git a/Homebrew/mas-tap.rb b/Homebrew/mas-tap.rb index e4fa9b5..b6d434f 100644 --- a/Homebrew/mas-tap.rb +++ b/Homebrew/mas-tap.rb @@ -21,8 +21,9 @@ class Mas < Formula depends_on :xcode => ["10.0", :build] def install - # Prevent warnings from causing build failures - # Prevent linker errors by telling all lib builds to use max size install names + # Working around build issues in dependencies + # - Prevent warnings from causing build failures + # - Prevent linker errors by telling all lib builds to use max size install names xcconfig = buildpath/"Overrides.xcconfig" xcconfig.write <<~EOS GCC_TREAT_WARNINGS_AS_ERRORS = NO @@ -31,14 +32,6 @@ class Mas < Formula ENV["XCODE_XCCONFIG_FILE"] = xcconfig system "carthage", "bootstrap", "--platform", "macOS" - - xcodebuild "install", - "-project", "mas-cli.xcodeproj", - "-scheme", "mas-cli Release", - "-configuration", "Release", - "OBJROOT=build", - "SYMROOT=build" - system "script/install", prefix bash_completion.install "contrib/completion/mas-completion.bash" => "mas" diff --git a/Homebrew/mas.rb b/Homebrew/mas.rb index 3bd9023..93af42a 100644 --- a/Homebrew/mas.rb +++ b/Homebrew/mas.rb @@ -16,8 +16,9 @@ class Mas < Formula depends_on :xcode => ["10.0", :build] def install - # Prevent warnings from causing build failures - # Prevent linker errors by telling all lib builds to use max size install names + # Working around build issues in dependencies + # - Prevent warnings from causing build failures + # - Prevent linker errors by telling all lib builds to use max size install names xcconfig = buildpath/"Overrides.xcconfig" xcconfig.write <<~EOS GCC_TREAT_WARNINGS_AS_ERRORS = NO @@ -26,14 +27,6 @@ class Mas < Formula ENV["XCODE_XCCONFIG_FILE"] = xcconfig system "carthage", "bootstrap", "--platform", "macOS" - - xcodebuild "install", - "-project", "mas-cli.xcodeproj", - "-scheme", "mas-cli Release", - "-configuration", "Release", - "OBJROOT=build", - "SYMROOT=build" - system "script/install", prefix bash_completion.install "contrib/completion/mas-completion.bash" => "mas"