🍺 Revise core formula after feedback and resolving errors

Homebrew/mas.rb

@@ -2,34 +2,35 @@ class Mas < Formula
   desc "Mac App Store command-line interface"
   homepage "https://github.com/mas-cli/mas"
   url "https://github.com/mas-cli/mas.git",
-    :branch => "release-1.4.3",
-    # :tag => "v1.4.2",
-    # :revision => "966872b32820c014a9004691f5da47f170702236",
-    :shallow => true
-  head "https://github.com/mas-cli/mas.git", :shallow => true
+      :tag => "v1.4.3",
+      :revision => "11a0e3e14e5a83aaaba193dfb6d18aa49a82b881"
+  head "https://github.com/mas-cli/mas.git"
 
   bottle do
     cellar :any_skip_relocation
+    sha256 "fb05286adfb9ab0a63a8027391647fb874fa810c07d412505f5bc7911139a3f2" => :mojave
     sha256 "b7585ced3a93d60e95357e93d729913a6f628fda82359e77c6553c2e802c50dc" => :high_sierra
     sha256 "af5be6aa9902d9cfc2aa69dbf313441a7c201463d516face721f900ceae9556b" => :sierra
   end
 
-  depends_on :xcode => ["10.0", :build]
   depends_on "carthage" => :build
+  depends_on :xcode => ["10.0", :build]
 
   def install
-    # Prevent build failures from warnings
+    # Prevent warnings from causing build failures
+    # Prevent linker errors by telling all lib builds to use max size install names
     xcconfig = buildpath/"Overrides.xcconfig"
-    File.open(xcconfig, 'w') { |file| file.write("GCC_TREAT_WARNINGS_AS_ERRORS = NO") }
+    xcconfig.write("GCC_TREAT_WARNINGS_AS_ERRORS = NO\nOTHER_LDFLAGS = -headerpad_max_install_names")
     ENV["XCODE_XCCONFIG_FILE"] = xcconfig
 
     system "carthage", "bootstrap", "--platform", "macOS"
 
-    xcodebuild "-project", "mas-cli.xcodeproj",
+    xcodebuild "install",
+                "-project", "mas-cli.xcodeproj",
                 "-scheme", "mas-cli Release",
-               "-configuration",🛠️ "Release",
-               "OBJROOT=#{buildpath.realpath}",
-               "SYMROOT=#{buildpath.realpath}"
+                "-configuration", "Release",
+                "OBJROOT=build",
+                "SYMROOT=build"
 
     system "script/install", prefix