From 3b7c9a47bd66fa33fe386c83f6d50bd0409b4306 Mon Sep 17 00:00:00 2001 From: Chris Araman Date: Wed, 12 May 2021 12:11:21 -0700 Subject: [PATCH 1/4] =?UTF-8?q?=F0=9F=8F=A1=20Update=20mock=20bundle=20pat?= =?UTF-8?q?h?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- Tests/MasKitTests/Controllers/MasAppLibrarySpec.swift | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Tests/MasKitTests/Controllers/MasAppLibrarySpec.swift b/Tests/MasKitTests/Controllers/MasAppLibrarySpec.swift index 26e0d7a..d5bec75 100644 --- a/Tests/MasKitTests/Controllers/MasAppLibrarySpec.swift +++ b/Tests/MasKitTests/Controllers/MasAppLibrarySpec.swift @@ -35,8 +35,8 @@ public class MasAppLibrarySpec: QuickSpec { let myApp = SoftwareProductMock( appName: "MyApp", bundleIdentifier: "com.example", - bundlePath: "", - bundleVersion: "", + bundlePath: "/Applications/MyApp.app", + bundleVersion: "1.0.0", itemIdentifier: 1234 ) From 15ffe067a01a2cf1c8ad7034989946802a0eba0b Mon Sep 17 00:00:00 2001 From: Chris Araman Date: Wed, 12 May 2021 12:16:25 -0700 Subject: [PATCH 2/4] =?UTF-8?q?=F0=9F=9A=A8=20Fail=20CI=20task=20if=20test?= =?UTF-8?q?s=20fail?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- script/test | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/script/test b/script/test index 34ed4eb..ff6e4d9 100755 --- a/script/test +++ b/script/test @@ -7,4 +7,4 @@ # echo "==> ✅ Testing" -swift test 2>&1 | xcpretty +set -o pipefail && swift test 2>&1 | xcpretty From c372dbc9fd1deba9f61f119499c7548c069373ee Mon Sep 17 00:00:00 2001 From: Chris Araman Date: Sun, 9 May 2021 11:01:49 -0700 Subject: [PATCH 3/4] =?UTF-8?q?=E2=AC=86=EF=B8=8F=20Nimble=20(9.2.0)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- Package.resolved | 4 ++-- Package.swift | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Package.resolved b/Package.resolved index a4a61a8..f58a362 100644 --- a/Package.resolved +++ b/Package.resolved @@ -33,8 +33,8 @@ "repositoryURL": "https://github.com/Quick/Nimble.git", "state": { "branch": null, - "revision": "d258c638d9ef214723a857a23f4113773aad28fb", - "version": "9.1.0" + "revision": "af1730dde4e6c0d45bf01b99f8a41713ce536790", + "version": "9.2.0" } }, { diff --git a/Package.swift b/Package.swift index 62caf46..843814e 100644 --- a/Package.swift +++ b/Package.swift @@ -22,7 +22,7 @@ let package = Package( dependencies: [ // Dependencies declare other packages that this package depends on. .package(url: "https://github.com/Carthage/Commandant.git", from: "0.18.0"), - .package(url: "https://github.com/Quick/Nimble.git", from: "9.1.0"), + .package(url: "https://github.com/Quick/Nimble.git", from: "9.2.0"), .package(url: "https://github.com/Quick/Quick.git", from: "4.0.0"), .package(url: "https://github.com/mxcl/PromiseKit.git", from: "6.13.3"), .package(url: "https://github.com/mxcl/Version.git", from: "2.0.0"), From 30f466734efaaf3b4f2c5c7906b1ae2dae2f909a Mon Sep 17 00:00:00 2001 From: Chris Araman Date: Sun, 9 May 2021 11:27:22 -0700 Subject: [PATCH 4/4] =?UTF-8?q?=F0=9F=9A=A8=20Version=20bumps=20are=20now?= =?UTF-8?q?=20tracked=20as=20git=20tags,=20not=20source=20changes?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- Dangerfile | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/Dangerfile b/Dangerfile index f58d0ea..9d6636b 100644 --- a/Dangerfile +++ b/Dangerfile @@ -11,18 +11,12 @@ has_app_changes = !git.modified_files.grep(/Sources/).empty? has_test_changes = !git.modified_files.grep(/Tests/).empty? -is_version_bump = git.modified_files.sort == [ - "Package.swift", - "MasKit/Package.swift" -].sort -message(":bookmark: Version bump!") if is_version_bump - -# if has_app_changes && !has_test_changes && !is_version_bump +# if has_app_changes && !has_test_changes # warn("Tests were not updated", sticky: false) # end # Thanks other people! -message(":tada:") if is_version_bump && github.pr_author != "phatblat" +message(":tada:") if github.pr_author != "phatblat" # Mainly to encourage writing up some reasoning about the PR, rather than just leaving a title if github.pr_body.length < 5