Mirrors/mas
2
0
Fork 0
mirror of https://github.com/mas-cli/mas synced 2025-02-16 12:38:30 +00:00
Code Issues Projects Releases Packages Wiki Activity

Improve parameter names.

Browse source 
Partial #592

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
This commit is contained in:
Ross Goldberg 2024-10-21 07:42:30 -04:00
parent 586de07389
commit 2af2a42a88
No known key found for this signature in database
2 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Sources/mas/Commands/Upgrade.swift
View file

@ -58,14 +58,14 @@ extension Mas {
let apps: [SoftwareProduct] = let apps: [SoftwareProduct] =
appIDs.isEmpty appIDs.isEmpty
? appLibrary.installedApps ? appLibrary.installedApps
: appIDs.compactMap { : appIDs.compactMap { appID in
if let appID = AppID($0) { if let appID = AppID(appID) {
// argument is an AppID, lookup app by id using argument // argument is an AppID, lookup app by id using argument
return appLibrary.installedApp(withAppID: appID) return appLibrary.installedApp(withAppID: appID)
} }
// argument is not an AppID, lookup app by name using argument // argument is not an AppID, lookup app by name using argument
return appLibrary.installedApp(named: $0) return appLibrary.installedApp(named: appID)
} }
let promises = apps.map { installedApp in let promises = apps.map { installedApp in

6
Sources/mas/Controllers/MasStoreSearch.swift
View file

@ -36,7 +36,7 @@ class MasStoreSearch: StoreSearch {
/// ///
/// - Parameter searchTerm: a search term matched against app names /// - Parameter searchTerm: a search term matched against app names
/// - Returns: A Promise of an Array of SearchResults matching searchTerm /// - Returns: A Promise of an Array of SearchResults matching searchTerm
func search(for appName: String) -> Promise<[SearchResult]> { func search(for searchTerm: String) -> Promise<[SearchResult]> {
// Search for apps for compatible platforms, in order of preference. // Search for apps for compatible platforms, in order of preference.
// Macs with Apple Silicon can run iPad and iPhone apps. // Macs with Apple Silicon can run iPad and iPhone apps.
var entities = [Entity.desktopSoftware] var entities = [Entity.desktopSoftware]
@ -45,8 +45,8 @@ class MasStoreSearch: StoreSearch {
} }
let results = entities.map { entity in let results = entities.map { entity in
guard let url = searchURL(for: appName, inCountry: country, ofEntity: entity) else { guard let url = searchURL(for: searchTerm, inCountry: country, ofEntity: entity) else {
fatalError("Failed to build URL for \(appName)") fatalError("Failed to build URL for \(searchTerm)")
} }
return loadSearchResults(url) return loadSearchResults(url)
} }