Commit graph

330 commits

Author SHA1 Message Date
Serial
754bf03413 Make things less confusing to use 2021-04-22 18:01:09 -04:00
Serial
bd48066b64 Add extra verification to tests 2021-04-22 13:56:51 -04:00
Serial
afbdd35493 Add aif extension 2021-04-22 13:27:50 -04:00
Serial
186d540d00 Clippy 2021-04-22 12:59:16 -04:00
Serial
dc23ec1ffd Support AIFF 2021-04-22 12:57:20 -04:00
Serial
fbfe0e916b Cleanup 2021-04-22 11:15:19 -04:00
Serial
b08efcc3ff Remove old lints 2021-04-21 14:58:53 -04:00
Serial
587de8f0a6 Comments for Vorbis/RiffFormat 2021-04-21 14:53:11 -04:00
Serial
3be3bf8880 Better table in README 2021-04-21 14:48:45 -04:00
Serial
79c03431bf Forgot to change TagType::Vorbis's features 2021-04-21 14:24:24 -04:00
Serial
6b770dc14c Give features better names 2021-04-21 14:22:52 -04:00
Serial
de334cc62b Clippy 2021-04-21 13:51:51 -04:00
Serial
90161287ab Add some benchmarks for reading from extension/signature 2021-04-21 13:48:21 -04:00
Serial
4d65545940 Update README 2021-04-21 13:03:06 -04:00
Serial
bc2bb8a92c Neater imports 2021-04-21 12:56:35 -04:00
Serial
05c7ac6d04 Support ID3 tags in RIFF chunks 2021-04-21 12:49:27 -04:00
Serial
4e01f98463 Use the correct names 2021-04-21 11:06:41 -04:00
Serial
297db6fbac Move some conversions to impl_tag macro 2021-04-20 23:14:17 -04:00
Serial
253609cc4b Add the ability to guess file format from file signature
Adds a new DetermineFrom enum to be used in Tag::read_from_path. This allows you to choose between guessing from extension or file signature.
2021-04-20 23:06:03 -04:00
Serial
baa1b1fd24 Hopefully the last time the test assets need to be updated 2021-04-20 20:51:12 -04:00
Serial
8ff6bb52c8 Start work on duration
Added a duration field to each tag struct, and implemented duration reading for mp3. All other tags return None for now.
2021-04-20 15:15:05 -04:00
Serial
0dd57cc4da Remove old trait 2021-04-20 12:21:09 -04:00
Serial
8c79ea46cb Managed to delete the test assets again 2021-04-20 12:08:44 -04:00
Serial
cdfa5de045 Forgot to remove old album_artists_vec method for Mp4Tag 2021-04-20 12:06:39 -04:00
Serial
e5231567cc Remove add_artist and add_album_artist
These were useless methods that shouldn't be handled by lofty anyway
2021-04-20 11:25:09 -04:00
Serial
df2e728974 Merge remote-tracking branch 'origin/main' 2021-04-18 15:39:13 -04:00
Serial
f5c743f3aa Finish all methods except for album covers
Signed-off-by: Serial <69764315+Serial-ATA@users.noreply.github.com>
2021-04-18 15:32:59 -04:00
Alex
c8bdca8ea5
New wav test asset 2021-04-18 14:38:37 -04:00
Alex
71cb4ffd69
Remove old (broken) WAV test asset 2021-04-18 14:37:58 -04:00
Serial
e28b3b5f7f Remove unused unstable features
Signed-off-by: Serial <69764315+Serial-ATA@users.noreply.github.com>
2021-04-18 14:30:00 -04:00
Serial
d0a381278f Switch to using "/" as a separator
Signed-off-by: Serial <69764315+Serial-ATA@users.noreply.github.com>
2021-04-18 14:25:11 -04:00
Serial
b072f0b0e5 Finally separate VorbisTag::read_from_path from the other tags
Signed-off-by: Serial <69764315+Serial-ATA@users.noreply.github.com>
2021-04-18 14:07:26 -04:00
Serial
48e6182e3a WAV now rereads properly
Signed-off-by: Serial <69764315+Serial-ATA@users.noreply.github.com>
2021-04-18 13:45:53 -04:00
Serial
3df43317fd Forgot some MP4 extensions
Signed-off-by: Serial <69764315+Serial-ATA@users.noreply.github.com>
2021-04-18 00:24:32 -04:00
Serial
c886cc87be Implement read/write for WAV (RIFF INFO LIST)
This format is pretty limited, and a few non-standard IDs were used, so there's a high chance the data will be inaccurate. At least it works somewhat :)

Signed-off-by: Serial <69764315+Serial-ATA@users.noreply.github.com>
2021-04-18 00:12:47 -04:00
Serial
511aa597b2 Would make sense to stop reading when the end is reached :)
Signed-off-by: Serial <69764315+Serial-ATA@users.noreply.github.com>
2021-04-17 17:09:32 -04:00
Serial
7797c1e92b Forgot to remove stuff from testing
Signed-off-by: Serial <69764315+Serial-ATA@users.noreply.github.com>
2021-04-17 15:45:40 -04:00
Serial
4cc33b5e53 Start work on wav decoding
Very few IDs supported right now, test doesn't work yet, and this only supports RIFF INFO chunks, ID3 has to wait for https://github.com/polyfloyd/rust-id3/pull/64

Signed-off-by: Serial <69764315+Serial-ATA@users.noreply.github.com>
2021-04-17 15:42:06 -04:00
Serial
e59a41420b Much nicer supported formats table :)
Signed-off-by: Serial <69764315+Serial-ATA@users.noreply.github.com>
2021-04-16 16:02:12 -04:00
Serial
4d6f2db8e9 Ape is no longer TODO :)
Signed-off-by: Serial <69764315+Serial-ATA@users.noreply.github.com>
2021-04-15 13:40:54 -04:00
Serial
a0e7a31322 Add test assets to gitignore
Forgot to do this earlier

Signed-off-by: Serial <69764315+Serial-ATA@users.noreply.github.com>
2021-04-15 13:33:50 -04:00
Serial
001c33bf86 Implement read/write for ape
Quite a few weird things had to be done due to the ape crate's choices, and ape's lack of a standardized set of keys, but it all seems to work.

Signed-off-by: Serial <69764315+Serial-ATA@users.noreply.github.com>
2021-04-15 13:26:06 -04:00
Serial
04a9ab4634 Clippy and some more doc comments
Signed-off-by: Serial <69764315+Serial-ATA@users.noreply.github.com>
2021-04-15 11:53:10 -04:00
Serial
ae81ff21e9 Clippy and misc cleanup
Signed-off-by: Serial <69764315+Serial-ATA@users.noreply.github.com>
2021-04-14 12:17:38 -04:00
Serial
0ec56ca015 Created conversion for VorbisTag -> metaflac::Tag
This fixes write_to for flac.

Signed-off-by: Serial <69764315+Serial-ATA@users.noreply.github.com>
2021-04-14 11:14:08 -04:00
Serial
f956dfd3e2 Working (rough) implementation of write_to for ogg
ogg can now successfully be read from and written to. This breaks all other tests currently.

Signed-off-by: Serial <69764315+Serial-ATA@users.noreply.github.com>
2021-04-13 23:29:13 -04:00
Serial
7c72287586 Created conversion for metaflac::Tag -> VorbisTag, fixed inner test 2021-04-06 22:33:39 -04:00
Serial
88ecd1c136 Forgot to delete the old files 2021-04-06 20:58:15 -04:00
Serial
702f6617c5 VERY rough implementation of a single VorbisTag struct for all formats using vorbis comments, seems to work so far. 2021-04-06 20:57:30 -04:00
Serial
c835687098 Actually use the correct name 2021-04-06 17:55:39 -04:00