Serial
de62c688dd
OGG: Fix clippy::trivially_copy_pass_by_ref
2023-07-05 13:18:21 -04:00
Serial
317fbb6e01
OGG: Stop silently discarding fields that are too large
...
Previously when writing `VorbisComments`, any field larger than `u32::MAX` would just be ignored. Now `TooMuchData` is thrown.
2023-07-05 13:18:21 -04:00
Serial
5ec7063db7
OGG: Fix reading error handling
2023-07-05 13:18:21 -04:00
Serial
273451ee4a
OGG: Move VorbisComments picture creation to new function
2023-07-05 13:18:21 -04:00
Serial
983866c87f
OGG: Remove unnecessary seek when writing
2023-07-05 13:18:21 -04:00
Serial
ea2cd93cda
OGG: Log warnings when ignored errors occur
2023-07-05 13:18:21 -04:00
Serial
79b241d140
OGG: Stop creating an intermediary String for fields
...
`read_comments` would previously read the entire field into memory, create a string, split the string into `key` and `value`, do byte comparisons on both, then allocate another two strings.
Now, the String creation is saved until all validation is done. In the case of `Picture`s, no strings are created at all (in `read_comments`, anyway).
2023-07-05 13:18:21 -04:00
Serial
ee146eecbd
OGG: Log a warning when a VorbisComments
field has no separator
2023-07-05 13:18:21 -04:00
Serial
d3e04ff98a
OGG: Stop requiring VorbisComments
to be passed to read_comments
2023-07-05 13:18:21 -04:00
Serial
d711c752e7
changelog: Add entry for #214
2023-07-04 20:57:26 -04:00
Frieder Hannenheim
f3841a37eb
Cargo fix & format
2023-07-04 20:52:10 -04:00
Frieder Hannenheim
f191df4e53
Fix test
2023-07-04 20:52:10 -04:00
Frieder Hannenheim
d4a67d0235
Add test (not working yet)
2023-07-04 20:52:10 -04:00
Frieder Hannenheim
5115e432f0
Actually enable writing KeyValue frames
2023-07-04 20:52:10 -04:00
Frieder Hannenheim
07a2c3ad0d
Implement matching TMCL to KeyValueFrame and rename FrameValue
2023-07-04 20:52:10 -04:00
Frieder Hannenheim
bbb4d5faa7
Update src/id3/v2/items/key_value_frame.rs
...
Co-authored-by: Alex <69764315+Serial-ATA@users.noreply.github.com>
2023-07-04 20:52:10 -04:00
Frieder Hannenheim
17c5f3711e
Update src/id3/v2/frame/mod.rs
...
Co-authored-by: Alex <69764315+Serial-ATA@users.noreply.github.com>
2023-07-04 20:52:10 -04:00
Frieder Hannenheim
5e9dfb88b3
Update src/id3/v2/items/key_value_frame.rs
...
Co-authored-by: Alex <69764315+Serial-ATA@users.noreply.github.com>
2023-07-04 20:52:10 -04:00
Frieder Hannenheim
d9b4382f2b
Update src/id3/v2/write/frame.rs
...
Co-authored-by: Alex <69764315+Serial-ATA@users.noreply.github.com>
2023-07-04 20:52:10 -04:00
Frieder Hannenheim
eb848678c2
fix formatting and clippy errors
2023-07-04 20:52:10 -04:00
Frieder Hannenheim
6a673dd057
- format changes
...
- change doc comments on KeyValueFrame
2023-07-04 20:52:10 -04:00
Frieder Hannenheim
fe8883ccd5
Add support for TIPL frames
2023-07-04 20:52:10 -04:00
Serial
307ef146d1
misc: Move question issues to discussions
2023-07-04 15:53:59 -04:00
Serial
ac3f0effbf
changelog: Update for #212 and #214
2023-07-03 20:29:21 -04:00
Serial
7fd0c3d37a
ID3v2: Simplify text trimming
2023-07-03 20:07:06 -04:00
Serial
4bcae1cf3a
ID3v2: Handle whitespace in number strings
...
Now whitespace will be trimmed and empty strings will be ignored.
2023-07-03 20:07:06 -04:00
Serial
2f995c1513
ID3v2: Fix module doc comment
2023-07-03 20:07:06 -04:00
Serial
d4af6535ba
APE: Properly convert track/disk number pairs when writing
...
This also changes the default track/disk number to `DEFAULT_NUMBER_IN_PAIR`.
closes #159
2023-07-03 20:07:06 -04:00
Serial
1879c46e79
misc: Downgrade Clippy and rustfmt to stable toolchain
2023-07-03 17:29:25 -04:00
Uwe Klotz
97a53c0974
id3v2: Fix skipping of frames
2023-07-03 16:59:33 -04:00
Serial
fb0838ba3b
ID3v2: Add a test for #214
2023-07-03 16:59:33 -04:00
Uwe Klotz
6549e92cf8
id3v2: Don't stop reading after skipping a frame
2023-07-03 16:59:33 -04:00
Uwe Klotz
ae5a7275e7
id3v2: Ignore frames with bad IDs while reading
2023-07-03 16:59:33 -04:00
Alex
f1e8ab6c2f
Discard changes to src/id3/v2/tag.rs
2023-07-02 14:07:18 -04:00
Uwe Klotz
003848c087
id3v2: Report bad or unsupported frame IDs
2023-07-02 14:07:18 -04:00
Serial
bbfaa27085
0.14.0
2023-06-08 14:35:28 -04:00
Serial
2f3f604103
misc: Update deps
2023-06-08 14:32:09 -04:00
Serial
d1183c3ff7
lofty_attr: 0.8.0
2023-06-08 14:16:39 -04:00
Serial
51c526ef0e
misc: Add more categories to Cargo.toml
2023-06-08 14:15:43 -04:00
Serial
17867f53c7
Musepack: Update ID3v2 parsing to new signature
2023-06-06 10:34:37 -04:00
Serial
1fb0aaacc5
changelog: Add entry for Musepack support
2023-06-06 10:34:37 -04:00
Serial
045874829f
Tests: Add missing Musepack SV5 test
2023-06-06 10:34:37 -04:00
Serial
b9e8c5cdd8
Misc: Update SUPPORTED_FORMATS.md
2023-06-06 10:34:37 -04:00
Serial
76823d105b
Clippy: Promote field_reassign_with_default
to global allow list
2023-06-06 10:34:37 -04:00
Serial
b2a604eb3d
musepack: Add fuzz and bench targets
2023-06-06 10:34:37 -04:00
Serial
62190b8f9f
musepack: Support SV4-SV6 property reading
2023-06-06 10:34:37 -04:00
Serial
d89250eef7
musepack: Support SV7 property reading
2023-06-06 10:34:37 -04:00
Serial
6888c17bad
APE: Stop skipping the preamble in tests
2023-06-06 10:34:37 -04:00
Serial
8c854d54a1
musepack: Add SV8 properties test
2023-06-06 10:34:37 -04:00
Serial
314474e77d
musepack: Fix variable length size reading
2023-06-06 10:34:37 -04:00