Mirrors/lofty-rs
2
0
Fork 0
mirror of https://github.com/Serial-ATA/lofty-rs synced 2024-12-13 14:12:31 +00:00
Code Issues Projects Releases Packages Wiki Activity

Add extra verification to tests

Browse source
This commit is contained in:
Serial 2021-04-22 13:56:51 -04:00
parent afbdd35493
commit bd48066b64
2 changed files with 35 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/components/tags/id3_tag.rs
View file

@ -95,7 +95,7 @@ impl AudioTagEdit for Id3v2Tag {
self.inner.year()
}
fn set_year(&mut self, year: i32) {
self.inner.set_year(year as i32)
self.inner.set_year(year)
}
fn remove_year(&mut self) {
self.inner.remove_year()

42
tests/io.rs
View file

@ -7,6 +7,8 @@ macro_rules! full_test {
fn $function() {
println!("-- Adding tags --");
add_tags!($file);
println!("-- Verifying tags --");
verify_write!($file);
println!("-- Removing tags --");
remove_tags!($file);
}
@ -22,23 +24,18 @@ macro_rules! add_tags {
println!("Setting title");
tag.set_title("foo title");
assert_eq!(tag.title(), Some("foo title"));
println!("Setting artist");
tag.set_artist("foo artist");
assert_eq!(tag.artist_str(), Some("foo artist"));
println!("Setting year");
tag.set_year(2020);
assert_eq!(tag.year(), Some(2020));
println!("Setting album title");
tag.set_album_title("foo album title");
assert_eq!(tag.album_title(), Some("foo album title"));
println!("Setting album artists");
tag.set_album_artist("foo album artist");
assert_eq!(tag.album_artists_vec(), Some(vec!["foo album artist"]));
// TODO
// let cover = Picture {
@ -54,6 +51,38 @@ macro_rules! add_tags {
};
}
macro_rules! verify_write {
($file:expr) => {
println!("Reading file");
let tag = Tag::default()
.read_from_path($file, DetermineFrom::Signature)
.unwrap();
let file_name = stringify!($file);
println!("Verifying title");
assert_eq!(tag.title(), Some("foo title"));
println!("Verifying artist");
assert_eq!(tag.artist_str(), Some("foo artist"));
// Skip this since RIFF INFO doesn't support year
if file_name != stringify!("tests/assets/a.wav") {
println!("Verifying year");
assert_eq!(tag.year(), Some(2020));
}
println!("Verifying album title");
assert_eq!(tag.album_title(), Some("foo album title"));
// Skip this since RIFF INFO doesn't guarantee album artist
if file_name != stringify!("tests/assets/a.wav") {
println!("Verifying album artist");
assert_eq!(tag.album_artists_vec(), Some(vec!["foo album artist"]));
}
};
}
macro_rules! remove_tags {
($file:expr) => {
println!("Reading file");
@ -61,9 +90,6 @@ macro_rules! remove_tags {
.read_from_path($file, DetermineFrom::Signature)
.unwrap();
println!("Checking title");
assert_eq!(tag.title(), Some("foo title"));
println!("Removing title");
tag.remove_title();
assert!(tag.title().is_none());