ID3v2: Add Id3v2Tag::get_texts

CHANGELOG.md

@@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   - Support for "RVA2", "OWNE", "ETCO", and "PRIV" frames through
                `id3::v2::{RelativeVolumeAdjustmentFrame, OwnershipFrame, EventTimingCodesFrame, PrivateFrame}`
   - `FrameId` now implements `Display`
+  - `Id3v2Tag::get_texts` for multi-value text frames
 - **MP4**:
   - `Atom::into_data`
   - `Atom::merge`
@@ -22,7 +23,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
     in a tag once and remove them. Those frames are: "MCDI", "ETCO", "MLLT", "SYTC", "RVRB", "PCNT", "RBUF", "POSS", "OWNE", "SEEK", and "ASPI".
   - `Id3v2Tag::remove` will now take a `FrameId` rather than `&str`
   - `FrameId` now implements `Into<Cow<'_, str>>`, making it possible to use it in `Frame::new`
-  - `ID3v2Tag` getters will now use `&FrameId` instead of `&str` for IDs
+  - `Id3v2Tag` getters will now use `&FrameId` instead of `&str` for IDs
 - **MP4**:
   - `Ilst::remove` will now return all of the removed atoms
   - `Ilst::insert_picture` will now combine all pictures into a single `covr` atom

src/id3/v2/tag.rs

@@ -190,6 +190,41 @@ impl Id3v2Tag {
 		None
 	}
 
+	/// Gets all of the values for a text frame
+	///
+	/// NOTE: Multiple values are only supported in ID3v2.4, this will not be
+	///       very useful for ID3v2.2/3 tags.
+	///
+	/// # Examples
+	///
+	/// ```rust
+	/// use lofty::id3::v2::{FrameId, Id3v2Tag};
+	/// use lofty::Accessor;
+	/// use std::borrow::Cow;
+	///
+	/// const TITLE_ID: FrameId<'_> = FrameId::Valid(Cow::Borrowed("TIT2"));
+	///
+	/// let mut tag = Id3v2Tag::new();
+	///
+	/// tag.set_title(String::from("Foo\0Bar"));
+	///
+	/// let mut titles = tag.get_texts(&TITLE_ID);
+	///
+	/// assert_eq!(titles.next(), Some("Foo"));
+	/// assert_eq!(titles.next(), Some("Bar"));
+	/// ```
+	pub fn get_texts(&self, id: &FrameId<'_>) -> Option<impl Iterator<Item = &str>> {
+		if let Some(Frame {
+			value: FrameValue::Text(TextInformationFrame { value, .. }),
+			..
+		}) = self.get(id)
+		{
+			return Some(value.split('\0'));
+		}
+
+		None
+	}
+
 	/// Gets the text for a user-defined frame
 	///
 	/// NOTE: If the tag is [`Id3v2Version::V4`], there could be multiple values separated by null characters (`'\0'`).
@@ -2376,11 +2411,12 @@ mod tests {
 	fn read_multiple_composers_should_not_fail_with_bad_frame_length() {
 		// Issue #255
 		let tag = read_tag("tests/tags/assets/id3v2/multiple_composers.id3v24");
-		assert_eq!(
+		let mut composers = tag
-			tag.get_text(&FrameId::Valid(Cow::Borrowed("TCOM")))
+			.get_texts(&FrameId::Valid(Cow::Borrowed("TCOM")))
-				.as_deref()
+			.unwrap();
-				.unwrap(),
+
-			"A/B"
+		assert_eq!(composers.next(), Some("A"));
-		);
+		assert_eq!(composers.next(), Some("B"));
+		assert_eq!(composers.next(), None)
 	}
 }