Mirrors/lofty-rs
2
0
Fork 0
mirror of https://github.com/Serial-ATA/lofty-rs synced 2024-11-10 06:34:18 +00:00
Code Issues Projects Releases Packages Wiki Activity

Add missing Apple ID3v2 frame IDs to verification

Browse source
This commit is contained in:
Serial 2022-03-20 10:43:19 -04:00
parent bd680be66a
commit 87d9db767d
No known key found for this signature in database
GPG key ID: DA95198DC17C4568
2 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
CHANGELOG.md
View file

@ -41,6 +41,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
It would attempt to read until it reached an EOF if it managed to make it through multiple iterations.
- **FLAC**: Support files with an ID3v2 tag
- This will be read only just like APE, but will allow such files to be read
- **ID3v2**: Support writing proprietary Apple frames
- When writing, frame IDs are verified with their content. The Apple specific frames "MVNM" and "MVIN" were missing,
causing an error if they were written with their proper type (`FrameValue::Text`)
## [0.5.3] - 2022-03-03

2
src/id3/v2/write/frame.rs
View file

@ -31,7 +31,7 @@ fn verify_frame(frame: &FrameRef<'_>) -> Result<()> {
| ("TXXX", FrameValue::UserText(_))
| ("WXXX", FrameValue::UserURL(_))
| (_, FrameValue::Binary(_))
| ("WFED" | "GRP1", FrameValue::Text { .. }) => Ok(()),
| ("WFED" | "GRP1" | "MVNM" | "MVIN", FrameValue::Text { .. }) => Ok(()),
(id, FrameValue::Text { .. }) if id.starts_with('T') => Ok(()),
(id, FrameValue::URL(_)) if id.starts_with('W') => Ok(()),
(id, frame_value) => Err(Id3v2Error::new(Id3v2ErrorKind::BadFrame(