Mirrors/lofty-rs
2
0
Fork 0
mirror of https://github.com/Serial-ATA/lofty-rs synced 2024-12-12 05:32:38 +00:00
Code Issues Projects Releases Packages Wiki Activity

MPEG: Verify the size of APE tags

Browse source
This commit is contained in:
Serial 2024-10-29 20:50:02 -04:00 committed by Alex
parent 8ad3aebfbc
commit 831ac30fa6
3 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lofty/src/mpeg/read.rs
View file

@ -163,7 +163,11 @@ where
// Seek back to the start of the tag
let pos = reader.stream_position()?;
reader.seek(SeekFrom::Start(pos - u64::from(header.size)))?;
let Some(start_of_tag) = pos.checked_sub(u64::from(header.size)) else {
err!(SizeMismatch);
};
reader.seek(SeekFrom::Start(start_of_tag))?;
},
_ => {
// Correct the position (APE header - Preamble)

BIN
lofty/tests/fuzz/assets/mpegfile_read_from/crash-7b5eb183cc14faf3ecc93bdf4a5e30b05f7a537d_minimized Normal file
View file

Binary file not shown.

7
lofty/tests/fuzz/mpegfile_read_from.rs
View file

@ -19,6 +19,13 @@ fn crash2() {
let _ = MpegFile::read_from(&mut reader, ParseOptions::new());
}
#[test_log::test]
fn crash3() {
let mut reader =
get_reader("mpegfile_read_from/crash-7b5eb183cc14faf3ecc93bdf4a5e30b05f7a537d_minimized");
let _ = MpegFile::read_from(&mut reader, ParseOptions::new());
}
#[test_log::test]
fn oom1() {
oom_test::<MpegFile>("mpegfile_read_from/oom-f8730cbfa5682ab12343ccb70de9b71a061ef4d0");