mirror of
https://github.com/sissbruecker/linkding
synced 2025-02-17 04:48:22 +00:00
f4e3d724f0
* Run import in batches, cache tags * Use bulk operations for bookmarks and assigning tags * Improve naming * Restore bookmark validation * Add logging * Bulk create tags * Use HTMLParser for parsing bookmarks * add parser tests * Add more importer tests * Add more importer tests * Remove pyparsing dependency Co-authored-by: Sascha Ißbrücker <sascha.issbruecker@gmail.com>
122 lines
5 KiB
Python
122 lines
5 KiB
Python
from typing import List
|
|
|
|
from django.test import TestCase
|
|
|
|
from bookmarks.services.parser import NetscapeBookmark
|
|
from bookmarks.services.parser import parse
|
|
from bookmarks.tests.helpers import ImportTestMixin, BookmarkHtmlTag
|
|
|
|
|
|
class ParserTestCase(TestCase, ImportTestMixin):
|
|
def assertTagsEqual(self, bookmarks: List[NetscapeBookmark], html_tags: List[BookmarkHtmlTag]):
|
|
self.assertEqual(len(bookmarks), len(html_tags))
|
|
for bookmark in bookmarks:
|
|
html_tag = html_tags[bookmarks.index(bookmark)]
|
|
self.assertEqual(bookmark.href, html_tag.href)
|
|
self.assertEqual(bookmark.title, html_tag.title)
|
|
self.assertEqual(bookmark.date_added, html_tag.add_date)
|
|
self.assertEqual(bookmark.description, html_tag.description)
|
|
self.assertEqual(bookmark.tag_string, html_tag.tags)
|
|
|
|
def test_parse_bookmarks(self):
|
|
html_tags = [
|
|
BookmarkHtmlTag(href='https://example.com', title='Example title', description='Example description',
|
|
add_date='1', tags='example-tag'),
|
|
BookmarkHtmlTag(href='https://foo.com', title='Foo title', description='',
|
|
add_date='2', tags=''),
|
|
BookmarkHtmlTag(href='https://bar.com', title='Bar title', description='Bar description',
|
|
add_date='3', tags='bar-tag, other-tag'),
|
|
]
|
|
html = self.render_html(html_tags)
|
|
bookmarks = parse(html)
|
|
|
|
self.assertTagsEqual(bookmarks, html_tags)
|
|
|
|
def test_no_bookmarks(self):
|
|
html = self.render_html()
|
|
bookmarks = parse(html)
|
|
|
|
self.assertEqual(bookmarks, [])
|
|
|
|
def test_reset_properties_after_adding_bookmark(self):
|
|
html_tags = [
|
|
BookmarkHtmlTag(href='https://example.com', title='Example title', description='Example description',
|
|
add_date='1', tags='example-tag'),
|
|
BookmarkHtmlTag(href='', title='', description='',
|
|
add_date='', tags='')
|
|
]
|
|
html = self.render_html(html_tags)
|
|
bookmarks = parse(html)
|
|
|
|
self.assertTagsEqual(bookmarks, html_tags)
|
|
|
|
def test_empty_title(self):
|
|
html_tags = [
|
|
BookmarkHtmlTag(href='https://example.com', title='', description='Example description',
|
|
add_date='1', tags='example-tag'),
|
|
]
|
|
html = self.render_html(tags_html='''
|
|
<DT><A HREF="https://example.com" ADD_DATE="1" TAGS="example-tag"></A>
|
|
<DD>Example description
|
|
''')
|
|
bookmarks = parse(html)
|
|
|
|
self.assertTagsEqual(bookmarks, html_tags)
|
|
|
|
def test_with_closing_description_tag(self):
|
|
html_tags = [
|
|
BookmarkHtmlTag(href='https://example.com', title='Example title', description='Example description',
|
|
add_date='1', tags='example-tag'),
|
|
BookmarkHtmlTag(href='https://foo.com', title='Foo title', description='',
|
|
add_date='2', tags=''),
|
|
]
|
|
html = self.render_html(tags_html='''
|
|
<DT><A HREF="https://example.com" ADD_DATE="1" TAGS="example-tag">Example title</A>
|
|
<DD>Example description</DD>
|
|
<DT><A HREF="https://foo.com" ADD_DATE="2">Foo title</A>
|
|
<DD></DD>
|
|
''')
|
|
bookmarks = parse(html)
|
|
|
|
self.assertTagsEqual(bookmarks, html_tags)
|
|
|
|
def test_description_tag_before_anchor_tag(self):
|
|
html_tags = [
|
|
BookmarkHtmlTag(href='https://example.com', title='Example title', description='Example description',
|
|
add_date='1', tags='example-tag'),
|
|
BookmarkHtmlTag(href='https://foo.com', title='Foo title', description='',
|
|
add_date='2', tags=''),
|
|
]
|
|
html = self.render_html(tags_html='''
|
|
<DT><DD>Example description</DD>
|
|
<A HREF="https://example.com" ADD_DATE="1" TAGS="example-tag">Example title</A>
|
|
<DT><DD></DD>
|
|
<A HREF="https://foo.com" ADD_DATE="2">Foo title</A>
|
|
''')
|
|
bookmarks = parse(html)
|
|
|
|
self.assertTagsEqual(bookmarks, html_tags)
|
|
|
|
def test_with_folders(self):
|
|
html_tags = [
|
|
BookmarkHtmlTag(href='https://example.com', title='Example title', description='Example description',
|
|
add_date='1', tags='example-tag'),
|
|
BookmarkHtmlTag(href='https://foo.com', title='Foo title', description='',
|
|
add_date='2', tags=''),
|
|
]
|
|
html = self.render_html(tags_html='''
|
|
<DL><p>
|
|
<DT><H3>Folder 1</H3>
|
|
<DL><p>
|
|
<DT><A HREF="https://example.com" ADD_DATE="1" TAGS="example-tag">Example title</A>
|
|
<DD>Example description
|
|
</DL><p>
|
|
<DT><H3>Folder 2</H3>
|
|
<DL><p>
|
|
<DT><A HREF="https://foo.com" ADD_DATE="2">Foo title</A>
|
|
</DL><p>
|
|
</DL><p>
|
|
''')
|
|
bookmarks = parse(html)
|
|
|
|
self.assertTagsEqual(bookmarks, html_tags)
|