diff --git a/bookmarks/services/singlefile.py b/bookmarks/services/singlefile.py index b269fcf..563fd53 100644 --- a/bookmarks/services/singlefile.py +++ b/bookmarks/services/singlefile.py @@ -9,7 +9,7 @@ import subprocess from django.conf import settings -class SingeFileError(Exception): +class SingleFileError(Exception): pass @@ -31,7 +31,7 @@ def create_snapshot(url: str, filepath: str): # check if the file was created if not os.path.exists(temp_filepath): - raise SingeFileError("Failed to create snapshot") + raise SingleFileError("Failed to create snapshot") with open(temp_filepath, "rb") as raw_file, gzip.open( filepath, "wb" @@ -47,12 +47,12 @@ def create_snapshot(url: str, filepath: str): ) process.terminate() process.wait(timeout=20) - raise SingeFileError("Timeout expired while creating snapshot") + raise SingleFileError("Timeout expired while creating snapshot") except subprocess.TimeoutExpired: # Kill the whole process group, which should also clean up any chromium # processes spawned by single-file logger.error("Timeout expired while terminating. Killing process...") os.killpg(os.getpgid(process.pid), signal.SIGTERM) - raise SingeFileError("Timeout expired while creating snapshot") + raise SingleFileError("Timeout expired while creating snapshot") except subprocess.CalledProcessError as error: - raise SingeFileError(f"Failed to create snapshot: {error.stderr}") + raise SingleFileError(f"Failed to create snapshot: {error.stderr}") diff --git a/bookmarks/tests/test_bookmarks_tasks.py b/bookmarks/tests/test_bookmarks_tasks.py index 25a42c9..828b514 100644 --- a/bookmarks/tests/test_bookmarks_tasks.py +++ b/bookmarks/tests/test_bookmarks_tasks.py @@ -536,7 +536,7 @@ class BookmarkTasksTestCase(TestCase, BookmarkFactoryMixin): def test_create_html_snapshot_should_handle_error(self): bookmark = self.setup_bookmark(url="https://example.com") - self.mock_singlefile_create_snapshot.side_effect = singlefile.SingeFileError( + self.mock_singlefile_create_snapshot.side_effect = singlefile.SingleFileError( "Error" ) tasks.create_html_snapshot(bookmark) diff --git a/bookmarks/tests/test_singlefile_service.py b/bookmarks/tests/test_singlefile_service.py index cf02656..c46d730 100644 --- a/bookmarks/tests/test_singlefile_service.py +++ b/bookmarks/tests/test_singlefile_service.py @@ -43,12 +43,12 @@ class SingleFileServiceTestCase(TestCase): with mock.patch("subprocess.Popen") as mock_popen: mock_popen.side_effect = subprocess.CalledProcessError(1, "command") - with self.assertRaises(singlefile.SingeFileError): + with self.assertRaises(singlefile.SingleFileError): singlefile.create_snapshot("http://example.com", self.html_filepath) # so also check that it raises error if output file isn't created with mock.patch("subprocess.Popen"): - with self.assertRaises(singlefile.SingeFileError): + with self.assertRaises(singlefile.SingleFileError): singlefile.create_snapshot("http://example.com", self.html_filepath) def test_create_snapshot_empty_options(self):