Mirrors/leptos
2
0
Fork 0
mirror of https://github.com/leptos-rs/leptos synced 2024-11-10 06:44:17 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix: signals mark subscribers dirty, but don't say they're always dirty if they haven't changed

Browse source
This commit is contained in:
Greg Johnston 2024-06-22 09:11:55 -04:00
parent f9ee36a27e
commit 7094dee150
1 changed files with 16 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
reactive_graph/src/signal/subscriber_traits.rs
View file

@ -57,14 +57,19 @@ impl<T: AsSubscriberSet + DefinedAt> ReactiveNode for T {
if let Some(inner) = self.as_subscriber_set() {
let subs = inner.borrow().write().unwrap().take();
for sub in subs {
sub.mark_check();
sub.mark_dirty();
}
}
}
fn update_if_necessary(&self) -> bool {
// if they're being checked, signals always count as "dirty"
true
// a signal will always mark its dependents Dirty when it runs, so they know
// that they may have changed and need to check themselves at least
//
// however, it's always possible that *another* signal or memo has triggered any
// given effect/memo, and so this signal should *not* say that it is dirty, as it
// may also be checked but has not changed
false
}
}
@ -117,13 +122,18 @@ impl ReactiveNode for RwLock<SubscriberSet> {
fn mark_subscribers_check(&self) {
let subs = self.write().unwrap().take();
for sub in subs {
sub.mark_check();
sub.mark_dirty();
}
}
fn update_if_necessary(&self) -> bool {
// if they're being checked, signals always count as "dirty"
true
// a signal will always mark its dependents Dirty when it runs, so they know
// that they may have changed and need to check themselves at least
//
// however, it's always possible that *another* signal or memo has triggered any
// given effect/memo, and so this signal should *not* say that it is dirty, as it
// may also be checked but has not changed
false
}
}