From 508ad52582c5faa1a57b28dd35f46780f88d51ef Mon Sep 17 00:00:00 2001 From: Greg Johnston Date: Tue, 21 Mar 2023 18:20:29 -0400 Subject: [PATCH] chore: fix clippy warnings (#721) * `v0.2.4` * chore: fix clippy warnings --- Cargo.toml | 28 ++++++++++++++-------------- leptos_macro/src/component.rs | 2 ++ leptos_macro/src/view.rs | 1 + leptos_macro/tests/component.rs | 2 +- meta/Cargo.toml | 2 +- router/Cargo.toml | 2 +- 6 files changed, 20 insertions(+), 17 deletions(-) diff --git a/Cargo.toml b/Cargo.toml index a66fc73cf..7a425e6a4 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -25,22 +25,22 @@ members = [ exclude = ["benchmarks", "examples"] [workspace.package] -version = "0.2.3" +version = "0.2.4" [workspace.dependencies] -leptos = { path = "./leptos", default-features = false, version = "0.2.3" } -leptos_dom = { path = "./leptos_dom", default-features = false, version = "0.2.3" } -leptos_hot_reload = { path = "./leptos_hot_reload", version = "0.2.3" } -leptos_macro = { path = "./leptos_macro", default-features = false, version = "0.2.3" } -leptos_reactive = { path = "./leptos_reactive", default-features = false, version = "0.2.3" } -leptos_server = { path = "./leptos_server", default-features = false, version = "0.2.3" } -server_fn = { path = "./server_fn", default-features = false, version = "0.2.3" } -server_fn_macro = { path = "./server_fn_macro", default-features = false, version = "0.2.3" } -server_fn_macro_default = { path = "./server_fn/server_fn_macro_default", default-features = false, version = "0.2.3" } -leptos_config = { path = "./leptos_config", default-features = false, version = "0.2.3" } -leptos_router = { path = "./router", version = "0.2.3" } -leptos_meta = { path = "./meta", default-feature = false, version = "0.2.3" } -leptos_integration_utils = { path = "./integrations/utils", version = "0.2.3" } +leptos = { path = "./leptos", default-features = false, version = "0.2.4" } +leptos_dom = { path = "./leptos_dom", default-features = false, version = "0.2.4" } +leptos_hot_reload = { path = "./leptos_hot_reload", version = "0.2.4" } +leptos_macro = { path = "./leptos_macro", default-features = false, version = "0.2.4" } +leptos_reactive = { path = "./leptos_reactive", default-features = false, version = "0.2.4" } +leptos_server = { path = "./leptos_server", default-features = false, version = "0.2.4" } +server_fn = { path = "./server_fn", default-features = false, version = "0.2.4" } +server_fn_macro = { path = "./server_fn_macro", default-features = false, version = "0.2.4" } +server_fn_macro_default = { path = "./server_fn/server_fn_macro_default", default-features = false, version = "0.2.4" } +leptos_config = { path = "./leptos_config", default-features = false, version = "0.2.4" } +leptos_router = { path = "./router", version = "0.2.4" } +leptos_meta = { path = "./meta", default-feature = false, version = "0.2.4" } +leptos_integration_utils = { path = "./integrations/utils", version = "0.2.4" } [profile.release] codegen-units = 1 diff --git a/leptos_macro/src/component.rs b/leptos_macro/src/component.rs index 9298897db..a04c5fc5b 100644 --- a/leptos_macro/src/component.rs +++ b/leptos_macro/src/component.rs @@ -130,6 +130,7 @@ impl ToTokens for Model { let mut body = body.to_owned(); body.sig.ident = format_ident!("__{}", body.sig.ident); + #[allow(clippy::redundant_clone)] // false positive let body_name = body.sig.ident.clone(); let (_, generics, where_clause) = body.sig.generics.split_for_impl(); @@ -153,6 +154,7 @@ impl ToTokens for Model { if cfg!(feature = "tracing") { ( quote! { + #[allow(clippy::let_with_type_underscore)] #[cfg_attr( debug_assertions, ::leptos::leptos_dom::tracing::instrument(level = "trace", name = #trace_name, skip_all) diff --git a/leptos_macro/src/view.rs b/leptos_macro/src/view.rs index 470628655..c51c8d22c 100644 --- a/leptos_macro/src/view.rs +++ b/leptos_macro/src/view.rs @@ -365,6 +365,7 @@ enum SsrElementChunks { View(TokenStream), } +#[allow(clippy::too_many_arguments)] fn element_to_tokens_ssr( cx: &Ident, node: &NodeElement, diff --git a/leptos_macro/tests/component.rs b/leptos_macro/tests/component.rs index 116266266..35a23e34d 100644 --- a/leptos_macro/tests/component.rs +++ b/leptos_macro/tests/component.rs @@ -20,7 +20,7 @@ fn Component( #[test] fn component() { let cp = ComponentProps::builder().into("").strip_option(9).build(); - assert_eq!(cp.optional, false); + assert!(!cp.optional); assert_eq!(cp.optional_no_strip, None); assert_eq!(cp.strip_option, Some(9)); assert_eq!(cp.default, NonZeroUsize::new(10).unwrap()); diff --git a/meta/Cargo.toml b/meta/Cargo.toml index f7e03ec6c..14c364cc4 100644 --- a/meta/Cargo.toml +++ b/meta/Cargo.toml @@ -1,6 +1,6 @@ [package] name = "leptos_meta" -version = "0.2.3" +version = "0.2.4" edition = "2021" authors = ["Greg Johnston"] license = "MIT" diff --git a/router/Cargo.toml b/router/Cargo.toml index ac406cce6..8e00fa422 100644 --- a/router/Cargo.toml +++ b/router/Cargo.toml @@ -1,6 +1,6 @@ [package] name = "leptos_router" -version = "0.2.3" +version = "0.2.4" edition = "2021" authors = ["Greg Johnston"] license = "MIT"