clippy stuff

leptos_dom/src/html.rs

@@ -6,12 +6,8 @@ use cfg_if::cfg_if;
 cfg_if! {
   if #[cfg(all(target_arch = "wasm32", feature = "web"))] {
     use crate::events::*;
-    use crate::macro_helpers::Property;
-    use crate::macro_helpers::{
-      attribute_expression, class_expression, property_expression,
-    };
+    use crate::macro_helpers::*;
     use crate::{mount_child, MountKind};
-    use leptos_reactive::create_render_effect;
     use once_cell::unsync::Lazy as LazyCell;
     use wasm_bindgen::JsCast;
 
@@ -46,7 +42,7 @@ cfg_if! {
 use crate::{
   ev::EventDescriptor,
   hydration::HydrationCtx,
-  macro_helpers::{Attribute, Class, IntoAttribute, IntoClass, IntoProperty},
+  macro_helpers::{IntoAttribute, IntoClass, IntoProperty},
   Element, Fragment, IntoView, NodeRef, Text, View,
 };
 use leptos_reactive::Scope;
@@ -493,16 +489,18 @@ impl<El: ElementDescriptor + 'static> HtmlElement<El> {
 
     #[cfg(all(target_arch = "wasm32", feature = "web"))]
     {
-        crate::macro_helpers::attribute_helper(
-            &self.element.as_ref(),
-            name,
-            attr.into_attribute(self.cx)
-        );
-        self
+      attribute_helper(
+        self.element.as_ref(),
+        name,
+        attr.into_attribute(self.cx),
+      );
+      self
     }
 
     #[cfg(not(all(target_arch = "wasm32", feature = "web")))]
     {
+      use crate::macro_helpers::Attribute;
+
       let mut this = self;
 
       let mut attr = attr.into_attribute(this.cx);
@@ -543,17 +541,15 @@ impl<El: ElementDescriptor + 'static> HtmlElement<El> {
     {
       let el = self.element.as_ref();
       let value = class.into_class(self.cx);
-      crate::macro_helpers::class_helper(
-        &el,
-        name.into(),
-        value
-      );
+      class_helper(el, name, value);
 
       self
     }
 
     #[cfg(not(all(target_arch = "wasm32", feature = "web")))]
     {
+      use crate::macro_helpers::Class;
+
       let mut this = self;
 
       let class = class.into_class(this.cx);
@@ -589,11 +585,7 @@ impl<El: ElementDescriptor + 'static> HtmlElement<El> {
       let name = name.into();
       let value = value.into_property(self.cx);
       let el = self.element.as_ref();
-      crate::macro_helpers::property_helper(
-          el,
-          name,
-          value
-      );
+      property_helper(el, name, value);
     }
 
     #[cfg(not(all(target_arch = "wasm32", feature = "web")))]
@@ -910,8 +902,8 @@ fn create_leptos_element(
     if let Some(el) = crate::document().get_element_by_id(&format!("_{id}")) {
       #[cfg(debug_assertions)]
       assert_eq!(
-        el.node_name().to_ascii_uppercase(),
-        &tag,
+        &el.node_name().to_ascii_uppercase(),
+        tag,
         "SSR and CSR elements have the same `TopoId` but different node \
          kinds. This is either a discrepancy between SSR and CSR rendering
             logic, which is considered a bug, or it can also be a leptos \
@@ -950,21 +942,20 @@ fn create_leptos_element(
 #[cfg(all(debug_assertions, target_arch = "wasm32", feature = "web"))]
 fn warn_on_ambiguous_a(parent: &web_sys::Element, child: &View) {
   if let View::Element(el) = &child {
-    if el.name == "a"
+    if (el.name == "a"
       || el.name == "script"
       || el.name == "style"
-      || el.name == "title"
+      || el.name == "title")
+      && parent.namespace_uri() != el.element.namespace_uri()
     {
-      if parent.namespace_uri() != el.element.namespace_uri() {
-        crate::warn!(
-          "Warning: you are appending an SVG element to an HTML element, or \
-           an HTML element to an SVG. Typically, this occurs when you create \
-           an <a/> or <script/> with the `view` macro and append it to an \
-           SVG, but the framework assumed it was HTML when you created it. To \
-           specify that it is an SVG element, use <svg::{{tag name}}/> in the \
-           view macro."
-        )
-      }
+      crate::warn!(
+        "Warning: you are appending an SVG element to an HTML element, or an \
+         HTML element to an SVG. Typically, this occurs when you create an \
+         <a/> or <script/> with the `view` macro and append it to an SVG, but \
+         the framework assumed it was HTML when you created it. To specify \
+         that it is an SVG element, use <svg::{{tag name}}/> in the view \
+         macro."
+      )
     }
   }
 }

leptos_dom/src/hydration.rs

@@ -21,7 +21,7 @@ cfg_if! {
         while let Ok(Some(node)) = walker.next_node() {
           if let Some(content) = node.text_content() {
             if let Some(hk) = content.strip_prefix("hk=") {
-              if let Some(hk) = hk.split("|").next() {
+              if let Some(hk) = hk.split('|').next() {
                 map.insert(hk.into(), node.unchecked_into());
               }
             }