Mirrors/leptos
2
0
Fork 0
mirror of https://github.com/leptos-rs/leptos synced 2024-11-10 06:44:17 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix: can't memoize JS properties, because they can be set between signal updates by user input

Browse source
This commit is contained in:
Greg Johnston 2024-06-17 08:00:13 -04:00
parent f191bb8324
commit 4a80c8b65b
1 changed files with 6 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
tachys/src/html/property.rs
View file

@ -181,9 +181,7 @@ macro_rules! prop_type {
fn rebuild(self, state: &mut Self::State, key: &str) {
let (el, prev) = state;
let value = self.into();
if value != *prev {
R::set_property(el, key, &value);
}
R::set_property(el, key, &value);
*prev = value;
}
@ -229,9 +227,7 @@ macro_rules! prop_type {
fn rebuild(self, state: &mut Self::State, key: &str) {
let (el, prev) = state;
let value = self.into();
if value != *prev {
R::set_property(el, key, &value);
}
R::set_property(el, key, &value);
*prev = value;
}
@ -275,9 +271,7 @@ macro_rules! prop_type_str {
fn rebuild(self, state: &mut Self::State, key: &str) {
let (el, prev) = state;
let value = JsValue::from(&*self);
if value != *prev {
R::set_property(el, key, &value);
}
R::set_property(el, key, &value);
*prev = value;
}
@ -325,9 +319,7 @@ macro_rules! prop_type_str {
fn rebuild(self, state: &mut Self::State, key: &str) {
let (el, prev) = state;
let value = JsValue::from(self.map(|n| JsValue::from_str(&n)));
if value != *prev {
R::set_property(el, key, &value);
}
R::set_property(el, key, &value);
*prev = value;
}
@ -375,9 +367,7 @@ where
fn rebuild(self, state: &mut Self::State, key: &str) {
let (el, prev) = state;
let value = JsValue::from_str(self.as_ref());
if value != *prev {
R::set_property(el, key, &value);
}
R::set_property(el, key, &value);
*prev = value;
}
@ -423,9 +413,7 @@ where
fn rebuild(self, state: &mut Self::State, key: &str) {
let (el, prev) = state;
let value = JsValue::from(self.map(|n| JsValue::from_str(&n)));
if value != *prev {
R::set_property(el, key, &value);
}
R::set_property(el, key, &value);
*prev = value;
}