From 27f2e60d16c9d488ae34500ddeac46f9aca80d61 Mon Sep 17 00:00:00 2001 From: Greg Johnston Date: Wed, 31 Jul 2024 12:45:55 -0400 Subject: [PATCH] chore: clean up unused imports in tests --- reactive_graph/tests/effect.rs | 31 ++++++++++++++++++++----------- reactive_graph/tests/memo.rs | 30 ++++++++++++++++++++++++++---- 2 files changed, 46 insertions(+), 15 deletions(-) diff --git a/reactive_graph/tests/effect.rs b/reactive_graph/tests/effect.rs index 9c4e9f777..536dd0520 100644 --- a/reactive_graph/tests/effect.rs +++ b/reactive_graph/tests/effect.rs @@ -1,18 +1,23 @@ -use any_spawner::Executor; -use reactive_graph::{ - effect::{Effect, RenderEffect}, - prelude::*, - signal::RwSignal, -}; -use std::{ - mem, - sync::{Arc, RwLock}, -}; -use tokio::task; +#[cfg(feature = "effects")] +pub mod imports { + pub use any_spawner::Executor; + pub use reactive_graph::{ + effect::{Effect, RenderEffect}, + prelude::*, + signal::RwSignal, + }; + pub use std::{ + mem, + sync::{Arc, RwLock}, + }; + pub use tokio::task; +} #[cfg(feature = "effects")] #[tokio::test] async fn render_effect_runs() { + use imports::*; + _ = Executor::init_tokio(); task::LocalSet::new() .run_until(async { @@ -46,6 +51,8 @@ async fn render_effect_runs() { #[cfg(feature = "effects")] #[tokio::test] async fn effect_runs() { + use imports::*; + _ = Executor::init_tokio(); task::LocalSet::new() @@ -78,6 +85,8 @@ async fn effect_runs() { #[cfg(feature = "effects")] #[tokio::test] async fn dynamic_dependencies() { + use imports::*; + _ = Executor::init_tokio(); task::LocalSet::new() diff --git a/reactive_graph/tests/memo.rs b/reactive_graph/tests/memo.rs index 13c7dc2bf..7348ac1cb 100644 --- a/reactive_graph/tests/memo.rs +++ b/reactive_graph/tests/memo.rs @@ -1,17 +1,31 @@ -use any_spawner::Executor; use reactive_graph::{ computed::{ArcMemo, Memo}, - effect::{Effect, RenderEffect}, prelude::*, signal::RwSignal, wrappers::read::Signal, }; use std::{ - mem, rc::Rc, sync::{Arc, RwLock}, }; -use tokio::task; + +#[cfg(feature = "effects")] +pub mod imports { + pub use any_spawner::Executor; + pub use reactive_graph::{ + computed::{ArcMemo, Memo}, + effect::{Effect, RenderEffect}, + prelude::*, + signal::RwSignal, + wrappers::read::Signal, + }; + pub use std::{ + mem, + rc::Rc, + sync::{Arc, RwLock}, + }; + pub use tokio::task; +} #[test] fn memo_calculates_value() { @@ -173,6 +187,8 @@ fn diamond_problem() { #[cfg(feature = "effects")] #[tokio::test] async fn dynamic_dependencies() { + use imports::*; + _ = Executor::init_tokio(); let first = RwSignal::new("Greg"); @@ -248,6 +264,8 @@ async fn dynamic_dependencies() { #[cfg(feature = "effects")] #[tokio::test] async fn render_effect_doesnt_rerun_if_memo_didnt_change() { + use imports::*; + _ = Executor::init_tokio(); task::LocalSet::new() @@ -289,6 +307,8 @@ async fn render_effect_doesnt_rerun_if_memo_didnt_change() { #[cfg(feature = "effects")] #[tokio::test] async fn effect_doesnt_rerun_if_memo_didnt_change() { + use imports::*; + _ = Executor::init_tokio(); task::LocalSet::new() @@ -323,6 +343,8 @@ async fn effect_doesnt_rerun_if_memo_didnt_change() { #[cfg(feature = "effects")] #[tokio::test] async fn effect_depending_on_signal_and_memo_doesnt_rerun_unnecessarily() { + use imports::*; + _ = Executor::init_tokio(); task::LocalSet::new()