Mirrors/leptos
2
0
Fork 0
mirror of https://github.com/leptos-rs/leptos synced 2024-11-10 14:54:16 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix: stop memoizing properties in a way that breaks prop:value (closes #768) (#772)

Browse source
This commit is contained in:
Greg Johnston 2023-03-30 19:44:38 -04:00 committed by GitHub
parent 16917997cd
commit 1ff56f7bfd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
leptos_dom/src/macro_helpers/into_property.rs
View file

@ -94,12 +94,7 @@ pub(crate) fn property_helper(
create_render_effect(cx, move |old| { create_render_effect(cx, move |old| {
let new = f(); let new = f();
let prop_name = wasm_bindgen::intern(&name); let prop_name = wasm_bindgen::intern(&name);
if old.as_ref() != Some(&new) property_expression(&el, prop_name, new.clone());
&& !(old.is_none()
&& new == wasm_bindgen::JsValue::UNDEFINED)
{
property_expression(&el, prop_name, new.clone())
}
new new
}); });
} }