From b8b522b42214ccd8b7fb2032afd0e1f4a38b8429 Mon Sep 17 00:00:00 2001
From: Phan An <me@phanan.net>
Date: Sun, 26 Apr 2020 21:14:23 +0200
Subject: [PATCH] chore: more tests for image/cover upload

---
 tests/Feature/AlbumCoverTest.php  | 17 ++++++++++++++++-
 tests/Feature/ArtistImageTest.php | 17 ++++++++++++++++-
 2 files changed, 32 insertions(+), 2 deletions(-)

diff --git a/tests/Feature/AlbumCoverTest.php b/tests/Feature/AlbumCoverTest.php
index 8bfdd567..cfadcd21 100644
--- a/tests/Feature/AlbumCoverTest.php
+++ b/tests/Feature/AlbumCoverTest.php
@@ -34,6 +34,21 @@ class AlbumCoverTest extends TestCase
 
         $this->putAsUser('api/album/9999/cover', [
             'cover' => 'data:image/jpeg;base64,Rm9v'
-        ], factory(User::class, 'admin')->create());
+        ], factory(User::class, 'admin')->create())
+            ->seeStatusCode(200);
+    }
+
+    public function testUpdateNotAllowedForNormalUsers(): void
+    {
+        factory(Album::class)->create(['id' => 9999]);
+
+        $this->mediaMetadataService
+            ->shouldReceive('writeAlbumCover')
+            ->never();
+
+        $this->putAsUser('api/album/9999/cover', [
+            'cover' => 'data:image/jpeg;base64,Rm9v'
+        ], factory(User::class)->create())
+            ->seeStatusCode(403);
     }
 }
diff --git a/tests/Feature/ArtistImageTest.php b/tests/Feature/ArtistImageTest.php
index 3289f7cf..00e4abf1 100644
--- a/tests/Feature/ArtistImageTest.php
+++ b/tests/Feature/ArtistImageTest.php
@@ -34,6 +34,21 @@ class ArtistImageTest extends TestCase
 
         $this->putAsUser('api/artist/9999/image', [
             'image' => 'data:image/jpeg;base64,Rm9v'
-        ], factory(User::class, 'admin')->create());
+        ], factory(User::class, 'admin')->create())
+            ->seeStatusCode(200);
+    }
+
+    public function testUpdateNotAllowedForNormalUsers(): void
+    {
+        factory(Artist::class)->create(['id' => 9999]);
+
+        $this->mediaMetadataService
+            ->shouldReceive('writeArtistImage')
+            ->never();
+
+        $this->putAsUser('api/artist/9999/image', [
+            'image' => 'data:image/jpeg;base64,Rm9v'
+        ], factory(User::class)->create())
+            ->seeStatusCode(403);
     }
 }