Mirrors/koel
2
0
Fork 0
mirror of https://github.com/koel/koel synced 2024-11-27 22:40:26 +00:00
Code Issues Projects Releases Packages Wiki Activity

Rename Download service

Browse source
This commit is contained in:
Phan An 2018-08-18 14:27:17 +02:00
parent f4c00abe02
commit 181357f3de
5 changed files with 8 additions and 107 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/Http/Controllers/API/Download/Controller.php
View file

@ -3,13 +3,13 @@
namespace App\Http\Controllers\API\Download;
use App\Http\Controllers\API\Controller as BaseController;
use App\Services\Download;
use App\Services\DownloadService;
abstract class Controller extends BaseController
{
protected $downloadService;
public function __construct(Download $downloadService)
public function __construct(DownloadService $downloadService)
{
$this->downloadService = $downloadService;
}

4
app/Providers/DownloadServiceProvider.php
View file

@ -2,7 +2,7 @@
namespace App\Providers;
use App\Services\Download;
use App\Services\DownloadService;
use Illuminate\Support\ServiceProvider;
class DownloadServiceProvider extends ServiceProvider
@ -25,7 +25,7 @@ class DownloadServiceProvider extends ServiceProvider
public function register()
{
app()->singleton('Download', function () {
return new Download();
return new DownloadService();
});
}
}

2
app/Services/Download.php → app/Services/DownloadService.php
View file

@ -10,7 +10,7 @@ use App\Models\SongZipArchive;
use Illuminate\Database\Eloquent\Collection;
use InvalidArgumentException;
class Download
class DownloadService
{
/**
* Generic method to generate a download archive from various source types.

6
tests/Feature/DownloadTest.php
View file

@ -7,13 +7,13 @@ use App\Models\Artist;
use App\Models\Playlist;
use App\Models\Song;
use App\Models\User;
use App\Services\Download;
use App\Services\DownloadService;
use Mockery\MockInterface;
class DownloadTest extends TestCase
{
/**
* @var MockInterface|Download
* @var MockInterface|DownloadService
*/
private $downloadService;
@ -21,7 +21,7 @@ class DownloadTest extends TestCase
{
parent::setUp();
$this->createSampleMediaSet();
$this->downloadService = $this->mockIocDependency(Download::class);
$this->downloadService = $this->mockIocDependency(DownloadService::class);
}
/** @test */

99
tests/Integration/Models/InteractionTest.php
View file

@ -1,99 +0,0 @@
<?php
namespace Tests\Integration\Models;
use App\Events\SongLikeToggled;
use App\Models\Interaction;
use App\Models\Song;
use App\Models\User;
use Illuminate\Support\Collection;
use Tests\TestCase;
class InteractionTest extends TestCase
{
/** @test */
public function it_increases_a_songs_play_count()
{
// Given an interaction
/** @var Interaction $interaction */
$interaction = factory(Interaction::class)->create();
// When I call the method to increases the song's play count
Interaction::increasePlayCount($interaction->song, $interaction->user);
// Then I see the play count is increased
/** @var Interaction $interaction */
$updatedInteraction = Interaction::find($interaction->id);
$this->assertEquals($interaction->play_count + 1, $updatedInteraction->play_count);
}
/**
* @test
*
* @throws \Exception
*/
public function it_toggles_like_status()
{
$this->expectsEvents(SongLikeToggled::class);
// Given an interaction
$interaction = factory(Interaction::class)->create();
// When I call the method to toggle the song's like status by user
Interaction::toggleLike($interaction->song, $interaction->user);
// Then I see the interaction's like status is toggled
/** @var Interaction $interaction */
$updatedInteraction = Interaction::find($interaction->id);
$this->assertNotSame($interaction->liked, $updatedInteraction->liked);
}
/**
* @test
*
* @throws \Exception
*/
public function user_can_like_multiple_songs_at_once()
{
$this->expectsEvents(SongLikeToggled::class);
// Given multiple song and a user
/** @var Collection $songs */
$songs = factory(Song::class, 2)->create();
$user = factory(User::class)->create();
// When I call the method to like songs in batch
Interaction::batchLike($songs->pluck('id')->all(), $user);
// Then I see the songs are all liked
$songs->each(function (Song $song) use ($user) {
$this->assertTrue(Interaction::whereSongIdAndUserId($song->id, $user->id)->first()->liked);
});
}
/**
* @test
*
* @throws \Exception
*/
public function user_can_unlike_multiple_songs_at_once()
{
$this->expectsEvents(SongLikeToggled::class);
// Given multiple interaction records
$user = factory(User::class)->create();
/** @var Collection $interactions */
$interactions = factory(Interaction::class, 3)->create([
'user_id' => $user->id,
'liked' => true,
]);
// When I call the method to like songs in batch
Interaction::batchUnlike($interactions->pluck('song.id')->all(), $user);
// Then I see the songs are all liked
$interactions->each(function (Interaction $interaction) {
$this->assertFalse(Interaction::find($interaction->id)->liked);
});
}
}