inspec/test/unit/resources/shadow_test.rb
Miah Johnson b40e553f15 Ensure @params in shadow resource always has a valid value. (#2939)
* Add tests for method chained shadow resource with readable and
unreadable shadow files.

Ensure @params always has a safe value, otherwise we may stacktrace when
unable to read /etc/shadow and invoked with method chaining.

* Wrap deprecation notices with a proc/must_output to clean up test
output.

Added some missing newlines.

Catch deprecation notice on `lines`.

* Resolve the majority of the issues pointed out by @tbramble.

Deprecate `lines`; its really only used internally but it was 'exposed'
through tests and who knows if there is external use. `lines` is not
documented as a property at least..

`#set_params` is much better now =)

Signed-off-by: Miah Johnson <miah@chia-pet.org>
2018-04-12 15:37:22 -04:00

154 lines
5.2 KiB
Ruby

# encoding: utf-8
require 'helper'
require 'inspec/resource'
describe 'Inspec::Resources::Shadow' do
let(:shadow) { load_resource('shadow') }
it 'content should be mapped correctly' do
_(shadow.content).must_equal "root:x:1:2:3\nwww-data:!!:10:20:30:40:50:60"
end
it 'retrieve users via field' do
_(shadow.user).must_equal %w{root www-data}
_(shadow.count).must_equal 2
end
it 'retrieve passwords via field' do
_(shadow.password).must_equal %w{x !!}
end
it 'retrieve last password change via field' do
_(shadow.last_change).must_equal %w{1 10}
end
it 'retrieve min password days via field' do
_(shadow.min_days).must_equal %w{2 20}
end
it 'retrieve max password days via field' do
_(shadow.max_days).must_equal %w{3 30}
end
it 'retrieve warning days for password expiry via field' do
_(shadow.warn_days).must_equal [nil, "40"]
end
it 'retrieve days before account is inactive via field' do
_(shadow.inactive_days).must_equal [nil, "50"]
end
it 'retrieve dates when account will expire via field' do
_(shadow.expiry_date).must_equal [nil, "60"]
end
it 'access all lines of the file' do
proc { _(shadow.lines[0]).must_equal 'root:x:1:2:3::::' }.must_output nil,
"[DEPRECATION] The shadow `lines` property is deprecated and will be removed in InSpec 3.0.\n"
end
it 'access all params of the file' do
_(shadow.entries[0].to_h).must_equal({
user: 'root', password: 'x', last_change: '1',
min_days: '2', max_days: '3', warn_days: nil,
inactive_days: nil, expiry_date: nil, reserved: nil,
content: nil, count: nil
})
end
it 'returns deprecation notice on user property' do
proc { _(shadow.users).must_equal %w{root www-data} }.must_output nil,
'[DEPRECATION] The shadow `users` property is deprecated and will' \
" be removed in InSpec 3.0. Please use `user` instead.\n"
end
it 'returns deprecatation notice on password property' do
proc { _(shadow.passwords).must_equal %w{x !!} }.must_output nil,
'[DEPRECATION] The shadow `passwords` property is deprecated and will' \
" be removed in InSpec 3.0. Please use `password` instead.\n"
end
it 'returns deprecation notice on last_change property' do
proc { _(shadow.last_changes).must_equal %w{1 10} }.must_output nil,
'[DEPRECATION] The shadow `last_changes` property is deprecated and will' \
" be removed in InSpec 3.0. Please use `last_change` instead.\n"
end
it 'returns deprecation notice on expiry_dates property' do
proc { _(shadow.expiry_dates).must_equal [nil, "60"] }.must_output nil,
'[DEPRECATION] The shadow `expiry_dates` property is deprecated and will' \
" be removed in InSpec 3.0. Please use `expiry_date` instead.\n"
end
describe 'multiple filters' do
it 'filters with min_days and max_days' do
_(shadow.filter(min_days: 20, max_days: 30).user).must_equal ['www-data']
_(shadow.filter(last_change: 1, min_days: 2).user).must_equal ['root']
end
end
describe 'when method chained' do
let(:unreadable_shadow) { load_resource('shadow', '/fakepath/fakefile') }
it 'can read /etc/shadow and #filter matches user with no password and inactive_days' do
users = shadow.filter(password: /[^x]/).entries.map { |x| x['user'] }
users.each do |user|
proc { expect(shadow.users(user).user).must_equal(['www-data']) }.must_output nil,
'[DEPRECATION] The shadow `users` property is deprecated and will' \
" be removed in InSpec 3.0. Please use `user` instead.\n"
proc { expect(shadow.users(user).inactive_days).must_equal(['50']) }.must_output nil,
'[DEPRECATION] The shadow `users` property is deprecated and will' \
" be removed in InSpec 3.0. Please use `user` instead.\n"
end
end
it 'cant read /etc/unreadable_shadow and #filter matches nothing' do
users = unreadable_shadow.filter(password: /[^x]/).entries.map { |x| x['user'] }
users.each do |user|
expect(shadow.users(user).user).must_equal([])
expect(shadow.users(user).inactive_days).must_equal([])
end
end
end
describe 'filter via name =~ /^www/' do
let(:child) { shadow.user(/^www/) }
it 'filters by user via name (regex)' do
_(child.user).must_equal ['www-data']
_(child.count).must_equal 1
end
it 'prints a nice to_s string' do
_(child.to_s).must_equal '/etc/shadow with user == /^www/'
end
end
describe 'filter via name = root' do
let(:child) { shadow.user('root') }
it 'filters by user name' do
_(child.user).must_equal %w{root}
_(child.count).must_equal 1
end
end
describe 'filter via min_days' do
let(:child) { shadow.min_days('20') }
it 'filters by property' do
_(child.user).must_equal %w{www-data}
_(child.count).must_equal 1
end
end
describe 'it raises errors' do
it 'raises error on unsupported os' do
resource = MockLoader.new(:windows).load_resource('shadow')
_(resource.resource_skipped?).must_equal true
_(resource.resource_exception_message)
.must_equal 'Resource Shadow is not supported on platform windows/6.2.9200.'
end
end
end