mirror of
https://github.com/inspec/inspec
synced 2024-12-04 02:19:50 +00:00
2bbcdbde9b
* Remove deprecated yumrepo. (#3435) * Remove deprecations for cli `--format` and metadata.rb (#3452) * Remove deprecated database_helpers stderr/stdout methods. Update deprecation text for processes/apache. * Remove deprecations for `--format` and metadata.rb Remove deprecated `format` code. Remove deprecated code test and change json-config format test to use reporter. Remove deprecated metadata.rb code Remove deprecation notice for old supports syntax. Deprecate metadata.rb from source_reader Remove rubocop disables as they are no longer required for this code block. Remove deprecated legacy metadata.rb mock profiles. Remove deprecated metadata.rb profile tests. Remove deprecated yumrepo test. * Allow inspec-3.0 branch to be tested. * Allow appveyor to test inspec-3.0 branch * Change runner tests to use reporter rather than format. Remove deprecated `supports: linux` tests. * Remove skip from inherited profiles from showing up in reporting (breaking change) (#3332) * Skip loading dependency profiles if they are unsupported on the current platform. Skip loading dependencies if they are unsupported on the current platform. Wrap our log and next in a conditional checking if the platform is supported. Change a `if !` into a `unless` Check if the backend is a Train Mock Connection and if so say that the profile does support the platform. While iterating through tests being loaded skip when the platform is unsupported. We now log a WARN when a profile is skipped due to unsupported platform, so lets check that. Modified existing test to log that there are 0 skipped tests, instead of 2. Add functional test that loads profile-support-skip with a json reporter to check that our controls are not loaded and that stderr contains our warning. * Rather than iterating through each test return before recursion if the platform is unsupported. * Resolve tests using a supported platform different from testing platform Add a control to `test/unit/mock/profiles/complete-profile` that would work on any OS with a Internet connection. This allows the profile to execute on any OS with success. `filesystem_spec.rb` was a control that would only work on Linux and some BSD's. We want profile tests to consistently work across development and testing platforms, and not get 'skipped' in some cases. Travis-CI tests on Linux, Inspec Dev team uses Linux and MacOS, Appveyor tests on Windows Also Updated `file_provider_test.rb` for `complete-profile` content changes. If you `MockLoader.load_profile` on a unsupported platform you might not hit the usual skip. Lets handle situations where the tests array in Profile#load_checks_params could be nil. * Use safe navigation rather than checking if tests is nil. Update tests to point to unsupported_inspec and account for WARN changes. Make unsupported_inspec profile support os-family 'unsupported_inspec' * Fix skip bug when using include/require controls. (#3487) * Fix skip bug when using include/require controls. * fix test and feedback. * Remove need for UUID detection for Automate report (#3507) * Add json metadata for skipped profiles (#3495) * Add skip metadata to json reports * Unify skip messages. * Update with status field. * Add testing. * Fix tests. * lint * Add skip exit codes for profile skips. * Update website for 3.0 launch Add `plugins` to sidebar. Change 2.0 -> 3.0 in slim files. Update 3.0 features list. * Fix comments * Update float to numeric. * Change Float to numeric. * updated feature list and impact doc * Change "What's new in InSpec 3.0" -> "Announcing InSpec 3.0" * Bump VERSION to 3.0.0 (#3511) * Remove 3.0 testing checks. * Fix azure link.
220 lines
7.1 KiB
Ruby
220 lines
7.1 KiB
Ruby
# encoding: utf-8
|
|
# copyright: 2017, Chef Software Inc.
|
|
|
|
require 'helper'
|
|
require 'thor'
|
|
|
|
describe 'BaseCLI' do
|
|
let(:cli) { Inspec::BaseCLI.new }
|
|
|
|
describe 'opts' do
|
|
it 'raises if `--password/--sudo-password` are used without value' do
|
|
default_options = { mock: { sudo_password: -1 } }
|
|
Inspec::BaseCLI.stubs(:default_options).returns(default_options)
|
|
|
|
e = proc { cli.send(:opts, :mock) }.must_raise(ArgumentError)
|
|
e.message.must_match(/Please provide a value for --sudo-password/)
|
|
end
|
|
|
|
it 'assumes `--sudo` if `--sudo-password` is used without it' do
|
|
default_options = { mock: { sudo_password: 'p@ssw0rd' } }
|
|
Inspec::BaseCLI.stubs(:default_options).returns(default_options)
|
|
|
|
opts = {}
|
|
out, err = capture_io do
|
|
cli.send(:opts, :mock)[:sudo].must_equal true
|
|
end
|
|
err.must_match /WARN: `--sudo-password` used without `--sudo`/
|
|
end
|
|
|
|
it 'calls `Compliance::API.login` if `opts[:compliance] is passed`' do
|
|
default_options = { mock: { compliance: 'mock' } }
|
|
Inspec::BaseCLI.stubs(:default_options).returns(default_options)
|
|
|
|
InspecPlugins::Compliance::API.expects(:login).with('mock')
|
|
|
|
cli.send(:opts, :mock)
|
|
end
|
|
end
|
|
|
|
describe 'merge_options' do
|
|
let(:default_options) do
|
|
{ exec: { 'reporter' => ['json'], 'backend_cache' => false }}
|
|
end
|
|
|
|
it 'cli defaults populate correctly' do
|
|
Inspec::BaseCLI.stubs(:default_options).returns(default_options)
|
|
|
|
opts = cli.send(:merged_opts, :exec)
|
|
expected = {"backend_cache"=>false, "reporter"=>{"json"=>{"stdout"=>true}}, "type"=>:exec}
|
|
opts.must_equal expected
|
|
end
|
|
|
|
it 'verify platform detect' do
|
|
hash = { name: 'test-os', families: 'aws, cloud', release: 'aws-sdk-v1' }
|
|
expect = <<EOF
|
|
Name: \e[1m\e[35mtest-os\e[0m
|
|
Families: \e[1m\e[35maws, cloud\e[0m
|
|
Release: \e[1m\e[35maws-sdk-v1\e[0m
|
|
EOF
|
|
_(Inspec::BaseCLI.detect(params: hash, indent: 2, color: 35)).must_equal expect
|
|
end
|
|
|
|
it 'json-config options override cli defaults' do
|
|
Inspec::BaseCLI.stubs(:default_options).returns(default_options)
|
|
|
|
parsed_json = { 'backend_cache' => true }
|
|
cli.expects(:options_json).returns(parsed_json)
|
|
|
|
opts = cli.send(:merged_opts, :exec)
|
|
expected = {"backend_cache"=>true, "reporter"=>{"json"=>{"stdout"=>true}}, "type"=>:exec}
|
|
opts.must_equal expected
|
|
end
|
|
|
|
it 'cli options override json-config and default' do
|
|
Inspec::BaseCLI.stubs(:default_options).returns(default_options)
|
|
|
|
parsed_json = { 'backend_cache' => false }
|
|
cli.expects(:options_json).returns(parsed_json)
|
|
|
|
cli_options = { 'backend_cache' => true }
|
|
cli.instance_variable_set(:@options, cli_options)
|
|
|
|
opts = cli.send(:merged_opts, :exec)
|
|
expected = {"backend_cache"=>true, "reporter"=>{"json"=>{"stdout"=>true}}, "type"=>:exec}
|
|
opts.must_equal expected
|
|
end
|
|
|
|
it 'make sure shell does not get exec defaults' do
|
|
Inspec::BaseCLI.stubs(:default_options).returns(default_options)
|
|
|
|
opts = cli.send(:merged_opts)
|
|
expected = {}
|
|
opts.must_equal expected
|
|
end
|
|
|
|
it 'make sure default reporter is overriden by json-config reporter' do
|
|
default_options['reporter'] = ['cli']
|
|
Inspec::BaseCLI.stubs(:default_options).returns(default_options)
|
|
|
|
parsed_json = { 'reporter' => ['json'] }
|
|
cli.expects(:options_json).returns(parsed_json)
|
|
|
|
opts = cli.send(:merged_opts, :exec)
|
|
expected = {"backend_cache"=>false, "reporter"=>{"json"=>{"stdout"=>true}}, "type"=>:exec}
|
|
opts.must_equal expected
|
|
end
|
|
end
|
|
|
|
describe 'configure_logger' do
|
|
let(:options) do
|
|
o = {
|
|
'log_location' => STDERR,
|
|
'log_level' => 'debug',
|
|
'reporter' => {
|
|
'json' => {
|
|
'stdout' => true,
|
|
},
|
|
},
|
|
}
|
|
Thor::CoreExt::HashWithIndifferentAccess.new(o)
|
|
end
|
|
let(:format) do
|
|
device = options[:logger].instance_variable_get(:"@logdev")
|
|
device.instance_variable_get(:"@dev")
|
|
end
|
|
|
|
it 'sets to stderr for log_location' do
|
|
cli.send(:configure_logger, options)
|
|
format.must_equal STDERR
|
|
end
|
|
|
|
it 'sets to stderr for json' do
|
|
options.delete('log_location')
|
|
options.delete('log_level')
|
|
cli.send(:configure_logger, options)
|
|
format.must_equal STDERR
|
|
end
|
|
|
|
it 'sets defaults to stdout for everything else' do
|
|
options.delete('log_location')
|
|
options.delete('log_level')
|
|
options.delete('reporter')
|
|
|
|
cli.send(:configure_logger, options)
|
|
format.must_equal STDOUT
|
|
end
|
|
end
|
|
|
|
describe 'parse_reporters' do
|
|
it 'parse cli reporters' do
|
|
opts = { 'reporter' => ['cli'] }
|
|
parsed = Inspec::BaseCLI.parse_reporters(opts)
|
|
expected_value = { 'reporter' => { 'cli' => { 'stdout' => true }}}
|
|
parsed.must_equal expected_value
|
|
end
|
|
|
|
it 'parses cli report and attaches target_id' do
|
|
opts = { 'reporter' => ['cli'], 'target_id' => '1d3e399f-4d71-4863-ac54-84d437fbc444' }
|
|
parsed = Inspec::BaseCLI.parse_reporters(opts)
|
|
expected_value = {"reporter"=>{"cli"=>{"stdout"=>true, "target_id"=>"1d3e399f-4d71-4863-ac54-84d437fbc444"}}, "target_id"=>"1d3e399f-4d71-4863-ac54-84d437fbc444"}
|
|
parsed.must_equal expected_value
|
|
end
|
|
end
|
|
|
|
describe 'validate_reporters' do
|
|
it 'valid reporter' do
|
|
stdout = { 'stdout' => true }
|
|
reporters = { 'json' => stdout }
|
|
Inspec::BaseCLI.validate_reporters(reporters)
|
|
end
|
|
|
|
it 'invalid reporter type' do
|
|
reporters = ['json', 'magenta']
|
|
proc { Inspec::BaseCLI.validate_reporters(reporters) }.must_raise NotImplementedError
|
|
end
|
|
|
|
it 'two reporters outputting to stdout' do
|
|
stdout = { 'stdout' => true }
|
|
reporters = { 'json' => stdout, 'cli' => stdout }
|
|
proc { Inspec::BaseCLI.validate_reporters(reporters) }.must_raise ArgumentError
|
|
end
|
|
end
|
|
|
|
describe 'suppress_log_output?' do
|
|
it 'suppresses json' do
|
|
opts = { 'reporter' => { 'json' => { 'stdout' => true }}}
|
|
cli.send(:suppress_log_output?, opts).must_equal true
|
|
end
|
|
|
|
it 'do not suppresses json-min when going to file' do
|
|
opts = { 'reporter' => { 'json-min' => { 'file' => '/tmp/json' }}}
|
|
cli.send(:suppress_log_output?, opts).must_equal false
|
|
end
|
|
|
|
it 'suppresses json-rspec' do
|
|
opts = { 'reporter' => { 'json-rspec' => { 'stdout' => true }}}
|
|
cli.send(:suppress_log_output?, opts).must_equal true
|
|
end
|
|
|
|
it 'suppresses json-automate' do
|
|
opts = { 'reporter' => { 'json-automate' => { 'stdout' => true }}}
|
|
cli.send(:suppress_log_output?, opts).must_equal true
|
|
end
|
|
|
|
it 'suppresses junit' do
|
|
opts = { 'reporter' => { 'junit' => { 'stdout' => true }}}
|
|
cli.send(:suppress_log_output?, opts).must_equal true
|
|
end
|
|
|
|
it 'do not suppresses cli' do
|
|
opts = { 'reporter' => { 'cli' => nil } }
|
|
cli.send(:suppress_log_output?, opts).must_equal false
|
|
end
|
|
|
|
it 'do not suppresses cli' do
|
|
opts = { 'reporter' => { 'cli' => nil, 'json' => {'file' => '/tmp/json' }}}
|
|
cli.send(:suppress_log_output?, opts).must_equal false
|
|
end
|
|
end
|
|
end
|