Commit graph

9389 commits

Author SHA1 Message Date
jwdean
6bcef24cbc Modified windows_feature to indicate enabled rather than just available
There are three conditions a windows feature may be in as represented by DISM:

1. Available in the OS and enabled
       dism returns 0 and dism output of state = 'Enabled'
2. Available in the OS but disabled
       dism returns 0 and dism output of state != 'Enabled'
3. Not available  
       dism returns != 0 

This change, in effect, modifies the meaning of installed == true to represent that the feature is both available and enabled. 
installed == false will now indicate the feature is either unavailable or disabled.
The prior implementation indicated the feature was available, but did not recognize the it might be disabled. The most logical use for an InSpec evaluation of a Windows Feature seems to be determining if the feature is enabled or disabled rather than simply available. This updated implementation better represents that goal. 

----------

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the
    best of my knowledge, is covered under an appropriate open
    source license and I have the right under that license to
    submit that work with modifications, whether created in whole
    or in part by me, under the same open source license (unless
    I am permitted to submit under a different license), as
    Indicated in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including
    all personal information I submit with it, including my
    sign-off) is maintained indefinitely and may be redistributed
    consistent with this project or the open source license(s)
    involved.

Signed-off-by: Jeff Dean <jwdean@scriptpro.com>
2021-05-04 15:05:52 -05:00
Tom Duffield
e2dc3d3cdc
Merge pull request #5481 from inspec/tduffield/remove-install-logic
Remove pipeline-specific logic from test scripts
2021-05-04 10:36:13 -05:00
Nikita Mathur
6d140b89b6 Review changes related to inspec compliance to be treated as backward compatible alias
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-05-04 19:04:54 +05:30
Vasu1105
95656f97da Remove TypeData command was causing error when its called in the same session which was resulting into windows_firewall_rule was not working correctly locally when we have more than one describe block for windows_firewall_rule resource
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-05-04 09:22:19 +00:00
Chef Expeditor
f479aa644c Bump version to 4.36.9 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-05-04 01:05:00 +00:00
Clinton Wolfe
1e2b0e79c1
Merge pull request #5487 from inspec/vasundhara/fix_depedent_control_errors
Fix  undefined method `+' for nil:NilClass\n\nProfile: - when using profile dependencies and require_controls
2021-05-03 21:03:27 -04:00
Clinton Wolfe
c61e70b75b Remove unused coveralls hooks from test helper
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2021-05-03 20:58:48 -04:00
Clinton Wolfe
6b4a55aa35 Remove coverage testing from CI
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2021-05-03 20:58:48 -04:00
Chef Expeditor
c07513ebe9 Bump version to 4.36.8 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-05-04 00:55:03 +00:00
Clinton Wolfe
5219faf353
Merge pull request #5498 from inspec/im/fix_link
Fix bad link
2021-05-03 20:52:48 -04:00
Chef Expeditor
ca0a56b1ad Bump version to 4.36.7 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-05-04 00:52:22 +00:00
Clinton Wolfe
37d5b810ed
Merge pull request #5501 from inspec/cw/fix-kitchen
Fixes for the integration-resources pipeline
2021-05-03 20:50:53 -04:00
Clinton Wolfe
06fcd26bee Conditionalize IPv6 support
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2021-05-03 20:18:31 -04:00
Clinton Wolfe
eb5615dd43 Add remaining platforms as separate steps
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2021-05-03 20:00:38 -04:00
Clinton Wolfe
f8c71cf212 Add docker=1 flag
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2021-05-03 19:43:31 -04:00
Clinton Wolfe
cf8bcfb9fa Borrow docker setup script from chef/chef and try a single suite
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2021-05-03 19:30:01 -04:00
Clinton Wolfe
e290877e33 Inline env vars in invocation
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2021-05-03 18:15:41 -04:00
Clinton Wolfe
904dd03cb7 Update kitchenfile name
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2021-05-03 17:21:38 -04:00
Clinton Wolfe
6817ed5aa9 Remove outdated instructions about testing AWS and Azure resources
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2021-05-03 17:04:12 -04:00
Chef Expeditor
0589d2434d Bump version to 4.36.6 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-05-03 21:03:04 +00:00
Clinton Wolfe
fa485a0fdd
Merge pull request #5204 from inspec/cw/add-tk-testing
Reinstate resource testing on supported platforms using Test-Kitchen
2021-05-03 17:01:30 -04:00
Clinton Wolfe
e9c82c62de Correct configuration for pull request trigger for integreation/resources pipeline
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2021-05-03 16:52:29 -04:00
Ian Maddaus
d18520363b Fix bad link
Signed-off-by: Ian Maddaus <Ian.Maddaus@progress.com>
2021-05-03 10:48:11 -07:00
Nikita Mathur
072a8c438f Presenting automate command as alias in both the content and dev docs
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-05-03 13:45:56 +05:30
Clinton Wolfe
3178569290 Run resource integration pipeline when opening PRs
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2021-05-02 22:39:25 -04:00
Clinton Wolfe
1edf2fea13 Enable now-working platforms, and remove EOL amazonlinux 1
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2021-05-02 22:12:31 -04:00
Clinton Wolfe
2c0cd30f25 Exclude fedora from installing iptables, as it causes a conflict
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2021-05-02 22:00:38 -04:00
Clinton Wolfe
ca14b2a901 Conditionally include a kitchen group in the gemfile for ruby 2.7+
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2021-05-02 21:53:24 -04:00
Clinton Wolfe
0b4a9a397b Remove EOL'd platforms
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2021-05-02 21:13:43 -04:00
Clinton Wolfe
a8298b42b7 Rename test:integration to test:kitchen for clarity in Rakefile
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2021-05-02 21:00:05 -04:00
Clinton Wolfe
099060e38d Seems more stable with concurrency 3, may increase later
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2021-05-02 21:00:05 -04:00
Clinton Wolfe
37f39582cc Disable opensuse testing for now
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2021-05-02 21:00:05 -04:00
Clinton Wolfe
26cc73f608 Add note about oraclelinux-8
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2021-05-02 21:00:05 -04:00
Clinton Wolfe
f5c8f67c2b Do not build inspec gem locally or install in os_prepare
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2021-05-02 21:00:05 -04:00
Clinton Wolfe
531abc0f30 Set Kitchenfile path for resource testing
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2021-05-02 21:00:05 -04:00
Clinton Wolfe
e8572d96e0 Add buildkite definition for Dokken kitchen jobs
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2021-05-02 21:00:05 -04:00
Clinton Wolfe
d9d021a861 Update versions of dokken images used and get most of them working; oraclelinux 8 is not working
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2021-05-02 21:00:05 -04:00
Clinton Wolfe
79468b721e Add commentary to kitchen.yml
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2021-05-02 21:00:05 -04:00
Clinton Wolfe
3df3e11c47 We're not talking to automate, don't pretend we are
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2021-05-02 21:00:05 -04:00
Clinton Wolfe
55732b848a Do not use audit cookbook for resource testing
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2021-05-02 21:00:05 -04:00
Clinton Wolfe
3dc64f0d9d Comment out aspirational test suites in kitchen.yml
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2021-05-02 21:00:05 -04:00
Chef Expeditor
dde2017bec Update CHANGELOG.md with details from pull request #5488
Obvious fix; these changes are the result of automation not creative thinking.
2021-05-03 00:51:13 +00:00
Clinton Wolfe
8bcc411608
Merge pull request #5488 from inspec/dependabot/add-v2-config-file
Upgrade to GitHub-native Dependabot
2021-05-02 20:49:57 -04:00
Chef Expeditor
7100701a93 Bump version to 4.36.5 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-05-03 00:40:52 +00:00
Chef Expeditor
99251e903e Update CHANGELOG.md with details from pull request #5492
Obvious fix; these changes are the result of automation not creative thinking.
2021-05-03 00:38:50 +00:00
Clinton Wolfe
44a53a17e4
Merge pull request #5491 from inspec/better_telemetry
Make sure we use chef-telemetry 1.0.8+
2021-05-02 20:38:15 -04:00
Clinton Wolfe
b7103d25ca
Merge pull request #5492 from inspec/new_ruby
Update Ruby in omnibus packages to 2.7.3
2021-05-02 20:37:18 -04:00
Chef Expeditor
66bf825c5f Update CHANGELOG.md with details from pull request #5493
Obvious fix; these changes are the result of automation not creative thinking.
2021-05-03 00:36:56 +00:00
Clinton Wolfe
d3a6fd9399
Merge pull request #5493 from inspec/openssl_bump
Update openssl to 1.1.1k on macos
2021-05-02 20:35:39 -04:00
Tim Smith
a0d15f2908 Update openssl to 1.1.1k on macos
This resolves several CVEs

Signed-off-by: Tim Smith <tsmith@chef.io>
2021-04-30 12:20:01 -07:00