Clinton Wolfe
6b0877591f
Refactor functional test to DRY up
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-12-04 13:32:19 -05:00
Clinton Wolfe
8679443698
Functional test for git fetcher failure handling
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-12-04 13:32:19 -05:00
Clinton Wolfe
4bda0ddeeb
fixture and implementation for git fetcher failure handling
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-12-04 13:32:19 -05:00
Clinton Wolfe
c1d1e6d12f
functional test for URL fetcher
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-12-04 13:32:19 -05:00
Clinton Wolfe
8a3213861a
Fixture and implementation for URL fetcher
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-12-04 13:32:19 -05:00
Clinton Wolfe
0ddf1687f5
A functional test for the local fetcher
...
I hate to do this, but unit testing this reveals odd behavior
in the fetcher - fetching in a unit harness appears to always succeed.
I'd like to make this into a unit test, but for now I want to focus on
the fetchers.
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-12-04 13:30:08 -05:00
Clinton Wolfe
72f1011979
Fixture and implementation for local fetcher error handling
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-12-04 13:30:08 -05:00
Ryan Davis
c5e38d81c4
Merge pull request #4759 from inspec/zenspider/windows-again-and-again
...
Bump windows deadline AGAIN.
2019-12-03 18:43:31 -08:00
Ryan Davis
2fdd68c805
Bump windows deadline AGAIN.
...
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-12-03 18:41:48 -08:00
Miah Johnson
b174273034
Merge pull request #4724 from mbaitelman/add_last_login_user
...
Add last login date to WindowsUser
2019-12-02 13:27:45 -08:00
Miah Johnson
7a837e16d1
Merge pull request #4745 from inspec/mj/cc-coverage
...
Enable Codeclimate Test Coverage
2019-12-02 13:27:00 -08:00
Ryan Davis
fe3c49e705
Merge pull request #4743 from inspec/zenspider/fixtures
...
Suppress output from rubygems installs.
2019-12-02 10:41:04 -08:00
Miah Johnson
fe8f868504
dont set a default simplecov format; we do that elsewhere.
...
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-11-28 00:53:22 -08:00
Miah Johnson
9db7b70e30
remove coveralls; all we need is simplecov
...
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-11-27 22:12:48 -08:00
Ryan Davis
5a0be99ffb
Added 2.7.0 gem repos to our fixtures.
...
This is NOT THE RIGHT WAY to do this... but it fixes a ton of tests. :(
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-11-27 15:42:52 -08:00
Ryan Davis
f2e4fb549c
Address and fix all our ruby 2.7 warnings & errors.
...
This does NOT include fixes for our dependencies that are also having
2.7 warnings (which cause our functional tests to fail because for
some reason we expect stderr to be empty, which is brittle).
I've got upstream PRs to fix all of those. My tests pass locally. I
could push a commit that modifies the Gemfile to use my forks, but I'd
like to see how this fares for now.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-11-27 15:42:52 -08:00
Ryan Davis
d4b3a5c149
Suppress output from rubygems installs.
...
I still wish this wouldn't fetch or install... but in the meantime,
leave my dots alone.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-11-27 13:42:43 -08:00
Clinton Wolfe
6adf7b13be
Merge pull request #4734 from inspec/cw/move-fetchers
...
Move lib/fetchers to lib/inspec/fetchers and re-namspace
2019-11-25 14:56:06 -05:00
Miah Johnson
a636f6bdc9
Merge pull request #4678 from inspec/mj/artifact_tests
...
Add several tests to our artifact suite
2019-11-25 11:53:57 -08:00
Miah Johnson
c993f91ca6
rubocop is on the beat
...
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-11-22 12:48:56 -08:00
Clinton Wolfe
9792bae00d
Move the registry cache object
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-11-22 10:09:51 -05:00
Clinton Wolfe
d9f55bf85c
Singularize the fetchers directory name
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-11-22 09:57:28 -05:00
Miah Johnson
45070c15c0
Fixup tests
...
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-11-21 17:01:10 -08:00
Clinton Wolfe
7807c3fa01
Re-namespace core Fetchers
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-11-18 13:20:35 -05:00
Clinton Wolfe
80ef0eeeba
Take back the Inspec::Fetcher namespace
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-11-15 16:23:00 -05:00
Mendy Baitelman
6baf0f8a1c
Fix tests
...
Signed-off-by: Mendy Baitelman <mendy@baitelman.com>
2019-11-14 21:22:07 -08:00
Ryan Davis
89888be944
Removing the osx? guard that has been pushed to minitest and released.
...
This is mostly to bump a release because our last one blew up.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-11-14 15:05:13 -08:00
Clinton Wolfe
b39d47bda7
Move fetcher files
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-11-14 15:25:43 -05:00
Mendy Baitelman
4ba95a0236
Fix syntax, start tests
...
Signed-off-by: Mendy Baitelman <mendy@baitelman.com>
2019-11-13 23:08:23 -08:00
Ryan Davis
540521031b
Merge pull request #4707 from inspec/zenspider/apt-fix
...
Fixes parsing of apt config files with arch specifier.
2019-11-13 15:48:15 -08:00
Ryan Davis
4e818faeb4
Fixes parsing of apt config files with arch specifier.
...
Fixes #4683 .
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-11-12 15:08:06 -08:00
Ryan Davis
865e0d43c0
Fixed a race condition in the tests on windows.
...
Second test would always fail, resumably because the GC kicks in and
the tempfile gets obliterated before the subprocess can read it.
Don't do tempfiles via let. Do them via ivars so they can persist.
2019-11-12 14:51:56 -08:00
Ryan Davis
efc51c44d9
Fixes to get inspec_exec_test.rb green on Windows.
2019-11-12 14:51:56 -08:00
Ryan Davis
f8ea33de8f
Added test command caching and refactored inspec helper to run_cmd.
...
Helps with some of the tests that want to run ruby directly.
Fixes #4416 .
2019-11-12 14:51:56 -08:00
Ryan Davis
bb7e69d145
Fixes for some of the inspec exec tests under Windows.
2019-11-12 14:51:56 -08:00
Ryan Davis
4242937bea
Changed a bunch of profiles to use / instead of /tmp for Windows compat.
2019-11-12 14:51:56 -08:00
Ryan Davis
2eaebe510c
Fixed installer_test by testing subsets of the paths.
...
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-11-12 14:51:56 -08:00
Ryan Davis
d1f67c02d0
Get the license_tests passing
...
...mostly by skipping
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-11-12 14:51:56 -08:00
Ryan Davis
e60dc84188
Cleaned up inspec artifact testing.
...
Removed redundant test/functional/inspec_artifact_test.rb
Cleaned up lib/plugins/inspec-artifact/test/functional/inspec_artifact_test.rb
Made an error on windows (install-profile fails) raise instead of just print.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-11-12 14:50:39 -08:00
Ryan Davis
c3fe1697bb
Fix the way we determine (and clean) the repo_path in functionals.
...
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-11-12 14:50:39 -08:00
Ryan Davis
ee327094fb
Strip all ANSI color codes from output in inspec_shell_test.rb
...
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-11-12 14:50:39 -08:00
Ryan Davis
b3b8336620
Get inspec_exec_test.rb passing on windows w/o skips.
...
+ Clean up lockfiles in profiles. (we shouldn't be creating these!)
+ Fix some exit code assertions based on platform.
+ Had to skip 2 tests (with timebombs) because this is rebased off of my performance branch which has 2 failures.
signed-off-by: Ryan Davis <zenspider@chef.io>
2019-11-12 14:50:39 -08:00
Ryan Davis
bfc8b357bf
Clean up testing in inspec exec by stripping ansi color codes from output.
...
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-11-12 14:50:39 -08:00
Clinton Wolfe
1db2941a9e
Fix for invocation when calling npm under sudo ( #4548 )
...
Fix for invocation when calling npm under sudo
2019-11-12 16:01:07 -05:00
Bryan McLellan
e4a096ba83
Merge pull request #4680 from inspec/btm/warn-objects
...
Deprecate inspec/object/* classes
2019-11-12 15:30:45 -05:00
Miah Johnson
6510679e6a
dont clobber
...
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-11-09 13:38:00 -08:00
Miah Johnson
b6b6afb29d
dry up other tests
...
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-11-09 13:36:15 -08:00
Miah Johnson
96d7eab62f
dry up exists tests
...
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-11-09 13:35:17 -08:00
Ryan Davis
b1c2af209b
Corresponding fixes for the move from test/unit/mock to test/fixtures.
...
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-11-08 19:20:12 -08:00
Ryan Davis
e8ca7d3cd3
Suppress output from rubygems installs.
...
I still wish this wouldn't fetch or install... but in the meantime,
leave my dots alone.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-11-08 18:35:23 -08:00
Ryan Davis
db8e6e7415
Moved test/unit/mock/* to test/fixtures
...
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-11-08 16:29:03 -08:00
Ryan Davis
244c7bbed4
Merge pull request #4677 from inspec/zenspider/bump-chefstyle
...
Bump chefstyle and fix up flagged code.
2019-11-08 16:07:42 -08:00
Ryan Davis
bb49d58cd9
Switched chefstyle back to Layout/AlignArguments=with_first_argument.
...
Fixed the flags mostly with `chefstyle -a` but also refactored/cleaned
some stuff by hand.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-11-08 12:57:43 -08:00
Bryan McLellan
3670500701
Deprecate inspec/object/* classes
...
The classes in inspec/object have been moved to the inspec-objects
library. They aren't used directly by Inspec and will be removed in the
next major release.
Signed-off-by: Bryan McLellan <btm@loftninjas.org>
2019-11-08 15:09:09 -05:00
Miah Johnson
6f829c2d27
drop leading /bin
...
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-11-07 17:13:49 -08:00
Miah Johnson
71e72af079
Change flunk to skip. drop parallelize me until multiple tests
...
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-11-07 16:19:19 -08:00
Miah Johnson
2a2dd29e5b
I moved up open3, so lets delete these
...
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-11-07 15:55:50 -08:00
Miah Johnson
ca1416fb0a
Add some very basic tests. Several of which outright flunk!
...
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-11-07 15:42:48 -08:00
Miah Johnson
6ad21441e4
Move exist checks to own test. Use open3
...
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-11-07 15:34:21 -08:00
Clinton Wolfe
f85de31292
Update test mock file to match invocation
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-11-07 15:39:08 -05:00
Miah Johnson
549e3c196e
Merge pull request #4675 from inspec/mj/hab1101
...
Get artifact/habitat starting tests on both Windows and Linux
2019-11-07 12:13:31 -08:00
Miah Johnson
13a1c30ba6
Corret build scripts
...
correct path to hab artifact
Rather than throwing, lets try to install the version
Make sure hab is in the path
we use -b on windows. lets be consistent
export project_root too
picardface
fix regex
execute rake _through_ habitat
make test vrooom
test presence of inspec
strip out clixml bs
... no which on bk.
full path to which
export PATH
test exist on linux/windows
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-11-07 10:09:35 -08:00
Clinton Wolfe
d9f34dda58
Make input() work in describe.one ( #4666 )
...
Make input() work in describe.one
2019-11-07 11:58:11 -05:00
Mendy Baitelman
1a9a47ee96
Merge remote-tracking branch 'upstream/master' into add-startuser-systemd-service
...
Signed-off-by: Mendy Baitelman <mendy@baitelman.com>
2019-11-04 21:07:56 -08:00
Clinton Wolfe
c045de4399
Temporarily add functional test for input in describe.one in isolated commit
...
As there is a team desire to move away from functional tests,
this commit is intended to be easily reverted once a facility for
running test fixture policies as unit tests in a clear way.
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-11-01 16:52:21 -04:00
Clinton Wolfe
f9b65cc54c
Test fixture profile for inputs in describe.one
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-11-01 16:52:21 -04:00
Ryan Davis
e54f0b3646
Fixed runner tests for windows.
...
Passes on my side and only fails on buildkite's windows. I have no
idea why / how it differs. This should be neutral enough that it works
on both.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-31 15:20:58 -07:00
Miah Johnson
1b93755410
Merge pull request #4653 from landychan/lchan/bug-fix-3611
...
Nginx Resource: Add parsing support for wildcard, dot prefix, and regex
2019-10-31 14:20:08 -07:00
Miah Johnson
7a68d58904
Merge pull request #4654 from inspec/mj/oracle
...
oracledb_session fixes
2019-10-31 14:13:56 -07:00
Miah Johnson
de4139aff8
Merge pull request #4568 from ramereth/yum-el8-support
...
Improve testing for yum.repo in CentOS 8
2019-10-31 14:13:05 -07:00
Ryan Davis
74c692c9eb
Pushed unmock up to helper.rb
...
Also switched osx group test to use quick_resource since it is cleaner.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-31 14:09:16 -07:00
Ryan Davis
fdc82b7d12
Tests shouldn't output. Ever.
...
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-31 14:09:16 -07:00
Ryan Davis
defe63dada
Test for bug #4524 and bug #4587 to verify that resources are available w/in rspec constructs.
...
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-31 14:09:16 -07:00
Miah Johnson
314715d9f8
let there be tests
...
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-30 19:11:38 -07:00
Miah Johnson
9173674ecd
Unsure why old mocking system is broken.
...
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-30 17:27:01 -07:00
Landy Chan
9e38bec396
Added wildcard and dot-prefixed identifier support. Combined regex identifier into standard identifier
...
Signed-off-by: Landy Chan <landychan92@gmail.com>
2019-10-30 16:39:38 -07:00
Landy Chan
e60179b91f
Added regex identifier
2019-10-30 13:51:20 -07:00
Miah Johnson
66cb95b2ca
Add tests to cover Linux/Windows differences in sqlplus execution
...
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-30 12:26:12 -07:00
Ryan Davis
83a6bd84dd
bumped the windows tests again
...
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-30 01:47:16 -07:00
Ryan Davis
f56ccb16cb
Merge pull request #4628 from inspec/zenspider/minitest-output
...
Fixed the rest of the minitest deprecations by removing FuncTestRunResult.
2019-10-29 14:47:36 -07:00
Miah Johnson
9c953a0e68
Merge pull request #4638 from inspec/mj/eha
...
Add #to_s to etc_hosts_allow, and add tests
2019-10-24 13:24:46 -07:00
Miah Johnson
44579ab4b3
Merge pull request #4637 from inspec/mj/3921
...
Fix filesystem resource when device has long name
2019-10-24 13:24:23 -07:00
Miah Johnson
ac399b7af9
Add #to_s to etc_hosts_allow, and add tests
...
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-24 12:07:26 -07:00
Lance Albertson
dab91a321a
Improve testing for yum.repo in CentOS 8
...
The output for ``yum -v repolist all`` changes slightly in CentOS 8. There are
two specific changes:
1. EL8 is no longer trailing the repo name with release version and arch (i.e.
base instead of base/7/x86)
2. EL8 no longer adds a trailing newline on the last repo and instead has a line
with ``Total packages:``. This means the repo listed last will never show up.
A fix was introduced in #4566 however the tests still use CentOS 7 yum output
instead of dnf repolist output. One issue was still discovered where it was
including the ``Total packages`` line in the last repository. This includes a
regex for to work around that and fixes for the tests.
Signed-off-by: Lance Albertson <lance@osuosl.org>
2019-10-24 08:22:42 -07:00
Miah Johnson
8e31367b51
Use new mock loader, update the command name
...
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-23 21:42:10 -07:00
Miah Johnson
e357232db1
Since our command is df -PT
lets match it in name
...
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-23 21:33:29 -07:00
Ryan Davis
8d51d878f6
Fixed users resource when "Last password change" is "never".
...
Extended quick_resource to have platform methods and a new string
command mock. The named resource to mock may now be a symbol.
Added a new test that shows how to use quick_resource with multiple commands.
Fixes #4629 .
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-23 16:49:49 -07:00
Ryan Davis
d201d1fbc2
Fixed the rest of the minitest deprecations by removing FuncTestRunResult.
...
Folded the json & other payloads into plain ivars on the test.
Found and removed some unused code while I was there.
Fixes #4533 .
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-22 12:15:28 -07:00
Ryan Davis
8d4e8c1d96
Merge pull request #4627 from inspec/zenspider/json-and-resource-cleanup
...
JSON processing and resource cleanup
2019-10-21 14:26:37 -07:00
Ryan Davis
9be2accf5d
Merge pull request #4598 from inspec/zenspider/win
...
Clean up testing in inspec exec by stripping ansi color codes from output.
2019-10-21 13:48:07 -07:00
Ryan Davis
e5e1a745cc
Fixed run_inspec_with_plugin to merge run options properly.
...
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-21 13:30:14 -07:00
Ryan Davis
b626c37386
Improve debugging of json parse failures in functional tests.
...
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-21 13:30:14 -07:00
Ryan Davis
fdaea02427
Clean up testing in inspec exec by stripping ansi color codes from output.
...
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-21 12:46:37 -07:00
Ryan Davis
dd3043a992
Merge pull request #4619 from inspec/zenspider/empty-tarball
...
Fix TarProvider when the tarball has empty files in it.
2019-10-21 12:31:29 -07:00
Ryan Davis
e4f4f5d1cc
Fix TarProvider when the tarball has empty files in it.
...
Added a unit test that runs in ~0.1s. Let's avoid heavy integration
tests where possible.
Fixes #4616
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-18 14:30:00 -07:00
Ryan Davis
3d604348a4
Merge pull request #4566 from inspec/zenspider/mock
...
Refactored and added an alternative test mock resource system.
2019-10-18 13:36:42 -07:00
Miah Johnson
23f31a0a72
Use a good profile with inspec check test
...
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-17 14:55:58 -07:00
Miah Johnson
d47d25e5cc
Merge pull request #4501 from inspec/mj/habitat-windows
...
Habitat plan for Windows
2019-10-17 13:54:50 -07:00
Miah Johnson
245f681cb8
Merge pull request #4601 from inspec/mj/tk
...
Re-organize test-kitchen files. Add BK Pipeline
2019-10-17 12:49:31 -07:00
Miah Johnson
e298f0f44b
move find_files inspec policy to kitchen directory
...
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-16 22:41:03 -07:00
Miah Johnson
e8ae9012ea
Move inspec-verify kitchen tests into more obvious directory
...
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-16 22:41:03 -07:00
Miah Johnson
97a258ae69
Use a more obvious directory structure for kitchen testing
...
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-16 22:41:03 -07:00
Miah Johnson
6e88b3ceb9
Fix rubocop warnings
...
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-16 21:01:19 -07:00
Miah Johnson
46e7b00add
Fix Rakefile and wtf
...
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-16 21:01:19 -07:00
Miah Johnson
9543ed8ecc
Add a Rakefile as our main Rakefile also requires 'train'
...
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-16 21:01:19 -07:00
Miah Johnson
4544ff30aa
Add a very simple test for Windows Habitat builds.
...
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-16 21:01:19 -07:00
Miah Johnson
6f460b9c3b
Remove this. It slows things down.
...
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-16 20:57:31 -07:00
Ryan Davis
fe34eb7869
Moved quick_resource and Fake helpers to test/helpers/resources.rb
...
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-16 16:54:07 -07:00
Ryan Davis
fc8ea79ad0
Fixed parsing yum output on centos8.
...
* Renamed and added extra test data to distinguish between centos 7 & centos 8.
* Renamed and added extra tests to cover centos 8.
* Fixed missing repo data by checking at the end if we were still in parse mode.
Fixes #4517
Signed-off-by: Ryan Davis <zenspider@chef.io>
Cc: Miah Johnson <miah@chia-pet.org>
2019-10-16 16:54:07 -07:00
Ryan Davis
201d98fd26
Refactored and added an alternative test mock resource system.
...
test/unit/resources/json_test.rb had the start of a setup to directly
instantiate resources. I've refactored that up to helper.rb and
extended it with some helper methods so we can directly specify what a
resource command should respond with. For many/most of our tests, this
should be sufficient.
Finally, I switched our yum tests over to use the new setup. This will
allow us to address #4517 and extend the tests for centos8 output
differences with ease. Ease, folks... ease.
Signed-off-by: Ryan Davis <zenspider@chef.io>
Cc: Miah Johnson <miah@chia-pet.org>
2019-10-16 16:54:07 -07:00
Miah Johnson
d48bb56087
Every other example has the value set to 1, so I changed this for consistency.
...
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-16 10:15:49 -07:00
Miah Johnson
4ec9f302b0
example -> example.tmp
...
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-16 10:15:49 -07:00
Miah Johnson
c3eb686b51
Remove debug
...
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-16 10:15:49 -07:00
Miah Johnson
301905e8de
b0rk b0rk
...
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-16 10:15:49 -07:00
Miah Johnson
41bc8fd7a0
Clean up some tests
...
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-16 10:15:49 -07:00
Miah Johnson
ae3ee6f657
Finish rename of example -> example-tmp.rb
...
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-16 10:13:24 -07:00
Miah Johnson
a40ec993e8
Rename files to remove references to gordon
...
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-16 10:13:24 -07:00
Miah Johnson
df7efefc9d
mostly a search and replace for gordon -> example
...
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-16 10:13:24 -07:00
Clinton Wolfe
bde308f72d
Replace input to_hash method, and add unit test for it ( #4545 )
...
Replace input to_hash method, and add unit test for it
2019-10-11 10:50:27 -07:00
Clinton Wolfe
b09edbbbf9
And the YAML fixture too.
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-10-09 20:49:33 -07:00
Clinton Wolfe
8f4ff8923e
Add functional test to exercise waivers during profile inheritance
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-10-09 19:10:48 -07:00
Ryan Davis
f9ec3053aa
Refactored unit test to be more like the other one.
...
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-09 17:41:03 -07:00
Ryan Davis
26ffea8d39
Make my diffs pretty for jsonmin tests.
...
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-09 17:40:53 -07:00
Ryan Davis
f3fc535fee
Changed formatting and ordering of test data to reduce diffs on failing tests.
...
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-09 17:40:31 -07:00
Clinton Wolfe
d150a568cd
More test fixes
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-10-09 17:20:24 -07:00
Clinton Wolfe
3c266655ee
Refactor exec-json functional tests to reduce subprocesses
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-10-08 21:04:58 -07:00
Clinton Wolfe
ba61cd3f45
Update JSON schema to reflect new waiver keys
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-10-08 21:01:19 -07:00
Clinton Wolfe
01991cc347
Update some failing test fixtures
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-10-08 21:00:11 -07:00
Clinton Wolfe
0f5fde9729
Modify waiver input file to use 'run' subfield instead of 'skip'
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-10-08 01:03:40 -07:00
Clinton Wolfe
7516f959d1
If there is no data, alwaya return an empty hash.
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-10-08 00:31:23 -07:00
Clinton Wolfe
56c2416c57
Move waiver JSON data from per-result to per-control
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-10-08 00:25:06 -07:00
Clinton Wolfe
88ed1794cb
Revert to a small amount of duplicating to_hash in inspec/input.rb
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-10-06 19:30:37 -04:00
Miah Johnson
e48d08343b
Merge pull request #4452 from mhackethal/user-windows-fix
...
User windows fix
2019-10-04 15:30:37 -07:00
Clinton Wolfe
11074bb7ce
Adjust indentation
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-10-04 14:06:49 -04:00
Clinton Wolfe
36db8b9a7b
Rely on copy of to_hash in objects/input.rb to avoid duplication
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-10-04 14:05:19 -04:00
Clinton Wolfe
51812a9e4e
Replace to_hsh method, and add unit test for it
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-10-04 14:05:19 -04:00
Miah Johnson
416c33e056
Add name property to interface resource
...
Also some general cleanup.
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-03 14:53:43 -07:00
Ryan Davis
6fd2db256d
Merge pull request #4560 from inspec/zenspider/apt
...
Fixed apt resource incorrectly parsing deb files w/ quoted URIs.
2019-10-03 14:50:48 -07:00
Ryan Davis
07dc5e3192
First pass at cleaning deprecations for old minitest/spec-style tests.
...
3 files left to go, and they're behaving oddly so I'm leaving them out
in this pass. Looks like 21 deprecations left.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-03 13:45:19 -07:00
Ryan Davis
09392943f5
Fixed apt resource incorrectly parsing deb files w/ quoted URIs.
...
Fixes #4559 .
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-03 12:55:15 -07:00
Ryan Davis
e070f151b9
Merge pull request #4557 from inspec/zenspider/rspec-expectations
...
Fixed tests to work with rspec-expectations 3.8.5+.
2019-10-03 12:51:08 -07:00
Ryan Davis
708a319ce8
Fixed tests to work with rspec-expectations 3.8.5+.
...
We were using a "private" method in our tests and they changed the
signature.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-02 18:08:19 -07:00
Ryan Davis
d1fbbada4d
Yet another bump of our skip_windows! due date.
...
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-09-30 12:23:15 -07:00
Ryan Davis
866efdf141
Merge pull request #4531 from inspec/mj/wtf_rake
...
Remove maintainers task from require
2019-09-27 14:45:21 -07:00
Ryan Davis
984e02e312
Quick fix for faraday_middleware bug introduced when bumping to faraday 0.16.0.
...
Namespacing changed in faraday from Faraday::Error::* to Faraday::*
but was not reflected in faraday_middleware (which hasn't released
since February). I will file an issue and/or PR with them later.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-09-27 14:19:45 -07:00
Ryan Davis
fd1ab6fff0
Merge pull request #4513 from inspec/zenspider/plugin_loader
...
Fixed Inspec::Plugin::V2::Registry#detect_system_plugins
2019-09-26 12:29:29 -07:00
Ryan Davis
ca4844210d
Fixed Inspec::Plugin::V2::Registry#detect_system_plugins
...
+ Falls back to checking for inspec-core if inspec not found.
+ Fails gracefully if neither are found.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-09-25 16:10:00 -07:00
Mendy Baitelman
d44f9edc55
Merge remote-tracking branch 'upstream/master' into add-startuser-systemd-service
...
Signed-off-by: Mendy Baitelman <mendy@baitelman.com>
2019-09-24 22:30:51 -07:00
Mendy Baitelman
d45963cd91
Fix spacing
...
Signed-off-by: Mendy Baitelman <mendy@baitelman.com>
2019-09-24 21:58:55 -07:00
Mendy Baitelman
76cd799c92
Add to params for tests
...
Signed-off-by: Mendy Baitelman <mendy@baitelman.com>
2019-09-24 21:49:29 -07:00
Ryan Davis
90c4904a55
Merge pull request #4490 from inspec/zenspider/split-long-functional
...
Split and parallelize some tests to make them faster
2019-09-24 17:45:57 -07:00
Irving Popovetsky
bbb927e3dd
Remove invalid test cases for tags
...
Signed-off-by: Irving Popovetsky <irving@chef.io>
2019-09-17 15:58:12 -07:00
Irving Popovetsky
4aebe87c2e
Update unit tests to match
...
Signed-off-by: Irving Popovetsky <irving@chef.io>
2019-09-17 15:58:12 -07:00
Ryan Davis
fc1ad67ffc
More parallelization for functionals.
...
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-09-17 11:50:31 -07:00
Ryan Davis
a473a94303
Merge pull request #4493 from inspec/mj/waiver3
...
Waivers Phase 3
2019-09-16 17:50:02 -07:00
Ryan Davis
d3f81f1194
Turn on parallelism for inspec_shell_test.rb
...
Seems safe after several runs.
Takes the time down from ~180s to 22s.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-09-16 17:19:32 -07:00
Ryan Davis
ba462724db
Turn on parallelism for inspec_exec_test.rb
...
Seems safe after several runs.
Takes the time down from ~275s to 35s.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-09-16 17:19:32 -07:00
Ryan Davis
a0a7917faa
Merge pull request #4485 from inspec/zenspider/objects-inputs
...
Split out Inspec::Input functional code from the code generation code.
2019-09-16 17:03:49 -07:00
Ryan Davis
1d3c9341ec
Finished up the phase 3 waiver json output tests.
...
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-09-16 16:39:34 -07:00
Miah Johnson
5d94b0d709
Add waiver_data to json output, update assertion to show where waiver_data lives.
...
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-09-16 14:49:05 -07:00
Miah Johnson
168c77e472
Refactor tests.
...
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-09-16 14:49:05 -07:00
Ryan Davis
e375ea30c8
Split out Inspec::Input functional code from the code generation code.
...
Includes moving errors into Inspec::Input and Inspec::InputRegistry.
Fixes #4456 .
Fixes #4473 .
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-09-13 17:12:20 -07:00
mhackethal
c3270b537a
update user_test.rb
...
Signed-off-by: mhackethal <mh@it31.de>
2019-09-13 21:19:20 +02:00
mhackethal
0b76859728
adjust user_test.rb
2019-09-13 20:45:54 +02:00
mhackethal
9e06f02e27
Update user_test.rb
...
adjust expectation of methods to be "nil" on windows
2019-09-13 13:14:34 +02:00
Miah Johnson
008ac9705b
Merge pull request #4484 from timgates42/feature/typo_becuase
...
Fix simple typo: becuase -> because
2019-09-12 17:25:37 -07:00
Tim Gates
f1e88ca65f
Fix simple typo: becuase -> because
...
Obvious Fix.
2019-09-13 09:30:00 +10:00
mhackethal
7ac468df5b
first test. Signed-off-by: mhackethal <mh@it31.de>
2019-09-12 21:44:13 +02:00
Clinton Wolfe
8132aaf85c
Merge pull request #3844 from inspec/ja/add-error-output-to-json-command
...
json resource: Add handling for `command:` error
2019-09-11 11:12:26 -04:00
Ryan Davis
a2b6517f9a
skip a test when on windows
...
(and make it more compatible for when it does work)
Blocked by #4465 .
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-09-10 14:19:42 -07:00
Ryan Davis
fcfcc354fe
Reworked test cases and impl to only respond to output, not exit code.
...
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-09-10 14:19:42 -07:00
Ryan Davis
dfce5e722f
Merge pull request #4427 from inspec/cw/waivers-overlay
...
waivers: functional test fixture and eval-time skipping
2019-09-09 18:41:37 -07:00
Ryan Davis
f5bbfe5fac
Merge pull request #4365 from inspec/zenspider/the-need-for-speed
...
Make inspec much faster for most commands.
2019-09-09 18:02:10 -07:00
Jerry Aldrich
0e1b3fa65a
json resource: Add handling for command:
error
...
This provides the user with messages if `json(command: 'command_that_errors')`
exits non-zero and/or has STDERR.
Without this the resource will report "No output from command" when really the
output is contained in STDERR.
Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
2019-09-09 15:16:34 -07:00
Ryan Davis
79b9c3cbad
Merge pull request #4451 from inspec/zenspider/fix-tarball-decoding
...
Try to decode archive contents to UTF-8 to avoid encoding corruption.
2019-09-09 11:13:48 -07:00
Clinton Wolfe
5d94440823
Fix logic error for future expiring waivers
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-09-09 11:29:26 -04:00
Clinton Wolfe
43bc7e0343
Modify @__skip_rule to distinguish only_if and waiver, and force waiver to win
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-09-09 11:29:26 -04:00
Clinton Wolfe
0db0a2bfdc
Don't assume waiver_ prefix in waiver files
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-09-09 11:29:26 -04:00
Clinton Wolfe
718e205cf2
Alter expiration_date behavior to match spec
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-09-09 11:29:26 -04:00
Clinton Wolfe
ff209b4bae
Refactor control_id lookup in waiver test file
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-09-09 11:29:26 -04:00
Clinton Wolfe
eb1ec437d7
Linting and test number corrections
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-09-09 11:29:26 -04:00
Clinton Wolfe
5891c9aee9
A failing functional test to skip waivered controls
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-09-09 11:29:26 -04:00
Clinton Wolfe
77b4e45175
Test fixture profile and input file for waivers
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-09-09 11:29:26 -04:00
mhackethal
6772f0b301
Update user_test.rb
2019-09-06 11:42:51 +02:00
Ryan Davis
d19d0bfd7c
Refactor tests for TarProvider and ZipProvider a bit.
...
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-09-06 00:42:36 -07:00
Ryan Davis
6e821e787e
Save off supports[:os] and restore it after each test.
...
This fixes some other tests that require supports[:os] to be correct.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-09-04 15:44:26 -07:00
Ryan Davis
6296fdc688
Replace backticks in test descriptions with single-quotes.
...
Backticks means you can't selectively run one of these tests w/o
subshelling out to `brew`, or having to edit first.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-09-04 15:44:26 -07:00
Ryan Davis
3b69967cc8
Fixed a bug in checking supports (strings vs symbols)
...
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-09-04 15:44:26 -07:00
Ryan Davis
b6bfeffd9e
Make inspec much faster for most commands.
...
Removes pre-loading and registration of resources by adding
method_missing to a couple key areas.
This still drops the ball in some areas, but it is a start.
2019-09-04 15:44:26 -07:00
Lance Albertson
1e94e3503e
Fix for postfix_conf when using a non-standard config location
...
Pass the first argument of the opts array instead of the whole array which
confuses the SimpleConfig parser. Also added a test which verifies this fixes
the issue.
In addition, change the base_name to something that matches other resource base
names.
Signed-off-by: Lance Albertson <lance@osuosl.org>
2019-09-03 15:28:44 -07:00
Ryan Davis
49330e8a8e
Extended skip_windows to the end of September.
...
This is getting depressing...
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-09-03 12:08:41 -07:00
kekaichinose
d33870b635
Merge pull request #4214 from inspec/zenspider/fix_nil_file
...
Fixed file resource raising UndefinedMethod on source_path
2019-08-30 13:19:54 -07:00
mhackethal
204c41bfd1
Update users.rb to include new attributes
2019-08-30 22:07:36 +02:00
Clinton Wolfe
a6bd7ec4b5
Merge pull request #4401 from inspec/cw/input-from-cli
...
inputs: Accept bare input from the command line
2019-08-28 15:41:21 -04:00
Clinton Wolfe
51de566d93
Assert adjustments
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-08-28 13:25:49 -04:00
Clinton Wolfe
82acec957e
Add API for fetching plugin vconfig values.
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-08-28 13:25:49 -04:00
Clinton Wolfe
38f3469ee3
Validation for the plugins area of the config file
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-08-28 13:25:49 -04:00
Clinton Wolfe
c6d355e4f7
Accept version 1.2 for config file format
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-08-28 13:25:49 -04:00
Clinton Wolfe
e346b16114
Tighten help listing assertion and adjust chomp
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-08-28 13:03:42 -04:00
Clinton Wolfe
296158c447
Implementation and functional tests for the --input CLI option
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-08-28 13:03:42 -04:00