Commit graph

3776 commits

Author SHA1 Message Date
Miah Johnson
3a8c474e56 Move our resource checks out of initialize.
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-30 15:14:41 -07:00
Landy Chan
e60179b91f Added regex identifier 2019-10-30 13:51:20 -07:00
Clinton Wolfe
954174c921 Fix config reference in compliance exec
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-10-30 15:56:07 -04:00
Miah Johnson
a46f78031b set sqlcl_bin if specified by users, else don't.
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-30 12:28:15 -07:00
Chef Expeditor
4c0675dc79 Bump version to 4.18.17 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-30 09:38:42 +00:00
Mendy Baitelman
1a289571ed Simplify logic
Signed-off-by: Mendy Baitelman <mendy@baitelman.com>
2019-10-29 22:03:34 -07:00
Chef Expeditor
d241dcab23 Bump version to 4.18.16 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-29 21:47:57 +00:00
Ryan Davis
f56ccb16cb
Merge pull request #4628 from inspec/zenspider/minitest-output
Fixed the rest of the minitest deprecations by removing FuncTestRunResult.
2019-10-29 14:47:36 -07:00
Chef Expeditor
58d9a975c1 Bump version to 4.18.15 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-24 20:25:59 +00:00
Chef Expeditor
4897f75371 Bump version to 4.18.14 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-24 20:25:17 +00:00
Miah Johnson
9c953a0e68
Merge pull request #4638 from inspec/mj/eha
Add #to_s to etc_hosts_allow, and add tests
2019-10-24 13:24:46 -07:00
Chef Expeditor
c0001ff873 Bump version to 4.18.13 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-24 20:24:35 +00:00
Miah Johnson
44579ab4b3
Merge pull request #4637 from inspec/mj/3921
Fix filesystem resource when device has long name
2019-10-24 13:24:23 -07:00
Miah Johnson
86acdda337
Merge pull request #4636 from inspec/mj/4630
iis_app_pool better handling of non-existent pools.
2019-10-24 13:24:03 -07:00
Chef Expeditor
71d0683ff0 Bump version to 4.18.12 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-24 20:23:51 +00:00
Miah Johnson
c9c8bc5f9d
Merge pull request #4635 from inspec/zenspider/users-bad-date
Fix a crash from users resource if the password has never been updated
2019-10-24 13:23:30 -07:00
Miah Johnson
ac399b7af9 Add #to_s to etc_hosts_allow, and add tests
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-24 12:07:26 -07:00
Lance Albertson
dab91a321a Improve testing for yum.repo in CentOS 8
The output for ``yum -v repolist all`` changes slightly in CentOS 8. There are
two specific changes:

1. EL8 is no longer trailing the repo name with release version and arch (i.e.
   base instead of base/7/x86)
2. EL8 no longer adds a trailing newline on the last repo and instead has a line
   with ``Total packages:``. This means the repo listed last will never show up.

A fix was introduced in #4566 however the tests still use CentOS 7 yum output
instead of dnf repolist output. One issue was still discovered where it was
including the ``Total packages`` line in the last repository. This includes a
regex for to work around that and fixes for the tests.

Signed-off-by: Lance Albertson <lance@osuosl.org>
2019-10-24 08:22:42 -07:00
Miah Johnson
0affbc0487 Use the posix output format
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-23 19:55:53 -07:00
Miah Johnson
90d3d9fd32 supports should cover this, salmon!
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-23 17:59:25 -07:00
Miah Johnson
e6b6762e51 Nicer memoize
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-23 17:58:58 -07:00
Miah Johnson
044110e6fc Return true/false if iis_app_pool[:pool_name] has a value (or not)
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-23 17:57:42 -07:00
Ryan Davis
8d51d878f6 Fixed users resource when "Last password change" is "never".
Extended quick_resource to have platform methods and a new string
command mock. The named resource to mock may now be a symbol.

Added a new test that shows how to use quick_resource with multiple commands.

Fixes #4629.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-23 16:49:49 -07:00
Ryan Davis
c9a3c927f9 Fixed inspec from crashing on startup when it can't create the cache directory.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-23 16:35:11 -07:00
Chef Expeditor
8200e625b4 Bump version to 4.18.11 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-23 21:54:39 +00:00
Ryan Davis
d201d1fbc2 Fixed the rest of the minitest deprecations by removing FuncTestRunResult.
Folded the json & other payloads into plain ivars on the test.
Found and removed some unused code while I was there.

Fixes #4533.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-22 12:15:28 -07:00
Chef Expeditor
aebcd3c119 Bump version to 4.18.10 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-21 21:26:54 +00:00
Ryan Davis
8d4e8c1d96
Merge pull request #4627 from inspec/zenspider/json-and-resource-cleanup
JSON processing and resource cleanup
2019-10-21 14:26:37 -07:00
Chef Expeditor
aaecbfa602 Bump version to 4.18.9 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-21 20:48:25 +00:00
Ryan Davis
4dfec45b8c Extra todos! Yay!
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-21 13:30:14 -07:00
Ryan Davis
33dacc4044 ResourceDSL#name should actually return the name if it is going to be named like a getter.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-21 13:30:14 -07:00
Ryan Davis
ebf90ca140 Added Resource.backfill_supports! to provide platform inheritance.
This make it so resources like yaml (which subclasses json) have their
platform information filled in properly.

This still isn't being called. Not sure where the right entry point
is... but the method is now available and allowed me to do analysis on
the rest of the resources.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-21 13:30:14 -07:00
Ryan Davis
7e013e0a48 Mark json as an 'os' platform.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-21 13:30:14 -07:00
Ryan Davis
915fdd0396 Mark mssql_session as a windows platform.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-21 13:30:14 -07:00
Ryan Davis
e469af9d70 Remove (test?) cruft modifying $LOAD_PATH in plugin loader.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-21 13:30:14 -07:00
Ryan Davis
d7a2e047f4 Rename describe.rb to describe_base.rb
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-21 13:30:14 -07:00
Chef Expeditor
13e9774da2 Bump version to 4.18.8 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-21 19:41:12 +00:00
Ryan Davis
031d4c592b
Merge pull request #4597 from inspec/zenspider/systemstackerror
Rescue SystemStackError to make errors during inspec check/archive more graceful.
2019-10-21 12:40:52 -07:00
Chef Expeditor
fa43309993 Bump version to 4.18.7 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-21 19:31:52 +00:00
Ryan Davis
dd3043a992
Merge pull request #4619 from inspec/zenspider/empty-tarball
Fix TarProvider when the tarball has empty files in it.
2019-10-21 12:31:29 -07:00
Ryan Davis
e4f4f5d1cc Fix TarProvider when the tarball has empty files in it.
Added a unit test that runs in ~0.1s. Let's avoid heavy integration
tests where possible.

Fixes #4616

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-18 14:30:00 -07:00
Chef Expeditor
cf4f5509dc Bump version to 4.18.6 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-18 20:37:00 +00:00
Ryan Davis
3d604348a4
Merge pull request #4566 from inspec/zenspider/mock
Refactored and added an alternative test mock resource system.
2019-10-18 13:36:42 -07:00
Ryan Davis
a61d8b9d34 Rescue SystemStackError to make errors during inspec check/archive more graceful.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-17 15:34:40 -07:00
Chef Expeditor
c7909b7dd7 Bump version to 4.18.5 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-17 22:19:39 +00:00
Chef Expeditor
344d99f510 Bump version to 4.18.4 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-17 19:49:55 +00:00
Chef Expeditor
0542ac5b30 Bump version to 4.18.3 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-17 19:39:13 +00:00
Ryan Davis
fc8ea79ad0 Fixed parsing yum output on centos8.
* Renamed and added extra test data to distinguish between centos 7 & centos 8.
* Renamed and added extra tests to cover centos 8.
* Fixed missing repo data by checking at the end if we were still in parse mode.

Fixes #4517

Signed-off-by: Ryan Davis <zenspider@chef.io>
Cc: Miah Johnson <miah@chia-pet.org>
2019-10-16 16:54:07 -07:00
Miah Johnson
df7efefc9d mostly a search and replace for gordon -> example
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-16 10:13:24 -07:00
Chef Expeditor
5e699d2fb3 Bump version to 4.18.2 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-15 18:22:14 +00:00
Chef Expeditor
8d71d3b4dc Bump version to 4.18.1 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-11 17:50:46 +00:00
Clinton Wolfe
bde308f72d
Replace input to_hash method, and add unit test for it (#4545)
Replace input to_hash method, and add unit test for it
2019-10-11 10:50:27 -07:00
Chef Expeditor
8bc9cbb9e8 Bump version to 4.18.0 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-10 20:39:36 +00:00
Clinton Wolfe
a04142d034
Waivers Feedback - Per control reporting and other minor issues (#4567)
Waivers Feedback - Per control reporting and other minor issues
2019-10-10 13:39:18 -07:00
Clinton Wolfe
1495583cdc linting
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-10-09 20:16:10 -07:00
Ryan Davis
b03bc67bbb Fixed 2 failing tests w/ missing empty hash waiver data.
Doesn't prove that data is being passed through when we have it.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-09 17:49:04 -07:00
Chef Expeditor
3302960a46 Bump version to 4.17.27 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-09 20:08:55 +00:00
Clinton Wolfe
ba61cd3f45 Update JSON schema to reflect new waiver keys
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-10-08 21:01:19 -07:00
Clinton Wolfe
0f5fde9729 Modify waiver input file to use 'run' subfield instead of 'skip'
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-10-08 01:03:40 -07:00
Clinton Wolfe
7516f959d1 If there is no data, alwaya return an empty hash.
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-10-08 00:31:23 -07:00
Clinton Wolfe
56c2416c57 Move waiver JSON data from per-result to per-control
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-10-08 00:25:06 -07:00
Clinton Wolfe
88ed1794cb Revert to a small amount of duplicating to_hash in inspec/input.rb
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-10-06 19:30:37 -04:00
Chef Expeditor
40b6fcfe6f Bump version to 4.17.26 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-04 22:30:55 +00:00
Miah Johnson
e48d08343b
Merge pull request #4452 from mhackethal/user-windows-fix
User windows fix
2019-10-04 15:30:37 -07:00
Chef Expeditor
656d3882bc Bump version to 4.17.25 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-04 22:27:17 +00:00
Ryan Davis
632dd5f18b
Merge pull request #4556 from inspec/zenspider/array/at
Don't use #at when you can use #[] for array (or hash) access.
2019-10-04 15:26:57 -07:00
Ryan Davis
f47990a030 Don't use #at when you can use #[] for array (or hash) access.
This is just more idiomatic ruby.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-04 15:24:42 -07:00
Chef Expeditor
a0fc2705c7 Bump version to 4.17.24 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-04 21:18:49 +00:00
Miah Johnson
1a76d59cca
Merge pull request #4553 from inspec/mj/polyfill
Remove unused polyfill.rb file adding to_h to Struct
2019-10-04 14:18:32 -07:00
Chef Expeditor
71a7506644 Bump version to 4.17.23 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-04 20:02:39 +00:00
Ryan Davis
471524711a
Merge pull request #4565 from inspec/zenspider/rspec_method_missing
Fix problem in method_missing in rspec extensions when backend unavailable.
2019-10-04 13:02:21 -07:00
Clinton Wolfe
36db8b9a7b Rely on copy of to_hash in objects/input.rb to avoid duplication
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-10-04 14:05:19 -04:00
Clinton Wolfe
51812a9e4e Replace to_hsh method, and add unit test for it
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-10-04 14:05:19 -04:00
Ryan Davis
9c0c62f89b Fix problem in method_missing in rspec extensions when backend unavailable.
Fixes #4564

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-04 00:36:16 -07:00
Chef Expeditor
f4c979cabd Bump version to 4.17.22 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-03 23:25:46 +00:00
Chef Expeditor
029a95541b Bump version to 4.17.21 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-03 23:25:02 +00:00
Miah Johnson
302abaaa85
Merge pull request #4558 from inspec/mj/4517
Add name property to interface resource
2019-10-03 16:24:58 -07:00
Miah Johnson
44a4f8f221 This file isn't used by anything inside of InSpec
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-03 14:59:26 -07:00
Miah Johnson
1e6daffd80 Missing require for EnvPrinter means inspec env stacktraced.
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-03 14:58:42 -07:00
Miah Johnson
416c33e056 Add name property to interface resource
Also some general cleanup.

Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-03 14:53:43 -07:00
Chef Expeditor
4411550ca9 Bump version to 4.17.20 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-03 21:51:31 +00:00
Chef Expeditor
a5e834d66b Bump version to 4.17.19 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-03 21:50:50 +00:00
Ryan Davis
6fd2db256d
Merge pull request #4560 from inspec/zenspider/apt
Fixed apt resource incorrectly parsing deb files w/ quoted URIs.
2019-10-03 14:50:48 -07:00
Ryan Davis
fd7a569d6b Minor cleanups for readability.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-03 13:45:19 -07:00
Ryan Davis
07dc5e3192 First pass at cleaning deprecations for old minitest/spec-style tests.
3 files left to go, and they're behaving oddly so I'm leaving them out
in this pass. Looks like 21 deprecations left.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-03 13:45:19 -07:00
Ryan Davis
09392943f5 Fixed apt resource incorrectly parsing deb files w/ quoted URIs.
Fixes #4559.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-03 12:55:15 -07:00
Chef Expeditor
c28284a797 Bump version to 4.17.18 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-03 19:51:29 +00:00
Chef Expeditor
90961d3cf7 Bump version to 4.17.17 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-02 04:11:17 +00:00
Clinton Wolfe
d7e39c38f9
Merge pull request #4550 from inspec/zenspider/only_if/os
Add no-op resource and switch Rule to use it for skipped resources.
2019-10-02 00:11:02 -04:00
Chef Expeditor
54f51b75df Bump version to 4.17.16 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-02 04:07:16 +00:00
Clinton Wolfe
a4090f9c1c
Merge pull request #4549 from inspec/zenspider/describe.one
Added method_missing to Inspec::DescribeBase (used by describe.one) to fix resource loading
2019-10-02 00:06:56 -04:00
Ryan Davis
ae6cec831d Add no-op resource and switch Rule to use it for skipped resources.
Avoids the situation of using `os` for non-os transports and blowing up.

Fixes #4541.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-01 17:26:32 -07:00
Ryan Davis
8b7a7386c8 Added method_missing to Inspec::DescribeBase (used by describe.one) to fix resource loading.
Fixes #4547.

Completely lacking in tests. Our current tests around describe.one are
not very useful in this context.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-01 16:37:53 -07:00
Ryan Davis
11b8e54223 Refactored Rule#with_dsl to be a bit more readable and flat.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-01 16:37:28 -07:00
Chef Expeditor
28dac6b5fb Bump version to 4.17.15 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-09-30 22:44:01 +00:00
Miah Johnson
7b039fea84
Merge pull request #4483 from frezbo/bug/inspec_config_clear
Fix config clearing
2019-09-30 15:43:41 -07:00
Chef Expeditor
592f091d95 Bump version to 4.17.14 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-09-30 19:26:49 +00:00
Chef Expeditor
09acafc612 Bump version to 4.17.13 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-09-30 19:15:47 +00:00
Chef Expeditor
bc6fdc25e3 Bump version to 4.17.12 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-09-30 19:15:20 +00:00
Ryan Davis
c9da57efa7
Merge pull request #4537 from syseleven/fix/group_loading
Add missing resource stubs for 'group' resource
2019-09-30 12:15:14 -07:00