Commit graph

6317 commits

Author SHA1 Message Date
Miah Johnson
ef902ced88
Merge pull request #4082 from inspec/mj/fkg
`rubocop -a` on kitchen directory
2019-05-16 11:45:14 -07:00
Miah Johnson
6a60f6137f Don't require telemetry/global_methods to prevent circular require
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-05-16 00:45:58 -07:00
Miah Johnson
75f071ae48 require telemetry/global_methods
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-05-16 00:45:24 -07:00
Miah Johnson
e2ccb9ae69 rubocop -a
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-05-16 00:29:16 -07:00
Miah Johnson
d70172f96e Fix @profile_name not initialized
I believe that if `@conf['profile']` doesn't exist @profile_name may not
be initialized.

```
inspec-master/lib/inspec/profile_context.rb:35: warning: instance variable @profile_name not initialized
```

Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-05-16 00:22:27 -07:00
Miah Johnson
832dc4a1c9 This test was too intimate.
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-05-15 19:30:39 -07:00
Miah Johnson
083c6c0bae Fix @unique_controls uninitialized warning
memoize @unique_controls to a Set if nil and
check that its empty? to continue and add controls

/home/miah/projects/github/inspec-master/lib/inspec/reporters/cli.rb:169: warning: instance variable @unique_controls not initialized

Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-05-15 17:29:37 -07:00
Chef Expeditor
67929db658
Bump version to 4.4.25 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-05-15 23:50:31 +00:00
Miah Johnson
67471cc308
Merge pull request #4078 from inspec/resolve_deprecation_warning
Remove the deprecated linux_kernel_parameter resource test
2019-05-15 16:50:01 -07:00
Tim Smith
0122ee8e60 Remove the deprecated linux_kernel_parameter resource test
This was testing serverspec compatibility, but those days are long past us and this is a deprecated resource now. This will quiet our tests up a bit.

Signed-off-by: Tim Smith <tsmith@chef.io>
2019-05-15 16:39:29 -07:00
Chef Expeditor
39dd4128d0
Bump version to 4.4.24 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-05-15 22:55:39 +00:00
Miah Johnson
970e151759
Merge pull request #4077 from inspec/local_testing
Build the InSpec gem directly in Kitchen so we can run locally
2019-05-15 15:55:22 -07:00
Tim Smith
ed8dbed517 Fix the box name for the macos boxes as well
The new boxes follow Apple's brand changes

Signed-off-by: Tim Smith <tsmith@chef.io>
2019-05-15 15:50:27 -07:00
Tim Smith
f91284a80f Don't use ERB where it isn't necessary
No need for this array

Signed-off-by: Tim Smith <tsmith@chef.io>
2019-05-15 15:47:19 -07:00
Tim Smith
364a669e6b Mac OS X -> macOS
Make Apple happy

Signed-off-by: Tim Smith <tsmith@chef.io>
2019-05-15 15:46:56 -07:00
Tim Smith
b50f923a91 Remove Solaris 10 testing
Chef doesn't run on Solaris 10 anymore so this won't work.

Signed-off-by: Tim Smith <tsmith@chef.io>
2019-05-15 15:46:38 -07:00
Tim Smith
a05699c5c3 Build the InSpec gem directly in Kitchen so we can run locally
Before you had to kick off kitchen via Rake as the Rake task build the local gem we injected into the cookbook. Now we do it within Test Kitchen using a feature that didn't exist when this was all written. Also --output is your friend and greatly reduces the complexity of all this.

Signed-off-by: Tim Smith <tsmith@chef.io>
2019-05-15 15:46:09 -07:00
Chef Expeditor
77f0efd1e8
Bump version to 4.4.23 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-05-15 22:40:48 +00:00
Ryan Davis
76cc58c559
Merge pull request #4076 from inspec/lcg/kitchen-rake-testing
Add kitchen rake testing
2019-05-15 15:40:31 -07:00
Chef Expeditor
043790dcb3
Bump version to 4.4.22 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-05-15 22:40:03 +00:00
Ryan Davis
ed6062a191
Merge pull request #4074 from inspec/tk_cleanup
Cleanup and fix failing Kitchen tests
2019-05-15 15:39:47 -07:00
Lamont Granquist
bb731fdbc9 Add kitchen rake testing
I'd suggest starting to structure kitchen testing like this with a
directory and subdirs to keep the kitchen testing gems out of the
root Gemfile entirely.

This still mounts the root dir in /inspec so the root Gemfile
is still what you're running the rake tests against.

By having an extra layer of subdirs, then you can split up different
use cases like the rake-testing vs. the audit cookbook testing.
Otherwise it'll be a mess of having to manage different kitchen.yml
files that require way too many different drivers/provisioners/verifiers
2019-05-15 15:30:26 -07:00
Tim Smith
9930e8d05d Test on Ruby 2.6.3 in Travis
Signed-off-by: Tim Smith <tsmith@chef.io>
2019-05-15 14:51:08 -07:00
Tim Smith
96ed4988e3 Temporarily set TK to 1.x
Until we figure out the licensing issues

Signed-off-by: Tim Smith <tsmith@chef.io>
2019-05-15 14:50:54 -07:00
Chef Expeditor
e470937ee3
Bump version to 4.4.21 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-05-15 21:43:57 +00:00
Miah Johnson
93eb8ad580
Merge pull request #4073 from inspec/ruby263
Upgrade to Ruby 2.6.3
2019-05-15 14:43:43 -07:00
Tim Smith
02d2751971 Add Debian 10 testing to Kitchen / Travis
Signed-off-by: Tim Smith <tsmith@chef.io>
2019-05-15 14:41:29 -07:00
Tim Smith
b27bd80429 Remove Ubuntu 14.04 from the kitchen config
This is EOL and we're not running tests on it in Travis anymore

Signed-off-by: Tim Smith <tsmith@chef.io>
2019-05-15 14:41:14 -07:00
Tim Smith
9197058698 Use the latest Chef 14 release in the Kitchen config
Get us to the latest Chef 14.

Signed-off-by: Tim Smith <tsmith@chef.io>
2019-05-15 14:39:03 -07:00
Tim Smith
84f67a3439 Remove the unused kitchen.ec2.yml file
This is many many years old and unused

Signed-off-by: Tim Smith <tsmith@chef.io>
2019-05-15 14:38:36 -07:00
Tim Smith
15323017cd Add opensuseleap15 to the vagrant kitchen config
Signed-off-by: Tim Smith <tsmith@chef.io>
2019-05-15 14:38:20 -07:00
Tim Smith
ab7aabaf96 Upgrade to Ruby 2.6.3
It has a few bugfixes and support for the new Japanese cal.

Signed-off-by: Tim Smith <tsmith@chef.io>
2019-05-15 14:26:25 -07:00
Chef Expeditor
060e00e6e2
Bump version to 4.4.20 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-05-15 20:44:39 +00:00
Miah Johnson
604fa31d94
Merge pull request #4072 from inspec/mj/COC
Update our Code of Conduct
2019-05-15 13:44:21 -07:00
Chef Expeditor
07082f2473
Bump version to 4.4.19 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-05-15 20:36:53 +00:00
Miah Johnson
2490371390
Merge pull request #4071 from inspec/licenseUpdate
Include info about Chef License Requirements
2019-05-15 13:36:34 -07:00
Miah Johnson
4d2ca97aa0 Update our Code of Conduct
This updates our Code of Conduct to match what is in our .github health
repo, which is also used by all of Chef.

Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-05-15 13:33:47 -07:00
Mary Jinglewski
f4eca9b2bf Include info about Chef License Requirements
Signed-off-by: Mary Jinglewski <mjinglewski@chef.io>
2019-05-15 16:31:59 -04:00
Chef Expeditor
2b54b0bede
Bump version to 4.4.18 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-05-15 19:31:33 +00:00
Miah Johnson
947e7ddad9
Merge pull request #4052 from aaronlippold/al/mssql-session-fix
Removed unneeded 'supports: windows'
2019-05-15 12:31:18 -07:00
Chef Expeditor
11f5c311d2
Bump version to 4.4.17 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-05-15 17:55:57 +00:00
Miah Johnson
bb92546bf2
Merge pull request #4037 from inspec/ap/improve-postgres-resource
Make the postgres resource more defensive
2019-05-15 10:55:41 -07:00
Chef Expeditor
73d6b6953f
Bump version to 4.4.16 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-05-15 17:05:18 +00:00
Ryan Davis
e8515ec604
Merge pull request #4044 from inspec/mj/codeclimate
Add codeclimate to our pipeline
2019-05-15 10:05:00 -07:00
Chef Expeditor
7381a6902f
Bump version to 4.4.15 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-05-15 08:39:16 +00:00
Ryan Davis
5056b942b0
Merge pull request #4066 from inspec/emergency_test_fixes
Emergency test fixes!
2019-05-15 01:38:59 -07:00
Ryan Davis
eead889325 Fix test framework contention.
RSpec is used internally. Minitest is used for our tests. They don't
really like each other. This fixes that and gets our tests
consistently running the correct number of tests (they were load-order
dependent before and each platform had its own different number of
tests it would run).

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-05-15 00:33:53 -07:00
Ryan Davis
fa7a8c9e19 Normalizing two test declarations.
These tests both involve dynamic un-rooted classes. As such, they have
no name and thus print like #<Class:0xXXXXXXXX:...>. I switched one to
a describe instead of Class.new(Minitest::Test) and the other I
stringified the anonymous class.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-05-14 23:27:18 -07:00
Ryan Davis
f5d35494d9 Pulling requires out of often called methods.
While debugging this hairy situation, I had hooked require to try to
figure out sequencing. These requires were called thousands upon
thousands of times, creating a lot of noise and having no benefit
other than a possible savings of a few millisecond on an already slow
startup.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-05-14 23:25:28 -07:00
Ryan Davis
6adf1d2560 Remove all byebug requires in code.
Please don't leave debugging remnants in the code.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-05-14 23:24:14 -07:00