Commit graph

3846 commits

Author SHA1 Message Date
Mendy Baitelman
8205a78fd2 Add last login to WindowsUser
Signed-off-by: Mendy Baitelman <mendy@baitelman.com>
2019-11-13 21:20:58 -08:00
Chef Expeditor
b9a55682dc Bump version to 4.18.38 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-11-13 23:51:04 +00:00
Chef Expeditor
741fcc3564 Bump version to 4.18.37 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-11-13 23:48:32 +00:00
Ryan Davis
540521031b
Merge pull request #4707 from inspec/zenspider/apt-fix
Fixes parsing of apt config files with arch specifier.
2019-11-13 15:48:15 -08:00
Chef Expeditor
95a8b55dcb Bump version to 4.18.36 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-11-13 20:35:08 +00:00
Chef Expeditor
4d705f31c0 Bump version to 4.18.35 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-11-13 20:34:03 +00:00
Ryan Davis
4e818faeb4 Fixes parsing of apt config files with arch specifier.
Fixes #4683.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-11-12 15:08:06 -08:00
Ryan Davis
d829fa2d61 Changed FileProvider to try to encode UTF-8 and convert newlines.
For Windows compatibility.
2019-11-12 14:51:56 -08:00
Ryan Davis
2a680058f4 Missing require?
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-11-12 14:51:56 -08:00
Ryan Davis
a27eef1d0b Fixed env vars on functional plugin tests for windows.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-11-12 14:51:56 -08:00
Ryan Davis
ead386df14 Fixed inspec_init_plugin_test.rb
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-11-12 14:51:56 -08:00
Ryan Davis
a598356e12 Strip down plugin helper and change windows prefix execution.
Powershell doesn't use "&&" and we have it all over the tests.
Changing to ";".

Also starting to unify the plugin helper w/ the functional helper
since it has a LOT of duplication.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-11-12 14:51:56 -08:00
Ryan Davis
e60dc84188 Cleaned up inspec artifact testing.
Removed redundant test/functional/inspec_artifact_test.rb
Cleaned up lib/plugins/inspec-artifact/test/functional/inspec_artifact_test.rb
Made an error on windows (install-profile fails) raise instead of just print.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-11-12 14:50:39 -08:00
Ryan Davis
2cb5f26998 Rearrange a require in metadata.rb to break circularity is load.
For some reason this works fine in linux & osx but fails on windows
but only when some things are loaded in isolation. *shrug*
2019-11-12 14:50:39 -08:00
Chef Expeditor
fb163ad294 Bump version to 4.18.34 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-11-12 21:01:36 +00:00
Clinton Wolfe
1db2941a9e
Fix for invocation when calling npm under sudo (#4548)
Fix for invocation when calling npm under sudo
2019-11-12 16:01:07 -05:00
Chef Expeditor
d9339eab02 Bump version to 4.18.33 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-11-12 20:31:02 +00:00
Bryan McLellan
e4a096ba83
Merge pull request #4680 from inspec/btm/warn-objects
Deprecate inspec/object/* classes
2019-11-12 15:30:45 -05:00
Chef Expeditor
91511c0ca4 Bump version to 4.18.32 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-11-12 20:21:53 +00:00
Ryan Davis
b1c2af209b Corresponding fixes for the move from test/unit/mock to test/fixtures.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-11-08 19:20:12 -08:00
Chef Expeditor
ad0e9abd33 Bump version to 4.18.31 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-11-09 00:08:00 +00:00
Ryan Davis
244c7bbed4
Merge pull request #4677 from inspec/zenspider/bump-chefstyle
Bump chefstyle and fix up flagged code.
2019-11-08 16:07:42 -08:00
Ryan Davis
bb49d58cd9 Switched chefstyle back to Layout/AlignArguments=with_first_argument.
Fixed the flags mostly with `chefstyle -a` but also refactored/cleaned
some stuff by hand.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-11-08 12:57:43 -08:00
Ryan Davis
8f1e607d55 Bump chefstyle and fix up flagged code.
Very minor.

I want to change a default config but I'll do that in a separate
commit since it is a bigger diff.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-11-08 12:57:43 -08:00
Bryan McLellan
3670500701 Deprecate inspec/object/* classes
The classes in inspec/object have been moved to the inspec-objects
library. They aren't used directly by Inspec and will be removed in the
next major release.

Signed-off-by: Bryan McLellan <btm@loftninjas.org>
2019-11-08 15:09:09 -05:00
Clinton Wolfe
5acc8fed1a Correctly detect NPM modules with a custom path on Windows
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-11-07 17:30:50 -05:00
Clinton Wolfe
34cd236036 Revert "Remove erroneous windows support declaration"
We do in fact support windows. We want to support windows with a custom path, too.

This reverts commit 2092984fdd.
2019-11-07 15:39:58 -05:00
Clinton Wolfe
2092984fdd Remove erroneous windows support declaration
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-11-07 15:39:08 -05:00
Clinton Wolfe
c0b5b9cd41 Fix for invocation when calling npm under sudo
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-11-07 15:39:08 -05:00
Chef Expeditor
b3f44ad91f Bump version to 4.18.30 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-11-07 16:58:31 +00:00
Clinton Wolfe
d9f34dda58
Make input() work in describe.one (#4666)
Make input() work in describe.one
2019-11-07 11:58:11 -05:00
Clinton Wolfe
bf5ce746c9 Make __profile_id private and add comment
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-11-07 10:49:49 -05:00
Chef Expeditor
3c1fadd1cb Bump version to 4.18.29 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-11-07 03:04:10 +00:00
Clinton Wolfe
11438d5d3c Refactor to DRY up repeated implementation of input()
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-11-06 11:13:18 -05:00
Chef Expeditor
b810f82328 Bump version to 4.18.28 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-11-06 00:33:09 +00:00
Ryan Davis
4ed9305535
Merge pull request #4670 from inspec/zenspider/gem-resource
Pre-load the gem resource to override the global gem method.
2019-11-05 16:32:48 -08:00
Chef Expeditor
76a8ac7190 Bump version to 4.18.27 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-11-05 07:20:46 +00:00
Mendy Baitelman
1a9a47ee96 Merge remote-tracking branch 'upstream/master' into add-startuser-systemd-service
Signed-off-by: Mendy Baitelman <mendy@baitelman.com>
2019-11-04 21:07:56 -08:00
Ryan Davis
04986547ac Added some todos to the gem resource.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-11-04 13:25:35 -08:00
Ryan Davis
5b6fdf9a98 Pre-load the gem resource to override the global gem method.
This seems problematic to me in general. We should probably not
override global methods. Renaming this to rubygem and providing a
deprecated alias seems like the right thing to do.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-11-04 13:25:35 -08:00
Chef Expeditor
b1fc46e883 Bump version to 4.18.26 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-11-01 21:56:36 +00:00
Clinton Wolfe
b776b84603 Rough implementation of input() in describe.one, could use dome DRYing
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-11-01 16:52:21 -04:00
Chef Expeditor
7841361428 Bump version to 4.18.25 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-11-01 18:45:27 +00:00
Chef Expeditor
15a70539b8 Bump version to 4.18.24 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-31 22:24:00 +00:00
Chef Expeditor
548c82ac36 Bump version to 4.18.23 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-31 21:41:31 +00:00
Miah Johnson
22dbfbd705 Ooops. I didn't need to remove this just yet. html parser is using it.
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-31 14:39:10 -07:00
Chef Expeditor
fe3fc3ffbf Bump version to 4.18.22 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-31 21:20:26 +00:00
Miah Johnson
1b93755410
Merge pull request #4653 from landychan/lchan/bug-fix-3611
Nginx Resource: Add parsing support for wildcard, dot prefix, and regex
2019-10-31 14:20:08 -07:00
Chef Expeditor
6f4a7ffe48 Bump version to 4.18.21 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-31 21:19:05 +00:00
Miah Johnson
7442955ed6
Merge pull request #4650 from inspec/cw/fix-compliance-exec
Fix config reference in `compliance exec`
2019-10-31 14:18:47 -07:00
Chef Expeditor
a7bd16a1f9 Bump version to 4.18.20 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-31 21:14:13 +00:00
Miah Johnson
7a68d58904
Merge pull request #4654 from inspec/mj/oracle
oracledb_session fixes
2019-10-31 14:13:56 -07:00
Chef Expeditor
26f4d66006 Bump version to 4.18.19 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-31 21:13:25 +00:00
Miah Johnson
de4139aff8
Merge pull request #4568 from ramereth/yum-el8-support
Improve testing for yum.repo in CentOS 8
2019-10-31 14:13:05 -07:00
Chef Expeditor
a599ba428b Bump version to 4.18.18 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-31 21:10:23 +00:00
Ryan Davis
7189f2e21a Fixed problem with accessing backend in TestDslLazyLoader#method_missing.
Fixes #4587.
Fixes #4524.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-31 14:09:16 -07:00
Ryan Davis
defe63dada Test for bug #4524 and bug #4587 to verify that resources are available w/in rspec constructs.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-31 14:09:16 -07:00
Miah Johnson
b63e886523 Fixes based on PR feedback.
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-31 11:44:08 -07:00
Miah Johnson
c582895434 cmd and command were too similar
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-30 19:41:57 -07:00
Miah Johnson
636f34f7fc remove old comments
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-30 19:41:28 -07:00
Miah Johnson
6bab53cbd3 after dropping the return we dont have to worry about executing during init
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-30 19:10:57 -07:00
Miah Johnson
0ff8383369 give bin a default value
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-30 19:10:03 -07:00
Miah Johnson
85df7f52ef Don't need to return on these.
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-30 17:28:14 -07:00
Landy Chan
9e38bec396 Added wildcard and dot-prefixed identifier support. Combined regex identifier into standard identifier
Signed-off-by: Landy Chan <landychan92@gmail.com>
2019-10-30 16:39:38 -07:00
Miah Johnson
6e346a3616 make readers match their instance variables
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-30 15:28:34 -07:00
Miah Johnson
c82a94f2a3 wire everythign up
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-30 15:28:19 -07:00
Miah Johnson
08462e4319 give our argument a better name
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-30 15:27:18 -07:00
Miah Johnson
36dc965d70 dead code
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-30 15:26:19 -07:00
Miah Johnson
45348965b6 figure out command outside of query.
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-30 15:25:03 -07:00
Miah Johnson
96d832effa fix verify_query
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-30 15:16:05 -07:00
Miah Johnson
3a8c474e56 Move our resource checks out of initialize.
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-30 15:14:41 -07:00
Landy Chan
e60179b91f Added regex identifier 2019-10-30 13:51:20 -07:00
Clinton Wolfe
954174c921 Fix config reference in compliance exec
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-10-30 15:56:07 -04:00
Miah Johnson
a46f78031b set sqlcl_bin if specified by users, else don't.
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-30 12:28:15 -07:00
Chef Expeditor
4c0675dc79 Bump version to 4.18.17 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-30 09:38:42 +00:00
Mendy Baitelman
1a289571ed Simplify logic
Signed-off-by: Mendy Baitelman <mendy@baitelman.com>
2019-10-29 22:03:34 -07:00
Chef Expeditor
d241dcab23 Bump version to 4.18.16 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-29 21:47:57 +00:00
Ryan Davis
f56ccb16cb
Merge pull request #4628 from inspec/zenspider/minitest-output
Fixed the rest of the minitest deprecations by removing FuncTestRunResult.
2019-10-29 14:47:36 -07:00
Chef Expeditor
58d9a975c1 Bump version to 4.18.15 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-24 20:25:59 +00:00
Chef Expeditor
4897f75371 Bump version to 4.18.14 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-24 20:25:17 +00:00
Miah Johnson
9c953a0e68
Merge pull request #4638 from inspec/mj/eha
Add #to_s to etc_hosts_allow, and add tests
2019-10-24 13:24:46 -07:00
Chef Expeditor
c0001ff873 Bump version to 4.18.13 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-24 20:24:35 +00:00
Miah Johnson
44579ab4b3
Merge pull request #4637 from inspec/mj/3921
Fix filesystem resource when device has long name
2019-10-24 13:24:23 -07:00
Miah Johnson
86acdda337
Merge pull request #4636 from inspec/mj/4630
iis_app_pool better handling of non-existent pools.
2019-10-24 13:24:03 -07:00
Chef Expeditor
71d0683ff0 Bump version to 4.18.12 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-24 20:23:51 +00:00
Miah Johnson
c9c8bc5f9d
Merge pull request #4635 from inspec/zenspider/users-bad-date
Fix a crash from users resource if the password has never been updated
2019-10-24 13:23:30 -07:00
Miah Johnson
ac399b7af9 Add #to_s to etc_hosts_allow, and add tests
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-24 12:07:26 -07:00
Lance Albertson
dab91a321a Improve testing for yum.repo in CentOS 8
The output for ``yum -v repolist all`` changes slightly in CentOS 8. There are
two specific changes:

1. EL8 is no longer trailing the repo name with release version and arch (i.e.
   base instead of base/7/x86)
2. EL8 no longer adds a trailing newline on the last repo and instead has a line
   with ``Total packages:``. This means the repo listed last will never show up.

A fix was introduced in #4566 however the tests still use CentOS 7 yum output
instead of dnf repolist output. One issue was still discovered where it was
including the ``Total packages`` line in the last repository. This includes a
regex for to work around that and fixes for the tests.

Signed-off-by: Lance Albertson <lance@osuosl.org>
2019-10-24 08:22:42 -07:00
Miah Johnson
0affbc0487 Use the posix output format
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-23 19:55:53 -07:00
Miah Johnson
90d3d9fd32 supports should cover this, salmon!
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-23 17:59:25 -07:00
Miah Johnson
e6b6762e51 Nicer memoize
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-23 17:58:58 -07:00
Miah Johnson
044110e6fc Return true/false if iis_app_pool[:pool_name] has a value (or not)
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-23 17:57:42 -07:00
Ryan Davis
8d51d878f6 Fixed users resource when "Last password change" is "never".
Extended quick_resource to have platform methods and a new string
command mock. The named resource to mock may now be a symbol.

Added a new test that shows how to use quick_resource with multiple commands.

Fixes #4629.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-23 16:49:49 -07:00
Ryan Davis
c9a3c927f9 Fixed inspec from crashing on startup when it can't create the cache directory.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-23 16:35:11 -07:00
Chef Expeditor
8200e625b4 Bump version to 4.18.11 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-23 21:54:39 +00:00
Ryan Davis
d201d1fbc2 Fixed the rest of the minitest deprecations by removing FuncTestRunResult.
Folded the json & other payloads into plain ivars on the test.
Found and removed some unused code while I was there.

Fixes #4533.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-22 12:15:28 -07:00
Chef Expeditor
aebcd3c119 Bump version to 4.18.10 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-21 21:26:54 +00:00
Ryan Davis
8d4e8c1d96
Merge pull request #4627 from inspec/zenspider/json-and-resource-cleanup
JSON processing and resource cleanup
2019-10-21 14:26:37 -07:00
Chef Expeditor
aaecbfa602 Bump version to 4.18.9 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-10-21 20:48:25 +00:00
Ryan Davis
4dfec45b8c Extra todos! Yay!
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-21 13:30:14 -07:00