Ryan Davis
d7bae9de30
Mostly minor cleanup, clarification, and comments.
...
Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-02-03 13:19:32 -08:00
Ryan Davis
fdc281d19c
Clean up the end of our custom require.
...
There are only 2 options. Shortcutting one of them with a `require` just
makes it messy. Use `if`. It's really basic. Basic is good. Maybe we
should try to push towards basic and good. It would be work but make
us happier in the long run.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-02-03 13:18:56 -08:00
Ryan Davis
51b65f6c2e
Overhaul Platform#supported?
...
+ State normal path first.
+ Use Enumerable to state your logic up front, don't build it into
loops with breaks/returns.
+ Remove nonsensical duplication of key formats. (should push up or remove)
+ Had to add an extra test case that wasn't covered here but was in
metadata_test.rb (why?!?)
Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-02-03 13:18:56 -08:00
Ryan Davis
10cb92da48
Clean up Platform#params.
...
State your normal case first, then deal with edge cases, not the other
way around.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-02-03 13:18:56 -08:00
Ryan Davis
aef285a1f6
Don't meta-program if you don't need to.
...
Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-02-03 13:18:56 -08:00
Ryan Davis
06ceba3f3d
Add test for LEC to expose second-level libraries require.
...
Not the best test in the world, but it is better than nothing.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-02-03 13:18:56 -08:00
Chef Expeditor
3cfd35f98f
Bump version to 4.18.82 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2020-02-01 02:04:23 +00:00
Ryan Davis
2c7101df26
Fix minor style issues.
...
I swear... rubocop hates me.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-01-31 18:01:01 -08:00
Chef Expeditor
4ab4b04bed
Bump version to 4.18.81 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2020-02-01 01:51:56 +00:00
Chef Expeditor
d09656cdff
Bump version to 4.18.80 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2020-02-01 01:38:34 +00:00
Ryan Davis
c79245cde3
Merge pull request #4869 from inspec/zenspider/crontab
...
Refactored crontab resource
2020-01-31 17:38:12 -08:00
Chef Expeditor
c3a37ee126
Bump version to 4.18.79 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2020-02-01 00:42:32 +00:00
Ryan Davis
c70f73dc96
Merge pull request #4864 from inspec/zenspider/resource/inspect
...
Added --inspect option to inspect shell command.
2020-01-31 16:42:00 -08:00
Chef Expeditor
01b9bacaa1
Bump version to 4.18.78 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2020-02-01 00:41:46 +00:00
Ryan Davis
cc1393bb9a
Merge pull request #4822 from PiQuer/master
...
make command.exist? POSIX conform
2020-01-31 16:41:27 -08:00
Chef Expeditor
09e0bc63da
Bump version to 4.18.77 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2020-01-31 22:29:39 +00:00
Chef Expeditor
d83ead45f9
Bump version to 4.18.76 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2020-01-31 01:21:42 +00:00
Chef Expeditor
7e258f8944
Bump version to 4.18.75 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2020-01-30 16:04:33 +00:00
Chef Expeditor
f69d76e4a0
Bump version to 4.18.74 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2020-01-30 00:36:49 +00:00
Ryan Davis
a79eb417a0
the correct, un-panicked fix.
...
Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-01-29 16:35:11 -08:00
Chef Expeditor
fb81c806b5
Bump version to 4.18.73 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2020-01-30 00:25:39 +00:00
Ryan Davis
622ae78d9a
bad master merge... rushing this through
...
Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-01-29 16:24:35 -08:00
Chef Expeditor
5c6be7b936
Bump version to 4.18.72 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2020-01-30 00:19:44 +00:00
Ryan Davis
f2155a64ed
Merge pull request #4843 from michaellihs/master
...
Add support for yocto linux in service resource
2020-01-29 16:19:27 -08:00
Ryan Davis
19ce5df589
Merge pull request #4827 from inspec/mj/namespaces
...
Move parsers under Utils
2020-01-29 16:18:43 -08:00
Chef Expeditor
bb70c50961
Bump version to 4.18.71 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2020-01-30 00:08:10 +00:00
Ryan Davis
10406545ca
Merge pull request #4862 from inspec/zenspider/resources
...
Fix up the platform on etc_hosts, virtualization, ini, and xml resources to fix OS disparity.
2020-01-29 16:07:47 -08:00
Chef Expeditor
eaf2d7ca5b
Bump version to 4.18.70 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2020-01-30 00:06:50 +00:00
Chef Expeditor
485aa93d90
Bump version to 4.18.69 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2020-01-29 23:50:00 +00:00
Ryan Davis
124b56b6ee
Merge pull request #4825 from inspec/zenspider/tarball
...
Properly report errors with bad tarball files.
2020-01-29 15:49:40 -08:00
Ryan Davis
2ae2bcf6fb
Merge pull request #4818 from JackChance/master
...
replaced instances of `have_protocols` with `have_protocol` in docume…
2020-01-29 15:46:25 -08:00
Ryan Davis
ceab1cbdac
Refactored crontab resource
...
Specifically the parsing was pretty unreadable. This refactoring
emphasizes using a default hash and merging in the differences for
what was parsed. Everything is funneled through one `merge_crontab`
method that does the actual parsing and the system vs user differences
are merged in after in their respective parse methods.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-01-29 13:56:11 -08:00
Clinton Wolfe
37455bdd11
Parallelize unit tests
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-29 16:15:58 -05:00
Clinton Wolfe
3419c84233
Make predicates private to reduce namespace pollution; added dockerenv check for docker mode
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-29 11:28:52 -05:00
Chef Expeditor
193905a827
Bump version to 4.18.68 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2020-01-29 16:03:44 +00:00
Ryan Davis
15f77941af
Some cleanup on the apache_conf resource.
...
The biggie to know is that all the extra read_content calls were
needlessly redundant with it also being called in initialize.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-01-28 14:53:37 -08:00
Ryan Davis
9c051da22b
Fix platform on apache_conf to include all unix.
...
Now discovers the first available conf file from a list of known
paths. Might have to expand based on various distros.
Had to tweak the tests because the mock loader mocks EVERYTHING every
time. :/
Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-01-28 14:53:37 -08:00
Ryan Davis
8bd2528ef8
Added --inspect option to inspect shell command.
...
* Removed Resource#inspect (calling to_s) to make debugging a happy experience.
* Added ResourceBehavior.toggle_inspect to add/remove a basic inspect.
* Added `--inspect` flag to `shell` command. Call toggle_inspect unless --inspect used.
* Cleaned up matchers.rb and removed most explicit calls to inspect.
* Added ResourceInspector to rspec's INSPECTOR_CLASSES.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-01-28 14:52:04 -08:00
Clinton Wolfe
357cf051b1
PR feedback part 1
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-28 11:06:12 -05:00
Chef Expeditor
41f3927e84
Bump version to 4.18.67 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2020-01-28 15:03:18 +00:00
Clinton Wolfe
46ade02401
Use an archive if possible when fetching fails and --airgap is… ( #4806 )
...
Use an archive if possible when fetching fails and --airgap is provided
2020-01-28 10:02:57 -05:00
Ryan Davis
df31f744f4
Fix up platform on filesystem resource.
...
From linux to unix. This should work fine even on AIX, according to
the man pages.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-01-27 15:34:33 -08:00
Ryan Davis
65c44d22e2
Audited virtualization a bit.
...
Cleaned up some code.
Reordered virtualization detection by order of probability.
Added TODOs for obvious problems.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-01-27 15:31:41 -08:00
Ryan Davis
f830ddeca6
Slimmed up and removed "clever" from file resource description.
...
Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-01-27 15:30:48 -08:00
Ryan Davis
b9d49e0fed
Fix up the platform on etc_hosts, virtualization, ini, and xml resources to fix OS disparity.
...
+ File format oriented resources should always be `os`.
+ virtualization should (in theory) be any unix (tho, it currently seems wrong).
+ etc_hosts should be any (reasonable) unix.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-01-27 15:29:52 -08:00
Clinton Wolfe
76a9c3e590
Install-path based install context detection
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-27 13:29:37 -05:00
Clinton Wolfe
eac3b31095
PR feedback re: cache warming
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-27 11:01:15 -05:00
Chef Expeditor
2089bf80c7
Bump version to 4.18.66 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2020-01-27 15:51:46 +00:00
Clinton Wolfe
31d2383285
Missing end quote in oracledb_session ( #4852 )
...
Missing end quote in oracledb_session
2020-01-27 10:51:25 -05:00
Chef Expeditor
cafb4f3e3e
Bump version to 4.18.65 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2020-01-27 15:31:19 +00:00