Commit graph

6682 commits

Author SHA1 Message Date
Miah Johnson
ab293892de Disable rubocop on Code Climate.
This is now managed by chefstyle which CC doesn't support. Every PR is
linted before tests are started so style is already strictly enforced.

Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-06-11 21:51:33 -07:00
Ryan Davis
f16238607d Turn off aws and azure testing via NO_AWS env.
This massively speeds up our testing, shaving our functionals by a
third (639s -> 423s). We can realize this speedup either by setting
the env or by jettisoning aws and azure into their own separately
tested gems.

This is currently turned off for travis just for demonstration
purposes.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-06-11 21:32:23 -07:00
Ryan Davis
387b713d79 Removing extra requires from inspec/profile.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-06-11 21:32:22 -07:00
Ryan Davis
dd7f9abb20 Revamped test/functional/ui_test.rb to check output before exit codes.
Helps with debugging.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-06-11 21:32:22 -07:00
Ryan Davis
fae4230a41 Removing inspec/profile_vendor from inspec/base_cli.
This was the next most expensive require in the analysis.

Also rearranged the way that ui handled tables to be lazy.

```
% SLOW=1 time rake test:functional

before: Finished in  681.514579s, 0.5136 runs/s, 2.9919 assertions/s.
after : Finished in  642.655918s, 0.5446 runs/s, 3.1728 assertions/s.
```

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-06-11 19:16:58 -07:00
Ryan Davis
bfbb89a05c First pass making bin/inspec faster.
This removes requiring 'inspec' in bin/inspec and goes straight to
'inspec/cli'. It removes almost all the top-level requires in
inspec/cli.rb. This requires some autoloads and rearrangements of
requires to the command methods themselves.

```
% SLOW=1 time rake test:functional

before: Finished in 1072.442633s, 0.3264 runs/s, 1.9013 assertions/s.
after:  Finished in  681.514579s, 0.5136 runs/s, 2.9919 assertions/s.
```

I'm positive there is more we can do.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-06-11 18:59:55 -07:00
Chef Expeditor
a35d37043e
Bump version to 4.5.2 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-06-12 01:54:13 +00:00
Miah Johnson
4ba2e787cd
Merge pull request #4194 from inspec/zenspider/chefstyle2
Apply chefstyle to codebase
2019-06-11 18:53:53 -07:00
Ryan Davis
692d6a9ab8 hand applied one that is now marked as unsafe in rubocop
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-06-11 18:52:38 -07:00
Ryan Davis
a141870d19 Switch to chefstyle in test:lint task
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-06-11 18:52:38 -07:00
Miah Johnson
c8836e6856 enforce_type_restriction! will exit before new_value
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-06-11 18:52:38 -07:00
Miah Johnson
68e540a15a Ignore Rubocop checks
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-06-11 18:52:38 -07:00
Miah Johnson
c579ed3097 Disable rubocop check on TMP_CACHE
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-06-11 18:52:38 -07:00
Miah Johnson
20531342d2 unused assignment
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-06-11 18:52:38 -07:00
Miah Johnson
729177f3c6 chefstyle -a
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-06-11 18:52:38 -07:00
Miah Johnson
649ed9aca5 This cache needs to be writable. Its a problem.
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-06-11 18:52:38 -07:00
Miah Johnson
e46018a517 chefstyle -a cleanup
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-06-11 18:52:38 -07:00
Miah Johnson
c458897ad1 != 0 vs !foo.zero?
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-06-11 18:52:38 -07:00
Ryan Davis
a5309ea392 blindly applied chefstyle -a
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-06-11 18:52:03 -07:00
Miah Johnson
5a0dd5a5d8 Exclude more bundled controls
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-06-11 18:10:06 -07:00
Miah Johnson
c0a4dfeea4 We need to ignore some example InSpec profiles, we don't want to apply
chefstyle to them.

Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-06-11 15:12:35 -07:00
Ryan Davis
52423e8a0c Switched dependency to chefstyle.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-06-11 15:07:34 -07:00
Chef Expeditor
77d2bebda2
Bump version to 4.5.1 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-06-11 20:04:03 +00:00
Clinton Wolfe
e155203c93
Add inspec-core-bin as a gem (#4009)
Add inspec-core-bin as a gem
2019-06-11 16:03:44 -04:00
Chef Expeditor
beeddb0806
Update CHANGELOG.md with details from pull request #4189
Obvious fix; these changes are the result of automation not creative thinking.
2019-06-11 18:20:54 +00:00
Miah Johnson
aa0ce3d5cc
Merge pull request #4189 from inspec/mj/stale
Close at 400 days, with a message.
2019-06-11 11:20:38 -07:00
Clinton Wolfe
d43abdb3cd Add a gemspec for core-bin
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-06-10 17:02:30 -04:00
Clinton Wolfe
a5794e2097 Add inspec-core-bin as a gem
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-06-10 17:02:30 -04:00
Chef Expeditor
e275f3343c
Bump version to 4.5.0 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-06-10 19:14:13 +00:00
Clinton Wolfe
ec1baf6237
New plugin type: Input (#4019)
New plugin type: Input
2019-06-10 15:13:57 -04:00
Clinton Wolfe
74c1386246 Relax codeclimate config
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-06-10 14:00:45 -04:00
Chef Expeditor
1ad929648b
Bump version to 4.4.75 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-06-06 22:30:50 +00:00
Miah Johnson
556ca588df
Merge pull request #4102 from inspec/mj/rake
Test execution changes for Rake, Travis, and Appveyor
2019-06-06 15:30:32 -07:00
Miah Johnson
aa8fa96607 doesn't like the ~>
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-06-06 13:46:22 -07:00
Miah Johnson
dd2efa0d14 Ensure Rubygems is at least version 3.0
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-06-06 13:46:22 -07:00
Miah Johnson
14ada2afb0 After further discussion, lets allow Warning to be toggled on by ENV
until things are better.

Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-06-06 13:46:22 -07:00
Miah Johnson
5b047dd836 rubocop
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-06-06 13:46:22 -07:00
Miah Johnson
1a448f6264 We need berkshelf for test-kitchen, but we need chef 14 to support ruby
2.4

Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-06-06 13:46:22 -07:00
Miah Johnson
6671f7f960 Our site uses InSpec to generate some docs, ensure license is accepted
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-06-06 13:46:22 -07:00
Miah Johnson
c28430a47b test-kitchen currently requires berkshelf
I also discussed with Jerry if we can replace Berks with policyfile for
our testing and it seems unlikely at this point. Will re-evaluate in the
future.

Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-06-06 13:46:22 -07:00
Miah Johnson
a794506380 berkshelf is making dependency fun. bye.
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-06-06 13:46:22 -07:00
Miah Johnson
906f700e75 Open up restrictions on these gems as they were.. out of date.
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-06-06 13:46:22 -07:00
Miah Johnson
5a18457692 All the kitchen gems are in integration group, we need this..
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-06-06 13:45:39 -07:00
Miah Johnson
e405dd0c80 Put pry with test tools, remove useless group
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-06-06 13:45:39 -07:00
Miah Johnson
f3720c2324 Don't update rubygems system before installing rubygems
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-06-06 13:45:39 -07:00
Miah Johnson
bedb7d11b3 Run all the tests.
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-06-06 13:45:39 -07:00
Miah Johnson
1e7003f2eb remove deprecated www release tasks
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-06-06 13:44:18 -07:00
Miah Johnson
945324a625 Allow warning disable via environment
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-06-06 13:44:18 -07:00
Miah Johnson
5d7c7502ab travis lint cleanup
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-06-06 13:44:18 -07:00
Miah Johnson
bd73fc58e5 remove test from the rake command
Sort the ci coverage job, maybe we can match without the script: as
well?

Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-06-06 13:44:18 -07:00