Commit graph

4771 commits

Author SHA1 Message Date
Tom Hodder
eeeeda18d8 quote password when generating mysql command string (#2685)
* quote password when generating mysql command string
* added a test for mysql_session, added shellwords escaping to mysql_session resource
* changed the name of the escape method
* clarified test conditions

Signed-off-by: Tom Hodder <tom@limepepper.co.uk>
2018-03-09 08:41:21 -05:00
Chef Expeditor
50772a67ef Bump version to 2.0.46 by Expeditor 2018-03-09 04:22:48 +00:00
Clinton Wolfe
7d8dbe496d Docs: Describe support boundary between RSpec and InSpec (#2753)
* Describe boundary between RSpec and InSpec
2018-03-08 20:22:34 -08:00
Chef Expeditor
74555c96a2 Update CHANGELOG.md to reflect the promotion of 2.0.45 2018-03-08 22:37:09 +00:00
Chef Expeditor
4d510f9c3c Bump version to 2.0.45 by Expeditor 2018-03-08 22:26:21 +00:00
Miah Johnson
75f39e74f2 Refine deprecated methods to be consisten with supported fields in (#2801)
shadow file.

After much thought the deprecations from #2642 were for the wrong methods.

Plural method names feel much more natural when working with this
resource because you can have more than a single result.

Consider a match like `shadow.user(/^www/)`, this could return multiple
users, so `shadow.users` feels more natural here.

The problem is that the fields we're matching in the shadow file itself
are singular. Each entry is for a user, which has a password, and some
other fields. A user never has `passwords` in the shadow file, only a
`password`.

This is made more obvious when you use the `filter` method.

When we use this filter: `shadow.filter(min_days: 20, max_days: 30)` we
are matching fields in the shadow file and not using our matcher
methods. This means that if there is a discrepancy between our matcher
methods, and the shadow fields the user could end up confused. Like I did =)

This PR changes:

Changed matchers to match shadow fields.
Updated documentation to reflect changes.
Updated tests to reflect changes.
Re-add `filter` method, and add a test for it.
Renamed variable for FilterTable to be less confusing.
Renamed query argument for methods to be consistent.
Cleanup docs based on comments from @jerryaldrichiii
Make Rubocop happy <3

Signed-off-by: Miah Johnson <miah@chia-pet.org>
2018-03-08 17:26:08 -05:00
Rob Campbell
ee35518882 Updates tutorial author last name from "Hedgepath" to "Hedgepeth" (#2802)
Signed-off-by: Rob Campbell <rcampbell@chef.io>
2018-03-08 16:03:27 -05:00
Chef Expeditor
e3a3b00859 Bump version to 2.0.44 by Expeditor 2018-03-08 21:02:04 +00:00
Miah Johnson
5fee525be8 Remove os checks from initialize as this is provided by platform (#2797)
Removes skip_resource and raise .. if InSpec.os stuff from initialize as this is covered by platform support.

Signed-off-by: Miah Johnson <miah@chia-pet.org>
2018-03-08 16:01:50 -05:00
Chef Expeditor
c42d8c12ad Bump version to 2.0.43 by Expeditor 2018-03-08 20:46:11 +00:00
Jared Quick
a9127d3f6c
Create reporter directory if it does not exist. (#2798)
Signed-off-by: Jared Quick <jquick@chef.io>
2018-03-08 15:45:59 -05:00
Chef Expeditor
9a46d5a97b Bump version to 2.0.42 by Expeditor 2018-03-08 20:38:28 +00:00
Noel Georgi
4c54e3fdd9 Added the missing variable reference (#2794)
Signed-off-by: Noel Georgi <noel.georgi@reancloud.com>
2018-03-08 15:38:14 -05:00
Chef Expeditor
4d6e35b0b5 Bump version to 2.0.41 by Expeditor 2018-03-08 04:04:39 +00:00
Wei He
a3898db2fe Fix http with connection error (#2770)
* fix: http resource handle connection failed (ex. port is not open)
* add test case

Signed-off-by: Wing924 <weihe924stephen@gmail.com>
2018-03-07 23:04:26 -05:00
Chef Expeditor
18675ae326 Bump version to 2.0.40 by Expeditor 2018-03-07 15:09:33 +00:00
Christoph Hartmann
3d87d75c5a
return 1 as exit code for commands that are not available (#2792)
* return 1 as exit code for commands that are not available

Signed-off-by: Christoph Hartmann <chris@lollyrock.com>

* update tests

Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
2018-03-07 16:09:22 +01:00
Chef Expeditor
9dca812689 Bump version to 2.0.39 by Expeditor 2018-03-07 14:31:45 +00:00
Miah Johnson
f6db0e345a Update shadow resource to use FilterTable (#2642)
* Change shadow resource to use FilterTable rather than custom filter
implementation.

Add tests for singluar aliased methods and other minor changes to work
with FilterTable output.
Coverage is at 100%

Signed-off-by: Miah Johnson <miah@chia-pet.org>

* merge master

Signed-off-by: Miah Johnson <miah@chia-pet.org>
2018-03-07 15:31:30 +01:00
Chef Expeditor
acd20e8aea Bump version to 2.0.38 by Expeditor 2018-03-07 13:39:37 +00:00
João Vale
3e2450e703 Host resource: use bash over netcat in Linux (#2607)
* Add support to use bash in host resource

Netcat's presence is widely regarded as a security issue, and thus not
always available. This solution first tries to use bash builtins and
timeout (from coreutils), so is less likely to require installing
additional packages.

* Darwin UDP support in host resource
* Host: use netcat first if available

Signed-off-by: João Vale <jpvale@gmail.com>
2018-03-07 08:39:27 -05:00
hannah-radish
0994c63d48 Usability testing fixes (#2755)
* Usability testing fixes

Signed-off-by: hannah-radish <hmaddy@chef.io>

* Bug fixes

Signed-off-by: hannah-radish <hmaddy@chef.io>
2018-03-07 12:25:54 +01:00
Louis Willcock
cd7f84f5e7 update docs to non-deprecated parameter syntax from name > username as per dep warnings (#2781)
Signed-off-by: JohnVonNeumann <louiswillcock@gmail.com>
2018-03-06 13:16:01 -05:00
Franklin Webber
c2f3dd4c61 Fixes docs for file example (#2552)
* Fixes docs for file example

* The version test should be a string
* There was a missing closing brace in the regex examples
* Some white-spaced got cleaned up
* I added the file name into the variable for the pg examples

Signed-off-by: Franklin Webber <franklin@chef.io>

* Updates docs file to use real postgre path

Signed-off-by: Franklin Webber <franklin@chef.io>

* Moves the 'real' example filepath to the describe

Signed-off-by: Franklin Webber <franklin@chef.io>
2018-03-06 19:00:26 +01:00
Chef Expeditor
b8d165d13f Bump version to 2.0.37 by Expeditor 2018-03-06 13:56:27 +00:00
Jerry Aldrich
e4e907624a iptables resource: Add support for other bin paths (#2783)
* iptables resource: Add support for other bin paths
* Use `%w{}` instead of `[]`

Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
2018-03-06 08:56:15 -05:00
Nicholas Duffy
0853e12cc3 Fix AWS IAM access keys example (#2756)
There is no `created_age`. This should
be `created_days_ago`.

Signed-off-by: Nicholas Duffy <duffn@outlook.com>
2018-03-05 16:05:10 -05:00
Jerry Aldrich
acf8a2eab5 Add g++ requirement to README.md (#2776)
The `g++` package is needed to install InSpec from RubyGems.

Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
2018-03-05 16:02:34 -05:00
Tommy Song
10ca3f44a0 docs: Add PS commands in Usage via Docker to README.md (#2778)
* Added commands support for Windows
* restructured the Usage via Docker block

Signed-off-by: Tommy Song <tommynsong@gmail.com>
2018-03-05 15:34:36 -05:00
Kimberly Garmoe
fbe2035a97 Corrects capitalization (#2764)
Signed-off-by: kagarmoe <kgarmoe@chef.io>
2018-03-05 09:07:06 -05:00
Kimberly Garmoe
77ee77c557 Removes errant articles (#2775)
Signed-off-by: kagarmoe <kgarmoe@chef.io>
2018-03-02 22:53:01 -05:00
Chef Expeditor
fad22481b8 Bump version to 2.0.36 by Expeditor 2018-03-02 18:51:06 +00:00
Clinton Wolfe
89ce8514df Update name of subnet fixture, fixing 3 failing integration tests (#2765)
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2018-03-02 13:49:33 -05:00
Aleksey Tsalolikhin
50e952701d Add cautionary note to include leading zero in file mode specifications (#2606)
Signed-off-by: Aleksey Tsalolikhin <aleksey@verticalsysadmin.com>
2018-03-02 13:47:46 -05:00
Chef Expeditor
a6852a6f5a Bump version to 2.0.35 by Expeditor 2018-03-02 18:45:29 +00:00
Clinton Wolfe
d0e6d2eb72 AWS API Pagination fixes (#2762)
* Add pagination support to aws_iam_groups
* Add pagination support to aws_iam_policy
* Add pagination to aws_iam_policies
* Adds pagination to aws_iam_access_keys
* Adds pagination to aws_kms_keys

Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2018-03-02 13:45:17 -05:00
Kimberly Garmoe
01357e1e29 Kg/az fix (#2763)
* Fixes typo
* Remove unclear phrase

Signed-off-by: kagarmoe <kgarmoe@chef.io>
2018-03-02 09:18:01 -05:00
Chef Expeditor
1e5c3d4d0d Bump version to 2.0.34 by Expeditor 2018-03-02 14:14:17 +00:00
Richard Nixon
47e4c578e0 Fix aws-iam-users pagination (#2761)
* Fix aws-iam-users pagination

PROBLEM: aws-iam-users resource only retrieves 100 records due to pagination
in the AWS IAM list_users function.

FIX: Iterate over all the pages using the AWS pagination variables `marker`
and `is_truncated`

Signed-off-by: Richard Nixon <richard.nixon@btinternet.com>
2018-03-02 09:14:05 -05:00
Jerry Aldrich
c2dcb11f52 Move TESTING_AGAINST_AWS.md to test/aws (#2669)
* Move `TESTING_AGAINST_AWS.md` to `test/aws`
* Add link in README.md

Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
2018-03-02 09:11:56 -05:00
Kimberly Garmoe
d02ae42747 fixes ec2 reference (#2766)
Signed-off-by: kagarmoe <kgarmoe@chef.io>
2018-03-02 09:06:11 -05:00
Chef Expeditor
3e5a8c110a Bump version to 2.0.33 by Expeditor 2018-03-02 14:03:11 +00:00
Jerry Aldrich
3da8fd1e98 command resource: Add exist? for Alpine Linux (#2768)
This allows `command('foo').exist?` to work on Alpine Linux.

Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
2018-03-02 09:02:58 -05:00
Chef Expeditor
1e14bbdf9d Update CHANGELOG.md to reflect the promotion of 2.0.32 2018-03-01 20:53:15 +00:00
Chef Expeditor
f7e8266e6a Bump version to 2.0.32 by Expeditor 2018-03-01 19:30:20 +00:00
Noel Georgi
dd033fbf1b mssql_session - Handling cases where the data is nil (#2752)
* Fixing bug where the row data returned is nil

Signed-off-by: Noel Georgi <noel.georgi@reancloud.com>
2018-03-01 14:30:07 -05:00
Kimberly Garmoe
24d5a9832e Updates language for Resource Packs (#2449)
* Updates language for Resource Packs

Signed-off-by: kagarmoe <kgarmoe@chef.io>
2018-03-01 11:32:55 -05:00
Chef Expeditor
087a9e5776 Bump version to 2.0.31 by Expeditor 2018-03-01 14:20:30 +00:00
Clinton Wolfe
154ab8b05d Docs: Clarify Matchers page to speak about Universal matchers (#2754)
* Distinguish between universal and specialized matchers
* Make the table of contents clickable
* Add note about RSpec matchers, possibly regrettable

Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
Signed-off-by: kgarmoe <kgarmoe@chef.io>
2018-03-01 09:20:20 -05:00
Kimberly Garmoe
f4ea53c3a5 Kg/k module (#2626)
* Refactors kernel_module

Signed-off-by: kagarmoe <kgarmoe@chef.io>
2018-02-28 17:12:37 -05:00