Mirrors/inspec
2
0
Fork 0
mirror of https://github.com/inspec/inspec synced 2024-11-23 13:13:22 +00:00
Code Issues Projects Releases Packages Wiki Activity
7642 commits 453 branches 1898 tags 74 MiB
Commit graph

1180 commits

Author SHA1 Message Date
Ryan Davis
902d7b563c Set the umask on travis in before_install. 
https://travis-ci.community/t/file-permissions-just-gone-up-to-664/1547/5

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-06-19 16:40:24 -07:00
Jerry Aldrich
80c595ba3d nginx_conf: Fix commented/empty file parsing 
This fixes `nginx_conf.params` when:
  - Given an empty file
  - Given a file with only comments
  - Given a file that has an include for a file that:
    - Is empty
    - Has all lines commented out

This also fixes a test where a missing file is actually empty

Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-06-17 21:57:26 -08:00
Miah Johnson
b21bcfabc4 Lets discuss this next week when we're all around =) 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-06-14 15:04:26 -07:00
Clinton Wolfe
dea323fa52 Test fixtures and failing functional test for input rename 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-06-12 19:00:53 -04:00
Clinton Wolfe
ab6933fcc7 A key value-add use of company time 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-06-12 13:05:49 -04:00
Clinton Wolfe
d8e485eb62 Edit the masrshalling code more carefully to match 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-06-12 12:51:02 -04:00
Clinton Wolfe
0023906812 Update test code regarding input marshalling 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-06-12 12:25:45 -04:00
Clinton Wolfe
46624396c7 Bulk edit of test files to use input() in DSL 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-06-12 12:17:19 -04:00
Ryan Davis
fae4230a41 Removing inspec/profile_vendor from inspec/base_cli. 
This was the next most expensive require in the analysis.

Also rearranged the way that ui handled tables to be lazy.

```
% SLOW=1 time rake test:functional

before: Finished in  681.514579s, 0.5136 runs/s, 2.9919 assertions/s.
after : Finished in  642.655918s, 0.5446 runs/s, 3.1728 assertions/s.
```

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-06-11 19:16:58 -07:00
Ryan Davis
692d6a9ab8 hand applied one that is now marked as unsafe in rubocop 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-06-11 18:52:38 -07:00
Miah Johnson
68e540a15a Ignore Rubocop checks 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-06-11 18:52:38 -07:00
Miah Johnson
e46018a517 chefstyle -a cleanup 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-06-11 18:52:38 -07:00
Ryan Davis
a5309ea392 blindly applied chefstyle -a 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-06-11 18:52:03 -07:00
Clinton Wolfe
1628383c8f Mis-spelled a method name 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-06-06 12:51:22 -04:00
Clinton Wolfe
9366804335 PR Feedback 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-06-06 12:51:22 -04:00
Clinton Wolfe
4b1ee722b4 Functional test for event log 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-06-06 12:51:22 -04:00
Clinton Wolfe
90da768ef0 Move event creation to input_registry to simplify plugin authorship 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-06-06 12:51:22 -04:00
Clinton Wolfe
53beaff372 Input plugin types work 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-06-06 12:51:22 -04:00
Clinton Wolfe
9e2e569d85 Add input plugin type API 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-06-06 12:51:21 -04:00
Clinton Wolfe
962dfc8d90 Failing tests for input plugin 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-06-06 12:51:21 -04:00
Clinton Wolfe
82f910e320 Plugin type declaration and unit test 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-06-06 12:51:21 -04:00
Ryan Davis
11638d36dd Now that we aren't parallelizing, start bringing back skipped tests. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-06-03 14:12:06 -07:00
Miah Johnson
a5c8021227 don't remove this leading newline =) 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-31 11:43:44 -07:00
Miah Johnson
2a1b1d8e88 Remove all leading newlines. 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-31 11:43:44 -07:00
Ryan Davis
4790e288a0
Merge pull request #4142 from inspec/zenspider/clean_unnecessary_requires 
Clean unnecessary requires
 2019-05-29 18:33:06 -07:00
Ryan Davis
be125598c8 Additional whitespace cleanup. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-29 17:58:02 -07:00
Ryan Davis
82c9aa6ed6 Got the rest of the tests to pass. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-29 17:58:02 -07:00
Ryan Davis
9ec91484fc Get all non-resource tests fixed again. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-29 17:58:02 -07:00
Ryan Davis
de8258c9f7 Get yaml_test.rb working 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-29 17:58:02 -07:00
Ryan Davis
761f48e63c Get user_test.rb working 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-29 17:58:02 -07:00
Ryan Davis
adaf2bc364 Removed aws resource requiring from test/helper and inspec/resource. 
This speeds up parallel unit test runs from a very consistent 2:49 to
a very consistent 1:53, or a 33% reduction.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-29 17:58:02 -07:00
Ryan Davis
23f8a1e30c Explicitly set default_external to UTF-8 for windows testing. 
This fixes 4 failures having to do with encoding mismatch.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-29 15:48:37 -07:00
Miah Johnson
6c19e81a06 Remove authors tags from source files. 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-28 12:47:39 -07:00
Clinton Wolfe
c8f0de05af
inspec check: Send log to STDERR when running with --format json (#4001) 
inspec check: Send log to STDERR when running with --format json
 2019-05-28 14:44:44 -04:00
Miah Johnson
2215bb0570 Update all requires pointing to util/ 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-28 11:30:16 -07:00
Ryan Davis
f36a7c8061 No tabs. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-25 03:40:36 -07:00
Miah Johnson
fb0993e0f2
Merge pull request #4089 from mirskiy/github_url_regex_bug 
Fix github url regex. Add period for repo
 2019-05-21 12:45:18 -07:00
Miah Johnson
27ee7a1a63
Merge pull request #4107 from inspec/zenspider/telemetry_requires 
Minor require cleanup for telemetry.
 2019-05-20 13:10:30 -07:00
Ryan Davis
9c6965b2ed Minor require cleanup for telemetry. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-20 13:09:38 -07:00
Miah Johnson
c7218a991a
Merge pull request #4108 from inspec/zenspider/remove_test_unit_helper 
Delete test/unit/helper.rb
 2019-05-20 13:08:07 -07:00
Miah Johnson
36029da0a3
Merge pull request #4116 from inspec/zenspider/clean_more_requires 
Clean more requires
 2019-05-20 13:07:04 -07:00
Ryan Davis
e1061f41f2 Clean more requires 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-20 13:01:18 -07:00
Ryan Davis
8c56477f02 Fixes a test interaction bug between installer and loader. 
Not sure how it was supposed to work in the first place. The plugin in
question depends on ordinal_array and that wasn't in that fixture dir.
Switching to 2 is all it apparently needed.

This does cause yet another double-load warning (VERSION already
defined). I don't know how we're supposed to get around that with the
way we've set up these tests.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-18 15:45:22 -07:00
Ryan Davis
8ea1889001
Merge pull request #4079 from inspec/mj/cli_warn 
Fix @unique_controls uninitialized warning
 2019-05-18 15:00:47 -07:00
Ryan Davis
892641f69d Delete test/unit/helper.rb 
I isn't used anywhere.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-18 14:21:33 -07:00
Ryan Davis
9b7c292d4c Use IO globals instead of IO constants. 
Helps testing and lots of other things if we only use $stdout/$stderr.

STDOUT/STDERR should only be used to restore the globals.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-18 12:48:18 -07:00
Ryan Davis
40d74cb5be Turn off logging after the configure_logger tests. 
Please do not increase the amount of noise our tests have from here on out.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-18 12:48:18 -07:00
Dan Mirsky
1e20e2998e Fix github tree url regex. Add period for repo 
Signed-off-by: Dan Mirsky <mirskiy@gmail.com>
 2019-05-18 10:50:39 -07:00
Ryan Davis
e72f3f34aa Skip more_permissive_than? file_test because broken only on CI. 
Trying to fix file_test failure that only happens on travis.

The "mock" file in question is supposed to have a stat of 644, but
actually has 664 but only on travis-ci.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-17 03:19:46 -07:00
Ryan Davis
bc028893e8 Fixed inconsistent use of MT::S's "expect" method (eg _) 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-17 02:26:07 -07:00
Ryan Davis
9b0d8edfb4 Fixed another bad test interaction. 
This time between:

+ PluginManagerCliDefinitionTests#(?:test_plugin_registered
+ PluginLoaderTests#test_load_mock_plugin_by_gem

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-17 02:26:07 -07:00
Ryan Davis
3ba7aecffb Skips the one test that hits rspec directly and causes mocha to blow out afterwards 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-17 02:26:07 -07:00
Ryan Davis
1b01aa7a57 Removed all redundant INSPEC_CONFIG_DIR setup from tests. 
Pushed up to setup

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-17 02:26:07 -07:00
Ryan Davis
8f3e1a0fe5 Fixes test failure interaction between Loader and Installer tests. 
Specifically, if these were run in this order:

+ PluginLoaderTests#test_load_mock_plugin_by_gem
+ PluginInstallerInstallationTests#test_install_a_gem_from_local_file

the latter would fail.

The failure was in test setup. The solution was partially to crib off
of and normalize with LoaderTest setup/teardown and partially to set extra things.

Specifically:

+ HOME wasn't being set so it was finding my ~/.inspec/plugins.json
+ ENV wasn't being reset for Gem.paths
+ Installer wasn't being reset correctly, so plugins were known across tests.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-17 02:26:07 -07:00
Ryan Davis
03dd753ad3 Omit user plugins for loader test failure. 
Fixes #4053

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-17 02:26:07 -07:00
Ryan Davis
84fd8af96a Added SLOW=1 env var to run slow installer tests, otherwise skipped 
+ Added SLOW=1 to appveyor (I hope?) and travis.
+ Off by default.

Speeds up installer tests from ~5.5 seconds to ~0.5 seconds.

Once this is established, we can push this up to the main helper and
generalize if it works out for us.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-17 02:26:07 -07:00
Ryan Davis
92d8cd4df9 Fixed two test order dependency bugs. 
+ Do extra cleanup of loaded_specs for the dependencies.
+ Ensure rake is actually activated.

Fixes #4030.
Fixes #4026.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-17 02:26:07 -07:00
Ryan Davis
4d4e8e1feb Turn off rdoc/ri generation in plugins. 
As commented, I'm happy to push this to our tests, but it does seem
odd that we'd install rdoc/ri for plugins.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-17 02:26:07 -07:00
Ryan Davis
6235c3f658 Fixed missing requires 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-17 02:26:06 -07:00
Ryan Davis
cdf95cd160 Fixed 3 failures in cmp matcher. 
+ float? comparison can raise a TypeError
+ octal? comparison was allowing non-octal values (which cast to 0)
+ symbol comparison was casting to a string, but then doing an == check instead of casecmp.

The latter seems optional, but consistent with the intent of cmp.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-17 02:26:06 -07:00
Ryan Davis
b80dfa2cbd Tests for cmp. 
Doesn't test any of the aux methods.

This uncovers ~3 errors in the code. Not fixed.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-17 02:26:06 -07:00
Miah Johnson
832dc4a1c9 This test was too intimate. 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-15 19:30:39 -07:00
Ryan Davis
fa7a8c9e19 Normalizing two test declarations. 
These tests both involve dynamic un-rooted classes. As such, they have
no name and thus print like #<Class:0xXXXXXXXX:...>. I switched one to
a describe instead of Class.new(Minitest::Test) and the other I
stringified the anonymous class.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-14 23:27:18 -07:00
Ryan Davis
6adf1d2560 Remove all byebug requires in code. 
Please don't leave debugging remnants in the code.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-14 23:24:14 -07:00
Miah Johnson
bf28482350
Merge pull request #4043 from inspec/ap/no-resource-capitalize 
Wrap resources in backticks and remove resource name capitalizing
 2019-05-08 23:49:25 -07:00
Miah Johnson
11b8da3283
Merge branch 'master' into mj/encoding 2019-05-08 12:59:55 -07:00
Miah Johnson
1edfeae5f4
Merge pull request #4025 from inspec/mj/3849 
Enable user telemetry opt-in / opt-out on cli
 2019-05-08 12:56:29 -07:00
Clinton Wolfe
b3e5788d2a
Merge pull request #4036 from inspec/mj/dst 
Add missing tests for DataSeries#enabled? #disable
 2019-05-08 15:49:19 -04:00
Miah Johnson
37ea6f2f77
Merge pull request #4023 from inspec/zenspider/minitest 
Modernize use of Minitest.
 2019-05-08 12:23:49 -07:00
Alex Pop
d7f06f98f1 Wrap resources in backticks and remove resource name capitalizing 
Signed-off-by: Alex Pop <alexpop@users.noreply.github.com>
 2019-05-08 20:17:51 +01:00
Miah Johnson
5a0913e3f6 Add missing tests for DataSeries#enabled? #disable 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-08 00:44:51 -07:00
Miah Johnson
d000f20f34 Update Collector#reset to clear telemetry_toggled_off 
Updated the name of #reset -> #reset! as we are modifying state of a
singeton.

Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-08 00:36:45 -07:00
Miah Johnson
871b0e9a38 Ensure telemetry can be disabled 
The #disable_telemetry method now toggles @telemetry_toggle_off.
The @telemetry_toggle_off is defaulted to false

The #telemetry_enabled? method now checks @telemetry_toggle_off
and we generally check the configuration. We do not flip
@telemetry_toggle_off based on the content of the configuration.

Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-08 00:30:24 -07:00
Miah Johnson
640d122327 Update Inspec::Config.mock in collector global methods 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-07 22:37:43 -07:00
Miah Johnson
0b9833dd96 condense true/false enabled tests 
Because of the way the test system loads I cannot guarantee that
`Inspec::Config.cached` won't be nil. I have to always pass in a mock
config object with our setting.
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-07 19:06:38 -07:00
Miah Johnson
659b4b373a Remove # encoding: utf8 magic comments 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-07 16:06:23 -07:00
Clinton Wolfe
80b847ae83
Improve testing on inputs that do not have values (#4007) 
Improve testing on inputs that do not have values
 2019-05-07 15:01:09 -04:00
Clinton Wolfe
ce16120b18 Failing functional test for running inspec check with a deprecation 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-05-06 14:58:10 -04:00
Miah Johnson
b51ad8acb8 When telemetry is disabled Inspec.record_telemetry_data doesn't record 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-03 16:13:45 -07:00
Miah Johnson
ac2d782266 Pass in mock config object to tests and validate telemetry_enabled? 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-03 16:07:24 -07:00
Ryan Davis
476c6878b3 Modernize use of Minitest. 
+ Turn off verbosity in Rakefile by default. Use `rake V=1` to turn back on.
+ MiniTest -> Minitest everywhere.
+ MiniTest::Unit::TestCase -> Minitest::Test everywhere.
+ Updated minitest doco urls to official and up-to-date site.
+ Normalize requires. Only needs "minitest/autorun" and "minitest/pride".

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-03 15:01:57 -07:00
Clinton Wolfe
e280990e76 Test fixtures and failing functional tests for DSL 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-30 23:54:29 -04:00
Clinton Wolfe
c4aa4314af Test fixture to exercise undeclared inputs 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-30 22:45:18 -04:00
Clinton Wolfe
7d2028287c Get unit and functional tests passing 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-26 13:14:32 -04:00
Clinton Wolfe
d9b7473118 Add inheritance test fixture 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-26 13:14:32 -04:00
Clinton Wolfe
9156a782fe Add stack introspection 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-26 13:14:32 -04:00
Clinton Wolfe
9faf4b1034 Add tests for marshalling 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-26 13:14:31 -04:00
Clinton Wolfe
0ba056cd94 Consolidate validation tests 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-26 13:14:31 -04:00
Clinton Wolfe
2450f45ac6 Detailed type validation works 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-26 13:14:31 -04:00
Clinton Wolfe
407dcd9028 Add unit tests for enforcing type validation 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-26 13:14:31 -04:00
Clinton Wolfe
2536d76324 Events work at the unit level, except for stack hueristics 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-26 13:14:31 -04:00
Clinton Wolfe
e3b2ec7d7c Sketch out events unit tests 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-26 13:14:31 -04:00
Clinton Wolfe
b8cde5530b Add event, some tests still commented out 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-26 13:14:31 -04:00
Clinton Wolfe
aae54d2cb6 Checkpoint commit after Input rename; precedence is broken 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-26 13:14:31 -04:00
Clinton Wolfe
b74f61e9de
Update deprecation settings for v4 (#3973) 
Update deprecation settings for v4
 2019-04-25 18:56:43 -04:00
Clinton Wolfe
9e6adcc7b1
update 'low' impact value to align with CVSS 3.0 (#3961) 
update 'low' impact value to align with CVSS 3.0
 2019-04-25 14:43:43 -04:00
Clinton Wolfe
9833b1950b
Update plugin test fixtures for Ruby 2.6 and remove for 2.3 (#3978) 
Update plugin test fixtures for Ruby 2.6 and remove for 2.3
 2019-04-25 11:10:17 -04:00
Clinton Wolfe
843ba7afa2
Improve ss parsing code for IPv6 addresses (#3962) 
Improve ss parsing code for IPv6 addresses
 2019-04-25 11:09:31 -04:00
Clinton Wolfe
77400b83b2 Also for train-test-fixture add 2.6.0 ABI and remove 2.3.0 ABI 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-23 23:45:59 -04:00
Clinton Wolfe
cf1d4f9994 Remove 2.3.0 ABI test fixture plugins 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-23 23:39:31 -04:00
Clinton Wolfe
3ec3607544 Add 2.6.0 ABI plugin test fixtures 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-23 23:37:59 -04:00
Aaron Lippold
a94fdc67d5 updated low to align with CVSS 3.0 
Signed-off-by: Aaron Lippold <lippold@gmail.com>
 2019-04-23 15:02:52 -04:00
Clinton Wolfe
f7b01093a4 Warn on using default with attributes 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-23 11:46:13 -04:00
Miah Johnson
2f78515164 Add a few tests for LinuxPorts class to validate ss parsing. 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-04-19 13:45:33 -07:00
Clinton Wolfe
3d0b8dff2e
Merge pull request #3956 from inspec/cw/use-deprecation-everywhere-4-port 
Use deprecation facility everywhere - v4 port
 2019-04-17 17:12:24 -04:00
Clinton Wolfe
7aeb1763a9
Merge pull request #3897 from mattlqx/interface-addresses 
Support address matchers on interface resource
 2019-04-17 11:57:29 -04:00
Clinton Wolfe
1552dc0210 Merge branch 'cw/use-deprecation-everywhere-3-port' of github.com:inspec/inspec into cw/use-deprecation-everywhere-4-port 2019-04-16 17:42:45 -04:00
Clinton Wolfe
a3a2699e8d Update unit tests to expect deprecations 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-16 17:28:39 -04:00
Clinton Wolfe
0c884b1415
Merge pull request #3895 from mitre/al-mitre/more-permissive-than 
Signed-off-by: Aaron Lippold <lippold@gmail.com>
 2019-04-16 14:41:43 -04:00
Matt Kulka
633cea6673 support address matchers on interface resource 
Adds missing functionality to `interface`. Fixes #1830

```
describe interface("eth0") do
  its(ipv4_addresses) { should include 1.2.3.4 }
end
```

And so on... see diff/docs for additional matchers.

Signed-off-by: Matt Kulka <mkulka@parchment.com>
 2019-04-12 08:24:13 -07:00
Jerry Aldrich
40031a9b83 Use deprecation facility throughout code 
This converts all current deprecation warnings/TODOs to use the
`Inspec.deprecate()` deprecation facility.

This also modifies `Inspec.deprecate()` to only require 1 argument.

Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-04-11 19:15:01 -04:00
Clinton Wolfe
4348e8fa07
Merge pull request #3935 from inspec/cw/add-license-gating 
Add license acceptance to InSpec v4
 2019-04-11 18:56:11 -04:00
Clinton Wolfe
03385b98ba
Merge pull request #3928 from inspec/mj/tmr 
Telemetry Object Model
 2019-04-11 16:23:17 -04:00
Miah Johnson
5adf33469a improve testing for DataSeries#to_h and DataSeries#to_json 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-04-11 12:22:29 -07:00
Miah Johnson
55ea2d984c Not sure how to make this not dependant on list_data_series to prove its 
functionality.

Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-04-11 12:17:59 -07:00
Clinton Wolfe
34d16553bb Use touched license file to make re-homed config test pass 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-11 15:03:27 -04:00
Miah Johnson
3c6db15124 improve tests for Collector#list_data_series 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-04-11 11:47:42 -07:00
Miah Johnson
ac78feb090 Remove list_data_series_by_name. 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-04-11 00:41:09 -07:00
Miah Johnson
56a5c80bf5 Rebuild the core telemetry interface. 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-04-09 16:58:40 -07:00
Clinton Wolfe
2b30646642 Merge branch 'cw/attrs-rename-cli-option' into 3-stable 2019-04-09 12:10:53 -04:00
Clinton Wolfe
b701317616
Merge pull request #3879 from inspec/cw/attrs-rename-cli-option 
Attribute->Input Rename: Rename cli option
 2019-04-09 11:46:29 -04:00
Miah Johnson
8435990722
Merge pull request #3899 from inspec/sp/crontab-path-update 
crontab: Add validation for path param
 2019-04-04 17:26:13 +00:00
Aaron Lippold
1e9f8fd018 Merge branch 'master' of https://github.com/inspec/inspec into al-mitre/more-permissive-than 
Signed-off-by: Aaron Lippold <lippold@gmail.com>
 2019-03-28 15:50:16 -04:00
Miah Johnson
6ce349dcde
Merge pull request #3873 from inspec/cw/config-add-caching 
Add caching to Inspec::Config
 2019-03-21 10:37:06 -07:00
Stuart Paterson
97f6f232c8
Replace single-quoted static string. 
Signed-off-by: Stuart Paterson <spaterson@chef.io>
 2019-03-21 16:24:10 +00:00
Stuart Paterson
5accfa5391
Add protection for crontab resource path and document it. 
Signed-off-by: Stuart Paterson <spaterson@chef.io>
 2019-03-21 15:49:00 +00:00
Clinton Wolfe
789fca2520
Merge pull request #3889 from devoptimist/decouple_tests 
Decoupling test profiles from example profiles
 2019-03-20 11:07:30 -04:00
Aaron Lippold
a2a86860d6 This adds the more_permissive_than?(mode) matcher to the file resource. 
Fixes #3893

Signed-off-by: Aaron Lippold <lippold@gmail.com>
 2019-03-18 18:10:13 -04:00
devoptimist
2d49f39adc moved example tests into their own sub dir, and reused examples_path variable 
Signed-off-by: devoptimist <sbrown@chef.io>
 2019-03-18 15:15:32 +00:00
Keith Walters
c2bd0616fe Allow http resource to follow redirects 
By specifying a `max_redirects` attribute, the `http` resource worker
will follow any HTTP Redirect response (301, 302, etc...) up to the
limit defined by this attribute. For a local worker, exceeding that
limit will raise a `FaradayMiddleware::RedirectLimitReached` exception.
For a remote worker, the curl command will exit without populating the
`status` and `body` properties.

Signed-off-by: Keith Walters <keith.walters@cattywamp.us>
 2019-03-16 20:54:52 -04:00
devoptimist
94d80f6c8f Decoupling test profiles from example profiles 
Signed-off-by: devoptimist <sbrown@chef.io>
 2019-03-14 00:32:13 +00:00
Clinton Wolfe
3cce8ba705 Replace attrs with input-files in remaining tests 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-03-08 12:40:33 -05:00
Clinton Wolfe
f7202c229b Add caching to Inspec::Config 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-03-06 14:59:06 -05:00
Clinton Wolfe
52f6351f84 Adjust regexes for credset name and add tests 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-02-27 15:14:27 -05:00
Clinton Wolfe
7328e82ae6 Implement credential set loading 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-02-27 15:14:27 -05:00
Clinton Wolfe
ef18081dfe Merge branch 'cw/attrs-rename-classes-methods' 
Accidentally merged cw/attrs-rename-default-attribute into cw/attrs-rename-classes-methods, intended to go to master.
 2019-02-26 15:38:20 -05:00
Clinton Wolfe
ac41a6ae20
Merge pull request #3811 from inspec/cw/attrs-rename-classes-methods 
Attribute->Input Rename:  Rename Classes and Methods
 2019-02-25 18:02:11 -05:00
Clinton Wolfe
c9e8716310 Change two more mentions of DEFAULT_ATTRIBUTE 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-02-22 10:10:50 -05:00
Clinton Wolfe
24e8c0a6dd Replace DEFAULT_ATTRUBUTE, unit test for it passes 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-02-22 10:05:31 -05:00
Jerry Aldrich
0684cda6c6 Suppress warnings in unit test output 
This does the following:
  - Captures warning for lack of `--sudo` with `--sudo-password`
  - Captures warnings for transformation of URL target in url fetcher
  - Changes deprecated `supports:` syntax to use new syntax

Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-02-22 00:10:39 -08:00
Clinton Wolfe
491ec001a2 Fix bad class name in unit test 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-02-20 20:41:10 -05:00
Clinton Wolfe
c28c244f16 Fix a handful of functional tests 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-02-20 20:41:10 -05:00
Clinton Wolfe
f7d58ad92c Replace most mentions of attribute with input in test/ 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-02-20 20:41:10 -05:00
Clinton Wolfe
ce99624095 Renamed AttributeRegistry->InputRegistry 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-02-20 20:41:09 -05:00
Clinton Wolfe
a1982a5f8b First pass on renaming attribute->input, unit test passes 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-02-20 20:41:09 -05:00
Clinton Wolfe
cbf1b665f8 Fix typo in require 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-02-14 12:37:27 -05:00
Clinton Wolfe
fc448ed6f1 Rename attribute_registry to input_registry 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-02-14 12:37:27 -05:00
Clinton Wolfe
c538eae2df Rename objects/attribute to objects/input 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-02-14 12:37:27 -05:00
Clinton Wolfe
66d0d146b2 Rename test control files 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-02-11 12:10:08 -05:00
Clinton Wolfe
785888a209 Rename functional tests, unit tests, and test fixtures 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-02-08 18:23:01 -05:00
Jerry Aldrich
273597d371 Remove encoding: utf-8 
Thanks @miah

Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-02-07 13:04:58 -08:00
Jerry Aldrich
7134989eba Respond to @clintoncwolfe's feedback 
Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-02-07 11:15:01 -08:00
Jerry Aldrich
a6f74a33b2 Fix Inspec::Config regression in Inspec::Backend 
With the changes in PR #3750, `Inspec::Backend.create` needs to support
both being passed a Hash and being passed an Inspec::Config. This adds
a line to convert a passed Hash to an Inspec::Config.

This also adds unit tests for Inspec::Backend because they were missing.

Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-02-07 01:00:05 -08:00
Clinton Wolfe
4cf9e23e9d Move most test fixture profiles under attributes/ 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-02-06 18:10:19 -05:00
Clinton Wolfe
05a011f6ff
Merge pull request #3629 from inspec/cw/init-plugin 
inspec-init plugin: generate inspec plugins
 2019-02-06 17:40:59 -05:00
Clinton Wolfe
02cb799ee6 Rename free to free_kb 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-02-06 14:01:04 -05:00
Clinton Wolfe
5bbd4c16d6 Add size_kb, and correct Powershell code to return KB for both total size and free space, rather than total in GB and free space in bytes 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-02-06 14:01:04 -05:00
Clinton Wolfe
fef637a6c6 Add percent_free property 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-02-06 14:01:04 -05:00
James Massardo
c1a9de7003 update helpers and mocks so tests run successfully 
Signed-off-by: James Massardo <jmassardo@chef.io>
 2019-02-06 14:01:04 -05:00
James Massardo
83c0c18fca Add free space and type to filesystem resource 
Signed-off-by: James Massardo <jmassardo@chef.io>
 2019-02-06 14:01:04 -05:00
Clinton Wolfe
5a5eb4a9a5
Merge pull request #3750 from inspec/cw/cred-set-support-02 
Formalize Config File
 2019-02-06 13:28:30 -05:00
Clinton Wolfe
f760c54cba Move plugin activate() method into Activator class 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-02-06 12:18:18 -05:00
Clinton Wolfe
a349f91e52 Make UI not print emphasis by default 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-02-06 11:58:10 -05:00
Clinton Wolfe
d31a13efc6 Two more test files needed mock updates 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-02-01 14:24:26 -05:00
Clinton Wolfe
ea78e2f3c5 Skip test that had always been broken; how was this every passing? 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-02-01 14:24:26 -05:00
Clinton Wolfe
b057b0dc01 Correct formatting test 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-02-01 14:24:26 -05:00
Clinton Wolfe
4507af4c29 More things 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-02-01 14:24:26 -05:00
Clinton Wolfe
e054be7d0d Comment on doubt of truthiness 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-02-01 14:24:26 -05:00
Clinton Wolfe
6c20f312fd Add bang to validate_reporters in tests, too 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-02-01 14:24:26 -05:00
Clinton Wolfe
06399fbc0f Add clarifying comments to unit test for malformed json test 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-02-01 14:24:26 -05:00
Clinton Wolfe
2f16146bce Fix a unit test 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-02-01 14:24:26 -05:00
Clinton Wolfe
bb6a73d7d4 Create config object and units tests 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-02-01 14:24:26 -05:00
Clinton Wolfe
6ed046bb23 More things 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-02-01 14:24:26 -05:00
Clinton Wolfe
102505a937 Use new config file system to read config 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-02-01 14:24:26 -05:00
Clinton Wolfe
f1f5b27237 Create config object and units tests 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-02-01 14:23:55 -05:00
Clinton Wolfe
761944b3ce
Merge pull request #3770 from inspec/ja/fix-bad-name-check 
More meaningful error when including controls from a missing dependency
 2019-01-31 16:14:35 -05:00
Clinton Wolfe
a1af115e26 Add eval to unit tests; break up codegen test into individual elements 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-01-30 14:29:18 -05:00
Jerry Aldrich
94d8d11120 Respond to feedback 
Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-01-30 09:26:04 -08:00
James Stocks
5868eb52e7 Fix Inspec::Attribute.to_ruby and add unit test 
Signed-off-by: James Stocks <jstocks@chef.io>
 2019-01-30 17:15:22 +00:00
Jerry Aldrich
f0c207dad9 Fix undefined method error from inspec check 
This changes the error message from using a bad reference in
`include_controls` from:

```
NoMethodError: undefined method `profile' for nil:NilClass
```

To one detailing that the profile cannot be loaded since it isn't listed
as a dependency.

Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-01-29 22:36:27 -08:00
Clinton Wolfe
4d7cbc624c Test and fix case in which both :default and :value are provided 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-01-28 00:42:27 -05:00
Clinton Wolfe
6b5a951ccf Update value/default usage in test files 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-01-28 00:42:27 -05:00
Clinton Wolfe
ee76c5bb54
Merge pull request #3740 from inspec/ja/adopt-3419 
iis_app_pool:  Fixes error with 'should not exist'
 2019-01-25 11:56:10 -05:00
David Alexander
53e3533b8c Fixes unit test for to_s of iis_app_pool 
Signed-off-by: David Alexander <opensource@thelonelyghost.com>
 2019-01-22 15:08:25 -08:00
Jerry Aldrich
e80e7d872e Mock files used for virtualization resource tests 
Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-01-22 13:09:17 -08:00
Jerry Aldrich
f7e8a0c80c Add deprecation check for processes.list 
Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-01-22 13:09:17 -08:00
Jerry Aldrich
3b8da7957d Mock missing_file in NGINX resource tests 
Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-01-22 13:09:17 -08:00
Jerry Aldrich
3fe7091254 Wrap deprecated ServerSpec matchers in procs 
Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-01-22 13:09:17 -08:00
Jerry Aldrich
5ea640a2cd Remove nil check in chocolatey_package test 
Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-01-22 13:09:17 -08:00
Jerry Aldrich
c1547ee898 Remove deprecated methods from shadow test 
Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-01-22 13:09:17 -08:00
Jerry Aldrich
a0b76defb0 Evaluate runner.run in a proc 
This removes the following line from the test output:

```
Test Summary: 0 successful, 0 failures, 0 skipped
```

Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-01-22 13:09:17 -08:00
Jerry Aldrich
2f20370426 Change .must_equal nil to .must_be_nil 
`.must_equal nil` is deprecated

Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-01-22 13:09:17 -08:00
Jerry Aldrich
bc56b2275a Use mocked file instead of an empty file call 
Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-01-22 13:09:17 -08:00
Jerry Aldrich
b440e3f132 Change DLS to DSL 
Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-01-22 13:09:17 -08:00
Jerry Aldrich
c348a2032a Remove test that uses deprecated ppa resource 
Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-01-22 13:09:17 -08:00
Clinton Wolfe
2f42803a90
inspec check: Allow 'Proprietary' as a valid license term. 
Signed-off-by: James Stocks <jstocks@chef.io>
 2019-01-22 15:50:38 -05:00
Clinton Wolfe
ed460c7869
Fix SSL tests by allowing multiple cipher counts 
Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-01-22 15:00:49 -05:00
Jerry Aldrich
5c4be8de87 Fix SSL tests by allowing multiple cipher counts 
The value of `ciphers` is 681 on my localhost, but 993 on Travis.

This modifies the test to allow both values.

Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-01-21 15:02:58 -08:00
Jerry Aldrich
10f0393683 Fix AWS tests found during ChefStyle spike 
This fixes some style issues and fixes a duplicated test method name.

Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-01-21 13:05:46 -08:00
Clinton Wolfe
0a131e4945
Centralized Deprecation Facility #3690 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-01-17 15:08:16 -05:00