Commit graph

7053 commits

Author SHA1 Message Date
Clinton Wolfe
8cab0e862b Adopt the new UI style table, breaking most of the UI tests, which were already broken anyway
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-08-27 21:29:42 -04:00
Clinton Wolfe
68329aa8e5 Linting
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-08-27 21:28:52 -04:00
Clinton Wolfe
e581245391 Plausible implementation of detect_system_plugins
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-08-27 21:28:52 -04:00
Clinton Wolfe
00b2d9480a Rename constant for user gem installs for clarity
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-08-27 21:28:52 -04:00
Clinton Wolfe
149663ba55 Updated messaging for user gem plugins
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-08-27 21:28:52 -04:00
Clinton Wolfe
4211d3eb7c Failing functional tests for listing plugin gems
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-08-27 21:26:49 -04:00
Clinton Wolfe
e90482e955 Refactor train plugin decoration
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-08-27 21:26:49 -04:00
Chef Expeditor
ba64d06ef7
Bump version to 4.14.2 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-08-28 00:03:34 +00:00
Clinton Wolfe
f90a4c633d
Merge pull request #4419 from inspec/cw/check-enforce-version
inspec check: warn if inspec_version is not supported by current inspec
2019-08-27 20:03:19 -04:00
Chef Expeditor
d2dd311561
Bump version to 4.14.1 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-08-27 23:54:27 +00:00
Clinton Wolfe
5e6c425895
Merge pull request #4411 from inspec/cw/remove-vault-from-exclusion-list
Remove inspec-vault from the plugin exclusion list
2019-08-27 19:54:11 -04:00
Chef Expeditor
9b84b7b5c1
Bump version to 4.14.0 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-08-27 20:35:09 +00:00
Clinton Wolfe
a849221b27
Merge pull request #4398 from inspec/cw/rename-runner-api
Accept input keys via the Runner API
2019-08-27 16:34:54 -04:00
Jaymala Sinha
d143a406b9 Deprecate macOS 10.12 and add macOS 10.15 support
Signed-off-by: Jaymala Sinha <jsinha@chef.io>
2019-08-27 11:28:09 -04:00
Clinton Wolfe
12c7c51fea Warn not error
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-08-26 23:29:19 -04:00
Clinton Wolfe
c6f33b3526 Add functional test for inspec check with runtime constraint
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-08-26 23:19:18 -04:00
Clinton Wolfe
714dc26006 Add unit test and include runtime version check in metadata.valid
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-08-26 23:05:49 -04:00
Clinton Wolfe
424318defa Stringify expected test outcomes for inputs
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-08-26 14:56:39 -04:00
Clinton Wolfe
f59497d982 Don't open a new train connect, and make an issue for improving helper support
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-08-26 13:12:30 -04:00
Clinton Wolfe
fffb776982 Add newline
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-08-22 21:53:02 -04:00
Clinton Wolfe
d462ac3de5 Convert runner api script layout ot heredoc
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-08-22 21:51:50 -04:00
Clinton Wolfe
ada6aad169 Move input name stringification into the method
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-08-22 21:40:01 -04:00
Clinton Wolfe
019cf6e590 Remove inspec-vault from the plugin exclusion list
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-08-22 15:25:52 -04:00
Ryan Davis
1dd1efa03f test change for bad resource/backend combo.
I think this is probably in contention with my other PR on resource
initialization. We definitely need to change that, so this might fall
to the side. Or maybe just the test needs to be redone. We'll discuss
and see.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-08-20 13:25:21 -07:00
Ryan Davis
bd3ec9aec7 Code cleanup.
While I was in here... nothing big.

It does seem like we have too many hard-coded symbols in our code in
general as well as too many symbol styles (underscore vs dash).

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-08-20 13:25:21 -07:00
Ryan Davis
7273a7380f Fixed file resource raising UndefinedMethod on source_path
This is a first pass at fixing the failure found by @scottvidmar where
file resource was raising undefined_method on nil. The problem was
that the initialize method for file was not being called at all
because Resource#initialize was returning early without reporting
anything.

This fix causes a failure in test/functional/inspec_exec_test.rb where
it is testing a similar scenario but for some reason the unsupported
resources get reported. We need to figure that part out, but in the
meantime this will at least report an error at the root cause rather
than down the road.

Fixes #4208

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-08-20 13:25:21 -07:00
Chef Expeditor
823c858073
Update CHANGELOG.md with details from pull request #4389
Obvious fix; these changes are the result of automation not creative thinking.
2019-08-20 19:13:44 +00:00
Clinton Wolfe
ce4d5cd2e8
Ignore .swp files (#4389)
Ignore .swp files
2019-08-20 15:13:31 -04:00
Clinton Wolfe
1f49ae4046 Skip runner API tests on windows
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-08-19 18:15:50 -04:00
Clinton Wolfe
2ef151dd56 Hrm, linting for upstream?
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-08-19 13:52:28 -04:00
Clinton Wolfe
cc4aa16212 Add test framework to run Runner API input tests
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-08-19 13:51:51 -04:00
Clinton Wolfe
93521dea0c Accept either input or attribute in the runner API
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-08-19 13:39:31 -04:00
Chef Expeditor
59301c54ad
Bump version to 4.13.2 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-08-19 16:56:07 +00:00
Clinton Wolfe
3f54f7ac46
Ensure that resources are always initialized in all cases (#4366)
Ensure that resources are always initialized in all cases
2019-08-19 12:55:52 -04:00
Chef Expeditor
88d23697f7
Bump version to 4.13.1 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-08-19 16:52:35 +00:00
Clinton Wolfe
e7ccdc03c9
Refactor lib/source_readers/inspec.rb (#4376)
Refactor lib/source_readers/inspec.rb
2019-08-19 12:52:20 -04:00
Chef Expeditor
7581ab37c7
Bump version to 4.13.0 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-08-19 16:38:32 +00:00
Clinton Wolfe
8dc350bc6c
Add a Postfix-specific configuration testing resource (#4378)
Add a Postfix-specific configuration testing resource
2019-08-19 12:38:17 -04:00
Ryan Davis
43e07e8f2d Finished refactoring!
Now that the code is easier to read and actually focuses on what it
does in a readable way, it is easier to reason about. In this case, we
have blocks being passed around in order to evaluate a bunch of
paths (read: strings) to determine if they're correct. Why do multiple
`start_with?` and `end_with?` calls? It doesn't cleanly describe what
it is trying to do. Instead, we can use regexps and it'll work just
fine, so lets do that. This simplifies things even further.

46.5: flog total

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-08-18 20:36:19 -07:00
Ryan Davis
3f0e9e9ffa Fix chefstyle.
This is an area where I really disagree with chefstyle. 🤷

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-08-18 20:36:19 -07:00
Ryan Davis
f8b8f968aa lib/source_readers/inspec.rb refactor 8/8: reformat
58.9: flog total

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-08-18 20:36:19 -07:00
Ryan Davis
ac6164e56d lib/source_readers/inspec.rb refactor 7/8: combine load_all and find_all.
58.9: flog total

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-08-18 20:36:19 -07:00
Ryan Davis
213a4489ed lib/source_readers/inspec.rb refactor 6/8: use if/compact instead of delete_if.
59.0: flog total

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-08-18 20:36:19 -07:00
Ryan Davis
6399116e5f lib/source_readers/inspec.rb refactor 5/8: extract to local var
60.1: flog total

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-08-18 20:36:19 -07:00
Ryan Davis
5d19283199 lib/source_readers/inspec.rb refactor 4/8: use to_h
59.8: flog total

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-08-18 20:36:19 -07:00
Ryan Davis
70d8ecf1e8 lib/source_readers/inspec.rb refactor 3/8: pull up file reading.
59.8: flog total

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-08-18 20:36:19 -07:00
Ryan Davis
4f0a5d6ba1 lib/source_readers/inspec.rb refactor 2/8: normalize variable names.
76.1: flog total

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-08-18 20:36:19 -07:00
Ryan Davis
6735d03a09 lib/source_readers/inspec.rb refactor 1/8: pull up file selection.
71.3: original flog total
73.0: flog total (this version)

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-08-18 20:36:19 -07:00
Ryan Davis
f4bae13c68 Fixes for 2 failed tests.
Rescue NotImplementedError and call failed_resource only if we haven't
already failed the support_check call.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-08-18 19:30:30 -07:00
Ryan Davis
cd5f58f8eb Do not call return inside of an initialize method.
It does NOT do what you think it does. It does NOT prevent an object
from coming back. All it does is have an uninitialized (or partially
initialized) object come back, which isn't helpful.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-08-18 17:28:56 -07:00