Commit graph

6655 commits

Author SHA1 Message Date
Ryan Davis
45ef0d84d0 Remove minitest/hell in favor of stable (but sloooow) tests.
Added InspecTest (which we should use across the board) and
ParallelTest (which we should use selectively and with metrics) to
helper.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-06-03 14:12:06 -07:00
Ryan Davis
d2edd3ce68 Move minitest/hell to test/helper.
Probably going to remove this next and focus on opting-in to parallelization.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-06-03 14:12:06 -07:00
Ryan Davis
bba9434600 Change the way we load rspec so it never exposes globally.
Essentially, the way rspec does stuff is pretty rude. By injecting
singleton methods into main (instead of Kernel, where all top-level
methods go) and "cleaning" them up using undef_method instead of
remove_method makes it pretty hard for anything else in the testing
arena to operate. I've already fixed the case where rspec would
overwrite minitest's `describe` in a way that made it very hard to put
back, but my fix didn't prevent rspec from doing it _AGAIN_.

This fixes the case where after some rspec interactions, mocha's
`any_instance` method would just disappear. I never did figure out
where or why this was happening, but I did address the how.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-06-03 14:12:06 -07:00
Chef Expeditor
5a7d548c14
Bump version to 4.4.66 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-06-03 20:39:48 +00:00
Ryan Davis
a2f2cd5087
Merge pull request #4109 from inspec/zenspider/helper_cleanup
Minor cleanup on test/helper.rb
2019-06-03 13:39:31 -07:00
kekaichinose
eb71ff8842
Update inspec_team-working_agreement.md 2019-06-03 12:23:07 -07:00
Clinton Wolfe
82cafccebb Remove enclosing HTML and re-render
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-06-03 11:56:34 -04:00
kekaichinose
dbba496923
Rename inspec_team-working_agreement to inspec_team-working_agreement.md 2019-06-03 08:56:07 -07:00
Clinton Wolfe
3cb3ca9f94 Remove two misrendering hyperlinks
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-06-03 11:35:48 -04:00
Artem Sidorenko
eaec745edf Using dist constants for license check
Signed-off-by: Artem Sidorenko <artem.sidorenko@t-systems.com>
2019-06-03 15:29:53 +02:00
Artem Sidorenko
9d03fd7882 Allow to switch off the license check
similar to the approach in chef/chef: https://github.com/chef/chef/pull/8354/files#diff-847fc1c7c0af04a65c570c6f4c3381e9R25

Signed-off-by: Artem Sidorenko <artem.sidorenko@t-systems.com>
2019-06-03 15:29:53 +02:00
Miah Johnson
0aea548dd8 Update tests to use json-schema, and test something.
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-06-01 23:17:53 -07:00
Miah Johnson
23245df6d1 Replace jsonschema with json-schema.
Also just use json, its packaged with ruby already.

Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-06-01 22:04:36 -07:00
kekaichinose
d0f4427576
Create InSpec Team Working Agreement
This is the written basis of how we "conduct business" within the InSpec team. As our product and project are open source, we should look to publish this for other in the community to see so that they not only know what we are about and how we operate, but so that as they become more involved in the project, they have a shared understanding of how to contribute.
2019-06-01 11:42:32 -07:00
Chef Expeditor
c0643c33ee
Bump version to 4.4.65 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-05-31 20:46:22 +00:00
Ryan Davis
a05f54d9e2
Merge pull request #4152 from inspec/mj/leadingnl
Remove all leading newlines.
2019-05-31 13:46:05 -07:00
Miah Johnson
9a580407e6 brittle tests
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-05-31 11:43:44 -07:00
Miah Johnson
a5c8021227 don't remove this leading newline =)
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-05-31 11:43:44 -07:00
Miah Johnson
2a1b1d8e88 Remove all leading newlines.
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-05-31 11:43:44 -07:00
Chef Expeditor
97df4c33fd
Bump version to 4.4.64 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-05-31 18:29:50 +00:00
Miah Johnson
b27f52b8d7
Merge pull request #4163 from inspec/cw/fix-4145-mention-inspec-bin
Mention inspec-bin gem in installation instructions
2019-05-31 11:29:37 -07:00
Chef Expeditor
e4567052e3
Bump version to 4.4.63 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-05-31 18:29:14 +00:00
Miah Johnson
03d607167b
Merge pull request #4169 from inspec/snappj/replace-jenkins-with-buildkite
Replace Jenkins omnibus build/test pipeline with Buildkite
2019-05-31 11:28:57 -07:00
Jeremiah Snapp
a0add503c4 Replace Jenkins omnibus build/test pipeline with Buildkite
Signed-off-by: Jeremiah Snapp <jeremiah@chef.io>
2019-05-31 14:21:08 -04:00
Chef Expeditor
ecbb8c0d17
Bump version to 4.4.62 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-05-30 19:07:17 +00:00
Ryan Davis
894c7bc9b7
Merge pull request #4165 from inspec/zenspider/green2
This should fix our licensing failures
2019-05-30 12:07:01 -07:00
Ryan Davis
d10591dc19 Some of our license tests fail if we have CHEF_LICENSE set, so wrap them up.
This still doesn't fix our parallelization issues. I think

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-05-30 11:17:19 -07:00
Miah Johnson
6873bf1fb2
Update README.md
Co-Authored-By: mjingle <mjingle@users.noreply.github.com>
2019-05-30 10:57:58 -07:00
Chef Expeditor
ece3c7b5a3
Update CHANGELOG.md with details from pull request #4164
Obvious fix; these changes are the result of automation not creative thinking.
2019-05-30 17:57:28 +00:00
Miah Johnson
965ef8ae76
Merge pull request #4164 from inspec/cw/fix-4021-sunset-warnings
Update sunset messages on 2 resources
2019-05-30 10:57:17 -07:00
Clinton Wolfe
06de2dc941 Update azure gr sunset notice
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-05-30 11:40:05 -04:00
Clinton Wolfe
c4d7a52b94 Update apache resource sunset notice
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-05-30 11:39:20 -04:00
Clinton Wolfe
d1a21f2aa2 Update gem install instructions on website downloads page
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-05-30 10:47:35 -04:00
Clinton Wolfe
639c3a7489 Clarify gem install instructions regarding inspec-bin in README
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-05-30 10:43:18 -04:00
Chef Expeditor
ed7861fcf6
Bump version to 4.4.61 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-05-30 01:33:24 +00:00
Ryan Davis
4790e288a0
Merge pull request #4142 from inspec/zenspider/clean_unnecessary_requires
Clean unnecessary requires
2019-05-29 18:33:06 -07:00
Chef Expeditor
66e95a4847
Bump version to 4.4.60 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-05-30 01:08:31 +00:00
Miah Johnson
6898319086
Merge pull request #4159 from inspec/zenspider/windows_fixes
Windows fixes
2019-05-29 18:08:18 -07:00
Ryan Davis
dfadc393b9 Even more removals and moves!
Turns out we don't even use CMD in any units... so why make it?

Lots of other stuff got ripped out. Tests basically shouldn't need to
require anything but 1 implementation file and a test framework.
Anything more than that is a smell.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-05-29 17:58:02 -07:00
Ryan Davis
be125598c8 Additional whitespace cleanup.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-05-29 17:58:02 -07:00
Ryan Davis
ec248217a7 Extra fix for utils move
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-05-29 17:58:02 -07:00
Ryan Davis
a8bcba780f Got the rest of the functionals to pass.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-05-29 17:58:02 -07:00
Ryan Davis
82c9aa6ed6 Got the rest of the tests to pass.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-05-29 17:58:02 -07:00
Ryan Davis
9ec91484fc Get all non-resource tests fixed again.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-05-29 17:58:02 -07:00
Ryan Davis
de8258c9f7 Get yaml_test.rb working
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-05-29 17:58:02 -07:00
Ryan Davis
761f48e63c Get user_test.rb working
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-05-29 17:58:02 -07:00
Ryan Davis
69f2927983 Stripping test/helper.rb of all the big inspec requires.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-05-29 17:58:02 -07:00
Ryan Davis
61585de0f0 Moved out all of the requires for inspec/resources/* from inspec/resource.rb
All requires moved to inspec/resources.rb

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-05-29 17:58:02 -07:00
Ryan Davis
adaf2bc364 Removed aws resource requiring from test/helper and inspec/resource.
This speeds up parallel unit test runs from a very consistent 2:49 to
a very consistent 1:53, or a 33% reduction.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-05-29 17:58:02 -07:00
Chef Expeditor
15c770183f
Bump version to 4.4.59 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-05-29 23:52:19 +00:00