Commit graph

4938 commits

Author SHA1 Message Date
James 'zofrex' Sanderson
c3b0310315 Fix broken regex
Signed-off-by: James 'zofrex' Sanderson <zofrex@gmail.com>
2021-10-13 08:57:51 +01:00
James 'zofrex' Sanderson
acf5a2c955 Fix Rubocop issues
Signed-off-by: James 'zofrex' Sanderson <zofrex@gmail.com>
2021-10-13 08:57:51 +01:00
James 'zofrex' Sanderson
41ea0da4a9 Fix FreeBSD service enabled check substring edge-case
* Now services named a suffix of another service don't have false positives for being enabled
* Use new 'enabled' service command on FreeBSD 10+

Signed-off-by: James 'zofrex' Sanderson <zofrex@gmail.com>
2021-10-13 08:57:51 +01:00
Chef Expeditor
648afbb6fa Bump version to 4.47.7 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-10-13 01:15:56 +00:00
Chef Expeditor
134ddfcbb5 Bump version to 4.47.6 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-10-13 01:13:30 +00:00
Chef Expeditor
8dc23ce7e1 Bump version to 4.47.5 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-10-13 01:11:03 +00:00
Chef Expeditor
d37b123bf6 Bump version to 4.47.4 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-10-13 01:07:19 +00:00
Clinton Wolfe
0bfb0bc648
Merge pull request #5667 from inspec/nm/group-user-sensitive
Group & User Resources - Resolve name case-sensitivity issue for windows
2021-10-12 21:05:57 -04:00
Nikita Mathur
09550ed7f3 User groups made case insensitive for user resource for include matcher
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-10-07 13:32:36 +05:30
Chef Expeditor
9a78b1dbe0 Bump version to 4.47.3 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-10-06 03:08:29 +00:00
Chef Expeditor
c86031c237 Bump version to 4.47.2 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-10-06 02:54:48 +00:00
Chef Expeditor
be800bd741 Bump version to 4.47.1 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-10-06 02:39:57 +00:00
Chef Expeditor
62a1e24a2c Bump version to 4.47.0 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-10-06 02:14:02 +00:00
Chef Expeditor
1bf5275aad Bump version to 4.46.15 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-10-06 01:59:23 +00:00
Clinton Wolfe
a79be0ca96
Merge pull request #5683 from inspec/nm/cassandra-resource
Add support for Cassandra DB
2021-10-05 21:55:24 -04:00
Chef Expeditor
4f4cfeb2fc Bump version to 4.46.14 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-10-06 00:28:33 +00:00
Nikita Mathur
62b0d211fa Windows user fetched in user resource without case sensitivity
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-10-05 15:36:35 +05:30
Nikita Mathur
eb7e7305f4 Members and members array made case insensitive for group resources
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-10-05 15:36:35 +05:30
Nikita Mathur
964fdacbee Resolve case sensitivity issues with group name in group resource for windows platform
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-10-05 15:36:35 +05:30
Vasu1105
9b66e2830c Merge branch 'add-http-for-windows-2' of github.com:mbaitelman/inspec into add-http-for-windows 2021-10-01 16:03:55 +05:30
Nikita Mathur
8546595f30 Review changes and build fix
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-10-01 14:43:37 +05:30
Nikita Mathur
b4ca1914c4 Add support for Cassandra DB resources
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-09-30 16:09:08 +05:30
Nikita Mathur
ced270725d Change after code review on cookstyle check
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-09-29 13:23:35 +05:30
Nikita Mathur
1de38f3b13 Build fix for archive and vendor tests due to cookstyle offenses
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-09-29 13:23:35 +05:30
Nikita Mathur
ab1d423a35 Use only inspec cops of cookstyle gem
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-09-29 13:23:35 +05:30
Nikita Mathur
bedde88849 Integrate inspec check with cookstyle
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-09-29 13:23:35 +05:30
Chef Expeditor
e5b7bcf4b9 Bump version to 4.46.13 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-09-28 12:19:40 +00:00
Clinton Wolfe
baf653282a
Merge pull request #5671 from inspec/vasundhara/fix-opa-resources
Fix opa_cli and opa_api resource unable to verify empty result {}
2021-09-28 08:18:09 -04:00
Chef Expeditor
37a7889407 Bump version to 4.46.12 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-09-28 12:15:35 +00:00
Vasu1105
04c1af6a24 Fixed lint
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-09-28 12:13:18 +05:30
Vasu1105
3e9223d603 Fixed lint and failing test
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-09-28 11:57:21 +05:30
Vasu1105
761fa4338e Fix - controls option was not working for depedent profile
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-09-28 11:19:04 +05:30
Chef Expeditor
ac07060c12 Bump version to 4.46.11 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-09-28 04:40:30 +00:00
Chef Expeditor
7493e26e47 Bump version to 4.46.10 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-09-28 04:37:02 +00:00
Clinton Wolfe
993c9d9225
Merge pull request #5657 from inspec/nm/tags-dependent
Fix --tags filter for dependent profiles
2021-09-28 00:35:32 -04:00
Chef Expeditor
2e23f13d11 Bump version to 4.46.9 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-09-28 04:32:22 +00:00
Clinton Wolfe
86e7da02a1
Merge pull request #5664 from inspec/nm/postgres-socket
Add option in `postgres_session` resource to establish socket connection
2021-09-28 00:30:49 -04:00
Chef Expeditor
b6076e0649 Bump version to 4.46.8 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-09-28 04:27:18 +00:00
Clinton Wolfe
f65b8375d8
Merge pull request #5665 from inspec/vasundhara/csv-resource-without-headers-support
Add csv without headers support in csv resource
2021-09-28 00:25:43 -04:00
Chef Expeditor
28ad8ed4d0 Bump version to 4.46.7 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-09-22 16:04:53 +00:00
Chef Expeditor
079de2a49a Bump version to 4.46.6 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-09-22 14:34:24 +00:00
Chef Expeditor
5b7f023368 Bump version to 4.46.5 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-09-22 14:16:35 +00:00
Vasu1105
63e7eb5395 Fix opa_api and opa_cli resource to handle empty result
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-09-22 16:23:12 +05:30
sspans-sbp
b8677ac51f Add rocky and almalinux to service resource
Signed-off-by: Sten Spans <sspans@schubergphilis.com>
2021-09-22 12:18:08 +02:00
Vasu1105
cc0d86a185 Add csv without headers support in csv resource
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-09-16 15:56:07 +05:30
Nikita Mathur
bdde8ffc3b Add optional parameter to establish socket based connection with postgres
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-09-16 13:06:07 +05:30
Nikita Mathur
a43f646c14 Code review changes - Improvisation on setting conf value of control eval context from dsl
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-09-14 14:03:38 +05:30
Chef Expeditor
f09d49da66 Bump version to 4.46.4 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-09-13 23:14:10 +00:00
Chef Expeditor
c6150f24cb Bump version to 4.46.3 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-09-13 18:59:33 +00:00
Chef Expeditor
a350803137 Bump version to 4.46.2 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-09-13 18:56:45 +00:00
Clinton Wolfe
19c1e39155
Merge pull request #5645 from inspec/vasundhara/update-code-to-remove-2.4
Update code to remove ruby 2.4 support
2021-09-13 14:54:54 -04:00
Chef Expeditor
d84f4e746e Bump version to 4.46.1 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-09-13 18:51:49 +00:00
Chef Expeditor
f49a2bcfd9 Bump version to 4.46.0 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-09-13 18:41:11 +00:00
Clinton Wolfe
49cd6883b9
Merge pull request #5589 from collinmcneese/cmcneese/chrony_conf
adds chrony_conf InSpec resource
2021-09-13 14:39:34 -04:00
Chef Expeditor
1e61237657 Bump version to 4.45.0 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-09-13 18:36:28 +00:00
Clinton Wolfe
ceaef891bb
Merge branch 'main' into nm/oracle-conf 2021-09-13 14:33:51 -04:00
Chef Expeditor
99a6d185a0 Bump version to 4.44.0 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-09-13 18:29:38 +00:00
Clinton Wolfe
dfbba4eeab
Merge pull request #5614 from inspec/vasundhara/add_ibmdb2_support
Add ibmdb2_conf and ibmdb2_session resource
2021-09-13 14:27:57 -04:00
Chef Expeditor
7d30fa8f24 Bump version to 4.43.0 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-09-13 18:24:40 +00:00
Clinton Wolfe
3727ddaef5
Merge pull request #5561 from inspec/cw/add-sybase
Add support for Sybase databases
2021-09-13 14:23:03 -04:00
Chef Expeditor
baa7b59916 Bump version to 4.42.0 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-09-13 18:18:59 +00:00
Clinton Wolfe
55e30270f9
Merge pull request #5574 from inspec/nm/mssql-conf
Add support for Mssql Conf resource
2021-09-13 14:17:19 -04:00
Chef Expeditor
2472280feb Bump version to 4.41.23 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-09-13 18:12:33 +00:00
Clinton Wolfe
bb1763d5e6
Merge pull request #5617 from inspec/vasundhara/inspec_check_docs_update
Update inspec check docs for --format option
2021-09-13 14:10:41 -04:00
Chef Expeditor
910a674ad6 Bump version to 4.41.22 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-09-10 17:45:38 +00:00
Chef Expeditor
92d4e031dc Bump version to 4.41.21 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-09-10 17:39:01 +00:00
Nikita Mathur
1d8b19fa98 Fix --tags filter for dependent profiles
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-09-07 16:49:32 +05:30
Vasu1105
5b5a1a1438 Removed comments which are not applicable now
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-09-01 18:07:56 +05:30
Vasu1105
10d96ece3f Add windows platform support for ibmdb2_conf and ibmdb2_session resource
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-09-01 18:06:16 +05:30
Vasu1105
12e3ee9aca Fix the command to query on the database
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-09-01 18:06:16 +05:30
Vasu1105
39432f29e5 IBM Db2 connection failure fix for error Reason Code 3
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-09-01 18:06:16 +05:30
Vasu1105
65852c2970 bad code : self require fix
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-09-01 18:06:16 +05:30
Vasu1105
763f221810 Fix lint errors
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-09-01 18:06:16 +05:30
Vasu1105
30ea9cfe57 Add ibmdb2_conf and ibmdb2_session resource
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-09-01 18:06:16 +05:30
Chef Expeditor
489318042c Bump version to 4.41.20 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-09-01 03:42:24 +00:00
Clinton Wolfe
28956c0cf5
Merge pull request #5643 from inspec/nm/tags-fix
Fix tags processing issue in profiles
2021-08-31 23:40:56 -04:00
Chef Expeditor
5c4d534066 Bump version to 4.41.19 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-09-01 03:29:23 +00:00
Clinton Wolfe
681e2eacfa
Merge pull request #5638 from inspec/nm/fetcher-default-branch-fix
Fix url fetcher when default git profile branch is not master
2021-08-31 23:27:56 -04:00
Chef Expeditor
b0debb83dd Bump version to 4.41.18 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-09-01 02:17:33 +00:00
Mendy Baitelman
7abebdf80b Merge remote-tracking branch 'upstream/main' into add-http-for-windows-2 2021-08-31 17:08:28 -07:00
Clinton Wolfe
d564ab21c6
Merge pull request #5640 from inspec/spelling_fixes
Fix typos identified by cspell
2021-08-31 16:29:06 -04:00
Nikita Mathur
c85f49d0d8 Change to filter tags on both key and value basis of hashmap style tags
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-08-31 18:14:58 +05:30
Nikita Mathur
ddcb096666 Fix control tags fetching logic which was breaking profiles with tags used
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-08-31 17:17:27 +05:30
Vasu1105
81b28c2c51 Change master to main branch for inspec-gcp and inspec-azure repo
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-08-31 14:04:38 +05:30
Nikita Mathur
ca1991451f Issue fix related to bitbucket default branch fetching in url fetcher
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-08-31 13:12:22 +05:30
Tim Smith
403647c3e4 Fix typos identified by cspell
Just a pile of misc typos

Signed-off-by: Tim Smith <tsmith@chef.io>
2021-08-30 16:49:46 -07:00
Chef Expeditor
52d9fe4321 Bump version to 4.41.17 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-08-30 21:26:04 +00:00
Clinton Wolfe
2db20dd576
Merge pull request #5625 from tecracer-theinen/fix/no-error-if-plugin-installed
Proposed implementation for installation warnings
2021-08-30 17:24:32 -04:00
Chef Expeditor
59c0a9a0e1 Bump version to 4.41.16 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-08-30 21:21:59 +00:00
Chef Expeditor
3c2d0cd48b Bump version to 4.41.15 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-08-30 21:19:18 +00:00
Clinton Wolfe
83fcc7fec4
Merge pull request #5629 from inspec/vasundhara/fix_for_security_policy_resource
Fix for security_policy resource does not return array for local groups
2021-08-30 17:17:16 -04:00
Chef Expeditor
635a7cbbc2 Bump version to 4.41.14 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-08-30 21:16:41 +00:00
Chef Expeditor
51c4615815 Bump version to 4.41.13 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-08-30 21:13:29 +00:00
Clinton Wolfe
04dabfee23
Merge pull request #5636 from inspec/vasundhara/remove-wmic-calls-security-identifier
Replace use of wmic from security_identifier resource as it will be deprecated soon
2021-08-30 17:11:58 -04:00
Chef Expeditor
2b2faa7c41 Bump version to 4.41.12 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-08-30 20:46:46 +00:00
Nikita Mathur
44cd84312f Fix url fetcher when default git profile branch is not master
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-08-30 19:10:12 +05:30
Vasu1105
99a170d7e5 Updated inspec-aws git url to replace branch to master to main
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-08-30 18:08:06 +05:30
Vasu1105
2100a66bef Removed use of wmic from security_identifier resource as it will be deprecated soon
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-08-30 12:47:03 +05:30
Vasu1105
8487da327f Fix for security_policy resource does not return array for local groups
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-08-27 18:34:25 +05:30
Chef Expeditor
601238ca81 Bump version to 4.41.11 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-08-27 04:28:05 +00:00
Chef Expeditor
16b23fd2c9 Bump version to 4.41.10 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-08-24 02:50:59 +00:00
Clinton Wolfe
77297cfef0
Merge pull request #5578 from elsnepal/aliyun3
Add aliyun3 support to service resource
2021-08-23 22:49:28 -04:00
Chef Expeditor
50698e85a1 Bump version to 4.41.9 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-08-24 02:41:20 +00:00
Clinton Wolfe
026788e294
Merge pull request #5623 from inspec/nm/apache-conf-merge-fix
Fix merging of included conf and main conf params in apache conf
2021-08-23 22:39:50 -04:00
Thomas Heinen
096e5cd655
Fix tests
Signed-off-by: Thomas Heinen <theinen@tecracer.de>
2021-08-23 15:01:17 +02:00
Chef Expeditor
b24ac70dfc Bump version to 4.41.8 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-08-23 12:12:53 +00:00
Thomas Heinen
72204bd0fc
Proposed implementation for installation warnings 2021-08-23 14:12:33 +02:00
Nikita Mathur
e6d4cedbd2 Fix merging of included conf and main conf params in apache conf resource
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-08-20 14:26:11 +05:30
Vasu1105
d1bc86a214 Fix postgres_session error Unable to connect to database
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-08-19 14:15:39 +05:30
Vasu1105
2f44f7bd05 Update inspec check docs for --format option
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-08-19 14:12:27 +05:30
Chef Expeditor
d85bdbc4e1 Bump version to 4.41.7 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-08-18 01:07:52 +00:00
Clinton Wolfe
6ae461c208
Merge pull request #5609 from inspec/nm/chef-license
Fix `--chef-license=accept` option to only show license accepted message
2021-08-17 21:05:59 -04:00
Chef Expeditor
c4eac8ce5a Bump version to 4.41.6 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-08-18 01:05:06 +00:00
Clinton Wolfe
13321abd4a
Merge pull request #5600 from inspec/nm/inspec-insecure
Fix `--insecure` not working with profile
2021-08-17 21:03:17 -04:00
Chef Expeditor
53f5890c62 Bump version to 4.41.5 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-08-18 01:02:14 +00:00
Clinton Wolfe
dcf49ad510
Merge pull request #5601 from inspec/nm/bug-apache-conf
Fix apache_conf issue when Server Root is not present in configuration
2021-08-17 21:00:38 -04:00
Chef Expeditor
1bb29048a2 Bump version to 4.41.4 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-08-18 00:52:57 +00:00
Clinton Wolfe
d191964e23
Merge pull request #5598 from inspec/nm/filtertable-range
Fix range based filtering in filter tables
2021-08-17 20:51:05 -04:00
Chef Expeditor
7d585646d0 Bump version to 4.41.3 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-08-18 00:50:15 +00:00
Chef Expeditor
185ae692fb Bump version to 4.41.2 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-08-13 23:57:34 +00:00
Chef Expeditor
d17025d28f Bump version to 4.41.1 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-08-11 17:53:54 +00:00
Nikita Mathur
856ef4e31b Chef license accept fix to show license accepted message and quit when no other option/command passed
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-07-28 12:47:50 +05:30
Chef Expeditor
1e380c1f43 Bump version to 4.41.0 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-07-28 03:16:20 +00:00
Clinton Wolfe
5bbe34acb0
Merge pull request #5596 from inspec/nm/control-tags
Filter active controls in profile by tags
2021-07-27 23:14:41 -04:00
Chef Expeditor
b8c75ea967 Bump version to 4.40.0 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-07-28 02:56:24 +00:00
Clinton Wolfe
48c5e22fc0
Merge pull request #5572 from inspec/vasundhara/add_mongodb_session
Add mongodb_session resource and docs.
2021-07-27 22:54:48 -04:00
Chef Expeditor
2d5a53cbb5 Bump version to 4.39.0 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-07-28 02:49:00 +00:00
Clinton Wolfe
e1f63cc7a5
Merge pull request #5592 from inspec/vasundhara/add_OPA_support
Add support for OPA: add resource opa_cli and opa_api
2021-07-27 22:47:23 -04:00
Nikita Mathur
aeed833f2f Build fix
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-07-26 12:51:36 +05:30
Nikita Mathur
625fa74442 Build fix
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-07-22 17:31:16 +05:30
Chef Expeditor
c22f609443 Bump version to 4.38.9 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-07-22 05:09:17 +00:00
Chef Expeditor
88d5614aaa Bump version to 4.38.8 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-07-20 17:15:14 +00:00
Vasu1105
6ed14dc7de Fix lint
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-07-19 15:01:31 +05:30
Vasu1105
f0ca02a1c5 Adds unit test for opa_api and opa_cli resource
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-07-19 14:44:47 +05:30
Nikita Mathur
bc429a27f1 Fixed issue for apache conf when serverRoot is not configured
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-07-19 13:46:58 +05:30
Nikita Mathur
b4ad811f05 Fix for null insecure option
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-07-15 17:43:12 +05:30
Nikita Mathur
69b15b6e64 Fix range usage in filter table
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-07-14 14:27:03 +05:30
Nikita Mathur
a16e9fcf45 Tag based filtering for controls - initial commit
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-07-09 19:03:15 +05:30
Nikita Mathur
89b0f95c75 Using os_env resource to read ORACLE_HOME env in oracle listener conf resource
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-07-09 16:31:45 +05:30
Vasu1105
b2e680f17b Fixed review comments. And added docs for opa_cli and opa_api resource.
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-07-09 15:50:35 +05:30
Chef Expeditor
ec76259eb1 Bump version to 4.38.7 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-07-08 23:49:34 +00:00
Clinton Wolfe
69213b555b
Merge pull request #5576 from inspec/vasundhara/postgresql_resource_update
Update postgresql resources to normalize it for platform supports
2021-07-08 18:48:04 -05:00
Chef Expeditor
e1fd1b12ea Bump version to 4.38.6 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-07-08 23:41:02 +00:00
Clinton Wolfe
f22c342704
Merge pull request #5584 from inspec/nm/mssql-port-fix
Remove default port for mssql_session, allowing named connections
2021-07-08 18:39:33 -05:00
Chef Expeditor
05cbca239b Bump version to 4.38.5 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-07-08 23:36:40 +00:00
Vasu1105
9b691b32ac Add support for OPA: add resource opa_cli and opa_api
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-07-08 18:14:22 +05:30
Collin McNeese
4e779ddf6b
fixes typo in resource description.
Signed-off-by: Collin McNeese <cmcneese@chef.io>
2021-07-07 11:38:21 -05:00
Collin McNeese
06eb9b9a84
adds chrony_conf InSpec resource
Signed-off-by: Collin McNeese <cmcneese@chef.io>
2021-07-06 10:46:47 -05:00
Nikita Mathur
f3633aa096 File existence check and other null checks
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-07-02 15:15:19 +05:30
Nikita Mathur
39dbb6819e Fix for expiry time parsing when in string format
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-07-02 00:53:05 +05:30
Vasu1105
471b7b4550 Fixed command for windows and replaced warn with Inspec::Log.warn
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-07-01 13:37:55 +05:30
Nikita Mathur
46328b4812 Removed default port option to enable using named instances with no port option
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-06-30 17:19:19 +05:30
Vasu1105
180ebf0590 Fixed review comments: Added attr_accessor for required parameters and removed pass to accept nil
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-06-30 13:54:17 +05:30
Nikita Mathur
cb31cefaa2 Review changes - Fetching listener file using env variable
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-06-29 14:43:56 +05:30
Nikita Mathur
6ea2023922 Review changes - File renames and copy right line removed from resources for oracle conf resources
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-06-29 12:25:48 +05:30
Nikita Mathur
534f601f52 Some optimisations in function calls to reduce redundancy
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-06-29 12:25:48 +05:30
Nikita Mathur
f921c25efc Oracle_db_conf and oracle_listener_conf changes, test cases and doc added
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-06-29 12:25:48 +05:30
Nikita Mathur
948a5c7efd Review changes - Removed copyright line from resource
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-06-29 12:05:25 +05:30
Chef Expeditor
01baf2f7c0 Bump version to 4.38.4 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-06-29 04:48:32 +00:00
Clinton Wolfe
61c83d28b3
Merge pull request #5567 from inspec/nm/oracle-session-exception
Oracle Session Exception Handling
2021-06-29 00:47:23 -04:00
Ashish Nepal
80b00794d5 add aliyun3 support 2021-06-26 20:30:57 +01:00
Vasu1105
964a5142f7 Revert changes for password authentication removal
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-06-25 16:53:49 +05:30
Vasu1105
74cbcc1c5a Removed password authentication as it breaks for windows and it needs to be handle by user using postgress configuration files
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-06-25 13:29:23 +05:30
Vasu1105
3b9a5c8956 Update postgresql resources to normalize it for platform supports
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-06-25 13:01:39 +05:30
Nikita Mathur
781ead9257 Added support for mssql conf resource
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-06-24 16:56:11 +05:30
Vasu1105
487fb5586c Some minor docs changes
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-06-24 14:44:29 +05:30
Vasu1105
7f7cbf0ddb Add unit test for mongodb_session resource
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-06-24 12:03:53 +05:30
Chef Expeditor
f88cde6425 Bump version to 4.38.3 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-06-23 21:55:54 +00:00
Vasu1105
a008514d57 Add mongodb_session resource and docs.
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-06-23 17:30:08 +05:30
Chef Expeditor
ad60fbe09e Bump version to 4.38.2 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-06-22 20:06:11 +00:00
Nikita Mathur
88641c3fac Fix in oracle command which weren't working in windows powershell
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-06-21 12:09:54 +05:30
Nikita Mathur
d08b8bb8f3 exception handling when exception in case of no error
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-06-18 14:14:28 +05:30
Chef Expeditor
077ada008e Bump version to 4.38.1 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-06-17 02:28:30 +00:00
Chef Expeditor
597b3e375a Bump version to 4.38.0 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-06-17 02:25:40 +00:00
Clinton Wolfe
e4c7dea551
Merge pull request #5562 from inspec/vasundhara/add_mongodb_conf_resource
Add support for mongodb_conf resource in InSpec
2021-06-16 22:24:24 -04:00
Chef Expeditor
54ff422974 Bump version to 4.37.30 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-06-16 21:48:37 +00:00
Nikita Mathur
c28bacdab7 Oracle session exception handling
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-06-16 19:37:58 +05:30
Vasu1105
607d9a1ebc Removed port property
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-06-15 20:04:00 +05:30
Chef Expeditor
77112671ba Bump version to 4.37.29 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-06-14 19:23:02 +00:00
Vasu1105
5f85e17745 Removed warning as per review comments
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-06-14 19:41:56 +05:30
Vasu1105
da00e359aa Add mongodb_conf resource to InSpec
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-06-14 18:17:05 +05:30
Clinton Wolfe
4e9c8b3272 Add sybase_conf config resource, based on using sybase_session to call sp_configure
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2021-06-10 22:41:07 -04:00
Chef Expeditor
3d69833514 Bump version to 4.37.28 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-06-10 00:53:27 +00:00
Clinton Wolfe
6080ba3108
Merge pull request #5553 from inspec/vasundhara/fix-postgres-session-resource
Fix postgres_session resource to raise exception if there is a error in connection or in query
2021-06-09 20:50:52 -04:00
Chef Expeditor
8b351fbd0f Bump version to 4.37.27 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-06-10 00:50:29 +00:00
Clinton Wolfe
741806bf83
Merge pull request #5551 from inspec/vasundhara/fix-mysql-session-resource
Fix mysql_session resource to raise exception if there is a error in connection or in query
2021-06-09 20:48:55 -04:00
Clinton Wolfe
63654e32b9 Fix bug in isql output parsing
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2021-06-08 23:33:32 -04:00
Clinton Wolfe
5738112db6 Change upload implementation from echo-based to native train-based
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2021-06-08 23:25:04 -04:00
Vasu1105
3a37a6f766 Fixed review comments
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-06-04 14:01:42 +05:30
Vasu1105
38206d80e8 Fixed review comments
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-06-04 11:21:01 +05:30
Chef Expeditor
db72bb402e Bump version to 4.37.26 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-06-04 03:28:22 +00:00
Chef Expeditor
52c4fe586a Bump version to 4.37.25 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-06-04 03:25:05 +00:00
Clinton Wolfe
aaf0177ac8
Merge pull request #5547 from inspec/nm/inspec-shell-depends
Fix related to loading dependent profiles from a profile in shell
2021-06-03 23:23:48 -04:00
Chef Expeditor
ea935ca2c1 Bump version to 4.37.24 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-06-03 22:57:55 +00:00
Vasu1105
53df45a923 Removed redundant self
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-06-03 19:31:11 +05:30
Vasu1105
6395137a5d Removed unwanted self
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-06-03 19:24:44 +05:30
Vasu1105
c801a03b88 Fix postgres_session resource to raise exception if database connection is not established due to any reason or there is error with query
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-06-03 19:11:25 +05:30
Nikita Mathur
4000749e95 Comment added to explain usage of priority in fetchers
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-06-03 12:48:04 +05:30
Clinton Wolfe
7da5c4aec3 Add error handling and output handling to sybase_session
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2021-06-02 22:06:58 -04:00
Vasu1105
0cf4d3dcf4 Fix linter
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-06-02 16:01:06 +05:30
Vasu1105
7d91371d9f Fix mysql_session resource to handle the exceptions if the mysql session is not established. Currently it does not raise any exception due to which the inspec test gives false result
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-06-02 15:35:23 +05:30
Clinton Wolfe
99ae095c66 Initial attempt at an isql-base sybase_session resource, with many rough edges remaining
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2021-06-01 22:48:10 -04:00
Chef Expeditor
99116a12a3 Bump version to 4.37.23 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-05-31 22:49:25 +00:00
Chef Expeditor
a855c7a555 Bump version to 4.37.22 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-05-31 22:39:46 +00:00
Clinton Wolfe
e198120cf7
Merge pull request #5534 from inspec/nm/compliance-remove-support
Removed support for compliance and a1 server from InSpec compliance
2021-05-31 18:38:13 -04:00
Chef Expeditor
003bee3036 Bump version to 4.37.21 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-05-31 22:08:01 +00:00
Clinton Wolfe
e841b576ad
Merge pull request #5536 from inspec/vasundhara/update-inspec-init-plugin
Update inspec init plugin
2021-05-31 18:06:39 -04:00
Nikita Mathur
3eea2b055a Fix related to loading dependent profiles from a profile in shell
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-05-31 21:38:35 +05:30
Vasu1105
849536a63a Minor updates rename activator to activators in some places
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-05-26 06:21:50 +05:30
Nikita Mathur
6ce9c04232 Check added for automate server 2 for server presence
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-05-25 17:47:48 +05:30
Vasu1105
0d1c82dae2 Dev docs for inspec init plugin
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-05-25 09:55:54 +05:30
Vasu1105
6a45164e87 Updated to use Inspec.deprecate instead of log to deprecate the --hook option
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-05-24 18:05:18 +05:30
Vasu1105
a3feab0943 Handles string for for descripiton parsing
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-05-24 16:50:37 +05:30
Vasu1105
cb573e6050 Fix typo
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-05-24 15:45:35 +05:30
Vasu1105
14906ec1cd Update inspec init plugin to deprecate --hook option and replace it with --activators. Make alias for backword compatibility
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-05-24 15:43:33 +05:30
Vasu1105
ee6fd1b158 Fix multiline descripition issue of not parsing the data correctly
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-05-24 14:53:48 +05:30
Vasu1105
39303635e9 Fix failing test
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-05-21 18:51:08 +05:30
Vasu1105
bc15deab93 Update inspec init plugin:
1. To use double quotes as per chefstyle
2. Template files renamed to .erb

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-05-21 18:04:26 +05:30
Chef Expeditor
b84d4607d6 Bump version to 4.37.20 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-05-20 18:57:52 +00:00
Chef Expeditor
df4f6ad375 Bump version to 4.37.19 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-05-20 18:54:45 +00:00
Clinton Wolfe
ceeb6c7d3d
Merge pull request #5530 from inspec/nm/detect-no-color
Bugfix for `inspec detect --no-color` to not return colourful output
2021-05-20 14:52:20 -04:00
Chef Expeditor
7e4e0f33fd Bump version to 4.37.18 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-05-20 18:51:49 +00:00
Clinton Wolfe
a8dcc727a0
Merge pull request #5529 from inspec/nm/stale-automate-urls
Added new automate doc link for login tokens in `inspec automate login --help` command
2021-05-20 14:49:59 -04:00
Nikita Mathur
dcb99872ff Removed support for compliance and a1 server from inspec compliance
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-05-20 17:12:22 +05:30
Nikita Mathur
3e06280f01 Replaced api doc from compliance help command with the relevant doc link
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-05-19 18:00:42 +05:30
Chef Expeditor
66a372d715 Bump version to 4.37.17 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-05-19 12:19:45 +00:00
Nikita Mathur
209948d3fd no color change where no ansi code is used at all
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-05-19 14:39:10 +05:30
Chef Expeditor
9922dc0504 Bump version to 4.37.16 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-05-18 19:44:35 +00:00
Chef Expeditor
fb14f9d667 Bump version to 4.37.15 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-05-18 19:38:50 +00:00
Clinton Wolfe
85ecf5373d
Merge pull request #5522 from inspec/vasundhara/fix-for-port-resource
Fix for port resource performance: adding more specific search while using ss command
2021-05-18 15:37:01 -04:00
Chef Expeditor
a75bf41a04 Bump version to 4.37.14 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-05-18 19:30:57 +00:00
Clinton Wolfe
cab833b88f
Merge pull request #5519 from inspec/nm/file-resource-bug
Changes returns nil on file non-existence through matcher `more_permissive_than`
2021-05-18 15:28:32 -04:00
Chef Expeditor
470aff4b77 Bump version to 4.37.13 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-05-18 19:27:51 +00:00
Nikita Mathur
f9659bfaf0 Test cases and color code changes for no-color option in detect cmd
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-05-18 16:09:42 +05:30
Nikita Mathur
38fd0ef56b inspec detect --no-color to not give colorful output
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-05-17 16:02:03 +05:30
Nikita Mathur
3fd2c57a5a Added new automate doc link for login tokens
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-05-17 14:30:49 +05:30
Nikita Mathur
483853ab81 To return only nil when file does not exist
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-05-17 13:48:17 +05:30
Vasu1105
9786a467f1 Fix lint errors
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-05-17 11:12:27 +05:30
Vasu1105
08f2fcf4bb Fix for port resource performance: adding more specific search while using ss command
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-05-17 11:12:26 +05:30
Chef Expeditor
1e96f31a0c Bump version to 4.37.12 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-05-16 21:18:11 +00:00
Chef Expeditor
44c4bf9a86 Bump version to 4.37.11 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-05-16 21:15:09 +00:00
Chef Expeditor
d0369f5271 Bump version to 4.37.10 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-05-16 20:58:53 +00:00
Chef Expeditor
17ebbe2033 Bump version to 4.37.9 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-05-16 20:56:18 +00:00
Kannan Ramakrishnan
feb12fef77 Fixed a typo in variable name. Signed-off-by: @kannanr <kannaa.ram@gmail.com> 2021-05-15 18:53:39 +05:30
Kannan Ramakrishnan
d1831a318c Lint errors handled. Signed-off-by: @kannanr <kannaa.ram@gmail.com> 2021-05-15 17:48:19 +05:30
Kannan Ramakrishnan
19c624cf38 Support zfs_pool and zfs_dataset resources on Linux. Handled #5075. Signed-off-by: @kannanr <kannaa.ram@gmail.com> 2021-05-15 12:18:39 +05:30
Chef Expeditor
54763c61d7 Bump version to 4.37.8 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-05-10 20:56:05 +00:00
Chef Expeditor
b90ed7b7a3 Bump version to 4.37.7 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-05-10 20:53:43 +00:00
Clinton Wolfe
e49fa72836
Merge pull request #5506 from jwdean/master
Modified windows_feature to indicate enabled rather than just available
2021-05-10 16:52:26 -04:00
Chef Expeditor
86e14edb7f Bump version to 4.37.6 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2021-05-10 20:50:28 +00:00