Clinton Wolfe
3419c84233
Make predicates private to reduce namespace pollution; added dockerenv check for docker mode
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-29 11:28:52 -05:00
Chef Expeditor
193905a827
Bump version to 4.18.68 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2020-01-29 16:03:44 +00:00
Ryan Davis
15f77941af
Some cleanup on the apache_conf resource.
...
The biggie to know is that all the extra read_content calls were
needlessly redundant with it also being called in initialize.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-01-28 14:53:37 -08:00
Ryan Davis
9c051da22b
Fix platform on apache_conf to include all unix.
...
Now discovers the first available conf file from a list of known
paths. Might have to expand based on various distros.
Had to tweak the tests because the mock loader mocks EVERYTHING every
time. :/
Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-01-28 14:53:37 -08:00
Ryan Davis
8bd2528ef8
Added --inspect option to inspect shell command.
...
* Removed Resource#inspect (calling to_s) to make debugging a happy experience.
* Added ResourceBehavior.toggle_inspect to add/remove a basic inspect.
* Added `--inspect` flag to `shell` command. Call toggle_inspect unless --inspect used.
* Cleaned up matchers.rb and removed most explicit calls to inspect.
* Added ResourceInspector to rspec's INSPECTOR_CLASSES.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-01-28 14:52:04 -08:00
Clinton Wolfe
357cf051b1
PR feedback part 1
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-28 11:06:12 -05:00
Chef Expeditor
41f3927e84
Bump version to 4.18.67 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2020-01-28 15:03:18 +00:00
Clinton Wolfe
46ade02401
Use an archive if possible when fetching fails and --airgap is… ( #4806 )
...
Use an archive if possible when fetching fails and --airgap is provided
2020-01-28 10:02:57 -05:00
Ryan Davis
df31f744f4
Fix up platform on filesystem resource.
...
From linux to unix. This should work fine even on AIX, according to
the man pages.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-01-27 15:34:33 -08:00
Ryan Davis
65c44d22e2
Audited virtualization a bit.
...
Cleaned up some code.
Reordered virtualization detection by order of probability.
Added TODOs for obvious problems.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-01-27 15:31:41 -08:00
Ryan Davis
f830ddeca6
Slimmed up and removed "clever" from file resource description.
...
Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-01-27 15:30:48 -08:00
Ryan Davis
b9d49e0fed
Fix up the platform on etc_hosts, virtualization, ini, and xml resources to fix OS disparity.
...
+ File format oriented resources should always be `os`.
+ virtualization should (in theory) be any unix (tho, it currently seems wrong).
+ etc_hosts should be any (reasonable) unix.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-01-27 15:29:52 -08:00
Clinton Wolfe
76a9c3e590
Install-path based install context detection
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-27 13:29:37 -05:00
Clinton Wolfe
eac3b31095
PR feedback re: cache warming
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-27 11:01:15 -05:00
Chef Expeditor
2089bf80c7
Bump version to 4.18.66 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2020-01-27 15:51:46 +00:00
Clinton Wolfe
31d2383285
Missing end quote in oracledb_session ( #4852 )
...
Missing end quote in oracledb_session
2020-01-27 10:51:25 -05:00
Chef Expeditor
cafb4f3e3e
Bump version to 4.18.65 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2020-01-27 15:31:19 +00:00
Miah Johnson
89549bd884
Missing end quote.
...
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2020-01-24 12:00:00 -08:00
Chef Expeditor
6434009051
Bump version to 4.18.64 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2020-01-24 17:40:12 +00:00
Ryan Davis
faf7833559
Clarified service logic logic for redhat flavors.
...
Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-01-23 16:36:44 -08:00
Ryan Davis
ad6ffcccd6
Switch Service#select_service_mgmt from huge if statement to case.
...
Having a ton of conditions with `%w{one-string}.include?(platform)` is
incredibly wasteful and slow. Apparently about 17x slower:
```
Calculating -------------------------------------
include_eh 529.315k (± 3.2%) i/s - 2.675M in 5.058296s
include_or_eq 909.795k (± 1.5%) i/s - 4.568M in 5.022491s
case_when 9.043M (± 2.8%) i/s - 45.443M in 5.029499s
Comparison:
case_when: 9042590.3 i/s
include_or_eq: 909795.2 i/s - 9.94x slower
include_eh: 529315.0 i/s - 17.08x slower
```
Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-01-23 16:36:36 -08:00
Ryan Davis
8f4bac23eb
Refactor some of resources/service.rb
...
Starting with: normalizing a huge if in select_service_mgmt to only
use strings.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-01-23 16:33:15 -08:00
Chef Expeditor
d013ac1e47
Bump version to 4.18.63 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2020-01-23 18:09:12 +00:00
Noel Georgi
7ac25401bb
Add: content option for x509_certificate
...
Signed-off-by: Noel Georgi <git@frezbo.com>
2020-01-22 13:49:35 +05:30
Chef Expeditor
7da7c2774b
Bump version to 4.18.62 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2020-01-21 21:18:34 +00:00
Raimar Sandner
fa2f2c2caa
make command.exist? POSIX conform
...
With the current implementation, on a Linux system without bash
command.exist? always returns false. 'sh -c' is guaranteed to exist on a
POSIX-conform system [1] whereas 'bash -c' only works if bash is
actually installed.
[1] https://pubs.opengroup.org/onlinepubs/9699919799/utilities/sh.html
Obvious fix.
2020-01-19 00:05:33 +01:00
Michael Lihs
edd93eea81
Add support for yocto linux in service resource
...
Signed-off-by: Michael Lihs <michael.lihs@thoughtworks.com>
2020-01-18 01:26:16 +01:00
Chef Expeditor
356de23c5c
Bump version to 4.18.61 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2020-01-15 21:02:41 +00:00
Ryan Davis
9bd07954a6
Merge pull request #4833 from inspec/zenspider/mac/groups
...
Fixed duplicate groups on osx by merging members by gid.
2020-01-15 13:02:24 -08:00
Chef Expeditor
8cede82c20
Bump version to 4.18.60 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2020-01-15 20:37:45 +00:00
Clinton Wolfe
4c270efe78
upstream is basic_auth_only not basic_auth ( #4834 )
...
upstream is basic_auth_only not basic_auth
2020-01-15 15:37:26 -05:00
Chef Expeditor
d4481b82fb
Bump version to 4.18.59 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2020-01-14 21:07:12 +00:00
Shawn Foley
83bc974923
winrm_basic_auth_only
...
Signed-off-by: Shawn Foley <shawn.foley@marketleader.com>
2020-01-14 08:46:06 -08:00
Ryan Davis
ea611634d1
Fixed duplicate groups on osx by merging members by gid.
...
Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-01-13 13:25:05 -08:00
Clinton Wolfe
71e34abae4
Clarify usage message for --airgap option
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-07 21:02:16 -08:00
Miah Johnson
0d57612103
Update references to use new namespace
...
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2020-01-07 15:12:42 -08:00
Miah Johnson
0f4538ca4d
Move all these modules to live until Inspec::Utils
...
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2020-01-07 15:12:42 -08:00
Clinton Wolfe
a11c41283c
Clarify comment on fallback_to_archive_fetch_failure
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-06 19:48:03 -05:00
Clinton Wolfe
479256fad3
Compress some code
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-06 19:32:13 -05:00
Clinton Wolfe
3a97e5d75b
Accept a refactornig suggestion
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-06 19:21:12 -05:00
Clinton Wolfe
835bd2be8c
A clumsy but effective way of usually dodging windows filesystem length restrictions.
...
Still definitely possible to run afoul of that issue, but that is not specific to
this feature, and frankly one might consider increasing thier FS path length
as a solution, as well.
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-06 18:54:23 -05:00
Ryan Davis
0e77af3a77
Fixed resolver_test.rb by making Inspec::Config.cached a lazy accessor.
...
Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-01-03 17:13:18 -08:00
Ryan Davis
885e4f6c71
Fix test failure for call to vendor!
w/o options.
...
Had to make options available for the mocking as well.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-01-03 17:12:51 -08:00
Clinton Wolfe
9bf8f2f4cd
Adjust usage message for --airgap option
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-03 14:15:05 -05:00
Clinton Wolfe
9ada8362b8
Push up update_from_opts implementation
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-03 14:15:05 -05:00
Clinton Wolfe
5369b7ac79
make a one-liner per miah
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-03 14:15:05 -05:00
Clinton Wolfe
b92537aff5
bangify vendor_dependencies
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-03 14:15:05 -05:00
Clinton Wolfe
6a0f7eeea9
A terrible implementation of fetcher fallback for compliance fetcher
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-03 14:15:05 -05:00
Clinton Wolfe
f4a3cf9144
Implementation for local fetcher
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-03 14:15:05 -05:00
Clinton Wolfe
4e0ad4a56b
Implementation of archive fallback for the URL fetcher
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-03 14:15:05 -05:00
Clinton Wolfe
1eb33049e4
Alter resolver to fallback to an archive if in airgap mode
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-03 14:15:05 -05:00
Clinton Wolfe
1806900794
Add an optional API method to update the internal state of a fetcher
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-03 14:15:04 -05:00
Clinton Wolfe
e1941b2d11
When archiving with --airgap, warm the vendor cache from any available local archives
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-03 14:15:04 -05:00
Clinton Wolfe
f9d419f219
Remove constructors from raise statements
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-03 14:15:04 -05:00
Clinton Wolfe
48a97ea60f
Add .invalid TLD to test hostanmes
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-03 14:15:04 -05:00
Chef Expeditor
395d6d5421
Bump version to 4.18.58 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2020-01-03 16:47:38 +00:00
Clinton Wolfe
328302dd48
Fix empty attributes array in json reporter ( #4815 )
...
shallow copy of params missed inputs
2020-01-03 11:47:16 -05:00
Ryan Davis
b51da7d037
Properly report errors with bad tarball files.
...
+ Raise a well-worded error with details and avoid an uncaught exception.
+ Fix error caused when the tar file is already invalid and we try to close it.
Fixes #3765 .
Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-01-02 16:13:55 -08:00
Chef Expeditor
230ce1532e
Bump version to 4.18.57 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2020-01-03 00:07:52 +00:00
Ryan Davis
f09595c33d
Merge pull request #4821 from inspec/zenspider/mocha2
...
Found and fixed more mocha/setup deprecations.
2020-01-02 16:07:35 -08:00
Chef Expeditor
8b5789004a
Bump version to 4.18.56 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2020-01-01 00:59:32 +00:00
Ryan Davis
c57a0e1f13
Found and fixed more mocha/setup deprecations.
...
This level of duplication is not good.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-12-31 15:46:47 -08:00
Ryan Davis
a0ffa67b71
Switched from profile_id to __profile_id per feedback.
...
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-12-31 15:27:12 -08:00
Ryan Davis
6426feeeb4
Removed the last of the metaprogramming from ControlEvalContext.
...
* Merged CEC.create args into CEC#initialize
* Converted the only call site of CEC.create to just call new.
* Added profile_context and resources_dsl accessors to CEC.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-12-31 15:27:12 -08:00
Ryan Davis
f6407fb01b
Future code cleanup TODO
...
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-12-31 15:27:12 -08:00
Ryan Davis
15941279ae
Removed 90+% of all metaprogramming from ControlEvalContext
...
+ Removed ControlEvalContext.rule_context entirely pushing into Rule
+ Gutted ControlEvalContext.create pushing into ControlEvalContext.
+ Added class ivar accessors for ControlEvalContext to bypass need for closures.
+ Converted all define_methods into defs.
+ Added resource_dsl to Rule#initialize
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-12-31 15:27:12 -08:00
Chef Expeditor
f4815204d9
Bump version to 4.18.55 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2019-12-31 22:20:03 +00:00
Nazli Beitollahpour
1486d8d890
issue 4807: shallow copy of params missed inputs
...
Signed-off-by: Nazli Beitollahpour <nazli.beitollahpour@umontreal.ca>
2019-12-31 13:02:27 -05:00
Cameron Straka
8b037fa9c2
replaced instances of have_protocols
with have_protocol
in documentation and examples
...
Signed-off-by: Cameron Straka <strakacameron@hotmail.com>
2019-12-31 10:51:55 -05:00
Ryan Davis
7d95ece60d
Remove circular require between fetcher and compliance plugin w/ autoloads.
...
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-12-24 04:10:48 -08:00
Chef Expeditor
5b957ef776
Bump version to 4.18.54 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2019-12-17 22:05:59 +00:00
Ryan Davis
83f7504d7c
Merge pull request #4789 from Perceptyx/add-freebsd-package
...
Add suport for freebsd package resource
2019-12-17 14:05:40 -08:00
Chef Expeditor
ee20fc5789
Bump version to 4.18.53 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2019-12-17 22:04:39 +00:00
Ryan Davis
409cd17551
Merge pull request #4794 from Perceptyx/add-freebsd-postfix_conf
...
postfix_conf: Changed supported platform to unix
2019-12-17 14:04:22 -08:00
Chef Expeditor
80d63db71e
Bump version to 4.18.52 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2019-12-17 22:02:36 +00:00
Felipe Zipitria
824c3f4e89
Changed supported platform to unix
...
Signed-off-by: Felipe Zipitria <fzipitria@perceptyx.com>
2019-12-17 12:16:35 -03:00
Felipe Zipitria
bff3fa960d
Add suport for freebsd package resource
...
Signed-off-by: Felipe Zipitria <fzipitria@perceptyx.com>
2019-12-17 08:39:43 -03:00
Chef Expeditor
2ed57d5d82
Bump version to 4.18.51 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2019-12-11 22:07:06 +00:00
Miah Johnson
cf0159b7e2
Merge pull request #4754 from inspec/jb/hab_template
...
remove inspec from pkg_deps/pkg_build_deps in template
2019-12-11 14:06:48 -08:00
Chef Expeditor
263e798cb7
Bump version to 4.18.50 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2019-12-10 19:56:56 +00:00
Ryan Davis
4811606b00
Merge pull request #4766 from inspec/zenspider/fix-warnings/method-redefined
...
Fix warnings coming from ruby -w
2019-12-10 11:56:37 -08:00
Chef Expeditor
2825e8df64
Bump version to 4.18.49 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2019-12-09 20:10:36 +00:00
Chef Expeditor
14e81b88f7
Bump version to 4.18.48 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2019-12-09 20:09:53 +00:00
Ryan Davis
5d8a0af8ce
Merge pull request #4768 from inspec/zenspider/bug628
...
Wire up backend to rspec metadata, allowing for example groups to use resources
2019-12-09 12:09:41 -08:00
Ryan Davis
77ce1b6559
Wire up backend to rspec metadata, allowing for example groups to use resources
...
Fixes #628 .
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-12-06 17:07:22 -08:00
Chef Expeditor
b9f8d1ea59
Bump version to 4.18.47 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2019-12-05 19:23:34 +00:00
Clinton Wolfe
7d2733df23
Make fetchers fail consistently ( #4736 )
...
Make fetchers fail consistently
2019-12-05 14:23:14 -05:00
Ryan Davis
11a22c63c7
Removed duplicate method warning in shadow resource.
...
Removed from filtertable because the deprecations are in the regular
methods.
Fixes #4213 .
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-12-04 17:13:39 -08:00
Ryan Davis
4942a572bb
Fix warnings coming from ruby -w
...
This first pass fixes all our circular requires and duplicate method
warnings that come from:
```
ruby -w -Ilib:test test/functional/helper.rb
```
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-12-04 17:07:37 -08:00
Chef Expeditor
55664f753a
Bump version to 4.18.46 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2019-12-04 20:23:35 +00:00
Ryan Davis
eca23385ea
Merge pull request #4760 from inspec/zenspider/detect+logger
...
Hook up logger to inspec detect.
2019-12-04 12:23:17 -08:00
Clinton Wolfe
84d4325516
Linting
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-12-04 13:35:13 -05:00
Clinton Wolfe
b6cb418af6
Flatten a conditional
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-12-04 13:32:58 -05:00
Clinton Wolfe
bba6d70b3b
Raise FetcherFailure for url headers missing
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-12-04 13:32:58 -05:00
Clinton Wolfe
8c53e8a6b9
Remove constructors from raise statements
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-12-04 13:32:58 -05:00
Clinton Wolfe
b34d489f5c
Add .invalid TLD to test hostanmes
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-12-04 13:32:58 -05:00
Clinton Wolfe
4bda0ddeeb
fixture and implementation for git fetcher failure handling
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-12-04 13:32:19 -05:00
Clinton Wolfe
8a3213861a
Fixture and implementation for URL fetcher
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-12-04 13:32:19 -05:00
Clinton Wolfe
72f1011979
Fixture and implementation for local fetcher error handling
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-12-04 13:30:08 -05:00
Chef Expeditor
31e4fea3ff
Bump version to 4.18.45 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2019-12-04 02:43:54 +00:00