Commit graph

8222 commits

Author SHA1 Message Date
Chef Expeditor
eaf2d7ca5b Bump version to 4.18.70 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-01-30 00:06:50 +00:00
Ryan Davis
6dba4bfe0c
Merge pull request #4854 from inspec/zenspider/gemspecs
Rework and unify gemspecs.
2020-01-29 16:06:31 -08:00
Chef Expeditor
485aa93d90 Bump version to 4.18.69 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-01-29 23:50:00 +00:00
Ryan Davis
124b56b6ee
Merge pull request #4825 from inspec/zenspider/tarball
Properly report errors with bad tarball files.
2020-01-29 15:49:40 -08:00
Ryan Davis
217d79d4d6 Revamp dependencies and file content across inspec and inspec-core.
+ inspec-core has all the real dependencies for inspec (the project).
+ inspec keeps all aws/azure/gcp code and their dependencies.
+ inspec depends on inspec-core and inspec-bin.
+ Removed test_files entirely.
+ Removed FNM_DOTMATCH on our globs... don't cargo cult.
+ Added some code to print out the gemspec and files to make it easier
  to debug by executing the gemspec directly.
+ Sorted all deps... so hard to find things.
+ Added version specifiers where needed.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-01-29 15:48:26 -08:00
Ryan Davis
56988f9f8a Rework and unify gemspecs.
First step is to get them agreeing on dependencies.

There's still some oddities between train vs train-core and
dependencies for AWS and the like, but this brings them in line so
diffing between them is MUCH better.

Next is to gut inspec and push everything over to inspec-core.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-01-29 15:47:20 -08:00
Ryan Davis
2ae2bcf6fb
Merge pull request #4818 from JackChance/master
replaced instances of `have_protocols` with `have_protocol` in docume…
2020-01-29 15:46:25 -08:00
Ryan Davis
ceab1cbdac Refactored crontab resource
Specifically the parsing was pretty unreadable. This refactoring
emphasizes using a default hash and merging in the differences for
what was parsed. Everything is funneled through one `merge_crontab`
method that does the actual parsing and the system vs user differences
are merged in after in their respective parse methods.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-01-29 13:56:11 -08:00
Clinton Wolfe
37455bdd11 Parallelize unit tests
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-29 16:15:58 -05:00
Clinton Wolfe
3419c84233 Make predicates private to reduce namespace pollution; added dockerenv check for docker mode
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-29 11:28:52 -05:00
Chef Expeditor
193905a827 Bump version to 4.18.68 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-01-29 16:03:44 +00:00
Clinton Wolfe
126fcc2988
Fix windows plugin functional tests (#4861)
Fix windows plugin functional tests
2020-01-29 11:03:25 -05:00
Ryan Davis
15f77941af Some cleanup on the apache_conf resource.
The biggie to know is that all the extra read_content calls were
needlessly redundant with it also being called in initialize.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-01-28 14:53:37 -08:00
Ryan Davis
9c051da22b Fix platform on apache_conf to include all unix.
Now discovers the first available conf file from a list of known
paths. Might have to expand based on various distros.

Had to tweak the tests because the mock loader mocks EVERYTHING every
time. :/

Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-01-28 14:53:37 -08:00
Ryan Davis
8bd2528ef8 Added --inspect option to inspect shell command.
* Removed Resource#inspect (calling to_s) to make debugging a happy experience.
* Added ResourceBehavior.toggle_inspect to add/remove a basic inspect.
* Added `--inspect` flag to `shell` command. Call toggle_inspect unless --inspect used.
* Cleaned up matchers.rb and removed most explicit calls to inspect.
* Added ResourceInspector to rspec's INSPECTOR_CLASSES.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-01-28 14:52:04 -08:00
Clinton Wolfe
3d5226fb68 Q-quote the args to the train plugin
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-28 13:48:10 -05:00
Clinton Wolfe
28f8d6cc5f Removing skip in archive test just seems to work, too
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-28 12:24:29 -05:00
Clinton Wolfe
6290ee0190 Just remove skips, it seems to work
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-28 11:57:25 -05:00
Clinton Wolfe
357cf051b1 PR feedback part 1
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-28 11:06:12 -05:00
Chef Expeditor
41f3927e84 Bump version to 4.18.67 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-01-28 15:03:18 +00:00
Clinton Wolfe
46ade02401
Use an archive if possible when fetching fails and --airgap is… (#4806)
Use an archive if possible when fetching fails and --airgap is provided
2020-01-28 10:02:57 -05:00
Ryan Davis
df31f744f4 Fix up platform on filesystem resource.
From linux to unix. This should work fine even on AIX, according to
the man pages.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-01-27 15:34:33 -08:00
Ryan Davis
65c44d22e2 Audited virtualization a bit.
Cleaned up some code.
Reordered virtualization detection by order of probability.
Added TODOs for obvious problems.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-01-27 15:31:41 -08:00
Ryan Davis
f830ddeca6 Slimmed up and removed "clever" from file resource description.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-01-27 15:30:48 -08:00
Ryan Davis
b9d49e0fed Fix up the platform on etc_hosts, virtualization, ini, and xml resources to fix OS disparity.
+ File format oriented resources should always be `os`.
+ virtualization should (in theory) be any unix (tho, it currently seems wrong).
+ etc_hosts should be any (reasonable) unix.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-01-27 15:29:52 -08:00
Clinton Wolfe
76a9c3e590 Install-path based install context detection
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-27 13:29:37 -05:00
Clinton Wolfe
eac3b31095 PR feedback re: cache warming
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-27 11:01:15 -05:00
Chef Expeditor
2089bf80c7 Bump version to 4.18.66 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-01-27 15:51:46 +00:00
Clinton Wolfe
31d2383285
Missing end quote in oracledb_session (#4852)
Missing end quote in oracledb_session
2020-01-27 10:51:25 -05:00
Chef Expeditor
cafb4f3e3e Bump version to 4.18.65 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-01-27 15:31:19 +00:00
Clinton Wolfe
1ac26b3477
Fixes all notarization issues (#4835)
Fixes all notarization issues
2020-01-27 10:31:00 -05:00
Jon Morrow
14dd7bde64 Fixes all notarization issues
This changes makes the neccessary changes to enable the pkg to pass apples notarization requirements.

1. Drop 'Developer ID Installer:' from signing key. This lets sigining pick up the correct key for what is being signed.
2. Update inspec software definition to delete test dir from rubyzip gem because its fixtures contain zip files that the notarization service cannot inspect.

Signed-off-by: Jon Morrow <jmorrow@chef.io>
2020-01-24 13:46:41 -08:00
Miah Johnson
89549bd884 Missing end quote.
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2020-01-24 12:00:00 -08:00
Miah Johnson
287c98fff4
Merge pull request #4840 from inspec/mj/tktk
Start forming resource-core
2020-01-24 11:39:09 -08:00
Miah Johnson
88164b058a
Merge branch 'master' into mj/tktk 2020-01-24 11:38:47 -08:00
Miah Johnson
038485f685
Merge pull request #4837 from inspec/mj/tk
Point to our updated kitchen/cookbooks path.
2020-01-24 11:37:56 -08:00
Chef Expeditor
6434009051 Bump version to 4.18.64 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-01-24 17:40:12 +00:00
Clinton Wolfe
1720576807
Refactor some of resources/service.rb (#4849)
Refactor some of resources/service.rb
2020-01-24 12:39:50 -05:00
Ryan Davis
faf7833559 Clarified service logic logic for redhat flavors.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-01-23 16:36:44 -08:00
Ryan Davis
ad6ffcccd6 Switch Service#select_service_mgmt from huge if statement to case.
Having a ton of conditions with `%w{one-string}.include?(platform)` is
incredibly wasteful and slow. Apparently about 17x slower:

```
Calculating -------------------------------------
          include_eh    529.315k (± 3.2%) i/s -      2.675M in   5.058296s
       include_or_eq    909.795k (± 1.5%) i/s -      4.568M in   5.022491s
           case_when      9.043M (± 2.8%) i/s -     45.443M in   5.029499s

Comparison:
           case_when:  9042590.3 i/s
       include_or_eq:   909795.2 i/s - 9.94x  slower
          include_eh:   529315.0 i/s - 17.08x  slower
```

Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-01-23 16:36:36 -08:00
Ryan Davis
8f4bac23eb Refactor some of resources/service.rb
Starting with: normalizing a huge if in select_service_mgmt to only
use strings.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-01-23 16:33:15 -08:00
Chef Expeditor
d013ac1e47 Bump version to 4.18.63 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-01-23 18:09:12 +00:00
Clinton Wolfe
0d9e91405e
Add: certificate content x509_certificate (#4845)
Add: certificate content x509_certificate
2020-01-23 13:08:51 -05:00
John Snow
7362a8db6d Remove the references to the core/cacerts so customers can specify it
Signed-off-by: John Snow <thelunaticscripter@outlook.com>
2020-01-23 12:49:26 -05:00
Noel Georgi
7ac25401bb
Add: content option for x509_certificate
Signed-off-by: Noel Georgi <git@frezbo.com>
2020-01-22 13:49:35 +05:30
Chef Expeditor
7da7c2774b Bump version to 4.18.62 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-01-21 21:18:34 +00:00
Ryan Davis
524e245365
Merge pull request #4841 from inspec/mj/2008Fixes
Windows 7 EOL Docs Update
2020-01-21 13:18:14 -08:00
Mary Jinglewski
5049975b0c Spacing Issue Fix
Signed-off-by: Mary Jinglewski <mjinglewski@chef.io>
2020-01-21 16:14:32 -05:00
Mary Jinglewski
15337b2eb3 Additional Fix
Signed-off-by: Mary Jinglewski <mjinglewski@chef.io>
2020-01-21 11:36:17 -05:00
Raimar Sandner
fa2f2c2caa make command.exist? POSIX conform
With the current implementation, on a Linux system without bash
command.exist? always returns false. 'sh -c' is guaranteed to exist on a
POSIX-conform system [1] whereas 'bash -c' only works if bash is
actually installed.

[1] https://pubs.opengroup.org/onlinepubs/9699919799/utilities/sh.html

Obvious fix.
2020-01-19 00:05:33 +01:00