Commit graph

203 commits

Author SHA1 Message Date
Clinton Wolfe
baf653282a
Merge pull request #5671 from inspec/vasundhara/fix-opa-resources
Fix opa_cli and opa_api resource unable to verify empty result {}
2021-09-28 08:18:09 -04:00
Clinton Wolfe
993c9d9225
Merge pull request #5657 from inspec/nm/tags-dependent
Fix --tags filter for dependent profiles
2021-09-28 00:35:32 -04:00
Vasu1105
2b9bef28cb test fixturs files for opa_api and opa_cli resource
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-09-22 16:27:15 +05:30
Clinton Wolfe
49cd6883b9
Merge pull request #5589 from collinmcneese/cmcneese/chrony_conf
adds chrony_conf InSpec resource
2021-09-13 14:39:34 -04:00
Clinton Wolfe
ceaef891bb
Merge branch 'main' into nm/oracle-conf 2021-09-13 14:33:51 -04:00
Nikita Mathur
1d8b19fa98 Fix --tags filter for dependent profiles
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-09-07 16:49:32 +05:30
Vasu1105
12e3ee9aca Fix the command to query on the database
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-09-01 18:06:16 +05:30
Vasu1105
30ea9cfe57 Add ibmdb2_conf and ibmdb2_session resource
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-09-01 18:06:16 +05:30
Clinton Wolfe
28956c0cf5
Merge pull request #5643 from inspec/nm/tags-fix
Fix tags processing issue in profiles
2021-08-31 23:40:56 -04:00
Mendy Baitelman
7abebdf80b Merge remote-tracking branch 'upstream/main' into add-http-for-windows-2 2021-08-31 17:08:28 -07:00
Clinton Wolfe
d564ab21c6
Merge pull request #5640 from inspec/spelling_fixes
Fix typos identified by cspell
2021-08-31 16:29:06 -04:00
Nikita Mathur
c85f49d0d8 Change to filter tags on both key and value basis of hashmap style tags
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-08-31 18:14:58 +05:30
Nikita Mathur
ddcb096666 Fix control tags fetching logic which was breaking profiles with tags used
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-08-31 17:17:27 +05:30
Vasu1105
81b28c2c51 Change master to main branch for inspec-gcp and inspec-azure repo
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-08-31 14:04:38 +05:30
Tim Smith
403647c3e4 Fix typos identified by cspell
Just a pile of misc typos

Signed-off-by: Tim Smith <tsmith@chef.io>
2021-08-30 16:49:46 -07:00
Clinton Wolfe
83fcc7fec4
Merge pull request #5629 from inspec/vasundhara/fix_for_security_policy_resource
Fix for security_policy resource does not return array for local groups
2021-08-30 17:17:16 -04:00
Clinton Wolfe
04dabfee23
Merge pull request #5636 from inspec/vasundhara/remove-wmic-calls-security-identifier
Replace use of wmic from security_identifier resource as it will be deprecated soon
2021-08-30 17:11:58 -04:00
Vasu1105
99a170d7e5 Updated inspec-aws git url to replace branch to master to main
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-08-30 18:08:06 +05:30
Vasu1105
2100a66bef Removed use of wmic from security_identifier resource as it will be deprecated soon
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-08-30 12:47:03 +05:30
Vasu1105
8487da327f Fix for security_policy resource does not return array for local groups
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-08-27 18:34:25 +05:30
Clinton Wolfe
dcf49ad510
Merge pull request #5601 from inspec/nm/bug-apache-conf
Fix apache_conf issue when Server Root is not present in configuration
2021-08-17 21:00:38 -04:00
Clinton Wolfe
5bbe34acb0
Merge pull request #5596 from inspec/nm/control-tags
Filter active controls in profile by tags
2021-07-27 23:14:41 -04:00
Vasu1105
f0ca02a1c5 Adds unit test for opa_api and opa_cli resource
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-07-19 14:44:47 +05:30
Nikita Mathur
1e8363587e Test case to test apache_conf when server root is not configured
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-07-19 14:41:29 +05:30
Nikita Mathur
a16e9fcf45 Tag based filtering for controls - initial commit
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-07-09 19:03:15 +05:30
Nikita Mathur
89b0f95c75 Using os_env resource to read ORACLE_HOME env in oracle listener conf resource
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-07-09 16:31:45 +05:30
Daniel Tingstrom
3e8738a4e6 Update firewalld resource to include more properties
Signed-off-by: Daniel Tingstrom <dtingstrom@mitre.org>
2021-07-08 16:50:48 -04:00
Collin McNeese
06eb9b9a84
adds chrony_conf InSpec resource
Signed-off-by: Collin McNeese <cmcneese@chef.io>
2021-07-06 10:46:47 -05:00
Nikita Mathur
cb31cefaa2 Review changes - Fetching listener file using env variable
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-06-29 14:43:56 +05:30
Nikita Mathur
f921c25efc Oracle_db_conf and oracle_listener_conf changes, test cases and doc added
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-06-29 12:25:48 +05:30
Clinton Wolfe
61c83d28b3
Merge pull request #5567 from inspec/nm/oracle-session-exception
Oracle Session Exception Handling
2021-06-29 00:47:23 -04:00
Nikita Mathur
7ec66a0ca9 Missing oracle-error file added for testing
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-06-24 00:13:04 +05:30
Clinton Wolfe
e4c7dea551
Merge pull request #5562 from inspec/vasundhara/add_mongodb_conf_resource
Add support for mongodb_conf resource in InSpec
2021-06-16 22:24:24 -04:00
Vasu1105
da00e359aa Add mongodb_conf resource to InSpec
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-06-14 18:17:05 +05:30
Clinton Wolfe
741806bf83
Merge pull request #5551 from inspec/vasundhara/fix-mysql-session-resource
Fix mysql_session resource to raise exception if there is a error in connection or in query
2021-06-09 20:48:55 -04:00
Vasu1105
6f4bd2413d Fixed failing test
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-06-04 17:24:28 +05:30
Nikita Mathur
3eea2b055a Fix related to loading dependent profiles from a profile in shell
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-05-31 21:38:35 +05:30
Clinton Wolfe
442c89d45e
Merge pull request #5523 from kannanr/master
Support zfs_pool and zfs_dataset resources on Linux. Handled #5075
2021-05-16 16:56:07 -04:00
Vasu1105
0d83a44f44 Fix the lint and failing test for windows_feature resource
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-05-15 16:56:53 +05:30
Kannan Ramakrishnan
19c624cf38 Support zfs_pool and zfs_dataset resources on Linux. Handled #5075. Signed-off-by: @kannanr <kannaa.ram@gmail.com> 2021-05-15 12:18:39 +05:30
Clinton Wolfe
1e2b0e79c1
Merge pull request #5487 from inspec/vasundhara/fix_depedent_control_errors
Fix  undefined method `+' for nil:NilClass\n\nProfile: - when using profile dependencies and require_controls
2021-05-03 21:03:27 -04:00
Nikita Mathur
457e544724 Fix for non-existent member for group resource
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-04-28 22:26:33 +05:30
Vasu1105
57c1484150 Adds one more profile inside the require_controls_test to check inheritance
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-04-27 19:29:13 +05:30
Vasu1105
76dca7f97c Adds policy property, unit test and documentation for modules and booleans
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-04-22 11:40:32 +05:30
Clinton Wolfe
79aa03ae14
Merge pull request #5466 from inspec/nm/inputs-regex
New input option `pattern` added for DSL and metadata inputs
2021-04-21 19:34:07 -04:00
Nikita Mathur
e77d5331c5 Added new pattern option, fix for input options on dsl and functional test cases for input options
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-04-21 12:33:54 +05:30
Vasu1105
58e30cfa81 Review comments fixed
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-04-21 11:43:03 +05:30
Vasu1105
cbe7e8c03f Add selinux resource with basic features support
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-04-21 11:43:02 +05:30
Clinton Wolfe
4dbee6b7bd Alter split code to handle comments containing the word 'control', and rename some vars
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2021-04-08 16:25:09 -04:00
Nick Schwaderer
db3e2751d6 Sets up testing and expectation for completely nuked waived controls
Signed-off-by: Nick Schwaderer <nschwaderer@chef.io>
2021-04-08 16:18:35 -04:00
Clinton Wolfe
fa41586910
Merge pull request #5446 from inspec/nm/fix-input-hash-access
Bug fix for loading hashmap inputs consistently
2021-04-07 08:49:53 -04:00
Nikita Mathur
82e126726b Improvements in hashmap profiles
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-04-07 16:09:27 +05:30
Nikita Mathur
094293b01d Refactored logic to enable hash indifference in all input types
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-04-05 16:10:55 +05:30
Nikita Mathur
ec30fc3d4e Hash with indifference changes for inputs used via runner api
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-04-05 14:41:35 +05:30
Nikita Mathur
a55b083b0a Improvements in various descriptions and a better way to check for hash type
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-03-31 12:35:13 +05:30
Nikita Mathur
c0b213c46a Bug fix for loading hashmap inputs consistently from external and metadata file
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-03-31 11:42:54 +05:30
Clinton Wolfe
8df0fb0814 Functional tests for command resource timeout
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2021-03-29 21:46:25 -04:00
Vasu1105
a0d669a0f0 Updated test so that can run in the test enviornment
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-03-25 19:15:50 +05:30
Vasu1105
7c25a2b5df Updated test
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-03-25 15:50:23 +05:30
Vasu1105
0a62a6ac3b Added functional test for FilterTable::ExceptionCatcher
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-03-25 15:50:22 +05:30
Vasu1105
45e9288e90 Revert "Profile to test the FilterTable::ExceptionCatcher issue"
This reverts commit 33e096f0854c0f156130fe610ab3ab8f8b65cad4.
2021-03-25 15:50:22 +05:30
Vasu1105
805cf46848 Profile to test the FilterTable::ExceptionCatcher issue
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-03-25 15:50:22 +05:30
Clinton Wolfe
3038ffa807
Merge pull request #5435 from collinmcneese/profile_init 2021-03-19 10:19:26 -04:00
Vasu1105
b180914889 Updated test for --controls option
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-03-19 16:10:12 +05:30
Vasu1105
9a404f5e0f Fixed failing test in inputs_test.rb
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-03-19 16:10:12 +05:30
Vasu1105
a5932b7da7 Fixes 5215: While using --controls options the control block was also getting evaluated as filtering of the control was happening after evaluating so added the filter logic in the control_eval_context. Also when we have describe block outside control block we are we
generating a control for them automatically and then execute due that also becomes a control and has to add same logic to filter the control in that mehtod

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-03-19 16:10:12 +05:30
Vasu1105
df8d589e25 Removed readme file from test profile
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-03-19 16:10:12 +05:30
Vasu1105
b4d319610a Fixing test cases
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-03-19 16:10:11 +05:30
Vasu1105
6853f6450e Added test to catch the control execution issue while using controls option
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-03-19 16:10:11 +05:30
Collin McNeese
88f6d99be3
updates test fixutres for cloud profiles to use inputs instead of attributes
Signed-off-by: Collin McNeese <cmcneese@chef.io>
2021-03-17 11:39:42 -05:00
mbaitelman
974d78af76 Add head test
Signed-off-by: mbaitelman <mendy@baitelman.com>
2021-03-09 21:42:50 -08:00
mbaitelman
ad1bf219eb Merge remote-tracking branch 'upstream/master' into add-http-for-windows-2
Signed-off-by: mbaitelman <mendy@baitelman.com>
2021-03-08 06:47:36 -08:00
mbaitelman
4ad11e8103 fixed tests
Signed-off-by: mbaitelman <mendy@baitelman.com>
2021-03-07 23:58:50 -08:00
Vasu1105
216306a219 removed unwanted README files from test fixtures and fixed some minor copy paste test
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-03-05 16:29:30 +05:30
Vasu1105
7dba4fa641 Fixes #5373 : Add option to filter empty profiles from report
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2021-03-04 22:09:48 +05:30
Clinton Wolfe
b425f1d6b9
Merge pull request #5414 from inspec/cw/ssh_conf_first_value 2021-02-23 12:05:44 -05:00
Clinton Wolfe
d22a1bd931 Failing unit test for multiple values in ssh_config
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2021-02-21 15:06:18 -05:00
Clinton Wolfe
b07b85f582 Failing test case for deep skip_control issue 5300
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2021-02-16 17:59:14 -05:00
David Marshall
874ee77791 add test for when run is not specified in waiver
The existing documentation explicitly claims that not specifying “run” in a waiver is equivalent to specifying “run: false.” It turns out to be the case that the claim is completely false. This commit includes a test for a new control 18_waivered_no_expiry_default_run that behaves exactly like the control 04_waivered_no_expiry_ran_fails. That is, not specifying run in a waiver is the same as specifying “run: true.”

Signed-off-by: David Marshall <dmarshall@gmail.com>
2020-12-28 16:26:19 -08:00
Clinton Wolfe
cdfb325ca3 Apply chefstyle -a, and manually remove duplicate requires
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-12-21 13:25:04 -05:00
Nick Schwaderer
acf2b2bbab Reverts without bug
Signed-off-by: Nick Schwaderer <nschwaderer@chef.io>
2020-11-23 15:49:52 +00:00
Nick Schwaderer
0860e631a7 Revert "Supply resource name, params to code_desc"
This reverts commit 345a832eb1.

Signed-off-by: Nick Schwaderer <nschwaderer@chef.io>
2020-11-23 15:46:19 +00:00
Nick Schwaderer
345a832eb1 Supply resource name, params to code_desc
Signed-off-by: Nick Schwaderer <nschwaderer@chef.io>
2020-11-19 09:59:53 +00:00
mbaitelman
58fd1311c5 Add test fixture
Signed-off-by: GitHub <noreply@github.com>
2020-10-16 18:02:31 +00:00
IanMadd
6a592a6db2 Update various readmes and docs
Signed-off-by: IanMadd <imaddaus@chef.io>
2020-09-14 14:09:23 -07:00
Nick Schwaderer
94224e0695
Merge pull request #5210 from Udyrfrykte/master
Improve handling of bracketed options in deb source
2020-09-14 15:56:25 +01:00
Nick Schwaderer
6a60b456ba
Merge pull request #5054 from inspec/cw/run-data-filters
RunData Filters; sensitive inputs; suppress diff; sorted output
2020-08-27 11:15:57 +01:00
Udyrfrykte
fe74f4fd5b Improve apt.rb's read_debs
Make it better at handling whitespace in bracketed options

Signed-off-by: Benoît Gastinne <Udyrfrykte@users.noreply.github.com>
2020-08-17 11:38:40 +02:00
Tim Smith
303f530850 Update to Chefstyle 1.2.1
Update a few cop names
Remove redundant returns

Signed-off-by: Tim Smith <tsmith@chef.io>
2020-08-12 13:12:26 -07:00
Clinton Wolfe
a839d4602c Add ability to sort results in reporting phase
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-08-10 14:32:08 -04:00
Clinton Wolfe
3aca12d622 Add option to suppress diff output
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-08-10 14:31:28 -04:00
Clinton Wolfe
ceca77e118 Mark inputs as sensitive
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-08-10 14:30:11 -04:00
Felipe Zipitria
d2ae7a7fbf
fix(osfamily): use corresponding family or name for bsd/freebsd
Signed-off-by: Felipe Zipitria <fzipitria@perceptyx.com>
2020-07-22 08:43:25 -03:00
Nick Schwaderer
2744ff43e5
Merge pull request #5128 from james-stocks/js/report_bad_profiles
Report faulty profiles instead of crashing
2020-07-15 13:28:17 +01:00
Nick Schwaderer
934aa8d49a
Merge pull request #5138 from jrbeilke/bug-apt-cdrom
skip apt-cdrom repos in apt resource when parsing lists
2020-07-14 11:49:21 +01:00
Nick Schwaderer
6d340b323c Allow ‘=‘ character in CLI inputs
Fixes #5131

Due to the use of `#split(‘=‘)` against inputs supplied via the CLI we had an edge case where inputs with `’=‘` in the value would cause a breakage.

This PR supplies a test for the regression and fixes the bug with a regex solution.

Signed-off-by: Nick Schwaderer <nschwaderer@chef.io>
2020-07-09 12:50:21 +01:00
Jon Beilke
bedef776a6 skip apt-cdrom repos in apt resource when parsing lists
Signed-off-by: Jon Beilke <Jonathan.Beilke@windlogics.com>
2020-07-08 14:19:09 -05:00
James Stocks
41087c5ec6 Set profiles that fail to load as failed
Signed-off-by: James Stocks <jstocks@chef.io>
2020-07-02 13:33:07 +01:00
Clinton Wolfe
d9007588a6 Add an heuristic-based IP lookup property
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-18 15:37:19 -04:00
Clinton Wolfe
52468e470e Barebones plural interfaces resource
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-18 15:37:19 -04:00