Mirrors/inspec
2
0
Fork 0
mirror of https://github.com/inspec/inspec synced 2024-12-19 17:43:44 +00:00
Code Issues Projects Releases Packages Wiki Activity
8510 commits 458 branches 1907 tags 77 MiB
Commit graph

1263 commits

Author SHA1 Message Date
Miah Johnson
de4139aff8
Merge pull request #4568 from ramereth/yum-el8-support 
Improve testing for yum.repo in CentOS 8
 2019-10-31 14:13:05 -07:00
Ryan Davis
74c692c9eb Pushed unmock up to helper.rb 
Also switched osx group test to use quick_resource since it is cleaner.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-10-31 14:09:16 -07:00
Ryan Davis
fdc82b7d12 Tests shouldn't output. Ever. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-10-31 14:09:16 -07:00
Ryan Davis
defe63dada Test for bug #4524 and bug #4587 to verify that resources are available w/in rspec constructs. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-10-31 14:09:16 -07:00
Miah Johnson
314715d9f8 let there be tests 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-10-30 19:11:38 -07:00
Miah Johnson
9173674ecd Unsure why old mocking system is broken. 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-10-30 17:27:01 -07:00
Landy Chan
9e38bec396 Added wildcard and dot-prefixed identifier support. Combined regex identifier into standard identifier 
Signed-off-by: Landy Chan <landychan92@gmail.com>
 2019-10-30 16:39:38 -07:00
Landy Chan
e60179b91f Added regex identifier 2019-10-30 13:51:20 -07:00
Miah Johnson
66cb95b2ca Add tests to cover Linux/Windows differences in sqlplus execution 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-10-30 12:26:12 -07:00
Miah Johnson
9c953a0e68
Merge pull request #4638 from inspec/mj/eha 
Add #to_s to etc_hosts_allow, and add tests
 2019-10-24 13:24:46 -07:00
Miah Johnson
44579ab4b3
Merge pull request #4637 from inspec/mj/3921 
Fix filesystem resource when device has long name
 2019-10-24 13:24:23 -07:00
Miah Johnson
ac399b7af9 Add #to_s to etc_hosts_allow, and add tests 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-10-24 12:07:26 -07:00
Lance Albertson
dab91a321a Improve testing for yum.repo in CentOS 8 
The output for ``yum -v repolist all`` changes slightly in CentOS 8. There are
two specific changes:

1. EL8 is no longer trailing the repo name with release version and arch (i.e.
   base instead of base/7/x86)
2. EL8 no longer adds a trailing newline on the last repo and instead has a line
   with ``Total packages:``. This means the repo listed last will never show up.

A fix was introduced in #4566 however the tests still use CentOS 7 yum output
instead of dnf repolist output. One issue was still discovered where it was
including the ``Total packages`` line in the last repository. This includes a
regex for to work around that and fixes for the tests.

Signed-off-by: Lance Albertson <lance@osuosl.org>
 2019-10-24 08:22:42 -07:00
Miah Johnson
8e31367b51 Use new mock loader, update the command name 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-10-23 21:42:10 -07:00
Miah Johnson
e357232db1 Since our command is df -PT lets match it in name 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-10-23 21:33:29 -07:00
Ryan Davis
8d51d878f6 Fixed users resource when "Last password change" is "never". 
Extended quick_resource to have platform methods and a new string
command mock. The named resource to mock may now be a symbol.

Added a new test that shows how to use quick_resource with multiple commands.

Fixes #4629.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-10-23 16:49:49 -07:00
Ryan Davis
dd3043a992
Merge pull request #4619 from inspec/zenspider/empty-tarball 
Fix TarProvider when the tarball has empty files in it.
 2019-10-21 12:31:29 -07:00
Ryan Davis
e4f4f5d1cc Fix TarProvider when the tarball has empty files in it. 
Added a unit test that runs in ~0.1s. Let's avoid heavy integration
tests where possible.

Fixes #4616

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-10-18 14:30:00 -07:00
Ryan Davis
3d604348a4
Merge pull request #4566 from inspec/zenspider/mock 
Refactored and added an alternative test mock resource system.
 2019-10-18 13:36:42 -07:00
Ryan Davis
fc8ea79ad0 Fixed parsing yum output on centos8. 
* Renamed and added extra test data to distinguish between centos 7 & centos 8.
* Renamed and added extra tests to cover centos 8.
* Fixed missing repo data by checking at the end if we were still in parse mode.

Fixes #4517

Signed-off-by: Ryan Davis <zenspider@chef.io>
Cc: Miah Johnson <miah@chia-pet.org>
 2019-10-16 16:54:07 -07:00
Ryan Davis
201d98fd26 Refactored and added an alternative test mock resource system. 
test/unit/resources/json_test.rb had the start of a setup to directly
instantiate resources. I've refactored that up to helper.rb and
extended it with some helper methods so we can directly specify what a
resource command should respond with. For many/most of our tests, this
should be sufficient.

Finally, I switched our yum tests over to use the new setup. This will
allow us to address #4517 and extend the tests for centos8 output
differences with ease. Ease, folks... ease.

Signed-off-by: Ryan Davis <zenspider@chef.io>
Cc: Miah Johnson <miah@chia-pet.org>
 2019-10-16 16:54:07 -07:00
Miah Johnson
d48bb56087 Every other example has the value set to 1, so I changed this for consistency. 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-10-16 10:15:49 -07:00
Miah Johnson
a40ec993e8 Rename files to remove references to gordon 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-10-16 10:13:24 -07:00
Miah Johnson
df7efefc9d mostly a search and replace for gordon -> example 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-10-16 10:13:24 -07:00
Clinton Wolfe
bde308f72d
Replace input to_hash method, and add unit test for it (#4545) 
Replace input to_hash method, and add unit test for it
 2019-10-11 10:50:27 -07:00
Clinton Wolfe
b09edbbbf9 And the YAML fixture too. 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-10-09 20:49:33 -07:00
Clinton Wolfe
8f4ff8923e Add functional test to exercise waivers during profile inheritance 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-10-09 19:10:48 -07:00
Ryan Davis
f9ec3053aa Refactored unit test to be more like the other one. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-10-09 17:41:03 -07:00
Ryan Davis
26ffea8d39 Make my diffs pretty for jsonmin tests. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-10-09 17:40:53 -07:00
Ryan Davis
f3fc535fee Changed formatting and ordering of test data to reduce diffs on failing tests. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-10-09 17:40:31 -07:00
Clinton Wolfe
d150a568cd More test fixes 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-10-09 17:20:24 -07:00
Clinton Wolfe
01991cc347 Update some failing test fixtures 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-10-08 21:00:11 -07:00
Clinton Wolfe
0f5fde9729 Modify waiver input file to use 'run' subfield instead of 'skip' 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-10-08 01:03:40 -07:00
Clinton Wolfe
88ed1794cb Revert to a small amount of duplicating to_hash in inspec/input.rb 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-10-06 19:30:37 -04:00
Miah Johnson
e48d08343b
Merge pull request #4452 from mhackethal/user-windows-fix 
User windows fix
 2019-10-04 15:30:37 -07:00
Clinton Wolfe
11074bb7ce Adjust indentation 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-10-04 14:06:49 -04:00
Clinton Wolfe
36db8b9a7b Rely on copy of to_hash in objects/input.rb to avoid duplication 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-10-04 14:05:19 -04:00
Clinton Wolfe
51812a9e4e Replace to_hsh method, and add unit test for it 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-10-04 14:05:19 -04:00
Miah Johnson
416c33e056 Add name property to interface resource 
Also some general cleanup.

Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-10-03 14:53:43 -07:00
Ryan Davis
6fd2db256d
Merge pull request #4560 from inspec/zenspider/apt 
Fixed apt resource incorrectly parsing deb files w/ quoted URIs.
 2019-10-03 14:50:48 -07:00
Ryan Davis
07dc5e3192 First pass at cleaning deprecations for old minitest/spec-style tests. 
3 files left to go, and they're behaving oddly so I'm leaving them out
in this pass. Looks like 21 deprecations left.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-10-03 13:45:19 -07:00
Ryan Davis
09392943f5 Fixed apt resource incorrectly parsing deb files w/ quoted URIs. 
Fixes #4559.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-10-03 12:55:15 -07:00
Ryan Davis
708a319ce8 Fixed tests to work with rspec-expectations 3.8.5+. 
We were using a "private" method in our tests and they changed the
signature.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-10-02 18:08:19 -07:00
Ryan Davis
866efdf141
Merge pull request #4531 from inspec/mj/wtf_rake 
Remove maintainers task from require
 2019-09-27 14:45:21 -07:00
Ryan Davis
984e02e312 Quick fix for faraday_middleware bug introduced when bumping to faraday 0.16.0. 
Namespacing changed in faraday from Faraday::Error::* to Faraday::*
but was not reflected in faraday_middleware (which hasn't released
since February). I will file an issue and/or PR with them later.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-27 14:19:45 -07:00
Ryan Davis
ca4844210d Fixed Inspec::Plugin::V2::Registry#detect_system_plugins 
+ Falls back to checking for inspec-core if inspec not found.
+ Fails gracefully if neither are found.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-25 16:10:00 -07:00
Mendy Baitelman
d44f9edc55 Merge remote-tracking branch 'upstream/master' into add-startuser-systemd-service 
Signed-off-by: Mendy Baitelman <mendy@baitelman.com>
 2019-09-24 22:30:51 -07:00
Mendy Baitelman
d45963cd91 Fix spacing 
Signed-off-by: Mendy Baitelman <mendy@baitelman.com>
 2019-09-24 21:58:55 -07:00
Mendy Baitelman
76cd799c92 Add to params for tests 
Signed-off-by: Mendy Baitelman <mendy@baitelman.com>
 2019-09-24 21:49:29 -07:00
Irving Popovetsky
bbb927e3dd Remove invalid test cases for tags 
Signed-off-by: Irving Popovetsky <irving@chef.io>
 2019-09-17 15:58:12 -07:00
Irving Popovetsky
4aebe87c2e Update unit tests to match 
Signed-off-by: Irving Popovetsky <irving@chef.io>
 2019-09-17 15:58:12 -07:00
Ryan Davis
a0a7917faa
Merge pull request #4485 from inspec/zenspider/objects-inputs 
Split out Inspec::Input functional code from the code generation code.
 2019-09-16 17:03:49 -07:00
Ryan Davis
e375ea30c8 Split out Inspec::Input functional code from the code generation code. 
Includes moving errors into Inspec::Input and Inspec::InputRegistry.

Fixes #4456.
Fixes #4473.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-13 17:12:20 -07:00
mhackethal
c3270b537a update user_test.rb 
Signed-off-by: mhackethal <mh@it31.de>
 2019-09-13 21:19:20 +02:00
mhackethal
0b76859728 adjust user_test.rb 2019-09-13 20:45:54 +02:00
mhackethal
9e06f02e27
Update user_test.rb 
adjust expectation of methods to be "nil" on windows
 2019-09-13 13:14:34 +02:00
Miah Johnson
008ac9705b
Merge pull request #4484 from timgates42/feature/typo_becuase 
Fix simple typo: becuase -> because
 2019-09-12 17:25:37 -07:00
Tim Gates
f1e88ca65f
Fix simple typo: becuase -> because 
Obvious Fix.
 2019-09-13 09:30:00 +10:00
Clinton Wolfe
8132aaf85c
Merge pull request #3844 from inspec/ja/add-error-output-to-json-command 
json resource: Add handling for `command:` error
 2019-09-11 11:12:26 -04:00
Ryan Davis
a2b6517f9a skip a test when on windows 
(and make it more compatible for when it does work)

Blocked by #4465.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-10 14:19:42 -07:00
Ryan Davis
fcfcc354fe Reworked test cases and impl to only respond to output, not exit code. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-10 14:19:42 -07:00
Ryan Davis
dfce5e722f
Merge pull request #4427 from inspec/cw/waivers-overlay 
waivers: functional test fixture and eval-time skipping
 2019-09-09 18:41:37 -07:00
Ryan Davis
f5bbfe5fac
Merge pull request #4365 from inspec/zenspider/the-need-for-speed 
Make inspec much faster for most commands.
 2019-09-09 18:02:10 -07:00
Jerry Aldrich
0e1b3fa65a json resource: Add handling for command: error 
This provides the user with messages if `json(command: 'command_that_errors')`
exits non-zero and/or has STDERR.

Without this the resource will report "No output from command" when really the
output is contained in STDERR.

Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-09-09 15:16:34 -07:00
Ryan Davis
79b9c3cbad
Merge pull request #4451 from inspec/zenspider/fix-tarball-decoding 
Try to decode archive contents to UTF-8 to avoid encoding corruption.
 2019-09-09 11:13:48 -07:00
Clinton Wolfe
43bc7e0343 Modify @__skip_rule to distinguish only_if and waiver, and force waiver to win 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-09-09 11:29:26 -04:00
Clinton Wolfe
0db0a2bfdc Don't assume waiver_ prefix in waiver files 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-09-09 11:29:26 -04:00
Clinton Wolfe
718e205cf2 Alter expiration_date behavior to match spec 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-09-09 11:29:26 -04:00
Clinton Wolfe
eb1ec437d7 Linting and test number corrections 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-09-09 11:29:26 -04:00
Clinton Wolfe
77b4e45175 Test fixture profile and input file for waivers 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-09-09 11:29:26 -04:00
mhackethal
6772f0b301
Update user_test.rb 2019-09-06 11:42:51 +02:00
Ryan Davis
d19d0bfd7c Refactor tests for TarProvider and ZipProvider a bit. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-06 00:42:36 -07:00
Ryan Davis
6e821e787e Save off supports[:os] and restore it after each test. 
This fixes some other tests that require supports[:os] to be correct.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-04 15:44:26 -07:00
Ryan Davis
6296fdc688 Replace backticks in test descriptions with single-quotes. 
Backticks means you can't selectively run one of these tests w/o
subshelling out to `brew`, or having to edit first.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-04 15:44:26 -07:00
Ryan Davis
3b69967cc8 Fixed a bug in checking supports (strings vs symbols) 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-04 15:44:26 -07:00
Ryan Davis
b6bfeffd9e Make inspec much faster for most commands. 
Removes pre-loading and registration of resources by adding
method_missing to a couple key areas.

This still drops the ball in some areas, but it is a start.
 2019-09-04 15:44:26 -07:00
Lance Albertson
1e94e3503e Fix for postfix_conf when using a non-standard config location 
Pass the first argument of the opts array instead of the whole array which
confuses the SimpleConfig parser. Also added a test which verifies this fixes
the issue.

In addition, change the base_name to something that matches other resource base
names.

Signed-off-by: Lance Albertson <lance@osuosl.org>
 2019-09-03 15:28:44 -07:00
mhackethal
204c41bfd1 Update users.rb to include new attributes 2019-08-30 22:07:36 +02:00
Clinton Wolfe
a6bd7ec4b5
Merge pull request #4401 from inspec/cw/input-from-cli 
inputs: Accept bare input from the command line
 2019-08-28 15:41:21 -04:00
Clinton Wolfe
51de566d93 Assert adjustments 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-28 13:25:49 -04:00
Clinton Wolfe
82acec957e Add API for fetching plugin vconfig values. 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-28 13:25:49 -04:00
Clinton Wolfe
38f3469ee3 Validation for the plugins area of the config file 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-28 13:25:49 -04:00
Clinton Wolfe
c6d355e4f7 Accept version 1.2 for config file format 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-28 13:25:49 -04:00
Clinton Wolfe
296158c447 Implementation and functional tests for the --input CLI option 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-28 13:03:42 -04:00
Clinton Wolfe
777f1a1bff Adjust checking for version when installing latest in unit test 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:29:42 -04:00
Clinton Wolfe
18640dd70c We do now include the version in the float fixture, for one thing 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:29:42 -04:00
Clinton Wolfe
16fecbefb5 Return version number when listing plugins; correct UX coloration 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:29:42 -04:00
Clinton Wolfe
f90a4c633d
Merge pull request #4419 from inspec/cw/check-enforce-version 
inspec check: warn if inspec_version is not supported by current inspec
 2019-08-27 20:03:19 -04:00
Clinton Wolfe
714dc26006 Add unit test and include runtime version check in metadata.valid 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-26 23:05:49 -04:00
Clinton Wolfe
424318defa Stringify expected test outcomes for inputs 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-26 14:56:39 -04:00
Clinton Wolfe
fffb776982 Add newline 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-22 21:53:02 -04:00
Clinton Wolfe
cc4aa16212 Add test framework to run Runner API input tests 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-19 13:51:51 -04:00
David Gasper
ee2806a342 Fix RuboCop issues 
Signed-off-by: David Gasper <dmgasper@osuosl.org>
 2019-08-08 14:32:19 -07:00
David Gasper
52ae5e434b Add docs and unit tests, remove .travis.yml 
Signed-off-by: David Gasper <dmgasper@osuosl.org>
 2019-08-08 13:54:35 -07:00
Clinton Wolfe
95e6bcb317
Modified DarwinGroup to collect all users properly. (#4343) 
group resource: Modified DarwinGroup to collect all users properly on macos
 2019-08-08 11:55:48 -04:00
Ryan Davis
374e365c02 Modified DarwinGroup to collect all users properly. 
I noticed that my profile targeting group "staff" on OSX wasn't
returning *me*. I'm awesome! So that seemed wrong. And it turns out it
is wrong. We were not collecting any users whose primary group was
that group. (almost all regular users are in group staff and they're
all missing).

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-07 20:27:13 -07:00
Mendy Baitelman
b2c29da936 Use dbus for testing 
Signed-off-by: Mendy Baitelman <mendy@baitelman.com>
 2019-08-06 21:34:46 -07:00
Mendy Baitelman
db58322d41 Add startname to systemd server 
Signed-off-by: Mendy Baitelman <mendy@baitelman.com>
 2019-08-06 21:04:52 -07:00
Mendy Baitelman
988357aad1 Fix tests 
Signed-off-by: Mendy Baitelman <mendy@baitelman.com>
 2019-08-06 18:58:03 -07:00
Clinton Wolfe
4f6d296a22 The error case in which the path does not exist 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-30 13:38:02 -04:00
Clinton Wolfe
860d21a370 Test for ./ 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-30 13:38:02 -04:00
Clinton Wolfe
31bedf7b37 Empty-string edge case 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-30 13:38:02 -04:00
Clinton Wolfe
fab58b590e Combo relative test in place 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-30 13:38:02 -04:00
Clinton Wolfe
e9ef8e25a3 Deep dependency works 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-30 13:38:02 -04:00
Clinton Wolfe
80241ec971 Passing basic test harness 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-30 13:38:02 -04:00
Clinton Wolfe
12fcb24932 Experiment with git subrepo storage 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-30 13:36:20 -04:00
Clinton Wolfe
f1a892c857 Move existing git fixture profile to a directory for git-fetchers 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-30 13:36:20 -04:00
Ryan Davis
1e2da6acc2 Moved another non-test to test/unit/mock/files 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-07-29 11:42:30 -07:00
Ryan Davis
4df8072665 These tests probably never passed. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-07-29 11:42:30 -07:00
Ryan Davis
be11d8898d Found more tests that we've probably never actually run. 
*sigh*

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-07-29 11:42:30 -07:00
Clinton Wolfe
be91550343
windows_task: Fix handling of multiple triggers (#4242) 
windows_task: Fix handling of multiple triggers
 2019-07-29 13:00:16 -04:00
Ryan Davis
917a531a92 Skipped all failing tests on windows AT the failures site. 
This activates a BUNCH of tests but keeps us green.

Whether these tests are valid or not is not being addressed here.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-07-24 18:09:08 -07:00
Ryan Davis
c6837a3915 Moved skip_windows! to top helper and extended date to end of next month. 
Fixed up requires in v2/installer_test.rb so it sees the top helper.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-07-24 18:06:25 -07:00
Ryan Davis
6dfa1d8310 Um. No. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-07-24 18:06:25 -07:00
Ryan Davis
bd79e9c895
Merge pull request #4316 from inspec/zenspider/fix-file-aws 
Fix exceptions when resources are used with incompatible transports
 2019-07-23 11:47:13 -07:00
Ryan Davis
7a1e1bb775
Merge pull request #4230 from yeoldegrove/sys_info 
add resource sys_info.manufacturer and sys_info.model
 2019-07-22 14:39:28 -07:00
Ryan Davis
7de549577c Return keys are really nice. 
They make code more readable by visually separating different sections
of text.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-07-22 14:19:15 -07:00
Ryan Davis
d3df69213b Fix handling using resources with incompatible resources (eg file + aws). 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-07-22 14:19:15 -07:00
Clinton Wolfe
12b577fccd linting 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-22 15:17:30 -04:00
Clinton Wolfe
b37d165878 Unit test for suppressing doc install 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-22 15:17:30 -04:00
Eike Waldt
da4168f83d
add darwin/OSX tests 
Signed-off-by: Eike Waldt <waldt@b1-systems.de>
 2019-07-16 21:53:19 +02:00
Eike Waldt
9c06a0c8e2
refactor tests for resource sys_info.manufacturer and sys_info.model 
Signed-off-by: Eike Waldt <waldt@b1-systems.de>
 2019-07-16 21:02:52 +02:00
Eike Waldt
9278d8109d
add tests for resource sys_info.manufacturer and sys_info.model 
Signed-off-by: Eike Waldt <waldt@b1-systems.de>
 2019-07-16 21:02:45 +02:00
Eike Waldt
474d70b78d
fix description on sys_info.hostname tests 
Signed-off-by: Eike Waldt <waldt@b1-systems.de>
 2019-07-16 20:39:38 +02:00
Clinton Wolfe
f4b9bc4b0b rework filtertable call and add rubocop exception 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-11 15:04:38 -04:00
Miah Johnson
a4f4fe5231 chefstyle -a; https://github.com/chef/chefstyle/pull/74 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-07-08 17:22:50 -07:00
Miah Johnson
8272d0184b
Merge pull request #4236 from ramereth/ip6tables 
Add ip6tables resource
 2019-07-08 11:45:33 -07:00
Clinton Wolfe
e4e7c255de Automated chefstyle application for rubocop 0.72 compatibility 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-03 17:24:41 -04:00
Jerry Aldrich
5e93c4b12e Appease RuboCop 
Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-07-01 22:45:04 -07:00
Jerry Aldrich
dafa4f4165 Try to appease Code Climate 
I...I don't know how to make it better.

Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-07-01 22:39:12 -07:00
Jerry Aldrich
668b8d82bf windows_task: Fix handling of multiple triggers 
When using `schtasks` a list is returned if the task has multiple
triggers. This merges that list with the last item taking precedence.
This is how `Get-ScheduledTask` behaves.

Initially, I was going to rewrite this resource to use
`Get-ScheduledTask` but the original author purposely did not do this
so that PowerShell v3 would be supported. We only support PowerShell
v5, but I don't want to break any current users and this change didn't
seem to controversial to me.

If it gives us trouble, I recommend rewriting it to use
`Get-ScheduledTask`.

Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-06-28 00:27:53 -07:00
Lance Albertson
3263d76627 Add ip6tables resource 
This should resolve #1011 which provides an ip6tables resource to test IPv6
iptables rules. This is essentially a copy of the iptables resource with a few
renames.

In addition, I've pulled in the integration tests for iptables into ip6tables
and enabled it on docker so that it properly gets tested regularly. The test
cookbook recipe has been updated to support all of the current platforms that
are being tested.

Signed-off-by: Lance Albertson <lance@osuosl.org>
 2019-06-24 17:01:34 -07:00
Jared Ledvina
45713b2627
Service add Debian 10 test 
Signed-off-by: Jared Ledvina <jared@techsmix.net>
 2019-06-22 13:23:32 -04:00
Ryan Davis
902d7b563c Set the umask on travis in before_install. 
https://travis-ci.community/t/file-permissions-just-gone-up-to-664/1547/5

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-06-19 16:40:24 -07:00
Jerry Aldrich
80c595ba3d nginx_conf: Fix commented/empty file parsing 
This fixes `nginx_conf.params` when:
  - Given an empty file
  - Given a file with only comments
  - Given a file that has an include for a file that:
    - Is empty
    - Has all lines commented out

This also fixes a test where a missing file is actually empty

Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-06-17 21:57:26 -08:00
Miah Johnson
b21bcfabc4 Lets discuss this next week when we're all around =) 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-06-14 15:04:26 -07:00
Clinton Wolfe
dea323fa52 Test fixtures and failing functional test for input rename 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-06-12 19:00:53 -04:00
Clinton Wolfe
ab6933fcc7 A key value-add use of company time 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-06-12 13:05:49 -04:00
Clinton Wolfe
d8e485eb62 Edit the masrshalling code more carefully to match 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-06-12 12:51:02 -04:00
Clinton Wolfe
0023906812 Update test code regarding input marshalling 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-06-12 12:25:45 -04:00
Clinton Wolfe
46624396c7 Bulk edit of test files to use input() in DSL 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-06-12 12:17:19 -04:00
Ryan Davis
fae4230a41 Removing inspec/profile_vendor from inspec/base_cli. 
This was the next most expensive require in the analysis.

Also rearranged the way that ui handled tables to be lazy.

```
% SLOW=1 time rake test:functional

before: Finished in  681.514579s, 0.5136 runs/s, 2.9919 assertions/s.
after : Finished in  642.655918s, 0.5446 runs/s, 3.1728 assertions/s.
```

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-06-11 19:16:58 -07:00
Ryan Davis
692d6a9ab8 hand applied one that is now marked as unsafe in rubocop 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-06-11 18:52:38 -07:00
Miah Johnson
68e540a15a Ignore Rubocop checks 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-06-11 18:52:38 -07:00
Miah Johnson
e46018a517 chefstyle -a cleanup 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-06-11 18:52:38 -07:00
Ryan Davis
a5309ea392 blindly applied chefstyle -a 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-06-11 18:52:03 -07:00
Clinton Wolfe
1628383c8f Mis-spelled a method name 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-06-06 12:51:22 -04:00
Clinton Wolfe
9366804335 PR Feedback 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-06-06 12:51:22 -04:00
Clinton Wolfe
4b1ee722b4 Functional test for event log 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-06-06 12:51:22 -04:00
Clinton Wolfe
90da768ef0 Move event creation to input_registry to simplify plugin authorship 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-06-06 12:51:22 -04:00