Commit graph

104 commits

Author SHA1 Message Date
Gokulakrishnan KS
14f546391f
Added fatal message check for postgres_session:query method (#7154)
* Added fatal message check for postgres_session:query method

Signed-off-by: Gokulakrishnan KS <Gokulakrishnan.KS@progress.com>

* Added empty new line for the new fixture

Signed-off-by: Gokulakrishnan KS <Gokulakrishnan.KS@progress.com>

---------

Signed-off-by: Gokulakrishnan KS <Gokulakrishnan.KS@progress.com>
2024-08-27 14:52:32 +05:30
Vasundhara Jagdale
ed033b9ac2
CHEF-7694 (CHEF-8271) : Fix security_policy resource returns array for non comma separated values (#6838)
* Adds unit test for more security policies

Signed-off-by: Vasu1105 <vasundhara.jagdale@progress.com>

* Fix for secuity_policy resource failing if policy includes single value in string format it returns array instead of string

Signed-off-by: Vasu1105 <vasundhara.jagdale@progress.com>

* Update code comments

Signed-off-by: Vasu1105 <vasundhara.jagdale@progress.com>

---------

Signed-off-by: Vasu1105 <vasundhara.jagdale@progress.com>
2023-11-08 18:46:36 +05:30
amlodzianowski
4c2aa78789
fix: ensure Invoke-WebRequest headers can be configured (#6484)
* fix: ensure Invoke-WebRequest headers can be configured

Signed-off-by: Adrian Mlodzianowski <amlodzianowski@logicworks.net>

* fix: use array for custom headers

Signed-off-by: Adrian Mlodzianowski <amlodzianowski@logicworks.net>

* test: add unit test for Windows simple HTTP request with headers

Signed-off-by: Adrian Mlodzianowski <amlodzianowski@logicworks.net>

---------

Signed-off-by: Adrian Mlodzianowski <amlodzianowski@logicworks.net>
Co-authored-by: Adrian Mlodzianowski <amlodzianowski@logicworks.net>
2023-05-15 21:28:48 -04:00
jjacque
33e148dae4
Add nftables resources (#6499)
* Fix systemd path for Leap image

Signed-off-by: Jeremy JACQUE <jeremy.jacque@algolia.com>

* Use vhef client version 17 as doocker cookbook do not support >= 18

Signed-off-by: Jeremy JACQUE <jeremy.jacque@algolia.com>

* Add nftables resource

Signed-off-by: Jeremy JACQUE <jeremy.jacque@algolia.com>

* Add nftables tests

Signed-off-by: Jeremy JACQUE <jeremy.jacque@algolia.com>

* Add fixtures for nftables tests

Signed-off-by: Jeremy JACQUE <jeremy.jacque@algolia.com>

* enable nftables only when attr is true - then disable iptables

Signed-off-by: Jeremy JACQUE <jeremy.jacque@algolia.com>

* By default test iptables, not nftables

Signed-off-by: Jeremy JACQUE <jeremy.jacque@algolia.com>

* Fix tests and lint errors

Signed-off-by: Jeremy JACQUE <jeremy.jacque@algolia.com>

* Increase unit test coverage for nftables

Signed-off-by: Jeremy JACQUE <jeremy.jacque@algolia.com>

* Do not use -nn nft option as behaviour changes based on nft version

Signed-off-by: Jeremy JACQUE <jeremy.jacque@algolia.com>

* Base nft params identification on its version, not os version

    Signed-off-by: Jeremy JACQUE <jeremy.jacque@algolia.com>

* Make test more human friendly by reversing unless/if logic

    Signed-off-by: Jeremy JACQUE <jeremy.jacque@algolia.com>

* Update mocked cmds with nft params

    Signed-off-by: Jeremy JACQUE <jeremy.jacque@algolia.com>

* Fix quoting issue with rubocop

Signed-off-by: Jeremy JACQUE <jeremy.jacque@algolia.com>

* Fix uninitiallized class vars

Signed-off-by: Jeremy JACQUE <jeremy.jacque@algolia.com>

* Fix unit test by adding nft version mocking

Signed-off-by: Jeremy JACQUE <jeremy.jacque@algolia.com>

* Clean nftables doc

Signed-off-by: Jeremy JACQUE <jeremy.jacque@algolia.com>

---------

Signed-off-by: Jeremy JACQUE <jeremy.jacque@algolia.com>
2023-05-15 20:05:01 -04:00
dtheyer
0695b0dbc8
Prevent negative status from crashing launchd service resource (#6262)
Signed-off-by: dtheyer <davidheyer2016@gmail.com>

Signed-off-by: dtheyer <davidheyer2016@gmail.com>
2022-11-29 09:37:12 -05:00
Sonu Saha
3bcf4e6544
Enhance lxc resource to test properties (#6243)
* ENHANCE: Extend lxc resource to test the properties

Signed-off-by: Sonu Saha <sonu.saha@progress.com>

* TEST: Extend test for introduced properties

Signed-off-by: Sonu Saha <sonu.saha@progress.com>

* DOCS: Extend test for introduced properties

Signed-off-by: Sonu Saha <sonu.saha@progress.com>

* FIX: Correct exception class to handle bad yaml

Signed-off-by: Sonu Saha <sonu.saha@progress.com>

* Doc Review

Signed-off-by: Deepa Kumaraswamy <dkumaras@progress.com>

* FIX: Handle specific exception to handle bad yaml

Signed-off-by: Sonu Saha <sonu.saha@progress.com>

Signed-off-by: Sonu Saha <sonu.saha@progress.com>
Signed-off-by: Deepa Kumaraswamy <dkumaras@progress.com>
Co-authored-by: Deepa Kumaraswamy <dkumaras@progress.com>
2022-09-15 09:23:45 -04:00
Vasundhara Jagdale
183d09c534
Adds podman resources. (#6183)
* CFINSPEC-368 Adds podman resource. Adds PodmanContainerFilter to handle podman.containers plural resource

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>

* Fix lint errors

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>

* Adds style simple to the filter table fields to flatten the array

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>

* CFINSPEC-368 Updated podman resource to work with podman images plural resource

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>

* CFINSPEC-368 Updated podman resource to work with podman networks plural resource

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>

* CFINSPEC-368 Updated podman resource to work with podman pods  plural resource

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>

* CFINSPEC-368 Updated podman resource to work with info and version parameter

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>

* CFINSPEC-368 Updated podman resource to work  with podman volumes plural resource. Also updated the docs to add pods, networks and other resource parameters details.

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>

* CFINSPEC-368 Updated podman resource to aspect object id to verify values of specified Podman object.

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>

* Updated docs

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>

* Updated column names to keep them same as the field names

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>

* Adds style simple to commands column for podman containers plural resource

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>

* CFINSPEC-360 Adds podman_container resource. Adds podman_object module

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>

* Fixed the require path

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>

* Fixed deprecation warning in unit test

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>

* Fixed indentation issue in the docs.

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>

* Renamed the methods names

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>

* Adds skip resource test

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>

* Updated podman.images to fetch only high level information as using query with low level information does not have required fields and represents the data in different way.

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>

* added method to parse command which uses format option to fetch specific placeholders

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>

* Update the podman,containers to fetch only high level information

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>

* Update podman.networks to fetch only hight level information

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>

* Removed style for where it is not required

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>

* Lint fix and some code improvisation

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>

* It turn out to be the docker object module can be utilized but still there is scope to rename that module to generic and not specific if going to use with other container management tools

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>

* Missing file in earlier commit

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>

* Content Review

Signed-off-by: Deepa Kumaraswamy <dkumaras@progress.com>

* CFINSPEC-361: Test for podman_image matchers and properties

Signed-off-by: Sonu Saha <sonu.saha@progress.com>

* CFINSPEC-361: Add podman_image matchers and properties

Signed-off-by: Sonu Saha <sonu.saha@progress.com>

* CFINSPEC-361: Documentation for podman_image matchers and properties

Signed-off-by: Sonu Saha <sonu.saha@progress.com>

* CFINSPEC-361: Fix Rubocop lint issues

Signed-off-by: Sonu Saha <sonu.saha@progress.com>

* CFINSPEC-361: Test for more properties

Signed-off-by: Sonu Saha <sonu.saha@progress.com>

* CFINSPEC-361: Add more podman_image properties

Signed-off-by: Sonu Saha <sonu.saha@progress.com>

* CFINSPEC-361: Documentation for podman_image properties

Signed-off-by: Sonu Saha <sonu.saha@progress.com>

* CFINSPEC-361: Test for low-level information of image

Signed-off-by: Sonu Saha <sonu.saha@progress.com>

* CFINSPEC-361: Add inspec_info property to test low-level info

Signed-off-by: Sonu Saha <sonu.saha@progress.com>

* CFINSPEC-361: Documentation for inspec_info property

Signed-off-by: Sonu Saha <sonu.saha@progress.com>

* CFINSPEC-361: Modify resource id to avoid dependency on other methods

Signed-off-by: Sonu Saha <sonu.saha@progress.com>

* CFINSPEC-361: Decouple podman_image from podman plural resource

Signed-off-by: Sonu Saha <sonu.saha@progress.com>

* CFINSPEC-361: Modify unit test and reqd fixtures

Signed-off-by: Sonu Saha <sonu.saha@progress.com>

* CFINSPEC-361: Handle nil scenario of inspect_info

Signed-off-by: Sonu Saha <sonu.saha@progress.com>

* CFINSPEC-361: Add missing property: id

Signed-off-by: Sonu Saha <sonu.saha@progress.com>

* CFINSPEC-361: Update documentation

Signed-off-by: Sonu Saha <sonu.saha@progress.com>

* CFINSPEC-361: Rename method and attribute name as suggested

Signed-off-by: Sonu Saha <sonu.saha@progress.com>

* CFINSPEC-361: Add stderr message in exception

Signed-off-by: Sonu Saha <sonu.saha@progress.com>

* CFINSPEC-361: Remove comment

Signed-off-by: Sonu Saha <sonu.saha@progress.com>

* CFINSPEC-361: Move json_key mapping to a method

Signed-off-by: Sonu Saha <sonu.saha@progress.com>

* Content Review

Signed-off-by: Deepa Kumaraswamy <dkumaras@progress.com>

* CFINSPEC-361: Remove exception and add nil

Signed-off-by: Sonu Saha <sonu.saha@progress.com>

* CFINSPEC-351: failing tests for podman_network resource

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>

* CFINSPEC-351 Adds podman_network resource properties

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>

* Fixed typo in the test

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>

* Refactored the code for podman_image to handle non exisiting image and for creating dynamic methods for properties

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>

* Uncommented the image test

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>

* Update the example for podman_network

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>

* Missing test fixture file

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>

* Adds doc for podman_network resource

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>

* Doc Review

Signed-off-by: Deepa Kumaraswamy <dkumaras@progress.com>

* Adds module for podman to group all common methods

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>

* Updated code to match the stderr string for non existing image and network. Also added the test for the same. Added code comments.

Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>

* TEST: Add failing test for podman_volume (CFINSPEC-351)

Signed-off-by: Sonu Saha <sonu.saha@progress.com>

* RESOURCE: Add podman_volume properties & matcher (CFINSPEC-351)

Signed-off-by: Sonu Saha <sonu.saha@progress.com>

* TEST: Add mock cmds and fixtures for test to pass (CFINSPEC-351)

Signed-off-by: Sonu Saha <sonu.saha@progress.com>

* DOCS: Update documentation for podman_volume (CFINSPEC-351)

Signed-off-by: Sonu Saha <sonu.saha@progress.com>

* TEST: Add failing test for podman_pod (CFINSPEC-351)

Signed-off-by: Sonu Saha <sonu.saha@progress.com>

* RESOURCE: Add podman_pod properties & matcher (CFINSPEC-351)

Signed-off-by: Sonu Saha <sonu.saha@progress.com>

* TEST: Add mock cmds and fixtures for test to pass (CFINSPEC-351)

Signed-off-by: Sonu Saha <sonu.saha@progress.com>

* DOCS: Update documentation for podman_pod (CFINSPEC-351)

Signed-off-by: Sonu Saha <sonu.saha@progress.com>

* DOCS: Update properties of podman_volume (CFINSPEC-351)

Signed-off-by: Sonu Saha <sonu.saha@progress.com>

* LINT: Remove trailing whitespaces (CFINSPEC-351)

Signed-off-by: Sonu Saha <sonu.saha@progress.com>

* REFACTOR: Extend existing fixture, remove new fixtures (CFINSPEC-351)

Signed-off-by: Sonu Saha <sonu.saha@progress.com>

* Content Review

Signed-off-by: Deepa Kumaraswamy <dkumaras@progress.com>

Co-authored-by: Deepa Kumaraswamy <dkumaras@progress.com>
Co-authored-by: Sonu Saha <sonu.saha@progress.com>
2022-08-04 09:13:45 -04:00
Clinton Wolfe
29ef063833
Merge pull request #6100 from inspec/ss/fix-processes-on-windows
CFINSPEC-291: Fix `processes` resource to consider processes without `path` on Windows
2022-06-08 17:32:00 -04:00
Sonu Saha
8ffca97e27 CFINSPEC-291: Add windows test for process without path
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
2022-06-08 18:28:02 +05:30
Clinton Wolfe
9e52000088
Merge pull request #6041 from inspec/ss/enhance-x509_certificate-resource
CFINSPEC-95: Enhance `x509_certificate` resource
2022-06-01 09:36:05 -04:00
Sonu Saha
c3b1ce3e9e CFINSPEC-291: Fix test according to changes introduced in processes
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
2022-06-01 13:10:07 +05:30
Sonu Saha
b4f52dff23 CFINSPEC-81: Add unit test for php_config
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
2022-05-17 12:51:42 +05:30
Vasundhara Jagdale
b1c1b1bc92
Merge pull request #5991 from inspec/ss/enhance-processes-resource
CFINSPEC-92: Enhance `processes` resource
2022-05-17 06:01:55 +00:00
Vasundhara Jagdale
0978c8c274
Merge pull request #6045 from inspec/ss/enhance-host-resource
CFINSPEC-90: Enhance `host` resource
2022-05-17 06:01:15 +00:00
Sonu Saha
72a986ace3 CFINSPEC-90: Correct existing unit test for windows to include ipv6 address
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
2022-05-07 00:22:12 +05:30
Sonu Saha
82b86064d6 CFINSPEC-95: Add unit test for new matchers & properties
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
2022-05-06 15:55:16 +05:30
Sonu Saha
f1e03bab3a CFINSPEC-84: Add unit test for x509_private_key
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
2022-04-27 15:59:40 +05:30
Sonu Saha
870c4b4b99 CFINSPEC-92: Add unit test for introduced matcher & property
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
2022-04-20 21:18:27 +05:30
Sonu Saha
e7726bf7c2 CFINSPEC-78: Complete unit test for the resource
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
2022-04-19 09:33:07 +05:30
Sonu Saha
be4e6f7594 CFINSPEC-78: Add unit test for be_enabled and be_running
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
2022-04-19 09:33:01 +05:30
Clinton Wolfe
7fddb8c772
Merge pull request #5981 from inspec/ss/enhance-service-resource
CFINSPEC-93: Enhance `service` resource
2022-04-18 18:04:16 -04:00
Sonu Saha
c83f146687 CFINSPEC-87: Add unit test for new matcher & properties
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
2022-04-13 13:24:58 +05:30
Sonu Saha
bb47d7fe21 CFINSPEC-93: Extend unit test for introduced matchers
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
2022-04-12 10:51:58 +05:30
Sonu Saha
606049abf9 Add service -l mock called in FreeBSD10Init info
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
2022-04-11 19:37:02 +05:30
Sonu Saha
1759912ade CFINSPEC-83: Add unit test and associated changes
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
2022-04-06 21:11:48 +05:30
Clinton Wolfe
5a8e6aaccb
Merge pull request #5961 from inspec/ss/add-mail_alias-resource
CFINSPEC-80: Add mail alias resource
2022-04-06 09:31:08 -04:00
Clinton Wolfe
5b6540c563
Merge pull request #5959 from inspec/ss/enhance-user-resource
CFINSPEC-94: Enhance user resource
2022-04-06 09:28:19 -04:00
Clinton Wolfe
b1835bf9f9
Merge pull request #5945 from inspec/ss/enhance-docker-image
CFINSPEC-86: Enhance docker_image resource
2022-03-30 19:56:48 -04:00
Sonu Saha
65f4766bec CFINSPEC-80: Define aliased_to matcher and add unit test
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
2022-03-30 17:26:15 +05:30
Sonu Saha
1a5c6c2772 CFINSPEC-94: Add unit test for introduced matchers and properties
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
2022-03-29 04:53:24 +05:30
Sonu Saha
f1073f26f5 CFINSPEC-85: Unit test for no mounted volumes and non existing container
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
2022-03-24 22:24:27 +05:30
Sonu Saha
617f1634e3 CFINSPEC-85: Handle multiple mounts for docker container
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
2022-03-24 10:51:06 +05:30
Sonu Saha
2c4b8bab40 CFINSPEC-86: Add unit test for docker_image inspect attributes
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
2022-03-23 23:12:09 +05:30
Sonu Saha
800bf5391a CFINSPEC-85: Add unit test to check for mounted volumes
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
2022-03-23 22:35:08 +05:30
Clinton Wolfe
818f3dc6dc
Merge pull request #5938 from inspec/nm/oracle-empty-case
CFINSPEC-156 Oracle query fix when empty result
2022-03-23 10:13:57 -04:00
Clinton Wolfe
a15280fcc5
Merge pull request #5937 from inspec/vasundhara/fix-postgres-session-resource
CFINSPEC-154: postgres_session resource allow query errors to be treat as failures.
2022-03-23 09:44:06 -04:00
Sonu Saha
4f151bd72c CFINSPEC-73: Add unit test and relevant files for cgroup
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
2022-03-23 08:40:34 +05:30
Nikita Mathur
0f4ccee07e Oracle session resource fix when empty results and zero rows
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2022-03-22 17:05:31 +05:30
Vasu1105
2d0d972d65 CFINSPEC-154: Updates postgres_session resource to raise exception only in case of connection and authentication error and allow any errors in query to be fetched using output property(keeping earlier behaviour).
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2022-03-22 15:12:44 +05:30
Sonu Saha
36bf43f350 CFINSPEC-79: Add unit test and its related changes for lxc resource
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
2022-03-16 15:34:47 +05:30
Clinton Wolfe
63a5fd26a6
Merge pull request #5597 from mitre/firewalld_update
Firewalld update -- exposed more fields, updated docs, added custom matchers
2022-03-10 15:40:17 -05:00
Will Dower
23d1749ee8 merging in master
Signed-off-by: Will Dower <wdower@mitre.org>
2022-03-07 15:53:10 -05:00
Sonu Saha
7c874e67df CFINSPEC-66 : Add Ipfilter resource
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
2022-03-03 13:37:34 -05:00
Sonu Saha
437abc866c CFINSPEC-77 : Add ipnat resource
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
2022-03-03 13:16:28 -05:00
Clinton Wolfe
c065e923c3
Merge pull request #5782 from inspec/nm/kernel-params
CFINSPEC-3 Added kernel_parameters resource
2022-02-09 03:52:01 -05:00
Vasu1105
53ef84c8dd Adds property file_permissions and be_inherit matcher to the file resource for Windows.
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
2022-01-12 15:26:40 +05:30
Clinton Wolfe
3664b0c47d
Merge pull request #5758 from inspec/nm/timezone-resource
Added Timezone Resource
2022-01-09 20:45:15 -05:00
Clinton Wolfe
97c4002e82
Merge pull request #5771 from inspec/nm/package-latest
Check for latest - package resource
2022-01-09 20:28:55 -05:00
Nikita Mathur
4b9692c6fd Added kernel parameters resource
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-12-31 14:57:57 +05:30
Nikita Mathur
5a3c73b521 Fix for parsing faulty multiline results
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
2021-12-24 16:41:53 +05:30