Commit graph

166 commits

Author SHA1 Message Date
Nick Schwaderer
cc521b5400
Merge pull request #5084 from inspec/cw/reporter-plugin-junit
Convert JUnit Reporter to a Plugin
2020-08-07 18:06:43 +01:00
James Stocks
cd077a1247 Improve profile status rendering in html2 reporter
Signed-off-by: James Stocks <jstocks@chef.io>
2020-07-09 14:02:42 +01:00
James Stocks
fd4c501c70 Change profile skip_message to status_message
Keep a duplicate of the message in skip_message for the JSON reporters, for backwards compaibility.

Signed-off-by: James Stocks <jstocks@chef.io>
2020-07-03 15:53:09 +01:00
James Stocks
d94d56c4b9 Ignore intermittent test teardown error
Occasionally when the `isolated` tests run in CI, this error is seen:

```
inspec-reporter-html2::when run on a basic profile#test_0002_should produce valid HTML:
Errno::ENOENT: No such file or directory @ apply2files - /tmp/temp20200625-1802-2izu7e.html
    /usr/local/lib/ruby/2.6.0/fileutils.rb:1437:in `unlink'
    /usr/local/lib/ruby/2.6.0/fileutils.rb:1437:in `block in remove_file'
    /usr/local/lib/ruby/2.6.0/fileutils.rb:1442:in `platform_support'
    /usr/local/lib/ruby/2.6.0/fileutils.rb:1436:in `remove_file'
    /usr/local/lib/ruby/2.6.0/fileutils.rb:775:in `remove_file'
    /usr/local/lib/ruby/2.6.0/fileutils.rb:562:in `block in rm'
    /usr/local/lib/ruby/2.6.0/fileutils.rb:561:in `each'
    /usr/local/lib/ruby/2.6.0/fileutils.rb:561:in `rm'
    lib/plugins/inspec-reporter-html2/test/functional/inspec_reporter_html2_test.rb:9:in `teardown'
```

It should be OK to ignore the failure to delete the test file - the issue doesn't reproduce on laptops, and CI uses clean VMs each time.

Signed-off-by: James Stocks <jstocks@chef.io>
2020-06-26 09:23:21 +01:00
Mary Jinglewski
ac615db4fb Copyediting
Signed-off-by: Mary Jinglewski <mjinglewski@chef.io>
2020-06-18 14:23:54 -04:00
Clinton Wolfe
bd292c9dbb Fix JS execution on Internet Explorer by adding MOTW
Mark of the Web is a special comment in HTML that IE looks for
to set the JS security zone when running a local HTML file.
See
http://msdn.microsoft.com/en-us/library/ms537628(v=vs.85).aspx

Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-18 14:23:54 -04:00
Clinton Wolfe
e4aa9f1793 Skip HTML validation testing on windows
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-18 14:23:54 -04:00
Clinton Wolfe
aa824d1b49 Fix a bad interaction involving clearing the plugin registry in unit testing
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-18 14:23:54 -04:00
Clinton Wolfe
83c7f84290 Add ability to show/hide child profiles, start off hidden
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-18 14:22:31 -04:00
Clinton Wolfe
adc59ea4ad Correct html validation assertion syntax
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-18 14:22:31 -04:00
Clinton Wolfe
b8b7e4e848 Add ability to inline alternate JS and CSS
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-18 14:22:31 -04:00
Clinton Wolfe
e7a5c59b90 Use PRODUCT_NAME from Dist to allow community to rebrand
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-18 14:21:51 -04:00
Clinton Wolfe
a131067a09 Add functional test, including html validation
This uses html-proofer, which adds in nokogiri as a testing dep.
I expect we'll be using nokogiri soon anyway for the JUnit reporter.

Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-18 14:21:51 -04:00
Clinton Wolfe
81e2f36fde Basic unit tests for plugin definition
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-18 14:21:51 -04:00
Clinton Wolfe
bb2dfaa02d First pass at docs
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-18 14:21:13 -04:00
Clinton Wolfe
c4487f1892 Initial commit of inspec-reporter-html2
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-18 14:21:13 -04:00
Nick Schwaderer
7068694885 Revert "Make CLI reporter into a plugin"
Signed-off-by: Nick Schwaderer <nschwaderer@chef.io>
2020-06-18 12:30:15 +01:00
Nick Schwaderer
82c6472444
Merge pull request #5069 from inspec/cw/reporter-plugin-cli
Make CLI reporter into a plugin
2020-06-17 17:02:07 +01:00
Clinton Wolfe
3651f85a7c Use methods to access RunData
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-11 16:46:04 -04:00
Clinton Wolfe
98ae89e6cc Convert JUnit reporter to plugin, RunData is still Hash-based
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-11 16:46:04 -04:00
Clinton Wolfe
458a5c4410 Replace Hash RunData access with method calls
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-03 21:51:21 -04:00
Clinton Wolfe
76033c03ff Convert CLI reporter to plugin, RunData is still Hash-based
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-03 21:13:27 -04:00
Clinton Wolfe
935bb81e6f Use RunData object instead of Hash
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-02 15:29:52 -04:00
Clinton Wolfe
402366c219 Convert json-min to be a plugin reporter, rundata is still a Hash
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-02 15:29:52 -04:00
James Stocks
23ed9bcf06
Merge pull request #5007 from inspec/cw/reporters-as-plugins
Reporters as Plugins
2020-05-22 16:10:29 +01:00
Nick Schwaderer
989d86c2ce Stores output of inspec json to archive and artifact
Signed-off-by: Nick Schwaderer <nschwaderer@chef.io>
2020-05-20 12:34:17 +01:00
Clinton Wolfe
36069943c4 Add ability to generate reporter plugins using inspec init
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-05-12 17:00:44 -04:00
John Snow
8d676f6ed2 Fix typo's after review
Signed-off-by: John Snow <thelunaticscripter@outlook.com>
2020-04-20 09:50:58 -04:00
John Snow
03c012e3c9 Add additional debug logging for automate login
Signed-off-by: John Snow <thelunaticscripter@outlook.com>
2020-04-17 15:50:40 -04:00
Clinton Wolfe
a8b04769ca Ignore deprecation warning in fileutils and rubygems gems under ruby 2.7
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-04-08 10:56:55 -04:00
Thomas Heinen
61646ad3af Add support for alternate Gem sources for plugin installation/search
Signed-off-by: Thomas Heinen <theinen@tecracer.de>
2020-03-19 11:40:18 +01:00
Miah Johnson
8be265772b fixup_train_plugin_status should not activate gems.
This is handled by load_all already.

Signed-off-by: Miah Johnson <miah@chia-pet.org>
2020-02-10 14:52:12 -08:00
Ryan Davis
885e4f6c71 Fix test failure for call to vendor! w/o options.
Had to make options available for the mocking as well.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-01-03 17:12:51 -08:00
Ryan Davis
c57a0e1f13 Found and fixed more mocha/setup deprecations.
This level of duplication is not good.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-12-31 15:46:47 -08:00
Ryan Davis
7d95ece60d Remove circular require between fetcher and compliance plugin w/ autoloads.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-12-24 04:10:48 -08:00
Josh Brand
3af3df34d7 remove inspec/jq from pkg_deps/pkg_build_deps
It's included as a dep in the scaffolding itself, and the multiple
dependencies cause failures when building (ty @smacfarlane <3)

`jq` is also no longer needed, it was an artifact of legacy testing

Signed-off-by: Josh Brand <jbrand@chef.io>
2019-12-03 18:04:51 -05:00
Clinton Wolfe
7807c3fa01 Re-namespace core Fetchers
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-11-18 13:20:35 -05:00
Ryan Davis
a27eef1d0b Fixed env vars on functional plugin tests for windows.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-11-12 14:51:56 -08:00
Ryan Davis
ead386df14 Fixed inspec_init_plugin_test.rb
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-11-12 14:51:56 -08:00
Ryan Davis
a598356e12 Strip down plugin helper and change windows prefix execution.
Powershell doesn't use "&&" and we have it all over the tests.
Changing to ";".

Also starting to unify the plugin helper w/ the functional helper
since it has a LOT of duplication.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-11-12 14:51:56 -08:00
Ryan Davis
e60dc84188 Cleaned up inspec artifact testing.
Removed redundant test/functional/inspec_artifact_test.rb
Cleaned up lib/plugins/inspec-artifact/test/functional/inspec_artifact_test.rb
Made an error on windows (install-profile fails) raise instead of just print.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-11-12 14:50:39 -08:00
Ryan Davis
b1c2af209b Corresponding fixes for the move from test/unit/mock to test/fixtures.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-11-08 19:20:12 -08:00
Ryan Davis
bb49d58cd9 Switched chefstyle back to Layout/AlignArguments=with_first_argument.
Fixed the flags mostly with `chefstyle -a` but also refactored/cleaned
some stuff by hand.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-11-08 12:57:43 -08:00
Miah Johnson
7442955ed6
Merge pull request #4650 from inspec/cw/fix-compliance-exec
Fix config reference in `compliance exec`
2019-10-31 14:18:47 -07:00
Clinton Wolfe
954174c921 Fix config reference in compliance exec
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-10-30 15:56:07 -04:00
Ryan Davis
d201d1fbc2 Fixed the rest of the minitest deprecations by removing FuncTestRunResult.
Folded the json & other payloads into plain ivars on the test.
Found and removed some unused code while I was there.

Fixes #4533.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-22 12:15:28 -07:00
Miah Johnson
df7efefc9d mostly a search and replace for gordon -> example
Signed-off-by: Miah Johnson <miah@chia-pet.org>
2019-10-16 10:13:24 -07:00
Ryan Davis
07dc5e3192 First pass at cleaning deprecations for old minitest/spec-style tests.
3 files left to go, and they're behaving oddly so I'm leaving them out
in this pass. Looks like 21 deprecations left.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-10-03 13:45:19 -07:00
Ryan Davis
fc1ad67ffc More parallelization for functionals.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-09-17 11:50:31 -07:00
Ryan Davis
769d492108 Split up inspec-plugin_test.rb into a file per subcommand + helper.
This takes the run time from ~3 minutes to ~1 minute (in parallel).

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-09-16 17:19:32 -07:00