Commit graph

7987 commits

Author SHA1 Message Date
Clinton Wolfe
3a97e5d75b Accept a refactornig suggestion
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-06 19:21:12 -05:00
Clinton Wolfe
835bd2be8c A clumsy but effective way of usually dodging windows filesystem length restrictions.
Still definitely possible to run afoul of that issue, but that is not specific to
this feature, and frankly one might consider increasing thier FS path length
as a solution, as well.

Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-06 18:54:23 -05:00
Ryan Davis
0e77af3a77 Fixed resolver_test.rb by making Inspec::Config.cached a lazy accessor.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-01-03 17:13:18 -08:00
Ryan Davis
885e4f6c71 Fix test failure for call to vendor! w/o options.
Had to make options available for the mocking as well.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-01-03 17:12:51 -08:00
Clinton Wolfe
ef9ef919fc Linting
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-03 14:15:05 -05:00
Clinton Wolfe
9bf8f2f4cd Adjust usage message for --airgap option
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-03 14:15:05 -05:00
Clinton Wolfe
3e3398ff29 Switch to using tmpdir option during testing to avoid rm calls
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-03 14:15:05 -05:00
Clinton Wolfe
9ada8362b8 Push up update_from_opts implementation
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-03 14:15:05 -05:00
Clinton Wolfe
ba4fa9832c parallelize fetcher tests, conditionalize automate fetcher
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-03 14:15:05 -05:00
Clinton Wolfe
5369b7ac79 make a one-liner per miah
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-03 14:15:05 -05:00
Clinton Wolfe
b92537aff5 bangify vendor_dependencies
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-03 14:15:05 -05:00
Clinton Wolfe
6a0f7eeea9 A terrible implementation of fetcher fallback for compliance fetcher
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-03 14:15:05 -05:00
Clinton Wolfe
913c066be9 Test fixture and functional test for compliance fetcher
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-03 14:15:05 -05:00
Clinton Wolfe
f4a3cf9144 Implementation for local fetcher
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-03 14:15:05 -05:00
Clinton Wolfe
82ae3b5fa1 Test fixtures and functional test for local fetcher
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-03 14:15:05 -05:00
Clinton Wolfe
4e0ad4a56b Implementation of archive fallback for the URL fetcher
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-03 14:15:05 -05:00
Clinton Wolfe
ed209643f3 Test fixture for url fetcher
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-03 14:15:05 -05:00
Clinton Wolfe
1eb33049e4 Alter resolver to fallback to an archive if in airgap mode
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-03 14:15:05 -05:00
Clinton Wolfe
1806900794 Add an optional API method to update the internal state of a fetcher
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-03 14:15:04 -05:00
Clinton Wolfe
e1941b2d11 When archiving with --airgap, warm the vendor cache from any available local archives
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-03 14:15:04 -05:00
Clinton Wolfe
928cf6f05e Functional test and fixtures for git fetcher fallback
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-03 14:15:04 -05:00
Clinton Wolfe
f9d419f219 Remove constructors from raise statements
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-03 14:15:04 -05:00
Clinton Wolfe
48a97ea60f Add .invalid TLD to test hostanmes
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-01-03 14:15:04 -05:00
Chef Expeditor
395d6d5421 Bump version to 4.18.58 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-01-03 16:47:38 +00:00
Clinton Wolfe
328302dd48
Fix empty attributes array in json reporter (#4815)
shallow copy of params missed inputs
2020-01-03 11:47:16 -05:00
Ryan Davis
b51da7d037 Properly report errors with bad tarball files.
+ Raise a well-worded error with details and avoid an uncaught exception.
+ Fix error caused when the tar file is already invalid and we try to close it.

Fixes #3765.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2020-01-02 16:13:55 -08:00
Chef Expeditor
230ce1532e Bump version to 4.18.57 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-01-03 00:07:52 +00:00
Ryan Davis
f09595c33d
Merge pull request #4821 from inspec/zenspider/mocha2
Found and fixed more mocha/setup deprecations.
2020-01-02 16:07:35 -08:00
Collin McNeese
78f9594839
updates file resource doc to add example for sticky bit with leading zero
Signed-off-by: Collin McNeese <cmcneese@chef.io>
2020-01-02 08:29:26 -06:00
Chef Expeditor
8b5789004a Bump version to 4.18.56 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-01-01 00:59:32 +00:00
Ryan Davis
edc416c118
Merge pull request #4778 from inspec/zenspider/I-just-wanted-to-write-let!
Removed all metaprogramming from ControlEvalContext
2019-12-31 16:59:13 -08:00
Ryan Davis
c57a0e1f13 Found and fixed more mocha/setup deprecations.
This level of duplication is not good.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-12-31 15:46:47 -08:00
Ryan Davis
73cccd8681 Cache the backend in profile_context_test.rb
And this speeds it up from 0.5s to 0.07s.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-12-31 15:27:12 -08:00
Ryan Davis
313f3462ca Cache MockLoader.connection.
Speeds up test/unit/profile/profile_context_test from 7-8s to 0.5s.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-12-31 15:27:12 -08:00
Ryan Davis
a0ffa67b71 Switched from profile_id to __profile_id per feedback.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-12-31 15:27:12 -08:00
Ryan Davis
6426feeeb4 Removed the last of the metaprogramming from ControlEvalContext.
* Merged CEC.create args into CEC#initialize
* Converted the only call site of CEC.create to just call new.
* Added profile_context and resources_dsl accessors to CEC.

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-12-31 15:27:12 -08:00
Ryan Davis
f6407fb01b Future code cleanup TODO
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-12-31 15:27:12 -08:00
Ryan Davis
15941279ae Removed 90+% of all metaprogramming from ControlEvalContext
+ Removed ControlEvalContext.rule_context entirely pushing into Rule
+ Gutted ControlEvalContext.create pushing into ControlEvalContext.
+ Added class ivar accessors for ControlEvalContext to bypass need for closures.
+ Converted all define_methods into defs.
+ Added resource_dsl to Rule#initialize

Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-12-31 15:27:12 -08:00
Ryan Davis
c505f3ba13
Merge pull request #4816 from inspec/zenspider/bk/2.7
Get on official ruby 2.7.0
2019-12-31 15:26:35 -08:00
Ryan Davis
c376a813b2 Remove -stretch from all our ruby images... just cleaner. no real reason.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-12-31 14:52:33 -08:00
Ryan Davis
3139392f1f Get on official ruby 2.7.0
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-12-31 14:52:33 -08:00
Chef Expeditor
f4815204d9 Bump version to 4.18.55 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2019-12-31 22:20:03 +00:00
Miah Johnson
819af52632
Merge pull request #4819 from inspec/cw/set-test-skip-bomb-into-q1-2020
Set test skip bomb date to end of 2020Q1
2019-12-31 14:19:41 -08:00
Nazli Beitollahpour
1486d8d890 issue 4807: shallow copy of params missed inputs
Signed-off-by: Nazli Beitollahpour <nazli.beitollahpour@umontreal.ca>
2019-12-31 13:02:27 -05:00
Clinton Wolfe
2409e8fb99 Set test skip bomb date to end of 2020Q1
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2019-12-31 12:19:27 -05:00
Cameron Straka
8b037fa9c2 replaced instances of have_protocols with have_protocol in documentation and examples
Signed-off-by: Cameron Straka <strakacameron@hotmail.com>
2019-12-31 10:51:55 -05:00
Ryan Davis
52623ee5a6
Merge pull request #4808 from inspec/zenspider/minor-cleanup
Remove circular require between fetcher and compliance plugin w/ autoloads.
2019-12-30 16:27:20 -08:00
Ryan Davis
8e281e007e oops
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-12-24 04:11:17 -08:00
Ryan Davis
7d95ece60d Remove circular require between fetcher and compliance plugin w/ autoloads.
Signed-off-by: Ryan Davis <zenspider@chef.io>
2019-12-24 04:10:48 -08:00
Miah Johnson
dc278348b6
Merge pull request #4800 from inspec/mj/powershell_is_trash
powershell doesnt care if 'regular executables' fail
2019-12-18 12:13:55 -08:00