Mirrors/inspec
2
0
Fork 0
mirror of https://github.com/inspec/inspec synced 2024-11-23 13:13:22 +00:00
Code Issues Projects Releases Packages Wiki Activity
7511 commits 453 branches 1898 tags 74 MiB
Commit graph

3751 commits

Author SHA1 Message Date
Ryan Davis
577521296c
Merge pull request #4476 from inspec/zenspider/gem_pathing 
Use File.realpath in Loader#plugin_gem_path to resolve all symlinks.
 2019-09-17 18:13:35 -07:00
Chef Expeditor
d35b123f67 Bump version to 4.17.2 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-18 01:13:19 +00:00
Irving Popovetsky
ffbcc29c59 Fix the Tag object to_ruby, as used by inspec-scap 
Signed-off-by: Irving Popovetsky <irving@chef.io>
 2019-09-17 15:58:12 -07:00
Ryan Davis
fc1ad67ffc More parallelization for functionals. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-17 11:50:31 -07:00
Chef Expeditor
9afbce04ca Bump version to 4.17.1 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-17 00:50:32 +00:00
Ryan Davis
a473a94303
Merge pull request #4493 from inspec/mj/waiver3 
Waivers Phase 3
 2019-09-16 17:50:02 -07:00
Chef Expeditor
a3006d7f4d Bump version to 4.17.0 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-17 00:46:42 +00:00
Clinton Wolfe
f1f5840fa7
Merge pull request #4388 from Vancelot11/vancelot/sys_info.hostname 
Expand sys_info resource functionality
 2019-09-16 20:46:25 -04:00
Ryan Davis
769d492108 Split up inspec-plugin_test.rb into a file per subcommand + helper. 
This takes the run time from ~3 minutes to ~1 minute (in parallel).

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-16 17:19:32 -07:00
Chef Expeditor
3f3c0fba32 Bump version to 4.16.15 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-17 00:04:05 +00:00
Ryan Davis
a0a7917faa
Merge pull request #4485 from inspec/zenspider/objects-inputs 
Split out Inspec::Input functional code from the code generation code.
 2019-09-16 17:03:49 -07:00
Ryan Davis
1526838ea6 Refactored JSON reporter to be much cleaner / consistent. 
Everything can just be a simple clean map + reject if nil value.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-16 16:55:38 -07:00
Miah Johnson
5d94b0d709 Add waiver_data to json output, update assertion to show where waiver_data lives. 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-09-16 14:49:05 -07:00
Ryan Davis
e375ea30c8 Split out Inspec::Input functional code from the code generation code. 
Includes moving errors into Inspec::Input and Inspec::InputRegistry.

Fixes #4456.
Fixes #4473.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-13 17:12:20 -07:00
Noel Georgi
48c22a118b
Support config clearing 
Signed-off-by: Noel Georgi <git@frezbo.com>
 2019-09-13 10:41:32 +05:30
Chef Expeditor
b9eff6e3b9 Bump version to 4.16.14 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-13 00:25:52 +00:00
Ryan Davis
5bf13e05d3 Use File.realpath in Loader#plugin_gem_path to resolve all symlinks. 
Fixes #4472.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-12 16:21:01 -07:00
Chef Expeditor
f419546e76 Bump version to 4.16.13 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-12 23:08:47 +00:00
Clinton Wolfe
d366af15e8
Merge pull request #4478 from inspec/cw/fix-symbol-error 
Add to_s definitions to several resources
 2019-09-12 19:08:31 -04:00
mhackethal
d3291ae61c fix whitespace. Signed-off-by: mhackethal <mh@it31.de> 2019-09-12 21:56:50 +02:00
mhackethal
c08db992a9
remove awk on lastb 2019-09-12 16:06:03 +02:00
mhackethal
e48f672968
Update users.rb 
Signed-off-by: mhackethal <mh@it31.de>
 2019-09-12 16:04:44 +02:00
Clinton Wolfe
23ca9ba64d Add to_s to remaining resources 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-09-11 20:20:37 -04:00
Clinton Wolfe
80db6b52c7 Add a to_s method for sys_info to avoid conversion error 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-09-11 19:56:05 -04:00
Chef Expeditor
d0505a98e5
Bump version to 4.16.12 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-11 22:33:40 +00:00
Clinton Wolfe
fe351dba61
Merge pull request #4469 from inspec/cw/waivers2-fixes 
Fix broken unit test by adding require
 2019-09-11 17:36:46 -04:00
Chef Expeditor
192c241ee0
Bump version to 4.16.11 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-11 15:12:40 +00:00
Clinton Wolfe
8132aaf85c
Merge pull request #3844 from inspec/ja/add-error-output-to-json-command 
json resource: Add handling for `command:` error
 2019-09-11 11:12:26 -04:00
Clinton Wolfe
e07cca0f8d Add require for input registry 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-09-11 10:31:23 -04:00
Ryan Davis
fcfcc354fe Reworked test cases and impl to only respond to output, not exit code. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-10 14:19:42 -07:00
Kerry Vance
933d7f14ac fix indentation 
Signed-off-by: Kerry Vance <vancelot@osuosl.org>
 2019-09-10 11:32:15 -07:00
Chef Expeditor
e0e61155d6
Bump version to 4.16.10 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-10 18:18:31 +00:00
Ryan Davis
576370cf62
Merge pull request #4437 from inspec/zenspider/waivers/input 
Rough draft on waiver input
 2019-09-10 11:18:17 -07:00
Ryan Davis
7a718103c5 Minor cleanup in config.rb. 
The logic involved was unnecessary and had a hard-coded string in it
that is now wrong.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-09 18:44:55 -07:00
Ryan Davis
ce80cf3cf9 First draft at waiver file processing. 
1) Don't know how much filtering or rewriting we want at this level.
2) Don't know where to put the tests.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-09 18:44:55 -07:00
Chef Expeditor
29feee9b00
Bump version to 4.16.9 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-10 01:41:52 +00:00
Ryan Davis
dfce5e722f
Merge pull request #4427 from inspec/cw/waivers-overlay 
waivers: functional test fixture and eval-time skipping
 2019-09-09 18:41:37 -07:00
Chef Expeditor
69b583bd3d
Bump version to 4.16.8 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-10 01:02:22 +00:00
Ryan Davis
f5bbfe5fac
Merge pull request #4365 from inspec/zenspider/the-need-for-speed 
Make inspec much faster for most commands.
 2019-09-09 18:02:10 -07:00
Jerry Aldrich
0e1b3fa65a json resource: Add handling for command: error 
This provides the user with messages if `json(command: 'command_that_errors')`
exits non-zero and/or has STDERR.

Without this the resource will report "No output from command" when really the
output is contained in STDERR.

Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-09-09 15:16:34 -07:00
Chef Expeditor
d1ecefc970
Bump version to 4.16.7 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-09 18:14:06 +00:00
Ryan Davis
79b9c3cbad
Merge pull request #4451 from inspec/zenspider/fix-tarball-decoding 
Try to decode archive contents to UTF-8 to avoid encoding corruption.
 2019-09-09 11:13:48 -07:00
Clinton Wolfe
5d94440823 Fix logic error for future expiring waivers 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-09-09 11:29:26 -04:00
Clinton Wolfe
9fd0fb242c Store waiver information in control metadata and pass into report run_data 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-09-09 11:29:26 -04:00
Clinton Wolfe
43bc7e0343 Modify @__skip_rule to distinguish only_if and waiver, and force waiver to win 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-09-09 11:29:26 -04:00
Clinton Wolfe
aab45b507f Clarify input-waiver interaction 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-09-09 11:29:26 -04:00
Clinton Wolfe
0db0a2bfdc Don't assume waiver_ prefix in waiver files 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-09-09 11:29:26 -04:00
Clinton Wolfe
718e205cf2 Alter expiration_date behavior to match spec 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-09-09 11:29:26 -04:00
Clinton Wolfe
6ec50efd22 Initial implementation of skipping a control by waivering it via input flagging 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-09-09 11:29:26 -04:00
Clinton Wolfe
6b618b6b83 Comments for clarity on skipping 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-09-09 11:29:26 -04:00
Chef Expeditor
b82158ba53
Bump version to 4.16.6 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-06 18:58:25 +00:00
Chef Expeditor
32d93b367d
Bump version to 4.16.5 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-06 18:57:54 +00:00
Miah Johnson
f11d6bcfba
Merge pull request #4443 from ramereth/fix-postfix_conf-other-file 
Fix for postfix_conf when using a non-standard config location
 2019-09-06 11:57:51 -07:00
Miah Johnson
d96b0a3281
Merge pull request #4446 from inspec/zenspider/activated_eh 
Rework activator plugin to be more idiomatic.
 2019-09-06 11:57:31 -07:00
Kerry Vance
41978b4bc7 reduce cognitive complexity, breakup function 
Signed-off-by: Kerry Vance <vancelot@osuosl.org>
 2019-09-06 10:34:31 -07:00
Ryan Davis
f93d0a2aee Make TarProvider much more efficient. 
Read each file once at the start.
Extract should use that cache as well.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-06 00:42:36 -07:00
Ryan Davis
9849906198 Cleaned up TarProvider#initialize. 
TarProvider still decompresses & reads N+1 times... that's next

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-05 17:33:08 -07:00
Ryan Davis
13301f30d1 Use ||= when possible, esp with lazy hashes. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-05 17:23:48 -07:00
Ryan Davis
e0a835a34d Added comments to the end of these classes to ease navigation. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-05 17:23:01 -07:00
Ryan Davis
fe4e687721 Try to decode archive contents to UTF-8 to avoid encoding corruption. 
Fixes #4135.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-05 17:22:02 -07:00
Kerry Vance
729d9965ed fails loudly with unsupported options 
Signed-off-by: Kerry Vance <vancelot@osuosl.org>
 2019-09-05 12:14:36 -07:00
Kerry Vance
540515f796 rename ip-address to ip_address 
Signed-off-by: Kerry Vance <vancelot@osuosl.org>

Signed-off-by: Kerry Vance <vancelot@osuosl.org>
 2019-09-05 12:13:52 -07:00
Kerry Vance
9dafab2215 removed deprecated alias option 
Signed-off-by: Kerry Vance <vancelot@osuosl.org>
 2019-09-05 11:56:13 -07:00
Kerry Vance
75b17561ee expand sys_info resource functionality 
Signed-off-by: Kerry Vance <vancelot@osuosl.org>
 2019-09-05 11:56:12 -07:00
Chef Expeditor
4c1523ff88
Bump version to 4.16.4 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-05 13:30:39 +00:00
Clinton Wolfe
dffefc3f0b
Merge pull request #4435 from inspec/zenspider/apt/fix 
Guard against nil in apt repo parser.
 2019-09-05 09:30:22 -04:00
Chef Expeditor
eb9096f14c
Bump version to 4.16.3 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-05 13:28:15 +00:00
Ryan Davis
8b0f6efb41 Fixed the formatting of inspec exec -h by not using long_desc. 
long_desc does some really bad word wrapping stuff that totally breaks
our formatting of the output (like code blocks). So, don't use it. If
we like this, I will apply it to all of them.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-04 16:54:37 -07:00
Ryan Davis
75ca4613c2 Extended to pick up our internal aws resources as well. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-04 15:44:26 -07:00
Ryan Davis
4590fee51d Documented lib/inspec/resources.rb current usage. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-04 15:44:26 -07:00
Ryan Davis
3b69967cc8 Fixed a bug in checking supports (strings vs symbols) 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-04 15:44:26 -07:00
Ryan Davis
3f0f675364 Moved rspec/matchers require to somewhere more appropriate. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-04 15:44:26 -07:00
Ryan Davis
2fc9ec3ec7 Refactor into Inspec::DSL.method_missing_resource 
This way I can add aws lazy loading to only one place.

I don't actually care that this is in Inspec::DSL. There is probably a
better place for it. Suggestions welcome.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-04 15:44:26 -07:00
Ryan Davis
ae88c3ddec Sped up inspec shell by avoiding pre-registering all reesources. 
Now it tries to load a resource when `help xxx` is invoked or loads
all resources when `help resources` is invoked. Otherwise, it stays
lazy.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-04 15:44:26 -07:00
Ryan Davis
e413cee6a4 I don't like this, but make chef shell require all resources. 
I think there is probably a better way to do this, but my first
instinct was that I'd have to dig into hacking pry, and I don't want
to do that right now.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-04 15:44:26 -07:00
Ryan Davis
b6bfeffd9e Make inspec much faster for most commands. 
Removes pre-loading and registration of resources by adding
method_missing to a couple key areas.

This still drops the ball in some areas, but it is a start.
 2019-09-04 15:44:26 -07:00
Ryan Davis
5a26b3c538 Rewrote apt.rb's read_debs' main loop. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-04 15:38:08 -07:00
Ryan Davis
1aebd53314 Rework apt.rb's read_debs. 
This goes a step further and relaxes the parsing quite a bit while
making it more readable and flexible.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-04 15:38:08 -07:00
Ryan Davis
4e822f3c37 Refactored V2::Activator into more idiomatic ruby. 
Predicate methods are usually added to make code more expressive, but
they still act off of normal attributes. Predicate methods are not
setters. This moves from X? to X and then aliases the predicate
method.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-04 15:33:48 -07:00
Ryan Davis
de22ba3ac1 Fixed warning from overlapping regexp range. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-04 15:33:48 -07:00
Ryan Davis
bb41b4fa8c Guard against nil in apt repo parser. 
Fixes #4093.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-04 15:32:47 -07:00
Lance Albertson
1e94e3503e Fix for postfix_conf when using a non-standard config location 
Pass the first argument of the opts array instead of the whole array which
confuses the SimpleConfig parser. Also added a test which verifies this fixes
the issue.

In addition, change the base_name to something that matches other resource base
names.

Signed-off-by: Lance Albertson <lance@osuosl.org>
 2019-09-03 15:28:44 -07:00
Chef Expeditor
d1ffce7278
Bump version to 4.16.2 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-03 20:24:54 +00:00
Chef Expeditor
8562397d78
Bump version to 4.16.1 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-30 20:20:21 +00:00
kekaichinose
d33870b635
Merge pull request #4214 from inspec/zenspider/fix_nil_file 
Fixed file resource raising UndefinedMethod on source_path
 2019-08-30 13:19:54 -07:00
mhackethal
204c41bfd1 Update users.rb to include new attributes 2019-08-30 22:07:36 +02:00
mhackethal
9d7f9e6f39 add cache credentials/meta_info to windows user resource 2019-08-29 23:12:42 +02:00
Chef Expeditor
435747a2d2
Bump version to 4.16.0 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-28 19:41:38 +00:00
Clinton Wolfe
a6bd7ec4b5
Merge pull request #4401 from inspec/cw/input-from-cli 
inputs: Accept bare input from the command line
 2019-08-28 15:41:21 -04:00
Chef Expeditor
683170bd26
Bump version to 4.15.0 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-28 19:34:05 +00:00
Clinton Wolfe
edf335bbc9 Use plugin filter predicates to check plugin names 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-28 13:36:12 -04:00
Clinton Wolfe
82acec957e Add API for fetching plugin vconfig values. 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-28 13:25:49 -04:00
Clinton Wolfe
38f3469ee3 Validation for the plugins area of the config file 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-28 13:25:49 -04:00
Clinton Wolfe
c6d355e4f7 Accept version 1.2 for config file format 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-28 13:25:49 -04:00
Chef Expeditor
4a515e5010
Bump version to 4.14.3 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-28 17:14:05 +00:00
Clinton Wolfe
e346b16114 Tighten help listing assertion and adjust chomp 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-28 13:03:42 -04:00
Clinton Wolfe
296158c447 Implementation and functional tests for the --input CLI option 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-28 13:03:42 -04:00
Clinton Wolfe
512189a06b Add CLI option and check in help 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-28 12:53:27 -04:00
Clinton Wolfe
7c2e1dfce2 Add explanatory comment 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:43:35 -04:00
Clinton Wolfe
ac78ecd5ae Swap actual and expected in a test file 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:29:42 -04:00
Clinton Wolfe
54f1011f7a Linting 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:29:42 -04:00
Clinton Wolfe
d7750054c8 Move sindows skip lines to be below test execution per rdavis 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:29:42 -04:00
Clinton Wolfe
9e4ace6799 Go ahead and refactor the fillter predicates 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:29:42 -04:00
Clinton Wolfe
d1a42b8059 filter was introduced in ruby 2.6 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:29:42 -04:00
Clinton Wolfe
f44c7bcdcd Convert the plugin name to a string only once when guessing at versions 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:29:42 -04:00
Clinton Wolfe
1b7a8f3888 Make const in test file 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:29:42 -04:00
Clinton Wolfe
28f747ebbb Interpolation 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:29:42 -04:00
Clinton Wolfe
8d80c89e56 Make install types and labels constant 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:29:42 -04:00
Clinton Wolfe
f962ef2662 Simplify sort for list output 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:29:42 -04:00
Clinton Wolfe
3cd6eee016 Add valid_plugin_name? predicate and push exclusion list check into its own method 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:29:42 -04:00
Clinton Wolfe
16fecbefb5 Return version number when listing plugins; correct UX coloration 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:29:42 -04:00
Clinton Wolfe
e1031cc818 Correct newlines and duplicate output ins various UX messaging 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:29:42 -04:00
Clinton Wolfe
cc758c7624 Linting 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:29:42 -04:00
Clinton Wolfe
f0aa934ddc List tests pass again, adding filtering options 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:29:42 -04:00
Clinton Wolfe
8cab0e862b Adopt the new UI style table, breaking most of the UI tests, which were already broken anyway 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:29:42 -04:00
Clinton Wolfe
68329aa8e5 Linting 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:28:52 -04:00
Clinton Wolfe
e581245391 Plausible implementation of detect_system_plugins 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:28:52 -04:00
Clinton Wolfe
00b2d9480a Rename constant for user gem installs for clarity 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:28:52 -04:00
Clinton Wolfe
149663ba55 Updated messaging for user gem plugins 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:28:52 -04:00
Clinton Wolfe
4211d3eb7c Failing functional tests for listing plugin gems 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:26:49 -04:00
Clinton Wolfe
e90482e955 Refactor train plugin decoration 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:26:49 -04:00
Chef Expeditor
ba64d06ef7
Bump version to 4.14.2 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-28 00:03:34 +00:00
Clinton Wolfe
f90a4c633d
Merge pull request #4419 from inspec/cw/check-enforce-version 
inspec check: warn if inspec_version is not supported by current inspec
 2019-08-27 20:03:19 -04:00
Chef Expeditor
d2dd311561
Bump version to 4.14.1 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-27 23:54:27 +00:00
Chef Expeditor
9b84b7b5c1
Bump version to 4.14.0 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-27 20:35:09 +00:00
Clinton Wolfe
12c7c51fea Warn not error 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-26 23:29:19 -04:00
Clinton Wolfe
714dc26006 Add unit test and include runtime version check in metadata.valid 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-26 23:05:49 -04:00
Clinton Wolfe
ada6aad169 Move input name stringification into the method 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-22 21:40:01 -04:00
Ryan Davis
bd3ec9aec7 Code cleanup. 
While I was in here... nothing big.

It does seem like we have too many hard-coded symbols in our code in
general as well as too many symbol styles (underscore vs dash).

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-20 13:25:21 -07:00
Ryan Davis
7273a7380f Fixed file resource raising UndefinedMethod on source_path 
This is a first pass at fixing the failure found by @scottvidmar where
file resource was raising undefined_method on nil. The problem was
that the initialize method for file was not being called at all
because Resource#initialize was returning early without reporting
anything.

This fix causes a failure in test/functional/inspec_exec_test.rb where
it is testing a similar scenario but for some reason the unsupported
resources get reported. We need to figure that part out, but in the
meantime this will at least report an error at the root cause rather
than down the road.

Fixes #4208

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-20 13:25:21 -07:00
Clinton Wolfe
2ef151dd56 Hrm, linting for upstream? 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-19 13:52:28 -04:00
Clinton Wolfe
cc4aa16212 Add test framework to run Runner API input tests 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-19 13:51:51 -04:00
Clinton Wolfe
93521dea0c Accept either input or attribute in the runner API 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-19 13:39:31 -04:00
Chef Expeditor
59301c54ad
Bump version to 4.13.2 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-19 16:56:07 +00:00
Clinton Wolfe
3f54f7ac46
Ensure that resources are always initialized in all cases (#4366) 
Ensure that resources are always initialized in all cases
 2019-08-19 12:55:52 -04:00
Chef Expeditor
88d23697f7
Bump version to 4.13.1 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-19 16:52:35 +00:00
Clinton Wolfe
e7ccdc03c9
Refactor lib/source_readers/inspec.rb (#4376) 
Refactor lib/source_readers/inspec.rb
 2019-08-19 12:52:20 -04:00
Chef Expeditor
7581ab37c7
Bump version to 4.13.0 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-19 16:38:32 +00:00
Clinton Wolfe
8dc350bc6c
Add a Postfix-specific configuration testing resource (#4378) 
Add a Postfix-specific configuration testing resource
 2019-08-19 12:38:17 -04:00
Ryan Davis
43e07e8f2d Finished refactoring! 
Now that the code is easier to read and actually focuses on what it
does in a readable way, it is easier to reason about. In this case, we
have blocks being passed around in order to evaluate a bunch of
paths (read: strings) to determine if they're correct. Why do multiple
`start_with?` and `end_with?` calls? It doesn't cleanly describe what
it is trying to do. Instead, we can use regexps and it'll work just
fine, so lets do that. This simplifies things even further.

46.5: flog total

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-18 20:36:19 -07:00
Ryan Davis
3f0e9e9ffa Fix chefstyle. 
This is an area where I really disagree with chefstyle. 🤷

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-18 20:36:19 -07:00
Ryan Davis
f8b8f968aa lib/source_readers/inspec.rb refactor 8/8: reformat 
58.9: flog total

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-18 20:36:19 -07:00
Ryan Davis
ac6164e56d lib/source_readers/inspec.rb refactor 7/8: combine load_all and find_all. 
58.9: flog total

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-18 20:36:19 -07:00
Ryan Davis
213a4489ed lib/source_readers/inspec.rb refactor 6/8: use if/compact instead of delete_if. 
59.0: flog total

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-18 20:36:19 -07:00
Ryan Davis
6399116e5f lib/source_readers/inspec.rb refactor 5/8: extract to local var 
60.1: flog total

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-18 20:36:19 -07:00
Ryan Davis
5d19283199 lib/source_readers/inspec.rb refactor 4/8: use to_h 
59.8: flog total

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-18 20:36:19 -07:00
Ryan Davis
70d8ecf1e8 lib/source_readers/inspec.rb refactor 3/8: pull up file reading. 
59.8: flog total

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-18 20:36:19 -07:00
Ryan Davis
4f0a5d6ba1 lib/source_readers/inspec.rb refactor 2/8: normalize variable names. 
76.1: flog total

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-18 20:36:19 -07:00
Ryan Davis
6735d03a09 lib/source_readers/inspec.rb refactor 1/8: pull up file selection. 
71.3: original flog total
73.0: flog total (this version)

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-18 20:36:19 -07:00
Ryan Davis
f4bae13c68 Fixes for 2 failed tests. 
Rescue NotImplementedError and call failed_resource only if we haven't
already failed the support_check call.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-18 19:30:30 -07:00
Ryan Davis
cd5f58f8eb Do not call return inside of an initialize method. 
It does NOT do what you think it does. It does NOT prevent an object
from coming back. All it does is have an uninitialized (or partially
initialized) object come back, which isn't helpful.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-18 17:28:56 -07:00
Chef Expeditor
8eded7e258
Bump version to 4.12.0 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-15 18:47:02 +00:00
dalee-bis
7f2dbd918f
Fixed MssqlSession.query not escaping double quote correctly 
When `MssqlSession.query` is escaping the `"` character, it is doing so by prefixing it with a backslash (e.g. `\"`). This does not escape the quote character. It should be escaped by adding an additional double quote character (e.g. `""`).
 2019-08-15 11:28:50 +01:00
Chef Expeditor
8e62048b97
Bump version to 4.11.5 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-13 16:59:16 +00:00
Chef Expeditor
134ff8048a
Bump version to 4.11.4 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-12 18:01:20 +00:00
Chef Expeditor
bce0fbe177
Bump version to 4.11.3 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-08 22:06:17 +00:00
David Gasper
52ae5e434b Add docs and unit tests, remove .travis.yml 
Signed-off-by: David Gasper <dmgasper@osuosl.org>
 2019-08-08 13:54:35 -07:00
David Gasper
6ba210d82d Add automatic path resolution 
Signed-off-by: David Gasper <dmgasper@osuosl.org>
 2019-08-08 13:54:22 -07:00
David Gasper
098610f128 Add Postfix_conf resource 
Signed-off-by: David Gasper <dmgasper@osuosl.org>
 2019-08-08 13:50:12 -07:00
Chef Expeditor
3981110da5
Bump version to 4.11.2 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-08 17:13:42 +00:00
Chef Expeditor
ffba747523
Bump version to 4.11.1 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-08 15:56:10 +00:00
Clinton Wolfe
95e6bcb317
Modified DarwinGroup to collect all users properly. (#4343) 
group resource: Modified DarwinGroup to collect all users properly on macos
 2019-08-08 11:55:48 -04:00
Chef Expeditor
8fad74d4a2
Bump version to 4.11.0 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-08 15:32:53 +00:00
Clinton Wolfe
c28dd8f9ec
Add startuser windows service (#4363) 
Add startuser windows service
 2019-08-08 11:32:39 -04:00
Chef Expeditor
7ab39ba273
Bump version to 4.10.7 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-08 15:16:21 +00:00
Ryan Davis
374e365c02 Modified DarwinGroup to collect all users properly. 
I noticed that my profile targeting group "staff" on OSX wasn't
returning *me*. I'm awesome! So that seemed wrong. And it turns out it
is wrong. We were not collecting any users whose primary group was
that group. (almost all regular users are in group staff and they're
all missing).

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-07 20:27:13 -07:00
Chef Expeditor
90fb536bf7
Bump version to 4.10.6 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-08 03:17:56 +00:00
Chef Expeditor
a6dd013ec2
Bump version to 4.10.5 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-07 20:29:26 +00:00
Mendy Baitelman
e3b641f676 Fix whitespace 
Signed-off-by: Mendy Baitelman <mendy@baitelman.com>
 2019-08-06 15:11:15 -07:00
Mendy Baitelman
4505471ec7 Fix differences 
Signed-off-by: Mendy Baitelman <mendy@baitelman.com>
 2019-08-06 13:26:37 -07:00
Mendy Baitelman
126b1efc74 Add startuser to windows service 
Signed-off-by: Mendy Baitelman <mendy@baitelman.com>
 2019-08-06 13:20:57 -07:00
Kris Shannon
4a30a8aa32 Move some resources into Inspec::Resources module 
The `DhParams`, `EtcHosts`, `GrubConfig`, `IisAppPool`, and `SSL`
resources were not properly located inside the `Inspec::Resources`
module.

Fixes: #4327

Signed-off-by: Kris Shannon <k.shannon@amaze.com.au>
 2019-08-05 18:17:01 +10:00
Chef Expeditor
723d53e6b1
Bump version to 4.10.4 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-01 00:16:47 +00:00
Chef Expeditor
4aa1ef81f3
Bump version to 4.10.3 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-30 23:45:06 +00:00
Chef Expeditor
1045f67a76
Bump version to 4.10.2 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-30 22:08:14 +00:00
Chef Expeditor
66f709875d
Bump version to 4.10.1 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-30 21:46:48 +00:00
Chef Expeditor
ae898b9eb3
Bump version to 4.10.0 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-30 18:38:10 +00:00
Clinton Wolfe
100e96db1c
Relative Path Support for the Git Fetcher (#4217) 
Relative Path Support for the Git Fetcher
 2019-07-30 14:37:54 -04:00
Chef Expeditor
fbf06ccc7d
Bump version to 4.9.1 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-30 18:37:23 +00:00
Clinton Wolfe
80d5788883
Apply new UI code to CLI and plugin-manager-cli (#4000) 
Apply new UI code to CLI and plugin-manager-cli
 2019-07-30 14:37:09 -04:00
Chef Expeditor
718629e42a
Bump version to 4.9.0 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-30 17:58:52 +00:00
Clinton Wolfe
b8c9043a3a
Permit plugin to be in path with git ref (#4251) 
Permit plugin to be in path with git ref
 2019-07-30 13:58:37 -04:00
Clinton Wolfe
f00e741999 PR feedback 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-30 13:38:02 -04:00
Clinton Wolfe
c03862fe7b Code climate updates 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-30 13:38:02 -04:00
Clinton Wolfe
abc5e84b87 Fix two tiresome cache issues with simple fixes 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-30 13:38:02 -04:00
Clinton Wolfe
1a47026419 Rename some vars, eliminate @profile_directory 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-30 13:38:02 -04:00
Clinton Wolfe
4f6d296a22 The error case in which the path does not exist 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-30 13:38:02 -04:00
Clinton Wolfe
80241ec971 Passing basic test harness 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-30 13:38:02 -04:00
Clinton Wolfe
c257763de6 Linting 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-30 13:38:02 -04:00
Clinton Wolfe
0e32d2429f Rename path_within_repo option to relative_path 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-30 13:36:20 -04:00
Clinton Wolfe
9c1fa967fd Rename profile_path to path_within_repo 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-30 13:36:20 -04:00
Jerry Aldrich
3e1d08cafe Add support for relative paths to the Git fetcher 
This adds support for specifying a path to a profile in a Git repo.

For example, you could have a Git repo containing multiple profiles and
you want to specify a single one like below:

```yaml
depends:
  - name: profile-1
    git: https://github.com/myorg/all-my-profiles.git
    profile_path: profiles/my-specific-profile-1
  - name: profile-2
    git: https://github.com/myorg/all-my-profiles.git
    profile_path: profiles/my-specific-profile-2
```
Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-07-30 13:36:20 -04:00
Clinton Wolfe
88962af285 Update UX message testing 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-30 13:19:43 -04:00
Clinton Wolfe
918acb01c1 Linting 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-30 13:19:43 -04:00
Miah Johnson
72f02e6cac Fix rubocop 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-07-30 13:19:43 -04:00
Miah Johnson
b148bc85a2 Only some of the output is red 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-07-30 13:19:43 -04:00
Miah Johnson
44592338c6 String interoplation > concatenation 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-07-30 13:19:43 -04:00
Miah Johnson
9fb755a213 Use EXIT value constants 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-07-30 13:19:43 -04:00
Miah Johnson
a524dc030f Convert to new Inspec::UI in inspec-plugin-manager-cli 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-07-30 13:19:43 -04:00
Miah Johnson
da9bd13fd4 Use Inspec::UI throughout InspecCLI 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-07-30 13:19:43 -04:00