Commit graph

8621 commits

Author SHA1 Message Date
Clinton Wolfe
786e3728d7 Failing tests for #4799
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-05-05 18:09:11 -04:00
Clinton Wolfe
970f583764 Tighten up tests
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-05-05 17:59:50 -04:00
Clinton Wolfe
acfda5a735 Clarify names of examples and a method
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-05-05 17:59:20 -04:00
Clinton Wolfe
e8d80dd3cd Update docs
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>

Linting

Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-05-05 17:37:23 -04:00
Clinton Wolfe
5e69e3bab6 Allow complex inputs on CLI
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-05-05 17:37:23 -04:00
Clinton Wolfe
c683c4d64d Failing test cases for 4963
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-05-05 17:37:23 -04:00
Clinton Wolfe
d9f2cdb171 Fix for #4977 by adding a cleanup function for CLI inputs
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-05-05 17:37:23 -04:00
Clinton Wolfe
824018efa3 Failing test cases for #4977
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-05-05 17:37:23 -04:00
Mary Jinglewski
52dbabc778 Copyediting
Signed-off-by: Mary Jinglewski <mjinglewski@chef.io>
2020-05-05 15:19:19 -04:00
Clinton Wolfe
47baa59ed8 Add comment tracking when reporters will migrate
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-05-05 16:51:31 +01:00
Clinton Wolfe
5accb27224 Linting, and a thinko
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-05-05 16:51:31 +01:00
Clinton Wolfe
9c1dbfb5f3 Add docs for reporter plugins
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-05-05 16:51:31 +01:00
Clinton Wolfe
5a7a48bb62 Basics of a working reporter plugin system
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-05-05 16:51:31 +01:00
Chef Expeditor
d9e5b65e3d Bump version to 4.18.111 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-05-05 10:28:20 +00:00
Nick Schwaderer
87d7978340
Merge pull request #5001 from inspec/ns/investigate_waivers_and_namespace_clashing
Allows input and control to have the same name
2020-05-05 11:28:03 +01:00
Nick Schwaderer
a1129f9efc Allows input and control to have the same name
In https://github.com/inspec/inspec/issues/4936 the issue was reported that naming an input the same as a control caused an unexpected failure.

In that particular case, the naming was a result of a pre-waivers workaround which is no longer necessary, but ultimately a breakage of that name clash is an unexpected occurrance.

Due to how inputs are named and registered, `__apply_waivers` thinks that an object is a waiver that is not a waiver and tries to process it. On the micro level, it breaks when trying to pass a variable to a string as if it were a Hash.

It is imperative that we preserve 100% of the current featureset, pass our tests, and fix this edge case along with new test coverage for the failure.

This PR updates the code to do a slightly more elegant and small ‘waiver check’ to stop the namespace clash from breaking our code.

Signed-off-by: Nick Schwaderer <nschwaderer@chef.io>
2020-05-05 10:00:19 +01:00
Chef Expeditor
3616ac21dc Bump version to 4.18.110 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-05-04 16:01:32 +00:00
James Stocks
b22e97de5c
Merge pull request #5010 from devopsdina/automate-reporter-json
Updating automate reporter example config to valid json
2020-05-04 17:01:16 +01:00
Clinton Wolfe
4c3a0aa4d7 Add comment tracking when reporters will migrate
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-05-04 11:52:17 -04:00
James Stocks
69fb6e0782 Move reporter option handling to base
They don't need to be json specific, they should apply to any reporter if the user has chosen these settings.

Signed-off-by: James Stocks <jstocks@chef.io>
2020-05-04 15:24:50 +01:00
James Stocks
ae66aee2b2 (WIP) Reporter options to truncate message and suppress stacktrace
TODO: Option names are not JSON specific but only json reporter has been implemented.

Signed-off-by: James Stocks <jstocks@chef.io>
2020-05-04 15:24:50 +01:00
James Stocks
5b0fdfec89
Merge pull request #5009 from james-stocks/js/windows_skip
Push Windows test skipping for 2 more months
2020-05-04 15:24:23 +01:00
James Stocks
e4fd110ff4 Push Windows test skipping for 2 more months
There are open issues for the failng cases and they are in our priority list.

https://github.com/inspec/inspec/issues?q=is%3Aopen+label%3A%22Aspect%3A+Testing%22+label%3A%22Platform%3A+Windows%22

Signed-off-by: James Stocks <jstocks@chef.io>
2020-05-04 14:55:51 +01:00
Clinton Wolfe
4cb613400f Advance windows test skip timebomb to beginning of 3rd quarter 2020
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-05-02 14:08:26 -04:00
Clinton Wolfe
510c7d847d Linting, and a thinko
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-05-02 14:04:55 -04:00
Clinton Wolfe
8f7ecbb503 Add docs for reporter plugins
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-05-02 00:23:41 -04:00
Clinton Wolfe
63d95b6b6b Basics of a working reporter plugin system
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-05-01 23:48:05 -04:00
Dina Muscanell
1da222a092 updating automate reporter example config to valid json; Signed-off-by: Dina Muscanell <dmuscanell@chef.io> 2020-05-01 14:03:16 -04:00
Chef Expeditor
2e887a94af Bump version to 4.18.109 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-05-01 14:22:05 +00:00
Nick Schwaderer
d5d9352897
Merge pull request #4995 from inspec/cw/late-warn-on-no-value
Fix for warning when input is provided
2020-05-01 15:21:47 +01:00
Clinton Wolfe
5a7ad0c352 Don't be obnoxious
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-04-30 15:36:25 -04:00
Chef Expeditor
7f77c101d2 Executed '.expeditor/update_dockerfile.sh'
Obvious fix; these changes are the result of automation not creative thinking.
2020-04-27 08:58:05 +00:00
Clinton Wolfe
131d6678de Fix for prematurely warning when checking for input value
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-04-24 16:38:57 -04:00
Clinton Wolfe
58e8bc5167 Divide tests into undeclared and required groups
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-04-24 16:38:11 -04:00
Clinton Wolfe
e88dab4365 Update message when input has no value
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-04-24 14:13:07 -04:00
Clinton Wolfe
a12dfcfdc0 Add a failing test case for 4769
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-04-24 13:57:28 -04:00
Chef Expeditor
b46b68ccd1 Bump version to 4.18.108 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-04-23 15:18:13 +00:00
James Stocks
14a85eba93
Merge pull request #4992 from inspec/ns/bump_method_source_version
Bumps method_source dependency version
2020-04-23 16:17:52 +01:00
Clinton Wolfe
b2deb9a4c1 Pin pry to ~> 0.13 to get Pry::Prompt new API to avoid deprecation warning
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-04-22 14:57:22 -04:00
Chef Expeditor
9200fec420 Bump version to 4.18.107 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-04-22 15:24:06 +00:00
James Stocks
c35657bf43
Merge pull request #4983 from jvogt/docs-config-json-fix
Docs fix - config.json example missing indentation and closing brace
2020-04-22 16:23:46 +01:00
James Stocks
836ef745be
Merge pull request #4969 from inspec/csnapp/add_ubuntu2004
Add Ubuntu 20.04 x86_64 support
2020-04-22 09:20:10 +01:00
Chef Expeditor
842d276bd3 Bump version to 4.18.106 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-04-22 08:10:56 +00:00
James Stocks
e7d9a79d5b
Merge pull request #4990 from TheLunaticScripter/tls/add_debug_a2_login
Add additional debug logging for automate login
2020-04-22 09:10:33 +01:00
Clinton Wolfe
dc5f8f1f64 Loosen gemspec constraint on method_source per tas50
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-04-21 16:43:06 -04:00
Clinton Wolfe
ad7569103e Alter inspec shell prompt to silence deprecation warning
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-04-21 16:38:21 -04:00
Clinton Wolfe
913dcac4b3 Alter call into Pry::Output to match new API and get shell tests passing
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-04-21 15:36:08 -04:00
Clinton Wolfe
a3ea5acb3f
Merge pull request #4980 from paul1994/pb/doc_fix
Fixed inputs example to display correct output when the same code is …
2020-04-21 11:56:42 -04:00
Nick Schwaderer
4021bb3c62 Bumps method_source dependency version
The `method_source` dependency for inspec-core has not been bumped in
five years, and it is indirectly holding `pry` back elsewhere in the
ecosystem which is causing issues for ruby 2.7+ support.

Signed-off-by: Nick Schwaderer <nschwaderer@chef.io>
2020-04-21 15:39:28 +01:00
John Snow
8d676f6ed2 Fix typo's after review
Signed-off-by: John Snow <thelunaticscripter@outlook.com>
2020-04-20 09:50:58 -04:00