Mirrors/inspec
2
0
Fork 0
mirror of https://github.com/inspec/inspec synced 2024-11-23 05:03:07 +00:00
Code Issues Projects Releases Packages Wiki Activity

Refactor control_id lookup in waiver test file

Browse source 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
This commit is contained in:
Clinton Wolfe 2019-09-03 22:25:39 -04:00
parent 6ec50efd22
commit ff209b4bae
1 changed files with 15 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
test/functional/waivers_test.rb
View file

@ -2,27 +2,26 @@ require "functional/helper"
describe "waivers" do
include FunctionalHelper
let(:cmd) { "exec #{waivers_profiles_path}/basic --input-file #{waivers_profiles_path}/basic/files/waivers.yaml" }
let(:run_result) { run_inspec_process(cmd, json: true) }
let(:waivers_profiles_path) { "#{profile_path}/waivers" }
let(:controls_by_id) { run_result.payload.json.dig("profiles", 0, "controls").map { |c| [c["id"], c] }.to_h }
def assert_test_outcome(expected, result_json)
assert_equal expected, result_json["status"]
def assert_test_outcome(expected, control_id)
assert_equal expected, controls_by_id.dig(control_id, "results", 0, "status")
end
def assert_waiver_annotation(result_json)
def assert_waiver_annotation(control_id)
# TODO - test JSON for waiver annotation
end
def refute_waiver_annotation(result_json)
def refute_waiver_annotation(control_id)
# TODO - test JSON for waiver annotation
# Don't suppose we get this for free by defining assert_waiver_annotation ...
end
describe "a fully pre-slugged control file" do
it "has all of the expected outcomes" do
cmd = "exec #{waivers_profiles_path}/basic --input-file #{waivers_profiles_path}/basic/files/waivers.yaml"
run_result = run_inspec_process(cmd, json: true)
controls_by_id = run_result.payload.json["profiles"][0]["controls"].map { |c| [c["id"], c] }.to_h
[
"01_not_waivered_passes",
"03_waivered_no_expiry_not_skipped_passes", # this had a waiver but still passed - no annotation?
@ -30,18 +29,16 @@ describe "waivers" do
"08_waivered_expiry_in_past_skipped", # another stale waiver
"09_waivered_expiry_in_future_not_skipped_passes", # unneeded waiver
].each do |control_id|
result = controls_by_id[control_id]["results"][0]
assert_test_outcome "passed", result
refute_waiver_annotation result
assert_test_outcome "passed", control_id
refute_waiver_annotation control_id
end
[
"02_not_waivered_fails",
"07_waivered_expiry_in_past_not_skipped_fails", # Should this give a special waiver expired message?
].each do |control_id|
result = controls_by_id[control_id]["results"][0]
assert_test_outcome "failed", result
refute_waiver_annotation result
assert_test_outcome "failed", control_id
refute_waiver_annotation control_id
end
# Each of these should have been forced to skip by the waiver system
@ -49,9 +46,8 @@ describe "waivers" do
05_waivered_no_expiry_skipped
11_waivered_expiry_in_future_skipped
}.each do |control_id|
result = controls_by_id[control_id]["results"][0]
assert_test_outcome "skipped", result
assert_waiver_annotation result
assert_test_outcome "skipped", control_id
assert_waiver_annotation control_id
end
# Each of these should have had a failure, but had a waiver annotation
@ -60,11 +56,9 @@ describe "waivers" do
04_waivered_no_expiry_not_skipped_fails
10_waivered_expiry_in_future_not_skipped_fails
}.each do |control_id|
result = controls_by_id[control_id]["results"][0]
assert_test_outcome "failed", result
assert_waiver_annotation result
assert_test_outcome "failed", control_id
assert_waiver_annotation control_id
end
end
end