From 0613772419ff292a4c599f812d79ae33a49d40fd Mon Sep 17 00:00:00 2001 From: Miah Johnson Date: Wed, 28 Aug 2019 11:16:08 -0700 Subject: [PATCH 1/3] Let expeditor respond to pull requests. closes 4429 Signed-off-by: Miah Johnson --- .expeditor/config.yml | 3 +++ .expeditor/templates/pull_request.mustache | 7 +++++++ 2 files changed, 10 insertions(+) create mode 100644 .expeditor/templates/pull_request.mustache diff --git a/.expeditor/config.yml b/.expeditor/config.yml index 505e6b6ce..009c4ba9c 100644 --- a/.expeditor/config.yml +++ b/.expeditor/config.yml @@ -146,3 +146,6 @@ subscriptions: - bash:.expeditor/announce-release.sh: post_commit: true - built_in:notify_chefio_slack_channels + - workload: pull_request_opened:{{agent_id}}:* + actions: + - post_github_comment:.expeditor/templates/pull_request.mustache diff --git a/.expeditor/templates/pull_request.mustache b/.expeditor/templates/pull_request.mustache new file mode 100644 index 000000000..f9e7109e6 --- /dev/null +++ b/.expeditor/templates/pull_request.mustache @@ -0,0 +1,7 @@ +Hello {{author}}! Thanks for the pull request! + +Here is what will happen next: +1. Your PR will be reviewed by the maintainers +2. If everything looks good, one of them will approve it, and your PR will be merged. + +Thank you for contributing! From d7f2e98dda217e48f10be2ddbd5ddc222b027a57 Mon Sep 17 00:00:00 2001 From: Miah Johnson Date: Wed, 28 Aug 2019 11:47:06 -0700 Subject: [PATCH 2/3] Minor cleanup Signed-off-by: Miah Johnson --- .expeditor/templates/pull_request.mustache | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.expeditor/templates/pull_request.mustache b/.expeditor/templates/pull_request.mustache index f9e7109e6..598581d39 100644 --- a/.expeditor/templates/pull_request.mustache +++ b/.expeditor/templates/pull_request.mustache @@ -1,7 +1,8 @@ Hello {{author}}! Thanks for the pull request! Here is what will happen next: -1. Your PR will be reviewed by the maintainers + +1. Your PR will be reviewed by the maintainers. 2. If everything looks good, one of them will approve it, and your PR will be merged. Thank you for contributing! From ae02dd63a2d177be5c5468697c1aea360c6757ee Mon Sep 17 00:00:00 2001 From: Miah Johnson Date: Wed, 28 Aug 2019 14:38:29 -0700 Subject: [PATCH 3/3] Update with suggestions. Signed-off-by: Miah Johnson --- .expeditor/templates/pull_request.mustache | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.expeditor/templates/pull_request.mustache b/.expeditor/templates/pull_request.mustache index 598581d39..fa781913a 100644 --- a/.expeditor/templates/pull_request.mustache +++ b/.expeditor/templates/pull_request.mustache @@ -3,6 +3,9 @@ Hello {{author}}! Thanks for the pull request! Here is what will happen next: 1. Your PR will be reviewed by the maintainers. -2. If everything looks good, one of them will approve it, and your PR will be merged. +2. Possible Outcomes + a. If everything looks good, one of them will approve it, and your PR will be merged. + b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner. + c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR. Thank you for contributing!