Mirrors/inspec
2
0
Fork 0
mirror of https://github.com/inspec/inspec synced 2024-11-25 14:10:25 +00:00
Code Issues Projects Releases Packages Wiki Activity

Update junit tests to use nokogiri

Browse source 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
This commit is contained in:
Clinton Wolfe 2020-06-10 19:23:52 -04:00 committed by Nick Schwaderer
parent 064d3f5d1c
commit 955ab36922
2 changed files with 17 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Gemfile
View file

@ -25,6 +25,7 @@ group :test do
gem "rake", ">= 10"
gem "simplecov", ["~> 0.10", "<=0.18.2"]
gem "concurrent-ruby", "~> 1.0"
gem "nokogiri", "~> 1.9"
gem "mocha", "~> 1.1"
gem "ruby-progressbar", "~> 1.8"
gem "webmock", "~> 3.0"

34
test/functional/inspec_exec_junit_test.rb
View file

@ -1,5 +1,5 @@
require "functional/helper"
require "rexml/document"
require "nokogiri"
describe "inspec exec with junit formatter" do
include FunctionalHelper
@ -9,11 +9,10 @@ describe "inspec exec with junit formatter" do
it "can execute a simple file with the junit formatter" do
out = inspec("exec " + example_control + " --reporter junit --no-create-lockfile")
# TODO: rexml is about as slow as you can go. Use nokogiri
doc = REXML::Document.new(out.stdout)
_(doc.has_elements?).must_equal true
_(out.stderr).must_equal ""
doc = Nokogiri::XML(out.stdout)
_(doc.document?).must_equal true
_(doc.errors).must_be_empty
assert_exit_code 0, out
end
@ -21,44 +20,43 @@ describe "inspec exec with junit formatter" do
it "can execute the profile with the junit formatter" do
out = inspec("exec " + complete_profile + " --reporter junit --no-create-lockfile")
# TODO: _never_ use rexml. Anything else is guaranteed faster
doc = REXML::Document.new(out.stdout)
_(doc.has_elements?).must_equal true
_(out.stderr).must_equal ""
doc = Nokogiri::XML(out.stdout)
_(doc.document?).must_equal true
_(doc.errors).must_be_empty
assert_exit_code 0, out
end
describe "execute a profile with junit formatting" do
let(:doc) { REXML::Document.new(inspec("exec " + example_profile + " --reporter junit --no-create-lockfile").stdout) }
let(:doc) { Nokogiri::XML(inspec("exec " + example_profile + " --reporter junit --no-create-lockfile").stdout) }
describe "the document" do
it "has only one testsuite" do
_(doc.elements.to_a("//testsuite").length).must_equal 1
_(doc.xpath("//testsuite").length).must_equal 1
end
end
describe "the test suite" do
let(:suite) { doc.elements.to_a("//testsuites/testsuite").first }
let(:suite) { doc.xpath("//testsuites/testsuite").first }
it "must have 4 testcase children" do
_(suite.elements.to_a("//testcase").length).must_equal 4
_(suite.xpath("//testcase").length).must_equal 4
end
it "has the tests attribute with 4 total tests" do
_(suite.attribute("tests").value).must_equal "4"
_(suite.attr("tests")).must_equal "4"
end
it "has the failures attribute with 0 total tests" do
_(suite.attribute("failed").value).must_equal "0"
_(suite.attr("failed")).must_equal "0"
end
it 'has 2 elements named "File / should be directory"' do
_(REXML::XPath.match(suite, "//testcase[@name='File / is expected to be directory']").length).must_equal 3
it 'has 3 elements named "File / should be directory"' do
_(suite.xpath("//testcase[@name='File / is expected to be directory']").length).must_equal 3
end
describe 'the testcase named "example_config Can\'t find file ..."' do
let(:example_yml_tests) { REXML::XPath.match(suite, "//testcase[@classname='profile.example-1.0' and @name='example_config']") }
let(:example_yml_tests) { suite.xpath("//testcase[@classname='profile.example-1.0' and @name='example_config']") }
let(:first_example_test) { example_yml_tests.first }
it "should be unique" do