From 31b24c4abf5f8747bcf657fff399d0cef0130e4e Mon Sep 17 00:00:00 2001 From: Miah Johnson Date: Fri, 27 Sep 2019 12:45:24 -0700 Subject: [PATCH 1/2] Remove maintainers task from require [miah@awakening inspec]$ bundle exec rake rake aborted! NameError: uninitialized constant Faraday::Error::ClientError Did you mean? Faraday::ClientError /home/miah/projects/github/.gems/inspec/ruby/2.6.0/gems/octokit-4.14.0/lib/octokit/middleware/follow_redirects.rb:14:in `' /home/miah/projects/github/.gems/inspec/ruby/2.6.0/gems/octokit-4.14.0/lib/octokit/middleware/follow_redirects.rb:11:in `' ... /home/miah/projects/github/inspec/tasks/maintainers.rb:27:in `require' ... (See full trace by running task with --trace) Signed-off-by: Miah Johnson --- Rakefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Rakefile b/Rakefile index 5d193531c..79df9591c 100755 --- a/Rakefile +++ b/Rakefile @@ -4,7 +4,7 @@ require "bundler" require "bundler/gem_helper" require "rake/testtask" require "train" -require_relative "tasks/maintainers" +# require_relative "tasks/maintainers" # TODO: bring back after we push faraday_middleware fix upstream require_relative "tasks/spdx" require "fileutils" From 984e02e312d004c2dd8318a44b7562a49e4d0687 Mon Sep 17 00:00:00 2001 From: Ryan Davis Date: Fri, 27 Sep 2019 14:12:10 -0700 Subject: [PATCH 2/2] Quick fix for faraday_middleware bug introduced when bumping to faraday 0.16.0. Namespacing changed in faraday from Faraday::Error::* to Faraday::* but was not reflected in faraday_middleware (which hasn't released since February). I will file an issue and/or PR with them later. Signed-off-by: Ryan Davis --- test/unit/resources/http_test.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/test/unit/resources/http_test.rb b/test/unit/resources/http_test.rb index 1165a8922..14e330d87 100644 --- a/test/unit/resources/http_test.rb +++ b/test/unit/resources/http_test.rb @@ -1,6 +1,7 @@ require "helper" require "inspec/resource" require "inspec/resources/http" +Faraday::Error::ClientError = ::Faraday::ClientError # TODO/HACK push upstream to faraday_middleware require "faraday_middleware/response/follow_redirects" describe "Inspec::Resources::Http" do