Mirrors/inspec
2
0
Fork 0
mirror of https://github.com/inspec/inspec synced 2025-02-20 16:08:41 +00:00
Code Issues Projects Releases Packages Wiki Activity

bugfix: do not allocate pty on ssh by default

Browse source 
PTY will effectively disable stderr output, so avoid it for now.

It will come up very soon when we get back to sudo; see if fifo or other solutions might be used. Stderr is important for accurate command execution...

For reference see this wonderful explanation:

http://unix.stackexchange.com/a/134169
Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
This commit is contained in:
Dominik Richter 2015-09-25 13:25:57 +02:00
parent c3d226e4a2
commit 6d7a46a589
1 changed files with 0 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
lib/vulcano/backend/ssh.rb
View file

@ -24,9 +24,6 @@ module Vulcano::Backends
cmd.force_encoding('binary') if cmd.respond_to?(:force_encoding) cmd.force_encoding('binary') if cmd.respond_to?(:force_encoding)
@ssh.open_channel do |channel| @ssh.open_channel do |channel|
channel.request_pty do |_, success|
abort 'Could not obtain pty on SSH channel ' if !success
end
channel.exec(cmd) do |_, success| channel.exec(cmd) do |_, success|
unless success unless success
abort 'Couldn\'t execute command on SSH.' abort 'Couldn\'t execute command on SSH.'