Mirrors/inspec
2
0
Fork 0
mirror of https://github.com/inspec/inspec synced 2024-11-26 22:50:36 +00:00
Code Issues Projects Releases Packages Wiki Activity

security_policy resource: use PID for filename instead of random (#2368)

Browse source 
* Update security policy export to use pid instead of random.

Signed-off-by: Jared Quick <jquick@chef.io>

* Update helper for the new train.

Signed-off-by: Jared Quick <jquick@chef.io>
This commit is contained in:
Jared Quick 2017-12-04 15:31:06 -05:00 committed by Adam Leff
parent 0aac3b13ad
commit 4b1c1b041f
3 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
lib/resources/security_policy.rb
View file

@ -14,7 +14,6 @@
# parameters. Therefore we need a combination of Registry and secedit output
require 'hashie'
require 'securerandom'
module Inspec::Resources
# known and supported MS privilege rights
@ -109,8 +108,8 @@ module Inspec::Resources
def read_content
return @content if defined?(@content)
# using random hex to prevent any race conditions with multiple runners
export_file = "win_secpol-#{SecureRandom.hex}.cfg"
# using process pid to prevent any race conditions with multiple runners
export_file = "win_secpol-#{Process.pid}.cfg"
# export the security policy
cmd = inspec.command("secedit /export /cfg #{export_file}")

9
test/helper.rb
View file

@ -73,7 +73,7 @@ class MockLoader
# pass the os identifier to emulate a specific operating system
def initialize(os = nil)
# selects operating system
@os = OPERATING_SYSTEMS[os || :ubuntu1404]
@platform = OPERATING_SYSTEMS[os || :ubuntu1404]
end
def backend
@ -84,11 +84,12 @@ class MockLoader
@backend = Inspec::Backend.create({ backend: :mock, verbose: true })
mock = @backend.backend
# set os emulation
mock.mock_os(@os)
# create all mock files
local = Train.create('local').connection
# set os emulation
mock.mock_os(@platform)
mockfile = lambda { |x|
path = ::File.join(scriptpath, '/unit/mock/files', x)
local.file(path)

4
test/unit/resources/security_policy_test.rb
View file

@ -8,7 +8,7 @@ require 'inspec/resource'
describe 'Inspec::Resources::SecurityPolicy' do
it 'verify processes resource' do
resource = load_resource('security_policy')
SecureRandom.expects(:hex).returns('abc123')
Process.expects(:pid).returns('abc123')
_(resource.MaximumPasswordAge).must_equal 42
_(resource.send('MACHINE\Software\Microsoft\Windows NT\CurrentVersion\Setup\RecoveryConsole\SecurityLevel')).must_equal '4,0'
@ -18,7 +18,7 @@ describe 'Inspec::Resources::SecurityPolicy' do
it 'parse empty policy file' do
resource = load_resource('security_policy')
SecureRandom.expects(:hex).returns('abc123')
Process.expects(:pid).returns('abc123')
backend = resource.inspec.backend
backend.commands['Get-Content win_secpol-abc123.cfg'] = backend.mock_command('', '', '', 0)