Mirrors/inspec
2
0
Fork 0
mirror of https://github.com/inspec/inspec synced 2025-02-17 06:28:40 +00:00
Code Issues Projects Releases Packages Wiki Activity

aws_iam_access_keys incorrectly populates created_date (#215)

Browse source 
Signed-off-by: Rony Xavier <rx294@nyu.edu>
This commit is contained in:
Rony Xavier 2018-01-31 22:16:30 -05:00 • committed by Clinton Wolfe
parent 032eda1063
commit 1b170dcfb6
3 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
docs/resources/aws_iam_access_keys.md
View file

@ -73,12 +73,12 @@ A true / false value indicating if an Access Key is currently "Active" (the norm
its('access_key_ids') { should include('AKIA1234567890ABCDEF')}
end
### created_date
### create_date
A DateTime identifying when the Access Key was created. See also `created_days_ago` and `created_hours_ago`.
# Detect keys older than 2017
describe aws_iam_access_keys.where { created_date < DateTime.parse('2017-01-01') } do
describe aws_iam_access_keys.where { create_date < DateTime.parse('2017-01-01') } do
it { should_not exist }
end

2
libraries/aws_iam_access_keys.rb
View file

@ -55,7 +55,7 @@ class AwsIamAccessKeys < Inspec.resource(1)
.add_accessor(:entries)
.add(:exists?) { |x| !x.entries.empty? }
.add(:access_key_ids, field: :access_key_id)
.add(:created_date, field: :created_date)
.add(:created_date, field: :create_date)
.add(:created_days_ago, field: :created_days_ago)
.add(:created_with_user, field: :created_with_user)
.add(:created_hours_ago, field: :created_hours_ago)

12
test/unit/resources/aws_iam_access_keys_test.rb
View file

@ -136,13 +136,13 @@ class AwsIamAccessKeysPropertiesTest < Minitest::Test
# created_date / created_days_ago / created_hours_ago #
#----------------------------------------------------------#
def test_property_created_date
assert_kind_of(DateTime, @all_basic.entries.first.created_date)
assert_kind_of(DateTime, @all_basic.entries.first.create_date)
arg_filtered = @all_basic.where(created_date: DateTime.parse('2017-10-27T17:58:00Z'))
arg_filtered = @all_basic.where(create_date: DateTime.parse('2017-10-27T17:58:00Z'))
assert_equal(1, arg_filtered.entries.count)
assert arg_filtered.access_key_ids.first.end_with?('BOB')
block_filtered = @all_basic.where { created_date.friday? }
block_filtered = @all_basic.where { create_date.friday? }
assert_equal(1, block_filtered.entries.count)
assert block_filtered.access_key_ids.first.end_with?('BOB')
end
@ -312,7 +312,7 @@ class BasicMAKP < AwsIamAccessKeys::AccessKeyProvider
username: 'bob',
access_key_id: 'AKIA1234567890123BOB',
id: 'AKIA1234567890123BOB',
created_date: DateTime.parse('2017-10-27T17:58:00Z'),
create_date: DateTime.parse('2017-10-27T17:58:00Z'),
created_days_ago: 4,
created_hours_ago: 102,
created_with_user: true,
@ -330,7 +330,7 @@ class BasicMAKP < AwsIamAccessKeys::AccessKeyProvider
username: 'sally',
access_key_id: 'AKIA12345678901SALLY',
id: 'AKIA12345678901SALLY',
created_date: DateTime.parse('2017-10-22T17:58:00Z'),
create_date: DateTime.parse('2017-10-22T17:58:00Z'),
created_days_ago: 9,
created_hours_ago: 222,
created_with_user: false,
@ -348,7 +348,7 @@ class BasicMAKP < AwsIamAccessKeys::AccessKeyProvider
username: 'robin',
access_key_id: 'AKIA12345678901ROBIN',
id: 'AKIA12345678901ROBIN',
created_date: DateTime.parse('2017-10-31T17:58:00Z'),
create_date: DateTime.parse('2017-10-31T17:58:00Z'),
created_days_ago: 1,
created_hours_ago: 12,
created_with_user: true,